2007-11-27 19:40:25 +00:00
|
|
|
/********************************************************************
|
2007-04-29 17:35:43 +00:00
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
|
|
|
Copyright (C) 1999, 2000 Matthias Ettrich <ettrich@kde.org>
|
|
|
|
Copyright (C) 2003 Lubos Lunak <l.lunak@kde.org>
|
|
|
|
|
2007-11-27 19:40:25 +00:00
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
#ifndef KWIN_SM_H
|
|
|
|
#define KWIN_SM_H
|
|
|
|
|
|
|
|
#include <QDataStream>
|
2013-09-06 13:22:16 +00:00
|
|
|
#include <kwinglobals.h>
|
|
|
|
#include <QStringList>
|
2007-04-29 17:35:43 +00:00
|
|
|
#include <netwm_def.h>
|
2008-02-02 20:54:19 +00:00
|
|
|
#include <QRect>
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2011-10-31 20:29:18 +00:00
|
|
|
#include <X11/SM/SMlib.h>
|
|
|
|
#include <fixx11h.h>
|
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
class QSocketNotifier;
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
2019-09-24 08:48:08 +00:00
|
|
|
class X11Client;
|
2009-11-15 03:24:04 +00:00
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
struct SessionInfo {
|
2007-04-29 17:35:43 +00:00
|
|
|
QByteArray sessionId;
|
|
|
|
QByteArray windowRole;
|
2016-06-23 17:40:40 +00:00
|
|
|
QByteArray wmCommand;
|
2007-04-29 17:35:43 +00:00
|
|
|
QByteArray wmClientMachine;
|
|
|
|
QByteArray resourceName;
|
|
|
|
QByteArray resourceClass;
|
|
|
|
|
|
|
|
QRect geometry;
|
|
|
|
QRect restore;
|
|
|
|
QRect fsrestore;
|
|
|
|
int maximized;
|
|
|
|
int fullscreen;
|
|
|
|
int desktop;
|
|
|
|
bool minimized;
|
|
|
|
bool onAllDesktops;
|
|
|
|
bool shaded;
|
|
|
|
bool keepAbove;
|
|
|
|
bool keepBelow;
|
|
|
|
bool skipTaskbar;
|
|
|
|
bool skipPager;
|
2010-05-03 20:04:44 +00:00
|
|
|
bool skipSwitcher;
|
2008-03-23 00:12:11 +00:00
|
|
|
bool noBorder;
|
2007-04-29 17:35:43 +00:00
|
|
|
NET::WindowType windowType;
|
|
|
|
QString shortcut;
|
|
|
|
bool active; // means 'was active in the saved session'
|
|
|
|
int stackingOrder;
|
2009-08-15 17:33:47 +00:00
|
|
|
float opacity;
|
2009-11-15 03:24:04 +00:00
|
|
|
|
2010-10-02 17:04:24 +00:00
|
|
|
QStringList activities;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
enum SMSavePhase {
|
2007-04-29 17:35:43 +00:00
|
|
|
SMSavePhase0, // saving global state in "phase 0"
|
|
|
|
SMSavePhase2, // saving window state in phase 2
|
|
|
|
SMSavePhase2Full // complete saving in phase2, there was no phase 0
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
class KWIN_EXPORT SessionSaveDoneHelper
|
2007-04-29 17:35:43 +00:00
|
|
|
: public QObject
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2007-04-29 17:35:43 +00:00
|
|
|
Q_OBJECT
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
|
|
|
SessionSaveDoneHelper();
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SessionSaveDoneHelper() override;
|
2011-01-30 14:34:42 +00:00
|
|
|
SmcConn connection() const {
|
|
|
|
return conn;
|
|
|
|
}
|
|
|
|
void saveDone();
|
|
|
|
void close();
|
2013-07-22 14:07:39 +00:00
|
|
|
private Q_SLOTS:
|
2011-01-30 14:34:42 +00:00
|
|
|
void processData();
|
|
|
|
private:
|
|
|
|
QSocketNotifier* notifier;
|
|
|
|
SmcConn conn;
|
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
#endif
|