yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/maximize_test.cpp

431 lines
19 KiB
C++
Raw Normal View History

[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2016 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#include "kwin_wayland_test.h"
Use AbstractClient instead of XdgShellClient wherever possible Summary: Currently, we have only one shell client type - XdgShellClient. We use it when we are dealing with Wayland clients. But it isn't really a good idea because we may need to support shell surfaces other than xdg-shell ones, for example input panel surfaces. In order to make kwin more extensible, this change replaces all usages of the XdgShellClient class with the AbstractClient class. Test Plan: Existing tests pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27778
2020-03-04 07:55:26 +00:00
#include "abstract_client.h"
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
#include "cursor.h"
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
#include "decorations/decorationbridge.h"
#include "decorations/settings.h"
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
#include "platform.h"
#include "screens.h"
#include "wayland_server.h"
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
#include "workspace.h"
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
#include <KWayland/Client/compositor.h>
#include <KWayland/Client/shm_pool.h>
#include <KWayland/Client/surface.h>
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
#include <KWayland/Client/server_decoration.h>
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
#include <KWayland/Client/xdgdecoration.h>
[wayland] Place all toplevels before the first configure Summary: Currently popups get positioned once at the initial configure, to set the correct size and again when they are mapped. Toplevels are currently only positioned when they are mapped. This works for all cases where the the toplevel defines its own size, but not if the window should have an initial size set by the placement strategy or window rules. Most notably the maximised placement strategy used on plasma mobile. Being out of sync and resizing later currently causes a positioning bug when plasma mobile is used with XdgShell. This patch repositions all top levels that don't have a position set through the plasma interface. Test Plan: Relevant unit test Reviewers: #kwin, bshah Reviewed By: bshah Subscribers: zzag, bshah, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D20241
2019-04-09 10:15:02 +00:00
#include <KWayland/Client/plasmashell.h>
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
#include <KDecoration2/DecoratedClient>
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
#include <KDecoration2/Decoration>
#include <KDecoration2/DecorationSettings>
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
using namespace KWin;
using namespace KWayland::Client;
static const QString s_socketName = QStringLiteral("wayland_test_kwin_maximized-0");
class TestMaximized : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase();
void init();
void cleanup();
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
void testMaximizedPassedToDeco();
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
void testInitiallyMaximized();
Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows Test Plan: Test pass Reviewers: #kwin, zzag, davidedmundson Reviewed By: #kwin, zzag Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29702
2020-05-13 10:53:43 +00:00
void testInitiallyMaximizedBorderless();
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
void testBorderlessMaximizedWindow();
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
void testBorderlessMaximizedWindowNoClientSideDecoration();
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
};
void TestMaximized::initTestCase()
{
qRegisterMetaType<KWin::AbstractClient*>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
QVERIFY(applicationStartedSpy.isValid());
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
Handle situation of no XDG_RUNTIME_DIR gracefully Summary: If KWin fails to start the Wayland server due to XDG_RUNTIME_DIR not being set, kwin_wayland should terminate with an error condition but not crash. This change makes sure that KWin detects that the Wayland server does not work and terminates the startup early and ensures that it doesn't crash while going down. An error message is shown that we could not create the Wayland server. Test Plan: Test case added which verifies that WaylandServer fails to init. Manual testing that kwin_wayland exits with error 1. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2078
2016-07-04 07:09:03 +00:00
QVERIFY(waylandServer()->init(s_socketName.toLocal8Bit()));
[platforms/virtual] Create output devices Summary: Create output devices in virtual backend. For that the setVirtualOutputs call can only come after the Wayland server has been initiliazied such that the display exists to create the output and output device interfaces. Tests have been adjusted for that. Test Plan: ``` 98% tests passed, 3 tests failed out of 148 Total Test time (real) = 362.97 sec The following tests FAILED: 33 - kwin-testInternalWindow (Failed) 39 - kwin-testPointerInput (Failed) 101 - kwin-testMoveResize (Failed) ``` Failing of these tests looks unrelated to the change. Reviewers: #kwin Subscribers: kwin Tags: #kwin Maniphest Tasks: T11459 Differential Revision: https://phabricator.kde.org/D23477
2019-08-26 21:16:53 +00:00
QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
QCOMPARE(screens()->count(), 2);
QCOMPARE(screens()->geometry(0), QRect(0, 0, 1280, 1024));
QCOMPARE(screens()->geometry(1), QRect(1280, 0, 1280, 1024));
waylandServer()->initWorkspace();
}
void TestMaximized::init()
{
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::Decoration |
[wayland] Place all toplevels before the first configure Summary: Currently popups get positioned once at the initial configure, to set the correct size and again when they are mapped. Toplevels are currently only positioned when they are mapped. This works for all cases where the the toplevel defines its own size, but not if the window should have an initial size set by the placement strategy or window rules. Most notably the maximised placement strategy used on plasma mobile. Being out of sync and resizing later currently causes a positioning bug when plasma mobile is used with XdgShell. This patch repositions all top levels that don't have a position set through the plasma interface. Test Plan: Relevant unit test Reviewers: #kwin, bshah Reviewed By: bshah Subscribers: zzag, bshah, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D20241
2019-04-09 10:15:02 +00:00
Test::AdditionalWaylandInterface::XdgDecoration |
Test::AdditionalWaylandInterface::PlasmaShell));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
screens()->setCurrent(0);
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
KWin::Cursors::self()->mouse()->setPos(QPoint(1280, 512));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
}
void TestMaximized::cleanup()
{
[autotest/integration] Introduce a Test helper library to have less code duplication Summary: A new namespace KWin::Test is added which provides a few helper functions. It makes it easy to setup a KWayland client connection with the base set to be able to create a Surface and flags to create additional interfaces. This replaces the KWayland connection dance in init() methods. For cleanup() there is also a dedicated helper function. In addition there are helper functions to: * render a surface * create a surface * create a shell surface * flush the wayland client connection * access to the created interfaces - for compatibility with existing code The idea is to extend this Test library also for other common use cases like creating an X11 connection and X11 windows, etc. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2053
2016-06-30 11:32:54 +00:00
Test::destroyWaylandConnection();
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
// adjust config
auto group = kwinApp()->config()->group("Windows");
group.writeEntry("BorderlessMaximizedWindows", false);
group.sync();
Workspace::self()->slotReconfigure();
QCOMPARE(options->borderlessMaximizedWindows(), false);
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
}
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
void TestMaximized::testMaximizedPassedToDeco()
{
Rename ShellClient to XdgShellClient Summary: Rename ShellClient to XdgShellClient in order to reflect that it represents only xdg-shell clients. Test Plan: Compiles, tests still pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23589
2019-08-30 21:36:58 +00:00
// this test verifies that when a XdgShellClient gets maximized the Decoration receives the signal
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Create the test client.
[autotest/integration] Introduce a Test helper library to have less code duplication Summary: A new namespace KWin::Test is added which provides a few helper functions. It makes it easy to setup a KWayland client connection with the base set to be able to create a Surface and flags to create additional interfaces. This replaces the KWayland connection dance in init() methods. For cleanup() there is also a dedicated helper function. In addition there are helper functions to: * render a surface * create a surface * create a shell surface * flush the wayland client connection * access to the created interfaces - for compatibility with existing code The idea is to extend this Test library also for other common use cases like creating an X11 connection and X11 windows, etc. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2053
2016-06-30 11:32:54 +00:00
QScopedPointer<Surface> surface(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
[autotest/integration] Introduce a Test helper library to have less code duplication Summary: A new namespace KWin::Test is added which provides a few helper functions. It makes it easy to setup a KWayland client connection with the base set to be able to create a Surface and flags to create additional interfaces. This replaces the KWayland connection dance in init() methods. For cleanup() there is also a dedicated helper function. In addition there are helper functions to: * render a surface * create a surface * create a shell surface * flush the wayland client connection * access to the created interfaces - for compatibility with existing code The idea is to extend this Test library also for other common use cases like creating an X11 connection and X11 windows, etc. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2053
2016-06-30 11:32:54 +00:00
QScopedPointer<ServerSideDecoration> ssd(Test::waylandServerSideDecoration()->create(surface.data()));
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
[autotest/integration] Add helper for waiting for a shown ShellClient Summary: Many tests create a Wayland window, render it and then wait till it's created in KWin as a ShellClient. To reduce code duplication the test helper provides helper methods to wait for the next ShellClient to be shown and to directly render and wait for the window for that to be shown. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2057
2016-07-01 07:54:44 +00:00
auto client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
QVERIFY(client);
QVERIFY(client->isDecorated());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
auto decoration = client->decoration();
QVERIFY(decoration);
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Wait for configure event that signals the client is active now.
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
QVERIFY(configureRequestedSpy.isValid());
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 1);
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
// When there are no borders, there is no change to them when maximizing.
// TODO: we should test both cases with fixed fake decoration for autotests.
const bool hasBorders = Decoration::DecorationBridge::self()->settings()->borderSize() != KDecoration2::BorderSize::None;
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
// now maximize
Request the resize of ShellSurface after Decoration updated the borders when maximizing Summary: This ensures that we don't send a size request with the borders still added. Test Plan: Verified that a maximized window is properly sized and doesn't have empty borders Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1807
2016-06-09 14:50:48 +00:00
QSignalSpy bordersChangedSpy(decoration, &KDecoration2::Decoration::bordersChanged);
QVERIFY(bordersChangedSpy.isValid());
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
QSignalSpy maximizedChangedSpy(decoration->client().data(), &KDecoration2::DecoratedClient::maximizedChanged);
QVERIFY(maximizedChangedSpy.isValid());
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
QVERIFY(frameGeometryChangedSpy.isValid());
[autotests] Fix maximize test Summary: testMaximizedPassedToDeco was failing because it didn't handle async maximization. testBorderlessMaximizedWindow was failing because setNoBorder can modify geometry, so we end up with a wrong restore geometry. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16755
2018-11-08 10:33:57 +00:00
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
workspace()->slotWindowMaximize();
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 2);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024 - decoration->borderTop()));
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Test::render(surface.data(), configureRequestedSpy.last().at(0).toSize(), Qt::red);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
// If no borders, there is only the initial geometry shape change, but none through border resizing.
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QCOMPARE(frameGeometryChangedSpy.count(), hasBorders ? 2 : 1);
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeFull);
QCOMPARE(maximizedChangedSpy.count(), 1);
QCOMPARE(maximizedChangedSpy.last().first().toBool(), true);
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
QCOMPARE(bordersChangedSpy.count(), hasBorders ? 1 : 0);
Request the resize of ShellSurface after Decoration updated the borders when maximizing Summary: This ensures that we don't send a size request with the borders still added. Test Plan: Verified that a maximized window is properly sized and doesn't have empty borders Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1807
2016-06-09 14:50:48 +00:00
QCOMPARE(decoration->borderLeft(), 0);
QCOMPARE(decoration->borderBottom(), 0);
QCOMPARE(decoration->borderRight(), 0);
QVERIFY(decoration->borderTop() != 0);
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
// now unmaximize again
workspace()->slotWindowMaximize();
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 3);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(100, 50));
[autotests] Fix maximize test Summary: testMaximizedPassedToDeco was failing because it didn't handle async maximization. testBorderlessMaximizedWindow was failing because setNoBorder can modify geometry, so we end up with a wrong restore geometry. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16755
2018-11-08 10:33:57 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
[autotests] Fix maximize test Summary: testMaximizedPassedToDeco was failing because it didn't handle async maximization. testBorderlessMaximizedWindow was failing because setNoBorder can modify geometry, so we end up with a wrong restore geometry. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16755
2018-11-08 10:33:57 +00:00
Test::render(surface.data(), QSize(100, 50), Qt::red);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
QCOMPARE(frameGeometryChangedSpy.count(), hasBorders ? 4 : 2);
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore);
QCOMPARE(maximizedChangedSpy.count(), 2);
QCOMPARE(maximizedChangedSpy.last().first().toBool(), false);
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
QCOMPARE(bordersChangedSpy.count(), hasBorders ? 2 : 0);
Introduce a RequestGeometryBlocker in ShellClient Summary: The idea is to not send multiple resize requests to a client when we know that we might have multiple geometry changes. E.g. when going from maximized to restored the borders change and trigger a resize in addition to the resize from switching to restored. The implementation is inspired by the GeometryUpdateBlocker. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1808
2016-06-09 14:54:06 +00:00
QVERIFY(decoration->borderTop() != 0);
[autotests] Fix remaining autotests with failing border calculation Summary: As in 2c088894b fix remaining autotests failing since no borders has become the new default behavior of Breeze. Autotests should not rely on this default behavior of Breeze though, but be run with a faked deco such that changes on Breeze does not directly change the autotests behavior. That's a goal for the future. Test Plan: 100% tests passed, 0 tests failed out of 147 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D21746
2019-06-11 13:24:24 +00:00
QVERIFY(decoration->borderLeft() != !hasBorders);
QVERIFY(decoration->borderRight() != !hasBorders);
QVERIFY(decoration->borderBottom() != !hasBorders);
Introduce a RequestGeometryBlocker in ShellClient Summary: The idea is to not send multiple resize requests to a client when we know that we might have multiple geometry changes. E.g. when going from maximized to restored the borders change and trigger a resize in addition to the resize from switching to restored. The implementation is inspired by the GeometryUpdateBlocker. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1808
2016-06-09 14:54:06 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Destroy the test client.
shellSurface.reset();
QVERIFY(Test::waitForWindowDestroyed(client));
Pass the maximized signal to DecoratedClient Summary: From the famous category: "How could that code ever have worked". Maximized state changes were never passed to window decorations. For X11 windows the decoration updated the state nevertheless, for Wayland windows the state did not get updated, thus a maximized window had borders and was shown with a not maximized button. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1805
2016-06-09 11:32:41 +00:00
}
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
void TestMaximized::testInitiallyMaximized()
{
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// This test verifies that a window created as maximized, will be maximized.
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Create the test client.
QScopedPointer<Surface> surface(Test::createSurface());
QScopedPointer<XdgShellSurface> shellSurface(
Test::createXdgShellStableSurface(surface.data(), surface.data(), Test::CreationSetup::CreateOnly));
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
QVERIFY(configureRequestedSpy.isValid());
shellSurface->setMaximized(true);
surface->commit(Surface::CommitFlag::None);
// Wait for the initial configure event.
XdgShellSurface::States states;
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 1);
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(!states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(states.testFlag(XdgShellSurface::State::Maximized));
// Now let's render in an incorrect size.
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Use AbstractClient instead of XdgShellClient wherever possible Summary: Currently, we have only one shell client type - XdgShellClient. We use it when we are dealing with Wayland clients. But it isn't really a good idea because we may need to support shell surfaces other than xdg-shell ones, for example input panel surfaces. In order to make kwin more extensible, this change replaces all usages of the XdgShellClient class with the AbstractClient class. Test Plan: Existing tests pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27778
2020-03-04 07:55:26 +00:00
AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
QVERIFY(client);
Rename geometry property to frameGeometry Summary: In order to properly implement xdg_surface.set_window_geometry we need two kinds of geometry - frame and buffer. The frame geometry specifies visible bounds of the client on the screen, excluding client-side drop shadows. The buffer geometry specifies rectangle on the screen that the attached buffer or x11 pixmap occupies on the screen. This change renames the geometry property to frameGeometry in order to reflect the new meaning assigned to it as well to make it easier to differentiate between frame geometry and buffer geometry in the future. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24334
2019-09-27 10:01:10 +00:00
QCOMPARE(client->frameGeometry(), QRect(0, 0, 100, 50));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
QEXPECT_FAIL("", "Should go out of maximzied", Continue);
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Destroy the client.
shellSurface.reset();
QVERIFY(Test::waitForWindowDestroyed(client));
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
}
Autotests: Add a test when relaunching a maximized cliend with BorderlessMaximizedWindows Test Plan: Test pass Reviewers: #kwin, zzag, davidedmundson Reviewed By: #kwin, zzag Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D29702
2020-05-13 10:53:43 +00:00
void TestMaximized::testInitiallyMaximizedBorderless()
{
// This test verifies that a window created as maximized, will be maximized and without Border with BorderlessMaximizedWindows
// adjust config
auto group = kwinApp()->config()->group("Windows");
group.writeEntry("BorderlessMaximizedWindows", true);
group.sync();
Workspace::self()->slotReconfigure();
QCOMPARE(options->borderlessMaximizedWindows(), true);
// Create the test client.
QScopedPointer<Surface> surface(Test::createSurface());
QScopedPointer<XdgShellSurface> shellSurface(
Test::createXdgShellStableSurface(surface.data(), surface.data(), Test::CreationSetup::CreateOnly));
QScopedPointer<XdgDecoration> decoration(
Test::xdgDecorationManager()->getToplevelDecoration(shellSurface.data()));
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
QVERIFY(configureRequestedSpy.isValid());
shellSurface->setMaximized(true);
QSignalSpy decorationConfiguredSpy(decoration.data(), &XdgDecoration::modeChanged);
QVERIFY(decorationConfiguredSpy.isValid());
decoration->setMode(XdgDecoration::Mode::ServerSide);
surface->commit(Surface::CommitFlag::None);
// Wait for the initial configure event.
XdgShellSurface::States states;
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 1);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024));
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(!states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(states.testFlag(XdgShellSurface::State::Maximized));
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(1280, 1024), Qt::blue);
QVERIFY(client);
QVERIFY(!client->isDecorated());
QVERIFY(client->isActive());
QVERIFY(client->isMaximizable());
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeFull);
QCOMPARE(client->requestedMaximizeMode(), MaximizeMode::MaximizeFull);
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
QCOMPARE(decoration->mode(), XdgDecoration::Mode::ServerSide);
// Destroy the client.
shellSurface.reset();
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(client));
}
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
void TestMaximized::testBorderlessMaximizedWindow()
{
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// This test verifies that a maximized client looses it's server-side
// decoration when the borderless maximized option is on.
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Enable the borderless maximized windows option.
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
auto group = kwinApp()->config()->group("Windows");
group.writeEntry("BorderlessMaximizedWindows", true);
group.sync();
Workspace::self()->slotReconfigure();
QCOMPARE(options->borderlessMaximizedWindows(), true);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Create the test client.
QScopedPointer<Surface> surface(Test::createSurface());
QScopedPointer<XdgShellSurface> shellSurface(
Test::createXdgShellStableSurface(surface.data(), surface.data(), Test::CreationSetup::CreateOnly));
QScopedPointer<XdgDecoration> decoration(
Test::xdgDecorationManager()->getToplevelDecoration(shellSurface.data()));
QSignalSpy decorationConfiguredSpy(decoration.data(), &XdgDecoration::modeChanged);
QVERIFY(decorationConfiguredSpy.isValid());
QSignalSpy configureRequestedSpy(shellSurface.data(), &XdgShellSurface::configureRequested);
QVERIFY(configureRequestedSpy.isValid());
decoration->setMode(XdgDecoration::Mode::ServerSide);
surface->commit(Surface::CommitFlag::None);
// Wait for the initial configure event.
XdgShellSurface::States states;
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 1);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(0, 0));
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(!states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(!states.testFlag(XdgShellSurface::State::Maximized));
// Map the client.
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Use AbstractClient instead of XdgShellClient wherever possible Summary: Currently, we have only one shell client type - XdgShellClient. We use it when we are dealing with Wayland clients. But it isn't really a good idea because we may need to support shell surfaces other than xdg-shell ones, for example input panel surfaces. In order to make kwin more extensible, this change replaces all usages of the XdgShellClient class with the AbstractClient class. Test Plan: Existing tests pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27778
2020-03-04 07:55:26 +00:00
AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QVERIFY(client);
QVERIFY(client->isActive());
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore);
QCOMPARE(client->requestedMaximizeMode(), MaximizeMode::MaximizeRestore);
QCOMPARE(client->isDecorated(), true);
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// We should receive a configure event when the client becomes active.
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 2);
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(!states.testFlag(XdgShellSurface::State::Maximized));
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Maximize the client.
Rename geometry property to frameGeometry Summary: In order to properly implement xdg_surface.set_window_geometry we need two kinds of geometry - frame and buffer. The frame geometry specifies visible bounds of the client on the screen, excluding client-side drop shadows. The buffer geometry specifies rectangle on the screen that the attached buffer or x11 pixmap occupies on the screen. This change renames the geometry property to frameGeometry in order to reflect the new meaning assigned to it as well to make it easier to differentiate between frame geometry and buffer geometry in the future. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24334
2019-09-27 10:01:10 +00:00
const QRect maximizeRestoreGeometry = client->frameGeometry();
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
workspace()->slotWindowMaximize();
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 3);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024));
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(states.testFlag(XdgShellSurface::State::Maximized));
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
QVERIFY(frameGeometryChangedSpy.isValid());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Test::render(surface.data(), QSize(1280, 1024), Qt::blue);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
Rename geometry property to frameGeometry Summary: In order to properly implement xdg_surface.set_window_geometry we need two kinds of geometry - frame and buffer. The frame geometry specifies visible bounds of the client on the screen, excluding client-side drop shadows. The buffer geometry specifies rectangle on the screen that the attached buffer or x11 pixmap occupies on the screen. This change renames the geometry property to frameGeometry in order to reflect the new meaning assigned to it as well to make it easier to differentiate between frame geometry and buffer geometry in the future. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24334
2019-09-27 10:01:10 +00:00
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeFull);
QCOMPARE(client->requestedMaximizeMode(), MaximizeMode::MaximizeFull);
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
QCOMPARE(client->isDecorated(), false);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Restore the client.
workspace()->slotWindowMaximize();
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 4);
QCOMPARE(configureRequestedSpy.last().at(0).toSize(), QSize(100, 50));
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(states.testFlag(XdgShellSurface::State::Activated));
QVERIFY(!states.testFlag(XdgShellSurface::State::Maximized));
shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
Test::render(surface.data(), QSize(100, 50), Qt::red);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
Rename geometry property to frameGeometry Summary: In order to properly implement xdg_surface.set_window_geometry we need two kinds of geometry - frame and buffer. The frame geometry specifies visible bounds of the client on the screen, excluding client-side drop shadows. The buffer geometry specifies rectangle on the screen that the attached buffer or x11 pixmap occupies on the screen. This change renames the geometry property to frameGeometry in order to reflect the new meaning assigned to it as well to make it easier to differentiate between frame geometry and buffer geometry in the future. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24334
2019-09-27 10:01:10 +00:00
QCOMPARE(client->frameGeometry(), maximizeRestoreGeometry);
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QCOMPARE(client->requestedMaximizeMode(), MaximizeMode::MaximizeRestore);
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
QCOMPARE(client->isDecorated(), true);
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
// Destroy the client.
shellSurface.reset();
QVERIFY(Test::waitForWindowDestroyed(client));
Implement borderlessMaximizedWindows for Wayland windows Summary: Maximize code was not yet adjusted to support decorations. Code is as much as possible similar to the X11 Client implementation. BUG: 370982 Test Plan: Added auto test and run a nested KWin/Wayland with the setting enabled Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3508
2016-11-25 15:45:40 +00:00
}
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
void TestMaximized::testBorderlessMaximizedWindowNoClientSideDecoration()
{
// test case verifies that borderless maximized windows doesn't cause
// clients to render client-side decorations instead (BUG 405385)
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
XdgShellSurface::States states;
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
// adjust config
auto group = kwinApp()->config()->group("Windows");
group.writeEntry("BorderlessMaximizedWindows", true);
group.sync();
Workspace::self()->slotReconfigure();
QCOMPARE(options->borderlessMaximizedWindows(), true);
QScopedPointer<Surface> surface(Test::createSurface());
QScopedPointer<XdgShellSurface> xdgShellSurface(Test::createXdgShellStableSurface(surface.data()));
QScopedPointer<XdgDecoration> deco(Test::xdgDecorationManager()->getToplevelDecoration(xdgShellSurface.data()));
QSignalSpy decorationConfiguredSpy(deco.data(), &XdgDecoration::modeChanged);
QVERIFY(decorationConfiguredSpy.isValid());
auto client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
QVERIFY(client->isDecorated());
QVERIFY(!client->noBorder());
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
Use AbstractClient instead of XdgShellClient wherever possible Summary: Currently, we have only one shell client type - XdgShellClient. We use it when we are dealing with Wayland clients. But it isn't really a good idea because we may need to support shell surfaces other than xdg-shell ones, for example input panel surfaces. In order to make kwin more extensible, this change replaces all usages of the XdgShellClient class with the AbstractClient class. Test Plan: Existing tests pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27778
2020-03-04 07:55:26 +00:00
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.isValid());
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
QSignalSpy configureRequestedSpy(xdgShellSurface.data(), &XdgShellSurface::configureRequested);
QVERIFY(configureRequestedSpy.isValid());
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
// Wait for the compositor to send a configure event with the Activated state.
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 1);
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(states & XdgShellSurface::State::Activated);
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
QCOMPARE(decorationConfiguredSpy.count(), 1);
QCOMPARE(deco->mode(), XdgDecoration::Mode::ServerSide);
// go to maximized
xdgShellSurface->setMaximized(true);
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 2);
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(states & XdgShellSurface::State::Maximized);
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
xdgShellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Test::render(surface.data(), configureRequestedSpy.last().first().toSize(), Qt::red);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
// no deco
QVERIFY(!client->isDecorated());
QVERIFY(client->noBorder());
// but still server-side
QCOMPARE(deco->mode(), XdgDecoration::Mode::ServerSide);
// go back to normal
xdgShellSurface->setMaximized(false);
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
QVERIFY(configureRequestedSpy.wait());
QCOMPARE(configureRequestedSpy.count(), 3);
states = configureRequestedSpy.last().at(1).value<XdgShellSurface::States>();
QVERIFY(!(states & XdgShellSurface::State::Maximized));
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
[wayland] Rework xdg-shell implementation Summary: This change splits the XdgShellClient class to better match existing abstractions in the xdg-shell protocol and fix a few issues related to sending configure events. In the new client classes, configure events are handled differently. Instead of blocking configure events, we try to send them as late as possible. Delaying configure events will let us merge changeMaximize() for X11 clients and Wayland clients and it also fixes the bug where we don't send the final configure event when user has finished resizing a window. Given that configure events are not sent immediately, XdgSurfaceClient keeps the last requested frame geometry and the last requested client geometry. This patch doesn't intend to fix all issues in kwin's implementation of the xdg-shell protocol. For example, we still handle surface unmapping very poorly. Test Plan: Tests pass. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27861
2020-02-17 18:39:17 +00:00
xdgShellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());
Test::render(surface.data(), configureRequestedSpy.last().first().toSize(), Qt::red);
Introduce Toplevel::frameGeometryChanged signal Summary: Currently we have two signals that are emitted when the Toplevel's geometry changes - geometryShapeChanged() and geometryChanged(). The former signal is used primarily to invalidate cached window quads and the latter is sort of emitted when the frame geometry changes. But it's not that easy. We have a bunch of connects that link those signals together... The worst part about all of this is that the window quads cache gets invalidated every time a geometry update occurs, for example when user moves a window around on the screen. This change introduces a new signal and deprecates the existing geometryChanged signal. frameGeometryChanged is similar to geometryChanged except that it is emitted when an _actual_ geometry change has occurred. We do still emit geometryShapeChanged signal. However, in long term, we need to get rid of this signal or come up with something that makes sense and doesn't require us to waste computational resources. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D26863
2020-02-05 09:28:50 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
Force server-side decoration if no borders are forced by user Otherwise the client will start drawing its own border now. BUG: 405385 FIXED-IN: 5.15.4 Differential Revision: https://phabricator.kde.org/D19705
2019-04-01 08:29:45 +00:00
QVERIFY(client->isDecorated());
QVERIFY(!client->noBorder());
QCOMPARE(deco->mode(), XdgDecoration::Mode::ServerSide);
}
[autotest/wayland] Add a test case for maximize windows The added test exposes the problem that a shell surface might request being maximized and then provide an incorrectly sized buffer. In this case the ShellClient is incorrectly considered as maximized. I don't have a good idea how to address this yet, but still publish the test case exposing the problem.
2016-06-07 08:27:02 +00:00
WAYLANDTEST_MAIN(TestMaximized)
#include "maximize_test.moc"
Reference in a new issue Copy permalink