2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2014-07-22 11:11:19 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
|
2014-07-22 11:11:19 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2014-07-22 11:11:19 +00:00
|
|
|
#include "settings.h"
|
|
|
|
// KWin
|
[decorations] Let KDecoration plugins recommend a border size per default
Summary:
This is an alternative solution to T8707 and in comparision to D13276 a less
drastic change to KWin's default behavior.
Instead of changing the border size default for all KDecoration plugins by
switching the default from border size Normal to None introduce new
functionality, which allows a KDecoration plugin to recommend a border size in
its metadata. By default KWin listens for these recommendations and sets the
border size accordingly.
If there is no metadata recommending a border size, KWin falls back to the
current setting of Normal sized borders.
A user is able to override the recommendations from the KCM, which has been
extended accordingly.
Test Plan: Manually with adjusted metadata of Breeze.
Reviewers: #kwin, #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin
Tags: #kwin
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13284
2019-05-04 14:48:44 +00:00
|
|
|
#include "decorationbridge.h"
|
2014-07-22 11:11:19 +00:00
|
|
|
#include "composite.h"
|
|
|
|
#include "virtualdesktops.h"
|
2014-12-04 15:28:06 +00:00
|
|
|
#include "workspace.h"
|
2017-12-12 14:00:43 +00:00
|
|
|
#include "appmenu.h"
|
2014-07-22 11:11:19 +00:00
|
|
|
|
2014-07-22 14:02:22 +00:00
|
|
|
#include <config-kwin.h>
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
#include <KDecoration2/DecorationSettings>
|
|
|
|
|
2014-07-22 14:02:22 +00:00
|
|
|
#include <KConfigGroup>
|
|
|
|
|
[decorations] Emit DecorationSettings::fontChanged signal
Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.
Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.
Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.
Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
BUG: 400980
FIXED-IN: 5.15.0
Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16908
2018-11-15 17:40:00 +00:00
|
|
|
#include <QFontDatabase>
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
namespace Decoration
|
|
|
|
{
|
|
|
|
SettingsImpl::SettingsImpl(KDecoration2::DecorationSettings *parent)
|
|
|
|
: QObject()
|
|
|
|
, DecorationSettingsPrivate(parent)
|
2014-07-24 06:37:48 +00:00
|
|
|
, m_borderSize(KDecoration2::BorderSize::Normal)
|
2014-07-22 11:11:19 +00:00
|
|
|
{
|
2014-07-22 14:02:22 +00:00
|
|
|
readSettings();
|
|
|
|
|
2014-12-03 12:10:35 +00:00
|
|
|
auto c = connect(Compositor::self(), &Compositor::compositingToggled,
|
2014-07-22 11:11:19 +00:00
|
|
|
parent, &KDecoration2::DecorationSettings::alphaChannelSupportedChanged);
|
|
|
|
connect(VirtualDesktopManager::self(), &VirtualDesktopManager::countChanged, this,
|
|
|
|
[parent](uint previous, uint current) {
|
|
|
|
if (previous != 1 && current != 1) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
emit parent->onAllDesktopsAvailableChanged(current > 1);
|
|
|
|
}
|
|
|
|
);
|
2014-12-03 12:10:35 +00:00
|
|
|
// prevent changes in Decoration due to Compositor being destroyed
|
|
|
|
connect(Compositor::self(), &Compositor::aboutToDestroy, this,
|
2020-03-15 19:59:29 +00:00
|
|
|
[c] { disconnect(c); }
|
2014-12-03 12:10:35 +00:00
|
|
|
);
|
2014-12-04 15:28:06 +00:00
|
|
|
connect(Workspace::self(), &Workspace::configChanged, this, &SettingsImpl::readSettings);
|
[decorations] Let KDecoration plugins recommend a border size per default
Summary:
This is an alternative solution to T8707 and in comparision to D13276 a less
drastic change to KWin's default behavior.
Instead of changing the border size default for all KDecoration plugins by
switching the default from border size Normal to None introduce new
functionality, which allows a KDecoration plugin to recommend a border size in
its metadata. By default KWin listens for these recommendations and sets the
border size accordingly.
If there is no metadata recommending a border size, KWin falls back to the
current setting of Normal sized borders.
A user is able to override the recommendations from the KCM, which has been
extended accordingly.
Test Plan: Manually with adjusted metadata of Breeze.
Reviewers: #kwin, #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin
Tags: #kwin
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13284
2019-05-04 14:48:44 +00:00
|
|
|
connect(DecorationBridge::self(), &DecorationBridge::metaDataLoaded, this, &SettingsImpl::readSettings);
|
2014-07-22 11:11:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
SettingsImpl::~SettingsImpl() = default;
|
|
|
|
|
|
|
|
bool SettingsImpl::isAlphaChannelSupported() const
|
|
|
|
{
|
|
|
|
return Compositor::self()->compositing();
|
|
|
|
}
|
|
|
|
|
|
|
|
bool SettingsImpl::isOnAllDesktopsAvailable() const
|
|
|
|
{
|
|
|
|
return VirtualDesktopManager::self()->count() > 1;
|
|
|
|
}
|
|
|
|
|
2014-07-25 06:07:08 +00:00
|
|
|
bool SettingsImpl::isCloseOnDoubleClickOnMenu() const
|
|
|
|
{
|
2014-12-04 15:28:06 +00:00
|
|
|
return m_closeDoubleClickMenu;
|
2014-07-25 06:07:08 +00:00
|
|
|
}
|
|
|
|
|
2014-07-22 14:02:22 +00:00
|
|
|
static QHash<KDecoration2::DecorationButtonType, QChar> s_buttonNames;
|
|
|
|
static void initButtons()
|
2014-07-22 11:11:19 +00:00
|
|
|
{
|
2014-07-22 14:02:22 +00:00
|
|
|
if (!s_buttonNames.isEmpty()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::Menu] = QChar('M');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::ApplicationMenu] = QChar('N');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::OnAllDesktops] = QChar('S');
|
2014-11-28 10:27:31 +00:00
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::ContextHelp] = QChar('H');
|
2014-07-22 14:02:22 +00:00
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::Minimize] = QChar('I');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::Maximize] = QChar('A');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::Close] = QChar('X');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::KeepAbove] = QChar('F');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::KeepBelow] = QChar('B');
|
|
|
|
s_buttonNames[KDecoration2::DecorationButtonType::Shade] = QChar('L');
|
|
|
|
}
|
|
|
|
|
2014-12-01 10:53:44 +00:00
|
|
|
static QString buttonsToString(const QVector<KDecoration2::DecorationButtonType> &buttons)
|
2014-07-22 14:02:22 +00:00
|
|
|
{
|
|
|
|
auto buttonToString = [](KDecoration2::DecorationButtonType button) -> QChar {
|
|
|
|
const auto it = s_buttonNames.constFind(button);
|
|
|
|
if (it != s_buttonNames.constEnd()) {
|
|
|
|
return it.value();
|
|
|
|
}
|
|
|
|
return QChar();
|
|
|
|
};
|
|
|
|
QString ret;
|
|
|
|
for (auto button : buttons) {
|
|
|
|
ret.append(buttonToString(button));
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-12-01 10:53:44 +00:00
|
|
|
QVector< KDecoration2::DecorationButtonType > SettingsImpl::readDecorationButtons(const KConfigGroup &config,
|
2014-07-22 14:02:22 +00:00
|
|
|
const char *key,
|
2014-12-01 10:53:44 +00:00
|
|
|
const QVector< KDecoration2::DecorationButtonType > &defaultValue) const
|
2014-07-22 14:02:22 +00:00
|
|
|
{
|
|
|
|
initButtons();
|
2014-12-01 10:53:44 +00:00
|
|
|
auto buttonsFromString = [](const QString &buttons) -> QVector<KDecoration2::DecorationButtonType> {
|
|
|
|
QVector<KDecoration2::DecorationButtonType> ret;
|
2014-07-22 14:02:22 +00:00
|
|
|
for (auto it = buttons.begin(); it != buttons.end(); ++it) {
|
|
|
|
for (auto it2 = s_buttonNames.constBegin(); it2 != s_buttonNames.constEnd(); ++it2) {
|
|
|
|
if (it2.value() == (*it)) {
|
|
|
|
ret << it2.key();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
};
|
|
|
|
return buttonsFromString(config.readEntry(key, buttonsToString(defaultValue)));
|
2014-07-22 11:11:19 +00:00
|
|
|
}
|
|
|
|
|
2014-12-04 15:28:06 +00:00
|
|
|
static KDecoration2::BorderSize stringToSize(const QString &name)
|
|
|
|
{
|
|
|
|
static const QMap<QString, KDecoration2::BorderSize> s_sizes = QMap<QString, KDecoration2::BorderSize>({
|
|
|
|
{QStringLiteral("None"), KDecoration2::BorderSize::None},
|
|
|
|
{QStringLiteral("NoSides"), KDecoration2::BorderSize::NoSides},
|
|
|
|
{QStringLiteral("Tiny"), KDecoration2::BorderSize::Tiny},
|
|
|
|
{QStringLiteral("Normal"), KDecoration2::BorderSize::Normal},
|
|
|
|
{QStringLiteral("Large"), KDecoration2::BorderSize::Large},
|
|
|
|
{QStringLiteral("VeryLarge"), KDecoration2::BorderSize::VeryLarge},
|
|
|
|
{QStringLiteral("Huge"), KDecoration2::BorderSize::Huge},
|
|
|
|
{QStringLiteral("VeryHuge"), KDecoration2::BorderSize::VeryHuge},
|
|
|
|
{QStringLiteral("Oversized"), KDecoration2::BorderSize::Oversized}
|
|
|
|
});
|
|
|
|
auto it = s_sizes.constFind(name);
|
|
|
|
if (it == s_sizes.constEnd()) {
|
|
|
|
// non sense values are interpreted just like normal
|
|
|
|
return KDecoration2::BorderSize::Normal;
|
|
|
|
}
|
|
|
|
return it.value();
|
|
|
|
}
|
|
|
|
|
2014-07-22 14:02:22 +00:00
|
|
|
void SettingsImpl::readSettings()
|
2014-07-22 11:11:19 +00:00
|
|
|
{
|
2016-01-29 10:24:18 +00:00
|
|
|
KConfigGroup config = kwinApp()->config()->group(QStringLiteral("org.kde.kdecoration2"));
|
2014-12-04 15:28:06 +00:00
|
|
|
const auto &left = readDecorationButtons(config, "ButtonsOnLeft", QVector<KDecoration2::DecorationButtonType >({
|
2014-07-22 14:02:22 +00:00
|
|
|
KDecoration2::DecorationButtonType::Menu,
|
|
|
|
KDecoration2::DecorationButtonType::OnAllDesktops
|
|
|
|
}));
|
2014-12-04 15:28:06 +00:00
|
|
|
if (left != m_leftButtons) {
|
|
|
|
m_leftButtons = left;
|
|
|
|
emit decorationSettings()->decorationButtonsLeftChanged(m_leftButtons);
|
|
|
|
}
|
|
|
|
const auto &right = readDecorationButtons(config, "ButtonsOnRight", QVector<KDecoration2::DecorationButtonType >({
|
2014-12-09 15:05:19 +00:00
|
|
|
KDecoration2::DecorationButtonType::ContextHelp,
|
2014-07-22 11:11:19 +00:00
|
|
|
KDecoration2::DecorationButtonType::Minimize,
|
|
|
|
KDecoration2::DecorationButtonType::Maximize,
|
|
|
|
KDecoration2::DecorationButtonType::Close
|
2014-07-22 14:02:22 +00:00
|
|
|
}));
|
2014-12-04 15:28:06 +00:00
|
|
|
if (right != m_rightButtons) {
|
|
|
|
m_rightButtons = right;
|
|
|
|
emit decorationSettings()->decorationButtonsRightChanged(m_rightButtons);
|
|
|
|
}
|
2017-12-12 14:00:43 +00:00
|
|
|
ApplicationMenu::self()->setViewEnabled(left.contains(KDecoration2::DecorationButtonType::ApplicationMenu) || right.contains(KDecoration2::DecorationButtonType::ApplicationMenu));
|
2014-12-04 15:28:06 +00:00
|
|
|
const bool close = config.readEntry("CloseOnDoubleClickOnMenu", false);
|
|
|
|
if (close != m_closeDoubleClickMenu) {
|
|
|
|
m_closeDoubleClickMenu = close;
|
|
|
|
emit decorationSettings()->closeOnDoubleClickOnMenuChanged(m_closeDoubleClickMenu);
|
|
|
|
}
|
[decorations] Let KDecoration plugins recommend a border size per default
Summary:
This is an alternative solution to T8707 and in comparision to D13276 a less
drastic change to KWin's default behavior.
Instead of changing the border size default for all KDecoration plugins by
switching the default from border size Normal to None introduce new
functionality, which allows a KDecoration plugin to recommend a border size in
its metadata. By default KWin listens for these recommendations and sets the
border size accordingly.
If there is no metadata recommending a border size, KWin falls back to the
current setting of Normal sized borders.
A user is able to override the recommendations from the KCM, which has been
extended accordingly.
Test Plan: Manually with adjusted metadata of Breeze.
Reviewers: #kwin, #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin
Tags: #kwin
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13284
2019-05-04 14:48:44 +00:00
|
|
|
m_autoBorderSize = config.readEntry("BorderSizeAuto", true);
|
|
|
|
|
|
|
|
auto size = stringToSize(config.readEntry("BorderSize", QStringLiteral("Normal")));
|
|
|
|
if (m_autoBorderSize) {
|
|
|
|
/* Falls back to Normal border size, if the plugin does not provide a valid recommendation. */
|
|
|
|
size = stringToSize(DecorationBridge::self()->recommendedBorderSize());
|
|
|
|
}
|
2014-12-04 15:28:06 +00:00
|
|
|
if (size != m_borderSize) {
|
|
|
|
m_borderSize = size;
|
|
|
|
emit decorationSettings()->borderSizeChanged(m_borderSize);
|
|
|
|
}
|
[decorations] Emit DecorationSettings::fontChanged signal
Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.
Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.
Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.
Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
BUG: 400980
FIXED-IN: 5.15.0
Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16908
2018-11-15 17:40:00 +00:00
|
|
|
const QFont font = QFontDatabase::systemFont(QFontDatabase::TitleFont);
|
|
|
|
if (font != m_font) {
|
|
|
|
m_font = font;
|
|
|
|
emit decorationSettings()->fontChanged(m_font);
|
|
|
|
}
|
2014-12-05 14:58:05 +00:00
|
|
|
|
|
|
|
emit decorationSettings()->reconfigured();
|
2014-07-22 11:11:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|