2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 1999, 2000 Matthias Ettrich <ettrich@kde.org>
|
|
|
|
SPDX-FileCopyrightText: 2003 Lubos Lunak <l.lunak@kde.org>
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
#ifndef MAIN_H
|
|
|
|
#define MAIN_H
|
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
#include <kwinglobals.h>
|
2014-08-15 12:03:52 +00:00
|
|
|
#include <config-kwin.h>
|
2014-08-12 07:08:48 +00:00
|
|
|
|
2016-01-29 08:48:02 +00:00
|
|
|
#include <KSharedConfig>
|
2013-07-26 05:52:56 +00:00
|
|
|
// Qt
|
2013-08-28 12:10:51 +00:00
|
|
|
#include <QApplication>
|
2013-07-26 05:52:56 +00:00
|
|
|
#include <QAbstractNativeEventFilter>
|
2015-07-07 15:35:57 +00:00
|
|
|
#include <QProcessEnvironment>
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2016-04-06 15:30:00 +00:00
|
|
|
class KPluginMetaData;
|
2014-08-12 07:08:48 +00:00
|
|
|
class QCommandLineParser;
|
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
2016-04-07 07:18:10 +00:00
|
|
|
class Platform;
|
2021-01-31 12:12:02 +00:00
|
|
|
class X11EventFilter;
|
2016-04-06 15:30:00 +00:00
|
|
|
|
2013-07-26 05:52:56 +00:00
|
|
|
class XcbEventFilter : public QAbstractNativeEventFilter
|
|
|
|
{
|
|
|
|
public:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
bool nativeEventFilter(const QByteArray &eventType, void *message, long int *result) override;
|
2013-07-26 05:52:56 +00:00
|
|
|
};
|
|
|
|
|
2021-01-31 12:12:02 +00:00
|
|
|
class X11EventFilterContainer : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
|
|
|
|
public:
|
|
|
|
explicit X11EventFilterContainer(X11EventFilter *filter);
|
|
|
|
|
|
|
|
X11EventFilter *filter() const;
|
|
|
|
|
|
|
|
private:
|
|
|
|
X11EventFilter *m_filter;
|
|
|
|
};
|
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
class KWIN_EXPORT Application : public QApplication
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2007-04-29 17:35:43 +00:00
|
|
|
Q_OBJECT
|
2015-02-19 08:59:21 +00:00
|
|
|
Q_PROPERTY(quint32 x11Time READ x11Time WRITE setX11Time)
|
2015-02-18 07:31:53 +00:00
|
|
|
Q_PROPERTY(quint32 x11RootWindow READ x11RootWindow CONSTANT)
|
2015-02-18 10:19:04 +00:00
|
|
|
Q_PROPERTY(void *x11Connection READ x11Connection NOTIFY x11ConnectionChanged)
|
2015-02-18 10:52:51 +00:00
|
|
|
Q_PROPERTY(int x11ScreenNumber READ x11ScreenNumber CONSTANT)
|
2016-11-16 15:53:17 +00:00
|
|
|
Q_PROPERTY(KSharedConfigPtr config READ config WRITE setConfig)
|
2017-01-27 16:15:32 +00:00
|
|
|
Q_PROPERTY(KSharedConfigPtr kxkbConfig READ kxkbConfig WRITE setKxkbConfig)
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
2013-06-25 06:52:08 +00:00
|
|
|
/**
|
2019-02-02 18:17:44 +00:00
|
|
|
* @brief This enum provides the various operation modes of KWin depending on the available
|
|
|
|
* Windowing Systems at startup. For example whether KWin only talks to X11 or also to a Wayland
|
|
|
|
* Compositor.
|
|
|
|
*
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2013-06-25 06:52:08 +00:00
|
|
|
enum OperationMode {
|
|
|
|
/**
|
2019-02-02 18:17:44 +00:00
|
|
|
* @brief KWin uses only X11 for managing windows and compositing
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2013-06-25 06:52:08 +00:00
|
|
|
OperationModeX11,
|
|
|
|
/**
|
2017-09-30 13:09:06 +00:00
|
|
|
* @brief KWin uses only Wayland
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2017-09-30 13:09:06 +00:00
|
|
|
OperationModeWaylandOnly,
|
2015-01-09 15:00:16 +00:00
|
|
|
/**
|
|
|
|
* @brief KWin uses Wayland and controls a nested Xwayland server.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2015-01-09 15:00:16 +00:00
|
|
|
OperationModeXwayland
|
2013-06-25 06:52:08 +00:00
|
|
|
};
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~Application() override;
|
2011-01-30 14:34:42 +00:00
|
|
|
|
2013-08-28 12:10:51 +00:00
|
|
|
void setConfigLock(bool lock);
|
|
|
|
|
2016-01-29 08:48:02 +00:00
|
|
|
KSharedConfigPtr config() const {
|
|
|
|
return m_config;
|
|
|
|
}
|
|
|
|
void setConfig(KSharedConfigPtr config) {
|
2019-10-29 22:04:15 +00:00
|
|
|
m_config = std::move(config);
|
2016-01-29 08:48:02 +00:00
|
|
|
}
|
|
|
|
|
2017-01-27 16:15:32 +00:00
|
|
|
KSharedConfigPtr kxkbConfig() const {
|
|
|
|
return m_kxkbConfig;
|
|
|
|
}
|
|
|
|
void setKxkbConfig(KSharedConfigPtr config) {
|
2019-10-29 22:04:15 +00:00
|
|
|
m_kxkbConfig = std::move(config);
|
2017-01-27 16:15:32 +00:00
|
|
|
}
|
|
|
|
|
2013-08-28 12:10:51 +00:00
|
|
|
void start();
|
2013-06-25 06:52:08 +00:00
|
|
|
/**
|
2019-02-02 18:17:44 +00:00
|
|
|
* @brief The operation mode used by KWin.
|
|
|
|
*
|
|
|
|
* @return OperationMode
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2013-06-25 06:52:08 +00:00
|
|
|
OperationMode operationMode() const;
|
|
|
|
void setOperationMode(OperationMode mode);
|
2013-06-25 07:53:45 +00:00
|
|
|
bool shouldUseWaylandForCompositing() const;
|
2013-08-28 12:10:51 +00:00
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
void setupTranslator();
|
|
|
|
void setupCommandLine(QCommandLineParser *parser);
|
|
|
|
void processCommandLine(QCommandLineParser *parser);
|
|
|
|
|
2021-01-31 12:12:02 +00:00
|
|
|
void registerEventFilter(X11EventFilter *filter);
|
|
|
|
void unregisterEventFilter(X11EventFilter *filter);
|
|
|
|
bool dispatchEvent(xcb_generic_event_t *event);
|
|
|
|
|
2015-02-19 08:59:21 +00:00
|
|
|
xcb_timestamp_t x11Time() const {
|
|
|
|
return m_x11Time;
|
|
|
|
}
|
2017-05-03 19:17:25 +00:00
|
|
|
enum class TimestampUpdate {
|
|
|
|
OnlyIfLarger,
|
|
|
|
Always
|
|
|
|
};
|
|
|
|
void setX11Time(xcb_timestamp_t timestamp, TimestampUpdate force = TimestampUpdate::OnlyIfLarger) {
|
2017-05-06 17:52:41 +00:00
|
|
|
if ((timestamp > m_x11Time || force == TimestampUpdate::Always) && timestamp != 0) {
|
2015-02-19 08:59:21 +00:00
|
|
|
m_x11Time = timestamp;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
void updateX11Time(xcb_generic_event_t *event);
|
2015-02-20 13:53:03 +00:00
|
|
|
void createScreens();
|
2015-02-19 08:59:21 +00:00
|
|
|
|
2013-08-28 12:10:51 +00:00
|
|
|
static void setCrashCount(int count);
|
|
|
|
static bool wasCrash();
|
2020-09-23 18:39:59 +00:00
|
|
|
void resetCrashesCount();
|
2013-08-28 12:10:51 +00:00
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
/**
|
|
|
|
* Creates the KAboutData object for the KWin instance and registers it as
|
|
|
|
* KAboutData::setApplicationData.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-08-12 07:08:48 +00:00
|
|
|
static void createAboutData();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @returns the X11 Screen number. If not applicable it's set to @c -1.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-08-12 07:08:48 +00:00
|
|
|
static int x11ScreenNumber();
|
|
|
|
/**
|
|
|
|
* Sets the X11 screen number of this KWin instance to @p screenNumber.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-08-12 07:08:48 +00:00
|
|
|
static void setX11ScreenNumber(int screenNumber);
|
|
|
|
/**
|
|
|
|
* @returns whether this is a multi head setup on X11.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-08-12 07:08:48 +00:00
|
|
|
static bool isX11MultiHead();
|
|
|
|
/**
|
|
|
|
* Sets whether this is a multi head setup on X11.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2014-08-12 07:08:48 +00:00
|
|
|
static void setX11MultiHead(bool multiHead);
|
|
|
|
|
2015-02-18 07:31:53 +00:00
|
|
|
/**
|
|
|
|
* @returns the X11 root window.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2015-02-18 07:31:53 +00:00
|
|
|
xcb_window_t x11RootWindow() const {
|
|
|
|
return m_rootWindow;
|
|
|
|
}
|
|
|
|
|
2015-02-18 10:19:04 +00:00
|
|
|
/**
|
|
|
|
* @returns the X11 xcb connection
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2015-02-18 10:19:04 +00:00
|
|
|
xcb_connection_t *x11Connection() const {
|
|
|
|
return m_connection;
|
|
|
|
}
|
|
|
|
|
2020-07-28 07:58:35 +00:00
|
|
|
/**
|
|
|
|
* @returns the X11 default screen
|
|
|
|
*/
|
|
|
|
xcb_screen_t *x11DefaultScreen() const {
|
|
|
|
return m_defaultScreen;
|
|
|
|
}
|
|
|
|
|
2020-10-14 15:04:57 +00:00
|
|
|
/**
|
|
|
|
* Returns @c true if we're in the middle of destroying the X11 connection.
|
|
|
|
*/
|
|
|
|
bool isClosingX11Connection() const {
|
|
|
|
return m_isClosingX11Connection;
|
|
|
|
}
|
|
|
|
|
2015-11-24 08:01:46 +00:00
|
|
|
#ifdef KWIN_BUILD_ACTIVITIES
|
|
|
|
bool usesKActivities() const {
|
|
|
|
return m_useKActivities;
|
|
|
|
}
|
|
|
|
void setUseKActivities(bool use) {
|
|
|
|
m_useKActivities = use;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2015-07-07 15:35:57 +00:00
|
|
|
virtual QProcessEnvironment processStartupEnvironment() const;
|
|
|
|
|
2016-04-06 15:30:00 +00:00
|
|
|
void initPlatform(const KPluginMetaData &plugin);
|
2016-04-07 07:18:10 +00:00
|
|
|
Platform *platform() const {
|
2016-04-06 15:30:00 +00:00
|
|
|
return m_platform;
|
|
|
|
}
|
|
|
|
|
2019-01-06 16:05:10 +00:00
|
|
|
bool isTerminating() const {
|
|
|
|
return m_terminating;
|
|
|
|
}
|
|
|
|
|
2014-08-12 07:08:48 +00:00
|
|
|
static void setupMalloc();
|
|
|
|
static void setupLocalizedString();
|
|
|
|
|
2014-08-15 12:03:52 +00:00
|
|
|
static bool usesLibinput();
|
|
|
|
static void setUseLibinput(bool use);
|
|
|
|
|
2015-02-18 10:19:04 +00:00
|
|
|
Q_SIGNALS:
|
|
|
|
void x11ConnectionChanged();
|
2015-11-12 14:13:42 +00:00
|
|
|
void x11ConnectionAboutToBeDestroyed();
|
2015-02-23 14:53:24 +00:00
|
|
|
void workspaceCreated();
|
2015-03-27 14:14:23 +00:00
|
|
|
void screensCreated();
|
2020-12-03 19:47:42 +00:00
|
|
|
void platformCreated();
|
2015-04-15 15:47:56 +00:00
|
|
|
void virtualTerminalCreated();
|
2020-07-07 09:32:29 +00:00
|
|
|
void started();
|
2015-02-18 10:19:04 +00:00
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
protected:
|
2014-08-12 07:08:48 +00:00
|
|
|
Application(OperationMode mode, int &argc, char **argv);
|
|
|
|
virtual void performStartup() = 0;
|
|
|
|
|
|
|
|
void notifyKSplash();
|
2020-07-07 09:32:29 +00:00
|
|
|
void notifyStarted();
|
2015-02-20 13:53:03 +00:00
|
|
|
void createInput();
|
2014-08-12 07:08:48 +00:00
|
|
|
void createWorkspace();
|
|
|
|
void createAtoms();
|
|
|
|
void createOptions();
|
2020-11-26 18:41:20 +00:00
|
|
|
void createPlugins();
|
2020-11-27 19:37:40 +00:00
|
|
|
void createColorManager();
|
2021-10-14 07:40:08 +00:00
|
|
|
void createInputMethod();
|
2020-07-20 08:07:08 +00:00
|
|
|
void installNativeX11EventFilter();
|
|
|
|
void removeNativeX11EventFilter();
|
2021-09-27 10:02:24 +00:00
|
|
|
void destroyInput();
|
2014-08-12 07:08:48 +00:00
|
|
|
void destroyWorkspace();
|
2015-05-27 07:09:05 +00:00
|
|
|
void destroyCompositor();
|
2020-11-26 18:41:20 +00:00
|
|
|
void destroyPlugins();
|
2020-11-27 19:37:40 +00:00
|
|
|
void destroyColorManager();
|
2021-10-14 07:40:08 +00:00
|
|
|
void destroyInputMethod();
|
2015-02-18 07:31:53 +00:00
|
|
|
/**
|
|
|
|
* Inheriting classes should use this method to set the X11 root window
|
|
|
|
* before accessing any X11 specific code pathes.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2015-02-18 07:31:53 +00:00
|
|
|
void setX11RootWindow(xcb_window_t root) {
|
|
|
|
m_rootWindow = root;
|
|
|
|
}
|
2015-02-18 10:19:04 +00:00
|
|
|
/**
|
|
|
|
* Inheriting classes should use this method to set the xcb connection
|
|
|
|
* before accessing any X11 specific code pathes.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2015-02-18 10:19:04 +00:00
|
|
|
void setX11Connection(xcb_connection_t *c) {
|
|
|
|
m_connection = c;
|
|
|
|
}
|
2020-07-28 07:58:35 +00:00
|
|
|
/**
|
|
|
|
* Inheriting classes should use this method to set the default screen
|
|
|
|
* before accessing any X11 specific code pathes.
|
|
|
|
*/
|
|
|
|
void setX11DefaultScreen(xcb_screen_t *screen) {
|
|
|
|
m_defaultScreen = screen;
|
|
|
|
}
|
2015-05-26 12:26:56 +00:00
|
|
|
void destroyAtoms();
|
Fix crash in XRenderPictureData::~XRenderPictureData
Summary:
If the XRender scene has cross-faded a window, then, eventually, KWin/X11 will
crash in the destructor of the XRenderPictureData class during tear down with
the following message in the terminal
```
ASSERT: "qApp" in file /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwinxrenderutils.cpp, line 163
```
The crash happens because X11StandalonePlatform attempts to clean up XRender
resources, including XRenderUtils::s_blendPicture, after the application object
has been destroyed.
In order to fix the crash, we have to destroy the platform object before the
destructor of QCoreApplication is executed.
Test Plan:
- Enable maximize effect
- Maximize a window
- Replace the current instance of KWin/X11 with another one
Without this patch, KWin/X11 crashes after the third step.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D25768
2019-12-12 12:06:20 +00:00
|
|
|
void destroyPlatform();
|
2014-08-12 07:08:48 +00:00
|
|
|
|
2019-01-06 16:05:10 +00:00
|
|
|
void setTerminating() {
|
|
|
|
m_terminating = true;
|
|
|
|
}
|
2020-10-14 15:04:57 +00:00
|
|
|
void setClosingX11Connection(bool set) {
|
|
|
|
m_isClosingX11Connection = set;
|
|
|
|
}
|
2019-01-06 16:05:10 +00:00
|
|
|
|
2015-05-01 14:55:15 +00:00
|
|
|
protected:
|
2016-05-06 14:28:29 +00:00
|
|
|
static int crashes;
|
2015-05-01 14:55:15 +00:00
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
private:
|
2021-01-31 12:12:02 +00:00
|
|
|
QList<QPointer<X11EventFilterContainer>> m_eventFilters;
|
|
|
|
QList<QPointer<X11EventFilterContainer>> m_genericEventFilters;
|
2013-07-26 05:52:56 +00:00
|
|
|
QScopedPointer<XcbEventFilter> m_eventFilter;
|
2013-08-28 12:10:51 +00:00
|
|
|
bool m_configLock;
|
2016-01-29 08:48:02 +00:00
|
|
|
KSharedConfigPtr m_config;
|
2017-01-27 16:15:32 +00:00
|
|
|
KSharedConfigPtr m_kxkbConfig;
|
2013-06-25 06:52:08 +00:00
|
|
|
OperationMode m_operationMode;
|
2015-02-19 08:59:21 +00:00
|
|
|
xcb_timestamp_t m_x11Time = XCB_TIME_CURRENT_TIME;
|
2015-02-18 07:31:53 +00:00
|
|
|
xcb_window_t m_rootWindow = XCB_WINDOW_NONE;
|
2015-02-18 10:19:04 +00:00
|
|
|
xcb_connection_t *m_connection = nullptr;
|
2020-07-28 07:58:35 +00:00
|
|
|
xcb_screen_t *m_defaultScreen = nullptr;
|
2015-11-24 08:01:46 +00:00
|
|
|
#ifdef KWIN_BUILD_ACTIVITIES
|
|
|
|
bool m_useKActivities = true;
|
|
|
|
#endif
|
2016-04-07 07:18:10 +00:00
|
|
|
Platform *m_platform = nullptr;
|
2019-01-06 16:05:10 +00:00
|
|
|
bool m_terminating = false;
|
2020-10-14 15:04:57 +00:00
|
|
|
bool m_isClosingX11Connection = false;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2014-01-09 13:47:57 +00:00
|
|
|
inline static Application *kwinApp()
|
|
|
|
{
|
|
|
|
return static_cast<Application*>(QCoreApplication::instance());
|
|
|
|
}
|
|
|
|
|
2018-08-22 00:20:16 +00:00
|
|
|
namespace Xwl
|
|
|
|
{
|
|
|
|
class Xwayland;
|
|
|
|
}
|
|
|
|
|
|
|
|
class KWIN_EXPORT ApplicationWaylandAbstract : public Application
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~ApplicationWaylandAbstract() override = 0;
|
2018-08-22 00:20:16 +00:00
|
|
|
protected:
|
|
|
|
friend class Xwl::Xwayland;
|
|
|
|
|
|
|
|
ApplicationWaylandAbstract(OperationMode mode, int &argc, char **argv);
|
|
|
|
virtual void setProcessStartupEnvironment(const QProcessEnvironment &environment) {
|
|
|
|
Q_UNUSED(environment);
|
|
|
|
}
|
|
|
|
virtual void startSession() {}
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
} // namespace
|
|
|
|
|
|
|
|
#endif
|