yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/screenedge_client_show_test.cpp

262 lines
11 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
#include "kwin_wayland_test.h"
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
Move multi-purpose code in its own directory Things such as Output, InputDevice and so on are made to be multi-purpose. In order to make this separation more clear, this change moves that code in the core directory. Some things still link to the abstraction level above (kwin), they can be tackled in future refactors. Ideally code in core/ should depend either on other code in core/ or system libs.
2022-08-29 07:55:49 +00:00
#include "core/output.h"
core: Rename Platform to OutputBackend
2022-11-05 10:43:41 +00:00
#include "core/outputbackend.h"
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
#include "deleted.h"
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
#include "pointer_input.h"
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
#include "screenedge.h"
#include "wayland_server.h"
#include "workspace.h"
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
#include "x11window.h"
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
#include <kwineffects.h>
#include <netwm.h>
#include <xcb/xcb_icccm.h>
namespace KWin
{
static const QString s_socketName = QStringLiteral("wayland_test_kwin_screenedge_client_show-0");
class ScreenEdgeClientShowTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase();
void init();
void testScreenEdgeShowHideX11_data();
void testScreenEdgeShowHideX11();
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
void testScreenEdgeShowX11Touch_data();
void testScreenEdgeShowX11Touch();
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
};
void ScreenEdgeClientShowTest::initTestCase()
{
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
qRegisterMetaType<KWin::Window *>();
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
qRegisterMetaType<KWin::Deleted *>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
Avoid converting socket name between QString and QByteArray back and forth It only contributes overhead.
2020-12-09 13:06:15 +00:00
QVERIFY(waylandServer()->init(s_socketName));
autotests: Port away from OutputBackend::setInitialWindowSize()
2022-11-16 21:03:50 +00:00
QMetaObject::invokeMethod(kwinApp()->outputBackend(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(QVector<QRect>, QVector<QRect>() << QRect(0, 0, 1280, 1024) << QRect(1280, 0, 1280, 1024)));
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
[autotest] Disable default TabBox on touch screen edge in ScreenEdgeClientShowTest Not needed and the QML doesn't work well in tests.
2017-06-19 19:54:11 +00:00
// set custom config which disable touch edge
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
KConfigGroup group = config->group("TabBox");
group.writeEntry(QStringLiteral("TouchBorderActivate"), "9");
group.sync();
kwinApp()->setConfig(config);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const auto outputs = workspace()->outputs();
autotests: Port common screen check preamble to AbstractOutput
2021-08-31 07:03:05 +00:00
QCOMPARE(outputs.count(), 2);
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
setenv("QT_QPA_PLATFORM", "wayland", true);
}
void ScreenEdgeClientShowTest::init()
{
Move active output tracking to workspace Active output is a window management concept. It indicates what output new windows have to be placed on if they have no output hint. So Workspace seems to be a better place for it than the Screens class, which is obsolete.
2021-08-28 18:58:29 +00:00
workspace()->setActiveOutput(QPoint(640, 512));
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(QPoint(640, 512));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QVERIFY(waylandServer()->windows().isEmpty());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
}
void ScreenEdgeClientShowTest::testScreenEdgeShowHideX11_data()
{
QTest::addColumn<QRect>("windowGeometry");
support for auto-hidden windows to resize Summary: auto hidden windows were shown again when their geometry changed, this was done for being as easy as possible as the unhide zone changed, but the behavior looked very annoying as autohide panels with an self resize taskbar would unhide themselves every time any window gets open or closed. This makes the edge keep track of windows that can resize/move themselves while auto hidden Test Plan: a self-resizing autohidden panel with a taskbar in it doesn't auto unhide anymore when a window is opened or closed. the unhide area gets properly updated Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: luebking, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4718
2017-03-08 22:54:58 +00:00
QTest::addColumn<QRect>("resizedWindowGeometry");
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
QTest::addColumn<quint32>("location");
QTest::addColumn<QPoint>("triggerPos");
support for auto-hidden windows to resize Summary: auto hidden windows were shown again when their geometry changed, this was done for being as easy as possible as the unhide zone changed, but the behavior looked very annoying as autohide panels with an self resize taskbar would unhide themselves every time any window gets open or closed. This makes the edge keep track of windows that can resize/move themselves while auto hidden Test Plan: a self-resizing autohidden panel with a taskbar in it doesn't auto unhide anymore when a window is opened or closed. the unhide area gets properly updated Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: luebking, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4718
2017-03-08 22:54:58 +00:00
QTest::newRow("bottom/left") << QRect(50, 1004, 1180, 20) << QRect(150, 1004, 1000, 20) << 2u << QPoint(100, 1023);
QTest::newRow("bottom/right") << QRect(1330, 1004, 1180, 20) << QRect(1410, 1004, 1000, 20) << 2u << QPoint(1400, 1023);
QTest::newRow("top/left") << QRect(50, 0, 1180, 20) << QRect(150, 0, 1000, 20) << 0u << QPoint(100, 0);
QTest::newRow("top/right") << QRect(1330, 0, 1180, 20) << QRect(1410, 0, 1000, 20) << 0u << QPoint(1400, 0);
QTest::newRow("left") << QRect(0, 10, 20, 1000) << QRect(0, 70, 20, 800) << 3u << QPoint(0, 50);
QTest::newRow("right") << QRect(2540, 10, 20, 1000) << QRect(2540, 70, 20, 800) << 1u << QPoint(2559, 60);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
}
void ScreenEdgeClientShowTest::testScreenEdgeShowHideX11()
{
// this test creates a window which borders the screen and sets the screenedge show hint
// that should trigger a show of the window whenever the cursor is pushed against the screen edge
// create the test window
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
// atom for the screenedge show hide functionality
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
Xcb::Atom atom(QByteArrayLiteral("_KDE_NET_WM_SCREEN_EDGE_SHOW"), false, c.get());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
QFETCH(QRect, windowGeometry);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
info.setWindowType(NET::Dock);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.last().first().value<X11Window *>();
QVERIFY(window);
QVERIFY(!window->isDecorated());
QCOMPARE(window->frameGeometry(), windowGeometry);
QVERIFY(!window->hasStrut());
QVERIFY(!window->isHiddenInternal());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QSignalSpy effectsWindowAdded(effects, &EffectsHandler::windowAdded);
QVERIFY(effectsWindowAdded.wait());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
// now try to hide
QFETCH(quint32, location);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_change_property(c.get(), XCB_PROP_MODE_REPLACE, windowId, atom, XCB_ATOM_CARDINAL, 32, 1, &location);
xcb_flush(c.get());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QSignalSpy effectsWindowHiddenSpy(effects, &EffectsHandler::windowHidden);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QSignalSpy clientHiddenSpy(window, &X11Window::windowHidden);
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QVERIFY(clientHiddenSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(window->isHiddenInternal());
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QCOMPARE(effectsWindowHiddenSpy.count(), 1);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
// now trigger the edge
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QSignalSpy effectsWindowShownSpy(effects, &EffectsHandler::windowShown);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
QFETCH(QPoint, triggerPos);
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(triggerPos);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(!window->isHiddenInternal());
Emit windowShown and windowHidden from Client::internalKeep and ::internalHide Summary: With this change auto-hiding panels are animated again by SlidingPopups effect. Test Plan: Test case adjusted, and tested in VM Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2157 BUG: 354407 FIXED-IN: 5.8.0
2016-07-14 08:54:35 +00:00
QCOMPARE(effectsWindowShownSpy.count(), 1);
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
[autotests] Fix ScreenEdgeClientShowTest::testScreenEdgeShowHideX11 on new CI On the new CI system this test is failing. This might be a variation of Qt 5.10 as I'm able to reproduce with Qt 5.10. From the investigation it is not a bug in KWin. The test was failing due to a missing xcb_flush. This happens when we go back to the event loop which seems not to happen in proper timing. By adding a qWait we force to go to the event loop, the flush is performed and the test passes.
2017-06-19 19:45:58 +00:00
// go into event loop to trigger xcb_flush
QTest::qWait(1);
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
// hide window again
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(QPoint(640, 512));
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_change_property(c.get(), XCB_PROP_MODE_REPLACE, windowId, atom, XCB_ATOM_CARDINAL, 32, 1, &location);
xcb_flush(c.get());
support for auto-hidden windows to resize Summary: auto hidden windows were shown again when their geometry changed, this was done for being as easy as possible as the unhide zone changed, but the behavior looked very annoying as autohide panels with an self resize taskbar would unhide themselves every time any window gets open or closed. This makes the edge keep track of windows that can resize/move themselves while auto hidden Test Plan: a self-resizing autohidden panel with a taskbar in it doesn't auto unhide anymore when a window is opened or closed. the unhide area gets properly updated Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: luebking, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4718
2017-03-08 22:54:58 +00:00
QVERIFY(clientHiddenSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(window->isHiddenInternal());
support for auto-hidden windows to resize Summary: auto hidden windows were shown again when their geometry changed, this was done for being as easy as possible as the unhide zone changed, but the behavior looked very annoying as autohide panels with an self resize taskbar would unhide themselves every time any window gets open or closed. This makes the edge keep track of windows that can resize/move themselves while auto hidden Test Plan: a self-resizing autohidden panel with a taskbar in it doesn't auto unhide anymore when a window is opened or closed. the unhide area gets properly updated Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: luebking, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4718
2017-03-08 22:54:58 +00:00
QFETCH(QRect, resizedWindowGeometry);
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
// resizewhile hidden
autotests: client -> window
2022-04-23 19:51:16 +00:00
window->moveResize(resizedWindowGeometry);
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
// triggerPos shouldn't be valid anymore
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(triggerPos);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(window->isHiddenInternal());
support for auto-hidden windows to resize Summary: auto hidden windows were shown again when their geometry changed, this was done for being as easy as possible as the unhide zone changed, but the behavior looked very annoying as autohide panels with an self resize taskbar would unhide themselves every time any window gets open or closed. This makes the edge keep track of windows that can resize/move themselves while auto hidden Test Plan: a self-resizing autohidden panel with a taskbar in it doesn't auto unhide anymore when a window is opened or closed. the unhide area gets properly updated Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: luebking, plasma-devel, kwin, #kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D4718
2017-03-08 22:54:58 +00:00
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
// destroy window again
autotests: client -> window
2022-04-23 19:51:16 +00:00
QSignalSpy windowClosedSpy(window, &X11Window::windowClosed);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_unmap_window(c.get(), windowId);
xcb_destroy_window(c.get(), windowId);
xcb_flush(c.get());
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
QVERIFY(windowClosedSpy.wait());
}
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
void ScreenEdgeClientShowTest::testScreenEdgeShowX11Touch_data()
{
QTest::addColumn<QRect>("windowGeometry");
QTest::addColumn<quint32>("location");
QTest::addColumn<QPoint>("touchDownPos");
QTest::addColumn<QPoint>("targetPos");
QTest::newRow("bottom/left") << QRect(50, 1004, 1180, 20) << 2u << QPoint(100, 1023) << QPoint(100, 540);
QTest::newRow("bottom/right") << QRect(1330, 1004, 1180, 20) << 2u << QPoint(1400, 1023) << QPoint(1400, 520);
QTest::newRow("top/left") << QRect(50, 0, 1180, 20) << 0u << QPoint(100, 0) << QPoint(100, 350);
QTest::newRow("top/right") << QRect(1330, 0, 1180, 20) << 0u << QPoint(1400, 0) << QPoint(1400, 400);
QTest::newRow("left") << QRect(0, 10, 20, 1000) << 3u << QPoint(0, 50) << QPoint(400, 50);
QTest::newRow("right") << QRect(2540, 10, 20, 1000) << 1u << QPoint(2559, 60) << QPoint(2200, 60);
}
void ScreenEdgeClientShowTest::testScreenEdgeShowX11Touch()
{
// this test creates a window which borders the screen and sets the screenedge show hint
// that should trigger a show of the window whenever the touch screen swipe gesture is triggered
// create the test window
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
// atom for the screenedge show hide functionality
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
Xcb::Atom atom(QByteArrayLiteral("_KDE_NET_WM_SCREEN_EDGE_SHOW"), false, c.get());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QFETCH(QRect, windowGeometry);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
info.setWindowType(NET::Dock);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.last().first().value<X11Window *>();
QVERIFY(window);
QVERIFY(!window->isDecorated());
QCOMPARE(window->frameGeometry(), windowGeometry);
QVERIFY(!window->hasStrut());
QVERIFY(!window->isHiddenInternal());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QSignalSpy effectsWindowAdded(effects, &EffectsHandler::windowAdded);
QVERIFY(effectsWindowAdded.wait());
// now try to hide
QFETCH(quint32, location);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_change_property(c.get(), XCB_PROP_MODE_REPLACE, windowId, atom, XCB_ATOM_CARDINAL, 32, 1, &location);
xcb_flush(c.get());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QSignalSpy effectsWindowHiddenSpy(effects, &EffectsHandler::windowHidden);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QSignalSpy clientHiddenSpy(window, &X11Window::windowHidden);
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QVERIFY(clientHiddenSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(window->isHiddenInternal());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QCOMPARE(effectsWindowHiddenSpy.count(), 1);
// now trigger the edge
QSignalSpy effectsWindowShownSpy(effects, &EffectsHandler::windowShown);
quint32 timestamp = 0;
QFETCH(QPoint, touchDownPos);
QFETCH(QPoint, targetPos);
Migrate all autotest input simulation functions [5/6] Make autotests create fake input devices Migrate all input simulation functions from kwinApp()->platform()->... to the their counter part in the Test namespace.
2022-03-10 10:27:35 +00:00
Test::touchDown(0, touchDownPos, timestamp++);
Test::touchMotion(0, targetPos, timestamp++);
Test::touchUp(0, timestamp++);
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QVERIFY(effectsWindowShownSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
QVERIFY(!window->isHiddenInternal());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QCOMPARE(effectsWindowShownSpy.count(), 1);
// destroy window again
autotests: client -> window
2022-04-23 19:51:16 +00:00
QSignalSpy windowClosedSpy(window, &X11Window::windowClosed);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_unmap_window(c.get(), windowId);
xcb_destroy_window(c.get(), windowId);
xcb_flush(c.get());
[autotests] Add test case for showing auto-hiding panel through swipe gesture
2017-03-28 20:01:16 +00:00
QVERIFY(windowClosedSpy.wait());
}
[autotests/integration] Add new test case for screenedge client show A test to simulate auto-hiding panels. Preparation step for making the slidingpopups effect working again for auto-hiding panels. The test case simulates creating a panel at the screen edge, hides it through the property and shows it again through the edge.
2016-07-14 07:45:03 +00:00
}
WAYLANDTEST_MAIN(KWin::ScreenEdgeClientShowTest)
#include "screenedge_client_show_test.moc"
Reference in a new issue Copy permalink