yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/src/effects/slide/CMakeLists.txt

37 lines
802 B
Text
Raw Normal View History

effects: Modularize builtin effects build Currently, cpp source files are included partially in effect sub-folders and src/effects/CMakeLists.txt, which is really confusing and hard to follow. With this change, effect targets will be defined in their own subfolders. This makes build files more straightforward. Effect sub-targets are eventually merged into a monolithic kwin4_effect_builtins target. Another reason for modularizing builtin effects is that no two effects can generate moc files with the same name atm even though they are in different sub-folders. This can be potentially useful in the future, e.g. making effects static plugins in order to decouple builtin effects from libkwin (every effect subfolder would need a main.cpp or plugin.cpp file, which will include the associated moc file).
2021-10-09 13:43:07 +00:00
#######################################
# Effect
set(slide_SOURCES
effects: Link builtin effects with executables The main motivation behind this change is to prepare kwin for importing kwayland-server code in libkwin. As is, builtin effects are linked with libkwin. Some builtin effects have wayland specific code. If we move wayland stuff in libkwin, there's going to be a circular dependency between kwin4_effect_builtins and libkwin targets. This change intends to break that dependency by linking builtin effects to kwin executable. The main issue with that is that EffectLoader would need to discover the effects indirectly. QStaticPlugin is used for that purpose. Besides breaking the cyclic dependency, it makes builtin effects use the same plugin infrastructure in libkwineffects that external effects use. Metadata in src/effects/effect_builtins.cpp was converted in a list of python dictionaries, which was fed to a python script that generated main.cpp and metadata.json files.
2021-10-12 11:06:31 +00:00
main.cpp
effects: Modularize builtin effects build Currently, cpp source files are included partially in effect sub-folders and src/effects/CMakeLists.txt, which is really confusing and hard to follow. With this change, effect targets will be defined in their own subfolders. This makes build files more straightforward. Effect sub-targets are eventually merged into a monolithic kwin4_effect_builtins target. Another reason for modularizing builtin effects is that no two effects can generate moc files with the same name atm even though they are in different sub-folders. This can be potentially useful in the future, e.g. making effects static plugins in order to decouple builtin effects from libkwin (every effect subfolder would need a main.cpp or plugin.cpp file, which will include the associated moc file).
2021-10-09 13:43:07 +00:00
slide.cpp
)
kconfig_add_kcfg_files(slide_SOURCES
slideconfig.kcfgc
)
kwin4_add_effect_module(kwin4_effect_slide ${slide_SOURCES})
cmake: Specify link libraries per effect target This allows to track per effect dependencies more precisely. The main problem with a library and a comment next to it saying who needs it is that the comment can get easily outdated.
2022-02-14 17:55:59 +00:00
target_link_libraries(kwin4_effect_slide PRIVATE
kwineffects
KF5::ConfigGui
)
effects: Modularize builtin effects build Currently, cpp source files are included partially in effect sub-folders and src/effects/CMakeLists.txt, which is really confusing and hard to follow. With this change, effect targets will be defined in their own subfolders. This makes build files more straightforward. Effect sub-targets are eventually merged into a monolithic kwin4_effect_builtins target. Another reason for modularizing builtin effects is that no two effects can generate moc files with the same name atm even though they are in different sub-folders. This can be potentially useful in the future, e.g. making effects static plugins in order to decouple builtin effects from libkwin (every effect subfolder would need a main.cpp or plugin.cpp file, which will include the associated moc file).
2021-10-09 13:43:07 +00:00
Cleaned up the effects/ directory by moving each individual effect into its own directory, cleaned up the effect config macros and renamed "MakeTransparent" to "Translucency" so that it matches its visible name. svn path=/trunk/KDE/kdebase/workspace/; revision=921749
2009-02-05 15:35:38 +00:00
#######################################
[effects/slide] Add 'Duration' option Summary: At the moment, there is no way to tweak duration of the slide animation. This change adds a configuration module so it is possible to change the duration. Test Plan: * enable virtual desktops * go to `System Settings > Desktop Behaviour > Desktop Effects` and select Slide effect under "Virtual Desktop Switching Animation" * click settings/options button and change duration Reviewers: #kwin, #plasma, graesslin Reviewed By: #kwin, #plasma, graesslin Subscribers: graesslin, plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D9382
2017-12-30 17:17:13 +00:00
# Config
effects: Build effect config only with KWIN_BUILD_KCMS Without effects KCM there is no access to effect configuration either Signed-off-by: Eike Hein <eike.hein@mbition.io>
2022-02-23 14:15:20 +00:00
if (KWIN_BUILD_KCMS)
set(kwin_slide_config_SRCS slide_config.cpp)
ki18n_wrap_ui(kwin_slide_config_SRCS slide_config.ui)
kconfig_add_kcfg_files(kwin_slide_config_SRCS slideconfig.kcfgc)
Cleaned up the effects/ directory by moving each individual effect into its own directory, cleaned up the effect config macros and renamed "MakeTransparent" to "Translucency" so that it matches its visible name. svn path=/trunk/KDE/kdebase/workspace/; revision=921749
2009-02-05 15:35:38 +00:00
effects: Build effect config only with KWIN_BUILD_KCMS Without effects KCM there is no access to effect configuration either Signed-off-by: Eike Hein <eike.hein@mbition.io>
2022-02-23 14:15:20 +00:00
kwin_add_effect_config(kwin_slide_config ${kwin_slide_config_SRCS})
[effects/slide] Add 'Duration' option Summary: At the moment, there is no way to tweak duration of the slide animation. This change adds a configuration module so it is possible to change the duration. Test Plan: * enable virtual desktops * go to `System Settings > Desktop Behaviour > Desktop Effects` and select Slide effect under "Virtual Desktop Switching Animation" * click settings/options button and change duration Reviewers: #kwin, #plasma, graesslin Reviewed By: #kwin, #plasma, graesslin Subscribers: graesslin, plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D9382
2017-12-30 17:17:13 +00:00
effects: Build effect config only with KWIN_BUILD_KCMS Without effects KCM there is no access to effect configuration either Signed-off-by: Eike Hein <eike.hein@mbition.io>
2022-02-23 14:15:20 +00:00
target_link_libraries(kwin_slide_config
KF5::ConfigWidgets
KF5::CoreAddons
KF5::I18n
Qt::DBus
KWinEffectsInterface
)
endif()
Reference in a new issue Copy permalink