yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/kwinbindings_test.cpp

253 lines
9.2 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2017 Martin Flöser <mgraesslin@kde.org>
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "kwin_wayland_test.h"
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "input.h"
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
#include "pointer_input.h"
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "scripting/scripting.h"
#include "useractions.h"
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
#include "virtualdesktops.h"
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "wayland_server.h"
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
#include "window.h"
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "workspace.h"
#include <KWayland/Client/surface.h>
#include <QDBusConnection>
#include <QDBusMessage>
#include <QDBusPendingReply>
Don't use QtTest => use QTest + missing include
2023-07-03 19:28:19 +00:00
#include <QTemporaryFile>
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
using namespace KWin;
static const QString s_socketName = QStringLiteral("wayland_test_kwin_kwinbindings-0");
class KWinBindingsTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase();
void init();
void cleanup();
void testSwitchWindow();
void testSwitchWindowScript();
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
void testWindowToDesktop_data();
void testWindowToDesktop();
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
};
void KWinBindingsTest::initTestCase()
{
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
qRegisterMetaType<KWin::Window *>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
Avoid converting socket name between QString and QByteArray back and forth It only contributes overhead.
2020-12-09 13:06:15 +00:00
QVERIFY(waylandServer()->init(s_socketName));
autotests: directly call setVirtualOutputs
2023-05-08 10:16:00 +00:00
Test::setOutputConfig({
QRect(0, 0, 1280, 1024),
QRect(1280, 0, 1280, 1024),
});
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
void KWinBindingsTest::init()
{
QVERIFY(Test::setupWaylandConnection());
Move active output tracking to workspace Active output is a window management concept. It indicates what output new windows have to be placed on if they have no output hint. So Workspace seems to be a better place for it than the Screens class, which is obsolete.
2021-08-28 18:58:29 +00:00
workspace()->setActiveOutput(QPoint(640, 512));
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
KWin::input()->pointer()->warp(QPoint(640, 512));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
void KWinBindingsTest::cleanup()
{
Test::destroyWaylandConnection();
}
void KWinBindingsTest::testSwitchWindow()
{
// first create windows
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> surface1(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface1(Test::createXdgToplevelSurface(surface1.get()));
auto c1 = Test::renderAndWaitForShown(surface1.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface2(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface2(Test::createXdgToplevelSurface(surface2.get()));
auto c2 = Test::renderAndWaitForShown(surface2.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface3(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface3(Test::createXdgToplevelSurface(surface3.get()));
auto c3 = Test::renderAndWaitForShown(surface3.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface4(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface4(Test::createXdgToplevelSurface(surface4.get()));
auto c4 = Test::renderAndWaitForShown(surface4.get(), QSize(100, 50), Qt::blue);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
QVERIFY(c4->isActive());
QVERIFY(c4 != c3);
QVERIFY(c3 != c2);
QVERIFY(c2 != c1);
// let's position all windows
Rework async geometry updates Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
c1->move(QPoint(0, 0));
c2->move(QPoint(200, 0));
c3->move(QPoint(200, 200));
c4->move(QPoint(0, 200));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
// now let's trigger the shortcuts
// invoke global shortcut through dbus
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
auto invokeShortcut = [](const QString &shortcut) {
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto msg = QDBusMessage::createMethodCall(
QStringLiteral("org.kde.kglobalaccel"),
QStringLiteral("/component/kwin"),
QStringLiteral("org.kde.kglobalaccel.Component"),
QStringLiteral("invokeShortcut"));
msg.setArguments(QList<QVariant>{shortcut});
QDBusConnection::sessionBus().asyncCall(msg);
};
invokeShortcut(QStringLiteral("Switch Window Up"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c1);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
invokeShortcut(QStringLiteral("Switch Window Right"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c2);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
invokeShortcut(QStringLiteral("Switch Window Down"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c3);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
invokeShortcut(QStringLiteral("Switch Window Left"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c4);
[autotest] Test opposite direction in switchWindow
2017-07-20 19:52:17 +00:00
// test opposite direction
invokeShortcut(QStringLiteral("Switch Window Left"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c3);
[autotest] Test opposite direction in switchWindow
2017-07-20 19:52:17 +00:00
invokeShortcut(QStringLiteral("Switch Window Down"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c2);
[autotest] Test opposite direction in switchWindow
2017-07-20 19:52:17 +00:00
invokeShortcut(QStringLiteral("Switch Window Right"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c1);
[autotest] Test opposite direction in switchWindow
2017-07-20 19:52:17 +00:00
invokeShortcut(QStringLiteral("Switch Window Up"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c4);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
void KWinBindingsTest::testSwitchWindowScript()
{
QVERIFY(Scripting::self());
// first create windows
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> surface1(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface1(Test::createXdgToplevelSurface(surface1.get()));
auto c1 = Test::renderAndWaitForShown(surface1.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface2(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface2(Test::createXdgToplevelSurface(surface2.get()));
auto c2 = Test::renderAndWaitForShown(surface2.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface3(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface3(Test::createXdgToplevelSurface(surface3.get()));
auto c3 = Test::renderAndWaitForShown(surface3.get(), QSize(100, 50), Qt::blue);
std::unique_ptr<KWayland::Client::Surface> surface4(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface4(Test::createXdgToplevelSurface(surface4.get()));
auto c4 = Test::renderAndWaitForShown(surface4.get(), QSize(100, 50), Qt::blue);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
QVERIFY(c4->isActive());
QVERIFY(c4 != c3);
QVERIFY(c3 != c2);
QVERIFY(c2 != c1);
// let's position all windows
Rework async geometry updates Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
c1->move(QPoint(0, 0));
c2->move(QPoint(200, 0));
c3->move(QPoint(200, 200));
c4->move(QPoint(0, 200));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
auto runScript = [](const QString &slot) {
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
QTemporaryFile tmpFile;
QVERIFY(tmpFile.open());
QTextStream out(&tmpFile);
out << "workspace." << slot << "()";
out.flush();
const int id = Scripting::self()->loadScript(tmpFile.fileName());
QVERIFY(id != -1);
QVERIFY(Scripting::self()->isScriptLoaded(tmpFile.fileName()));
auto s = Scripting::self()->findScript(tmpFile.fileName());
QVERIFY(s);
QSignalSpy runningChangedSpy(s, &AbstractScript::runningChanged);
s->run();
[autotests] Try making KWinBindingsTest::testSwitchWindowScript more robust Another random failure on build.kde.org (see T6546). This tries to use QTRY_COMPARE on the SignalSpy's count instead of a wait in the hope that this can handle the multi-threaded situation better. Though it might also be possible that the other thread just didn't run in the 5 sec we waited.
2017-08-13 15:08:49 +00:00
QTRY_COMPARE(runningChangedSpy.count(), 1);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
};
runScript(QStringLiteral("slotSwitchWindowUp"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c1);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
runScript(QStringLiteral("slotSwitchWindowRight"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c2);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
runScript(QStringLiteral("slotSwitchWindowDown"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c3);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
runScript(QStringLiteral("slotSwitchWindowLeft"));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QTRY_COMPARE(workspace()->activeWindow(), c4);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
void KWinBindingsTest::testWindowToDesktop_data()
{
QTest::addColumn<int>("desktop");
QTest::newRow("2") << 2;
QTest::newRow("3") << 3;
QTest::newRow("4") << 4;
QTest::newRow("5") << 5;
QTest::newRow("6") << 6;
QTest::newRow("7") << 7;
QTest::newRow("8") << 8;
QTest::newRow("9") << 9;
QTest::newRow("10") << 10;
QTest::newRow("11") << 11;
QTest::newRow("12") << 12;
QTest::newRow("13") << 13;
QTest::newRow("14") << 14;
QTest::newRow("15") << 15;
QTest::newRow("16") << 16;
QTest::newRow("17") << 17;
QTest::newRow("18") << 18;
QTest::newRow("19") << 19;
QTest::newRow("20") << 20;
}
void KWinBindingsTest::testWindowToDesktop()
{
// first go to desktop one
VirtualDesktopManager::self()->setCurrent(VirtualDesktopManager::self()->desktops().first());
// now create a window
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> surface(Test::createSurface());
std::unique_ptr<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.get()));
auto window = Test::renderAndWaitForShown(surface.get(), QSize(100, 50), Qt::blue);
Rename Window::desktopChanged() We have Window::desktops(), so rename the signal to match it.
2023-02-24 15:28:56 +00:00
QSignalSpy desktopsChangedSpy(window, &Window::desktopsChanged);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QCOMPARE(workspace()->activeWindow(), window);
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
QFETCH(int, desktop);
VirtualDesktopManager::self()->setCount(desktop);
Move Window::desktop to X11Window Window::desktop() is obsolete. On the other hand, X11 doesn't support having a window on several virtual desktops, so we still need it. As a compromise, this change moves it to X11Window instead.
2023-03-30 16:41:46 +00:00
const auto desktops = VirtualDesktopManager::self()->desktops();
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
// now trigger the shortcut
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
auto invokeShortcut = [](int desktop) {
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
auto msg = QDBusMessage::createMethodCall(
QStringLiteral("org.kde.kglobalaccel"),
QStringLiteral("/component/kwin"),
QStringLiteral("org.kde.kglobalaccel.Component"),
QStringLiteral("invokeShortcut"));
msg.setArguments(QList<QVariant>{QStringLiteral("Window to Desktop %1").arg(desktop)});
QDBusConnection::sessionBus().asyncCall(msg);
};
invokeShortcut(desktop);
Rename Window::desktopChanged() We have Window::desktops(), so rename the signal to match it.
2023-02-24 15:28:56 +00:00
QVERIFY(desktopsChangedSpy.wait());
Move Window::desktop to X11Window Window::desktop() is obsolete. On the other hand, X11 doesn't support having a window on several virtual desktops, so we still need it. As a compromise, this change moves it to X11Window instead.
2023-03-30 16:41:46 +00:00
QCOMPARE(window->desktops(), QVector<VirtualDesktop *>{desktops.at(desktop - 1)});
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
// back to desktop 1
invokeShortcut(1);
Rename Window::desktopChanged() We have Window::desktops(), so rename the signal to match it.
2023-02-24 15:28:56 +00:00
QVERIFY(desktopsChangedSpy.wait());
Move Window::desktop to X11Window Window::desktop() is obsolete. On the other hand, X11 doesn't support having a window on several virtual desktops, so we still need it. As a compromise, this change moves it to X11Window instead.
2023-03-30 16:41:46 +00:00
QCOMPARE(window->desktops(), QVector<VirtualDesktop *>{desktops.at(0)});
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
// invoke with one desktop too many
invokeShortcut(desktop + 1);
// that should fail
Rename Window::desktopChanged() We have Window::desktops(), so rename the signal to match it.
2023-02-24 15:28:56 +00:00
QVERIFY(!desktopsChangedSpy.wait(100));
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
}
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
WAYLANDTEST_MAIN(KWinBindingsTest)
#include "kwinbindings_test.moc"
Reference in a new issue Copy permalink