yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/src/effects/magnifier/CMakeLists.txt

38 lines
921 B
Text
Raw Normal View History

effects: Modularize builtin effects build Currently, cpp source files are included partially in effect sub-folders and src/effects/CMakeLists.txt, which is really confusing and hard to follow. With this change, effect targets will be defined in their own subfolders. This makes build files more straightforward. Effect sub-targets are eventually merged into a monolithic kwin4_effect_builtins target. Another reason for modularizing builtin effects is that no two effects can generate moc files with the same name atm even though they are in different sub-folders. This can be potentially useful in the future, e.g. making effects static plugins in order to decouple builtin effects from libkwin (every effect subfolder would need a main.cpp or plugin.cpp file, which will include the associated moc file).
2021-10-09 13:43:07 +00:00
#######################################
# Effect
set(magnifier_SOURCES
magnifier.cpp
)
kconfig_add_kcfg_files(magnifier_SOURCES
magnifierconfig.kcfgc
)
kwin4_add_effect_module(kwin4_effect_magnifier ${magnifier_SOURCES})
Cleaned up the effects/ directory by moving each individual effect into its own directory, cleaned up the effect config macros and renamed "MakeTransparent" to "Translucency" so that it matches its visible name. svn path=/trunk/KDE/kdebase/workspace/; revision=921749
2009-02-05 15:35:38 +00:00
#######################################
# Config
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
set(kwin_magnifier_config_SRCS magnifier_config.cpp)
Adjust effects_builtins for new ki18n * Use ki18n_wrap_ui for ui files * define TRANSLATION_DOMAIN in CMakeLists.txt
2014-04-29 06:25:19 +00:00
ki18n_wrap_ui(kwin_magnifier_config_SRCS magnifier_config.ui)
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
kconfig_add_kcfg_files(kwin_magnifier_config_SRCS magnifierconfig.kcfgc)
Cleaned up the effects/ directory by moving each individual effect into its own directory, cleaned up the effect config macros and renamed "MakeTransparent" to "Translucency" so that it matches its visible name. svn path=/trunk/KDE/kdebase/workspace/; revision=921749
2009-02-05 15:35:38 +00:00
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
add_library(kwin_magnifier_config MODULE ${kwin_magnifier_config_SRCS})
Cleaned up the effects/ directory by moving each individual effect into its own directory, cleaned up the effect config macros and renamed "MakeTransparent" to "Translucency" so that it matches its visible name. svn path=/trunk/KDE/kdebase/workspace/; revision=921749
2009-02-05 15:35:38 +00:00
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
target_link_libraries(kwin_magnifier_config
KF5::ConfigWidgets
KF5::GlobalAccel
KF5::I18n
KF5::XmlGui
Reduce the amount of objects that are compiled several times Summary: We build some objects several times which makes it uncomfortable to develop KWin since every time we modify something a lot of things get rebuilt. This should help a bit although it doesn't solve all the problems. Test Plan: Builds, tests pass Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: davidedmundson, zzag, anthonyfieroni, iasensio, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28445
2020-04-01 22:41:38 +00:00
KWinEffectsInterface
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
)
Use SERVICE_TYPES parameter to kcoreaddons_desktop_to_json()
2015-12-09 23:42:45 +00:00
kcoreaddons_desktop_to_json(kwin_magnifier_config magnifier_config.desktop SERVICE_TYPES kcmodule.desktop)
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
install(
TARGETS
kwin_magnifier_config
DESTINATION
GIT_SILENT: dont use deprecated cmake variable
2021-01-29 10:34:52 +00:00
${KDE_INSTALL_PLUGINDIR}/kwin/effects/configs
[kwin] Create one plugin per effect configuration There are no advantages for the effects KCM to have all the effect config modules in one plugin. By having a plugin per effect we can use the KPluginTrader to easily find the configuration plugin for a given effect and load it. To make this possible the following changes are done: * config_builtins.cpp is deleted * add_subdirectory is used for all effects which have a config module * toplevel CMakeLists.txt contains the sources again for the effects which have a config module, but effects which don't have a config module are still included and thus the macro is still used * plugin created for the config module, name pattern is: kwin_effectname_config * plugin installed to ${PLUGIN_INSTALL_DIR}/kwin/effects/configs * desktop file adjusted to new plugin name and keyword removed * desktop file converted to json as meta data and no longer installed * Uses K_PLUGIN_FACTORY_WITH_JSON * Macros for config are dropped from kwineffects.h REVIEW: 116854
2014-03-17 13:56:11 +00:00
)
Reference in a new issue Copy permalink