yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/kwinbindings_test.cpp

255 lines
9 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2017 Martin Flöser <mgraesslin@kde.org>
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "kwin_wayland_test.h"
Use AbstractClient instead of XdgShellClient wherever possible Summary: Currently, we have only one shell client type - XdgShellClient. We use it when we are dealing with Wayland clients. But it isn't really a good idea because we may need to support shell surfaces other than xdg-shell ones, for example input panel surfaces. In order to make kwin more extensible, this change replaces all usages of the XdgShellClient class with the AbstractClient class. Test Plan: Existing tests pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27778
2020-03-04 07:55:26 +00:00
#include "abstract_client.h"
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "cursor.h"
#include "input.h"
#include "platform.h"
#include "screens.h"
#include "scripting/scripting.h"
#include "useractions.h"
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
#include "virtualdesktops.h"
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
#include "wayland_server.h"
#include "workspace.h"
#include <KWayland/Client/surface.h>
#include <QDBusConnection>
#include <QDBusMessage>
#include <QDBusPendingReply>
using namespace KWin;
using namespace KWayland::Client;
static const QString s_socketName = QStringLiteral("wayland_test_kwin_kwinbindings-0");
class KWinBindingsTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase();
void init();
void cleanup();
void testSwitchWindow();
void testSwitchWindowScript();
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
void testWindowToDesktop_data();
void testWindowToDesktop();
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
};
void KWinBindingsTest::initTestCase()
{
qRegisterMetaType<KWin::AbstractClient*>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
QVERIFY(applicationStartedSpy.isValid());
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
Avoid converting socket name between QString and QByteArray back and forth It only contributes overhead.
2020-12-09 13:06:15 +00:00
QVERIFY(waylandServer()->init(s_socketName));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
waylandServer()->initWorkspace();
}
void KWinBindingsTest::init()
{
QVERIFY(Test::setupWaylandConnection());
screens()->setCurrent(0);
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
KWin::Cursors::self()->mouse()->setPos(QPoint(640, 512));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
void KWinBindingsTest::cleanup()
{
Test::destroyWaylandConnection();
}
void KWinBindingsTest::testSwitchWindow()
{
// first create windows
QScopedPointer<Surface> surface1(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface1(Test::createXdgShellStableSurface(surface1.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c1 = Test::renderAndWaitForShown(surface1.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface2(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface2(Test::createXdgShellStableSurface(surface2.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c2 = Test::renderAndWaitForShown(surface2.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface3(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface3(Test::createXdgShellStableSurface(surface3.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c3 = Test::renderAndWaitForShown(surface3.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface4(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface4(Test::createXdgShellStableSurface(surface4.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c4 = Test::renderAndWaitForShown(surface4.data(), QSize(100, 50), Qt::blue);
QVERIFY(c4->isActive());
QVERIFY(c4 != c3);
QVERIFY(c3 != c2);
QVERIFY(c2 != c1);
// let's position all windows
c1->move(0, 0);
c2->move(200, 0);
c3->move(200, 200);
c4->move(0, 200);
// now let's trigger the shortcuts
// invoke global shortcut through dbus
auto invokeShortcut = [] (const QString &shortcut) {
auto msg = QDBusMessage::createMethodCall(
QStringLiteral("org.kde.kglobalaccel"),
QStringLiteral("/component/kwin"),
QStringLiteral("org.kde.kglobalaccel.Component"),
QStringLiteral("invokeShortcut"));
msg.setArguments(QList<QVariant>{shortcut});
QDBusConnection::sessionBus().asyncCall(msg);
};
invokeShortcut(QStringLiteral("Switch Window Up"));
QTRY_COMPARE(workspace()->activeClient(), c1);
invokeShortcut(QStringLiteral("Switch Window Right"));
QTRY_COMPARE(workspace()->activeClient(), c2);
invokeShortcut(QStringLiteral("Switch Window Down"));
QTRY_COMPARE(workspace()->activeClient(), c3);
invokeShortcut(QStringLiteral("Switch Window Left"));
QTRY_COMPARE(workspace()->activeClient(), c4);
[autotest] Test opposite direction in switchWindow
2017-07-20 19:52:17 +00:00
// test opposite direction
invokeShortcut(QStringLiteral("Switch Window Left"));
QTRY_COMPARE(workspace()->activeClient(), c3);
invokeShortcut(QStringLiteral("Switch Window Down"));
QTRY_COMPARE(workspace()->activeClient(), c2);
invokeShortcut(QStringLiteral("Switch Window Right"));
QTRY_COMPARE(workspace()->activeClient(), c1);
invokeShortcut(QStringLiteral("Switch Window Up"));
QTRY_COMPARE(workspace()->activeClient(), c4);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
}
void KWinBindingsTest::testSwitchWindowScript()
{
QVERIFY(Scripting::self());
// first create windows
QScopedPointer<Surface> surface1(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface1(Test::createXdgShellStableSurface(surface1.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c1 = Test::renderAndWaitForShown(surface1.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface2(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface2(Test::createXdgShellStableSurface(surface2.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c2 = Test::renderAndWaitForShown(surface2.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface3(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface3(Test::createXdgShellStableSurface(surface3.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c3 = Test::renderAndWaitForShown(surface3.data(), QSize(100, 50), Qt::blue);
QScopedPointer<Surface> surface4(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface4(Test::createXdgShellStableSurface(surface4.data()));
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
auto c4 = Test::renderAndWaitForShown(surface4.data(), QSize(100, 50), Qt::blue);
QVERIFY(c4->isActive());
QVERIFY(c4 != c3);
QVERIFY(c3 != c2);
QVERIFY(c2 != c1);
// let's position all windows
c1->move(0, 0);
c2->move(200, 0);
c3->move(200, 200);
c4->move(0, 200);
auto runScript = [] (const QString &slot) {
QTemporaryFile tmpFile;
QVERIFY(tmpFile.open());
QTextStream out(&tmpFile);
out << "workspace." << slot << "()";
out.flush();
const int id = Scripting::self()->loadScript(tmpFile.fileName());
QVERIFY(id != -1);
QVERIFY(Scripting::self()->isScriptLoaded(tmpFile.fileName()));
auto s = Scripting::self()->findScript(tmpFile.fileName());
QVERIFY(s);
QSignalSpy runningChangedSpy(s, &AbstractScript::runningChanged);
QVERIFY(runningChangedSpy.isValid());
s->run();
[autotests] Try making KWinBindingsTest::testSwitchWindowScript more robust Another random failure on build.kde.org (see T6546). This tries to use QTRY_COMPARE on the SignalSpy's count instead of a wait in the hope that this can handle the multi-threaded situation better. Though it might also be possible that the other thread just didn't run in the 5 sec we waited.
2017-08-13 15:08:49 +00:00
QTRY_COMPARE(runningChangedSpy.count(), 1);
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
};
runScript(QStringLiteral("slotSwitchWindowUp"));
QTRY_COMPARE(workspace()->activeClient(), c1);
runScript(QStringLiteral("slotSwitchWindowRight"));
QTRY_COMPARE(workspace()->activeClient(), c2);
runScript(QStringLiteral("slotSwitchWindowDown"));
QTRY_COMPARE(workspace()->activeClient(), c3);
runScript(QStringLiteral("slotSwitchWindowLeft"));
QTRY_COMPARE(workspace()->activeClient(), c4);
}
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
void KWinBindingsTest::testWindowToDesktop_data()
{
QTest::addColumn<int>("desktop");
QTest::newRow("2") << 2;
QTest::newRow("3") << 3;
QTest::newRow("4") << 4;
QTest::newRow("5") << 5;
QTest::newRow("6") << 6;
QTest::newRow("7") << 7;
QTest::newRow("8") << 8;
QTest::newRow("9") << 9;
QTest::newRow("10") << 10;
QTest::newRow("11") << 11;
QTest::newRow("12") << 12;
QTest::newRow("13") << 13;
QTest::newRow("14") << 14;
QTest::newRow("15") << 15;
QTest::newRow("16") << 16;
QTest::newRow("17") << 17;
QTest::newRow("18") << 18;
QTest::newRow("19") << 19;
QTest::newRow("20") << 20;
}
void KWinBindingsTest::testWindowToDesktop()
{
// first go to desktop one
VirtualDesktopManager::self()->setCurrent(VirtualDesktopManager::self()->desktops().first());
// now create a window
QScopedPointer<Surface> surface(Test::createSurface());
[autotests] Don't test wl-shell clients Summary: This change removes all traces of wl-shell in the test suite. That's a prerequisite for dropping wl-shell support in KWin. Given that wl-shell and xdg-shell are not interchangeable, some tests were removed and initialization sequence in some tests was adjusted. The most notable change is ensuring that each plasmashell window sets its role and initial position before committing the surface. Setting those properties before the first surface commit is important because our window placement code needs to know window type in order to avoid maximizing panels, popups, etc. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23561
2019-08-27 15:01:14 +00:00
QScopedPointer<XdgShellSurface> shellSurface(Test::createXdgShellStableSurface(surface.data()));
[autotests] Add test case for sending window to desktop shortcuts
2017-07-21 05:12:36 +00:00
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
QSignalSpy desktopChangedSpy(c, &AbstractClient::desktopChanged);
QVERIFY(desktopChangedSpy.isValid());
QCOMPARE(workspace()->activeClient(), c);
QFETCH(int, desktop);
VirtualDesktopManager::self()->setCount(desktop);
// now trigger the shortcut
auto invokeShortcut = [] (int desktop) {
auto msg = QDBusMessage::createMethodCall(
QStringLiteral("org.kde.kglobalaccel"),
QStringLiteral("/component/kwin"),
QStringLiteral("org.kde.kglobalaccel.Component"),
QStringLiteral("invokeShortcut"));
msg.setArguments(QList<QVariant>{QStringLiteral("Window to Desktop %1").arg(desktop)});
QDBusConnection::sessionBus().asyncCall(msg);
};
invokeShortcut(desktop);
QVERIFY(desktopChangedSpy.wait());
QCOMPARE(c->desktop(), desktop);
// back to desktop 1
invokeShortcut(1);
QVERIFY(desktopChangedSpy.wait());
QCOMPARE(c->desktop(), 1);
// invoke with one desktop too many
invokeShortcut(desktop + 1);
// that should fail
QVERIFY(!desktopChangedSpy.wait(100));
}
[autotests] Add test cases for switchWindow A new test class for KWinBindings added which is intended to group the testing of the various slots set up in kwinbindings.cpp. As the scripts also delegate to the slots this is also tested.
2017-07-20 18:49:42 +00:00
WAYLANDTEST_MAIN(KWinBindingsTest)
#include "kwinbindings_test.moc"
Reference in a new issue Copy permalink