yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/plugins/platforms/x11/windowed/egl_x11_backend.h

45 lines
1 KiB
C
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
#ifndef KWIN_EGL_X11_BACKEND_H
#define KWIN_EGL_X11_BACKEND_H
#include "eglonxbackend.h"
namespace KWin
{
class X11WindowedBackend;
/**
* @brief OpenGL Backend using Egl windowing system over an X overlay window.
Use more traditional doxygen style Summary: So far we were following a bit unique and rare doxygen comment style: /** * Contents of the comment. **/ Doxygen comments with this style look balanced and neat, but many people that contribute to KWin don't follow this style. Instead, they prefer more traditional doxygen comment style, i.e. /** * Contents of the comment. */ Reviewing such changes has been a bit frustrating for me (so selfish!) and for other contributors. This change switches doxygen comment style in KWin to a more traditional style. The main reason for doing this is to make code review process easier for new contributors as well us. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22812
2019-07-29 18:58:33 +00:00
*/
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
class EglX11Backend : public EglOnXBackend
{
public:
explicit EglX11Backend(X11WindowedBackend *backend);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~EglX11Backend() override;
bool usesOverlayWindow() const override;
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
bool perScreenRendering() const override;
Use consistent naming for begin/end frame hooks Currently, the OpenGLBackend and the QPainterBackend have hooks to indicate the start and the end of compositing cycle, but in both cases, the hooks have different names. This change fixes that inconsistency.
2020-11-09 14:31:26 +00:00
QRegion beginFrame(int screenId) override;
void endFrame(int screenId, const QRegion &damage, const QRegion &damagedRegion) override;
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
protected:
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
void present() override;
[backends/x11] Add a dedicated EGL backend for multi-surface rendering Based on the existing EglOnXBackend. Main difference is that this subclass implements perScreenRendering with support for one EGLSurface per output.
2015-11-25 12:33:40 +00:00
void cleanupSurfaces() override;
bool createSurfaces() override;
private:
void setupViewport(int screenId);
QVector<EGLSurface> m_surfaces;
X11WindowedBackend *m_backend;
};
} // namespace
#endif
Reference in a new issue Copy permalink