2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2018-12-02 12:09:37 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2018 Martin Flöser <mgraesslin@kde.org>
|
2018-12-02 12:09:37 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2018-12-02 12:09:37 +00:00
|
|
|
#include "kwin_wayland_test.h"
|
|
|
|
#include "cursor.h"
|
|
|
|
#include "input.h"
|
|
|
|
#include "keyboard_input.h"
|
|
|
|
#include "platform.h"
|
|
|
|
#include "screenedge.h"
|
|
|
|
#include "screens.h"
|
|
|
|
#include "wayland_server.h"
|
|
|
|
#include "workspace.h"
|
|
|
|
|
|
|
|
#include <KConfigGroup>
|
|
|
|
#include <KGlobalAccel>
|
|
|
|
|
|
|
|
#include <QDBusConnection>
|
|
|
|
|
|
|
|
#include <linux/input.h>
|
|
|
|
|
|
|
|
using namespace KWin;
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_no_global_shortcuts-0");
|
|
|
|
static const QString s_serviceName = QStringLiteral("org.kde.KWin.Test.ModifierOnlyShortcut");
|
|
|
|
static const QString s_path = QStringLiteral("/Test");
|
|
|
|
|
|
|
|
Q_DECLARE_METATYPE(KWin::ElectricBorder)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This test verifies the NoGlobalShortcuts initialization flag
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2018-12-02 12:09:37 +00:00
|
|
|
class NoGlobalShortcutsTest : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
private Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void init();
|
|
|
|
void cleanup();
|
|
|
|
|
|
|
|
void testTrigger_data();
|
|
|
|
void testTrigger();
|
|
|
|
void testKGlobalAccel();
|
|
|
|
void testPointerShortcut();
|
|
|
|
void testAxisShortcut_data();
|
|
|
|
void testAxisShortcut();
|
|
|
|
void testScreenEdge();
|
|
|
|
};
|
|
|
|
|
|
|
|
class Target : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
Q_CLASSINFO("D-Bus Interface", "org.kde.KWin.Test.ModifierOnlyShortcut")
|
|
|
|
|
|
|
|
public:
|
|
|
|
Target();
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~Target() override;
|
2018-12-02 12:09:37 +00:00
|
|
|
|
|
|
|
public Q_SLOTS:
|
|
|
|
Q_SCRIPTABLE void shortcut();
|
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void shortcutTriggered();
|
|
|
|
};
|
|
|
|
|
|
|
|
Target::Target()
|
|
|
|
: QObject()
|
|
|
|
{
|
|
|
|
QDBusConnection::sessionBus().registerService(s_serviceName);
|
|
|
|
QDBusConnection::sessionBus().registerObject(s_path, s_serviceName, this, QDBusConnection::ExportScriptableSlots);
|
|
|
|
}
|
|
|
|
|
|
|
|
Target::~Target()
|
|
|
|
{
|
|
|
|
QDBusConnection::sessionBus().unregisterObject(s_path);
|
|
|
|
QDBusConnection::sessionBus().unregisterService(s_serviceName);
|
|
|
|
}
|
|
|
|
|
|
|
|
void Target::shortcut()
|
|
|
|
{
|
2021-06-08 07:02:14 +00:00
|
|
|
Q_EMIT shortcutTriggered();
|
2018-12-02 12:09:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::initTestCase()
|
|
|
|
{
|
|
|
|
qRegisterMetaType<KWin::ElectricBorder>("ElectricBorder");
|
2020-07-07 09:32:29 +00:00
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
|
|
|
QVERIFY(applicationStartedSpy.isValid());
|
2018-12-02 12:09:37 +00:00
|
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
2020-12-09 13:06:15 +00:00
|
|
|
QVERIFY(waylandServer()->init(s_socketName, KWin::WaylandServer::InitializationFlag::NoGlobalShortcuts));
|
2018-12-02 12:09:37 +00:00
|
|
|
|
|
|
|
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
|
|
|
|
qputenv("KWIN_XKB_DEFAULT_KEYMAP", "1");
|
|
|
|
qputenv("XKB_DEFAULT_RULES", "evdev");
|
|
|
|
|
|
|
|
kwinApp()->start();
|
2020-07-07 09:32:29 +00:00
|
|
|
QVERIFY(applicationStartedSpy.wait());
|
2021-05-08 00:08:22 +00:00
|
|
|
Test::initWaylandWorkspace();
|
2018-12-02 12:09:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::init()
|
|
|
|
{
|
|
|
|
screens()->setCurrent(0);
|
2020-04-02 16:18:01 +00:00
|
|
|
KWin::Cursors::self()->mouse()->setPos(QPoint(640, 512));
|
2018-12-02 12:09:37 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::cleanup()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testTrigger_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QStringList>("metaConfig");
|
|
|
|
QTest::addColumn<QStringList>("altConfig");
|
|
|
|
QTest::addColumn<QStringList>("controlConfig");
|
|
|
|
QTest::addColumn<QStringList>("shiftConfig");
|
|
|
|
QTest::addColumn<int>("modifier");
|
|
|
|
QTest::addColumn<QList<int>>("nonTriggeringMods");
|
|
|
|
|
|
|
|
const QStringList trigger = QStringList{s_serviceName, s_path, s_serviceName, QStringLiteral("shortcut")};
|
|
|
|
const QStringList e = QStringList();
|
|
|
|
|
|
|
|
QTest::newRow("leftMeta") << trigger << e << e << e << KEY_LEFTMETA << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("rightMeta") << trigger << e << e << e << KEY_RIGHTMETA << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("leftAlt") << e << trigger << e << e << KEY_LEFTALT << QList<int>{KEY_LEFTMETA, KEY_RIGHTMETA, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("rightAlt") << e << trigger << e << e << KEY_RIGHTALT << QList<int>{KEY_LEFTMETA, KEY_RIGHTMETA, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("leftControl") << e << e << trigger << e << KEY_LEFTCTRL << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTMETA, KEY_RIGHTMETA, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("rightControl") << e << e << trigger << e << KEY_RIGHTCTRL << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTMETA, KEY_RIGHTMETA, KEY_LEFTSHIFT, KEY_RIGHTSHIFT};
|
|
|
|
QTest::newRow("leftShift") << e << e << e << trigger << KEY_LEFTSHIFT << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTMETA, KEY_RIGHTMETA};
|
|
|
|
QTest::newRow("rightShift") << e << e << e << trigger <<KEY_RIGHTSHIFT << QList<int>{KEY_LEFTALT, KEY_RIGHTALT, KEY_LEFTCTRL, KEY_RIGHTCTRL, KEY_LEFTMETA, KEY_RIGHTMETA};
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testTrigger()
|
|
|
|
{
|
|
|
|
// test based on ModifierOnlyShortcutTest::testTrigger
|
|
|
|
Target target;
|
|
|
|
QSignalSpy triggeredSpy(&target, &Target::shortcutTriggered);
|
|
|
|
QVERIFY(triggeredSpy.isValid());
|
|
|
|
|
|
|
|
KConfigGroup group = kwinApp()->config()->group("ModifierOnlyShortcuts");
|
|
|
|
QFETCH(QStringList, metaConfig);
|
|
|
|
QFETCH(QStringList, altConfig);
|
|
|
|
QFETCH(QStringList, shiftConfig);
|
|
|
|
QFETCH(QStringList, controlConfig);
|
|
|
|
group.writeEntry("Meta", metaConfig);
|
|
|
|
group.writeEntry("Alt", altConfig);
|
|
|
|
group.writeEntry("Shift", shiftConfig);
|
|
|
|
group.writeEntry("Control", controlConfig);
|
|
|
|
group.sync();
|
|
|
|
workspace()->slotReconfigure();
|
|
|
|
|
|
|
|
// configured shortcut should trigger
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
QFETCH(int, modifier);
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(modifier, timestamp++);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(modifier, timestamp++);
|
|
|
|
QCOMPARE(triggeredSpy.count(), 0);
|
|
|
|
|
|
|
|
// the other shortcuts should not trigger
|
|
|
|
QFETCH(QList<int>, nonTriggeringMods);
|
|
|
|
for (auto it = nonTriggeringMods.constBegin(), end = nonTriggeringMods.constEnd(); it != end; it++) {
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(*it, timestamp++);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(*it, timestamp++);
|
|
|
|
QCOMPARE(triggeredSpy.count(), 0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testKGlobalAccel()
|
|
|
|
{
|
|
|
|
QScopedPointer<QAction> action(new QAction(nullptr));
|
|
|
|
action->setProperty("componentName", QStringLiteral(KWIN_NAME));
|
|
|
|
action->setObjectName(QStringLiteral("globalshortcuts-test-meta-shift-w"));
|
|
|
|
QSignalSpy triggeredSpy(action.data(), &QAction::triggered);
|
|
|
|
QVERIFY(triggeredSpy.isValid());
|
|
|
|
KGlobalAccel::self()->setShortcut(action.data(), QList<QKeySequence>{Qt::META + Qt::SHIFT + Qt::Key_W}, KGlobalAccel::NoAutoloading);
|
|
|
|
input()->registerShortcut(Qt::META + Qt::SHIFT + Qt::Key_W, action.data());
|
|
|
|
|
|
|
|
// press meta+shift+w
|
|
|
|
quint32 timestamp = 0;
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_LEFTMETA, timestamp++);
|
|
|
|
QCOMPARE(input()->keyboardModifiers(), Qt::MetaModifier);
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_LEFTSHIFT, timestamp++);
|
|
|
|
QCOMPARE(input()->keyboardModifiers(), Qt::ShiftModifier | Qt::MetaModifier);
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_W, timestamp++);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_W, timestamp++);
|
|
|
|
|
|
|
|
// release meta+shift
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_LEFTSHIFT, timestamp++);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_LEFTMETA, timestamp++);
|
|
|
|
|
|
|
|
QVERIFY(!triggeredSpy.wait());
|
|
|
|
QCOMPARE(triggeredSpy.count(), 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testPointerShortcut()
|
|
|
|
{
|
|
|
|
// based on LockScreenTest::testPointerShortcut
|
|
|
|
QScopedPointer<QAction> action(new QAction(nullptr));
|
|
|
|
QSignalSpy actionSpy(action.data(), &QAction::triggered);
|
|
|
|
QVERIFY(actionSpy.isValid());
|
|
|
|
input()->registerPointerShortcut(Qt::MetaModifier, Qt::LeftButton, action.data());
|
|
|
|
|
|
|
|
// try to trigger the shortcut
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_LEFTMETA, timestamp++);
|
|
|
|
kwinApp()->platform()->pointerButtonPressed(BTN_LEFT, timestamp++);
|
|
|
|
QCoreApplication::instance()->processEvents();
|
|
|
|
QCOMPARE(actionSpy.count(), 0);
|
|
|
|
kwinApp()->platform()->pointerButtonReleased(BTN_LEFT, timestamp++);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_LEFTMETA, timestamp++);
|
|
|
|
QCoreApplication::instance()->processEvents();
|
|
|
|
QCOMPARE(actionSpy.count(), 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testAxisShortcut_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<Qt::Orientation>("direction");
|
|
|
|
QTest::addColumn<int>("sign");
|
|
|
|
|
|
|
|
QTest::newRow("up") << Qt::Vertical << 1;
|
|
|
|
QTest::newRow("down") << Qt::Vertical << -1;
|
|
|
|
QTest::newRow("left") << Qt::Horizontal << 1;
|
|
|
|
QTest::newRow("right") << Qt::Horizontal << -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testAxisShortcut()
|
|
|
|
{
|
|
|
|
// based on LockScreenTest::testAxisShortcut
|
|
|
|
QScopedPointer<QAction> action(new QAction(nullptr));
|
|
|
|
QSignalSpy actionSpy(action.data(), &QAction::triggered);
|
|
|
|
QVERIFY(actionSpy.isValid());
|
|
|
|
QFETCH(Qt::Orientation, direction);
|
|
|
|
QFETCH(int, sign);
|
|
|
|
PointerAxisDirection axisDirection = PointerAxisUp;
|
|
|
|
if (direction == Qt::Vertical) {
|
|
|
|
axisDirection = sign > 0 ? PointerAxisUp : PointerAxisDown;
|
|
|
|
} else {
|
|
|
|
axisDirection = sign > 0 ? PointerAxisLeft : PointerAxisRight;
|
|
|
|
}
|
|
|
|
input()->registerAxisShortcut(Qt::MetaModifier, axisDirection, action.data());
|
|
|
|
|
|
|
|
// try to trigger the shortcut
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_LEFTMETA, timestamp++);
|
|
|
|
if (direction == Qt::Vertical)
|
|
|
|
kwinApp()->platform()->pointerAxisVertical(sign * 5.0, timestamp++);
|
|
|
|
else
|
|
|
|
kwinApp()->platform()->pointerAxisHorizontal(sign * 5.0, timestamp++);
|
|
|
|
QCoreApplication::instance()->processEvents();
|
|
|
|
QCOMPARE(actionSpy.count(), 0);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_LEFTMETA, timestamp++);
|
|
|
|
QCoreApplication::instance()->processEvents();
|
|
|
|
QCOMPARE(actionSpy.count(), 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void NoGlobalShortcutsTest::testScreenEdge()
|
|
|
|
{
|
|
|
|
// based on LockScreenTest::testScreenEdge
|
|
|
|
QSignalSpy screenEdgeSpy(ScreenEdges::self(), &ScreenEdges::approaching);
|
|
|
|
QVERIFY(screenEdgeSpy.isValid());
|
|
|
|
QCOMPARE(screenEdgeSpy.count(), 0);
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
kwinApp()->platform()->pointerMotion({5, 5}, timestamp++);
|
|
|
|
QCOMPARE(screenEdgeSpy.count(), 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
WAYLANDTEST_MAIN(NoGlobalShortcutsTest)
|
|
|
|
#include "no_global_shortcuts_test.moc"
|