kwin/autotests/libxrenderutils/CMakeLists.txt

add_executable(blendPictureTest blendpicture_test.cpp)
set_target_properties(blendPictureTest PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
add_test(NAME xrenderutils-blendPictureTest COMMAND blendPictureTest)
target_link_libraries(blendPictureTest
    kwinxrenderutils
    Qt::Test
    Qt::Gui
    Qt::X11Extras
    XCB::XCB
    XCB::RENDER
    XCB::XFIXES
)
ecm_mark_as_test(blendPictureTest)
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731 2016-06-01 08:21:19 +00:00			`add_executable(blendPictureTest blendpicture_test.cpp)`
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef. 2017-07-29 16:47:58 +00:00			`set_target_properties(blendPictureTest PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")`
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543 2017-08-25 16:18:20 +00:00			`add_test(NAME xrenderutils-blendPictureTest COMMAND blendPictureTest)`
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731 2016-06-01 08:21:19 +00:00			`target_link_libraries(blendPictureTest`
			`kwinxrenderutils`
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT 2021-01-30 16:18:21 +00:00			`Qt::Test`
			`Qt::Gui`
			`Qt::X11Extras`
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731 2016-06-01 08:21:19 +00:00			`XCB::XCB`
			`XCB::RENDER`
			`XCB::XFIXES`
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it. 2019-09-17 09:15:35 +00:00			`)`
[libkwinxrenderutils] Clean up static blend picture before going down Summary: The method xRenderBlendPicture created a static XRenderPicture on first usage. To cleanup a XRenderPicture an xcb_connection_t* is needed. As it's static the cleanup happens on exit handler and at that time Qt already destroyed the xcb_connection_t*. With a certain chance this will crash. To expose the problem a Q_ASSERT(qApp) is added in the destructor of XRenderPicture. Using xrenderBlendPicture() will hit this assert on application exit. This is demonstrated by the added auto test. The actual fix to the problem is moving the static variable out of the method and introduce a global cleanup method just like the init method. This is now called from Workspace dtor, so before application goes down. CCBUG: 363251 Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1731 2016-06-01 08:21:19 +00:00			`ecm_mark_as_test(blendPictureTest)`