2013-08-17 08:28:09 +00:00
|
|
|
/**************************************************************************
|
|
|
|
* KWin - the KDE window manager *
|
|
|
|
* This file is part of the KDE project. *
|
|
|
|
* *
|
|
|
|
* Copyright (C) 2013 Antonis Tsiapaliokas <kok3rs@gmail.com> *
|
|
|
|
* *
|
|
|
|
* This program is free software; you can redistribute it and/or modify *
|
|
|
|
* it under the terms of the GNU General Public License as published by *
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or *
|
|
|
|
* (at your option) any later version. *
|
|
|
|
* *
|
|
|
|
* This program is distributed in the hope that it will be useful, *
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
|
|
* GNU General Public License for more details. *
|
|
|
|
* *
|
|
|
|
* You should have received a copy of the GNU General Public License *
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
|
|
**************************************************************************/
|
|
|
|
|
|
|
|
|
|
|
|
#ifndef COMPOSITING_H
|
|
|
|
#define COMPOSITING_H
|
2013-08-29 16:58:51 +00:00
|
|
|
|
|
|
|
#include <QAbstractItemModel>
|
2013-08-17 08:28:09 +00:00
|
|
|
#include <QObject>
|
2019-09-25 13:49:52 +00:00
|
|
|
#include <KSharedConfig>
|
2013-08-17 08:28:09 +00:00
|
|
|
|
2016-08-26 10:56:25 +00:00
|
|
|
class OrgKdeKwinCompositingInterface;
|
|
|
|
|
2013-08-17 08:28:09 +00:00
|
|
|
namespace KWin {
|
|
|
|
namespace Compositing {
|
|
|
|
|
2014-04-23 06:21:35 +00:00
|
|
|
class OpenGLPlatformInterfaceModel;
|
|
|
|
|
2013-08-28 07:36:53 +00:00
|
|
|
class Compositing : public QObject
|
|
|
|
{
|
2013-08-17 08:28:09 +00:00
|
|
|
|
|
|
|
Q_OBJECT
|
2013-12-02 12:25:28 +00:00
|
|
|
Q_PROPERTY(int animationSpeed READ animationSpeed WRITE setAnimationSpeed NOTIFY animationSpeedChanged)
|
|
|
|
Q_PROPERTY(int windowThumbnail READ windowThumbnail WRITE setWindowThumbnail NOTIFY windowThumbnailChanged)
|
|
|
|
Q_PROPERTY(int glScaleFilter READ glScaleFilter WRITE setGlScaleFilter NOTIFY glScaleFilterChanged)
|
|
|
|
Q_PROPERTY(bool xrScaleFilter READ xrScaleFilter WRITE setXrScaleFilter NOTIFY xrScaleFilterChanged)
|
|
|
|
Q_PROPERTY(int glSwapStrategy READ glSwapStrategy WRITE setGlSwapStrategy NOTIFY glSwapStrategyChanged)
|
2013-12-02 14:24:43 +00:00
|
|
|
Q_PROPERTY(int compositingType READ compositingType WRITE setCompositingType NOTIFY compositingTypeChanged)
|
2016-07-16 17:14:44 +00:00
|
|
|
Q_PROPERTY(bool compositingEnabled READ compositingEnabled WRITE setCompositingEnabled NOTIFY compositingEnabledChanged)
|
2014-04-23 06:21:35 +00:00
|
|
|
Q_PROPERTY(KWin::Compositing::OpenGLPlatformInterfaceModel *openGLPlatformInterfaceModel READ openGLPlatformInterfaceModel CONSTANT)
|
|
|
|
Q_PROPERTY(int openGLPlatformInterface READ openGLPlatformInterface WRITE setOpenGLPlatformInterface NOTIFY openGLPlatformInterfaceChanged)
|
2016-08-26 06:56:42 +00:00
|
|
|
Q_PROPERTY(bool windowsBlockCompositing READ windowsBlockCompositing WRITE setWindowsBlockCompositing NOTIFY windowsBlockCompositingChanged)
|
2016-08-26 10:56:25 +00:00
|
|
|
Q_PROPERTY(bool compositingRequired READ compositingRequired CONSTANT)
|
2013-08-17 08:28:09 +00:00
|
|
|
public:
|
Use nullptr everywhere
Summary:
Because KWin is a very old project, we use three kinds of null pointer
literals: 0, NULL, and nullptr. Since C++11, it's recommended to use
nullptr keyword.
This change converts all usages of 0 and NULL literal to nullptr. Even
though it breaks git history, we need to do it in order to have consistent
code as well to ease code reviews (it's very tempting for some people to
add unrelated changes to their patches, e.g. converting NULL to nullptr).
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson, romangg
Reviewed By: #kwin, davidedmundson, romangg
Subscribers: romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
|
|
|
explicit Compositing(QObject *parent = nullptr);
|
2013-08-17 08:28:09 +00:00
|
|
|
|
2013-09-10 07:46:14 +00:00
|
|
|
Q_INVOKABLE bool OpenGLIsUnsafe() const;
|
2013-08-17 08:28:09 +00:00
|
|
|
Q_INVOKABLE bool OpenGLIsBroken();
|
2014-06-03 09:39:10 +00:00
|
|
|
Q_INVOKABLE void reenableOpenGLDetection();
|
2019-09-25 13:49:52 +00:00
|
|
|
qreal animationSpeed() const;
|
2013-09-11 11:11:39 +00:00
|
|
|
int windowThumbnail() const;
|
2013-12-02 10:46:52 +00:00
|
|
|
int glScaleFilter() const;
|
|
|
|
bool xrScaleFilter() const;
|
2013-09-12 11:42:18 +00:00
|
|
|
int glSwapStrategy() const;
|
2013-12-02 14:24:43 +00:00
|
|
|
int compositingType() const;
|
2013-12-15 14:20:06 +00:00
|
|
|
bool compositingEnabled() const;
|
2014-04-23 06:21:35 +00:00
|
|
|
int openGLPlatformInterface() const;
|
2016-08-26 06:56:42 +00:00
|
|
|
bool windowsBlockCompositing() const;
|
2016-08-26 10:56:25 +00:00
|
|
|
bool compositingRequired() const;
|
2014-04-23 06:21:35 +00:00
|
|
|
|
|
|
|
OpenGLPlatformInterfaceModel *openGLPlatformInterfaceModel() const;
|
2013-08-22 15:49:49 +00:00
|
|
|
|
2019-09-25 13:49:52 +00:00
|
|
|
void setAnimationSpeed(qreal speed);
|
2013-12-02 12:25:28 +00:00
|
|
|
void setWindowThumbnail(int index);
|
|
|
|
void setGlScaleFilter(int index);
|
|
|
|
void setXrScaleFilter(bool filter);
|
|
|
|
void setGlSwapStrategy(int strategy);
|
2013-12-02 14:24:43 +00:00
|
|
|
void setCompositingType(int index);
|
2013-12-15 14:20:06 +00:00
|
|
|
void setCompositingEnabled(bool enalbed);
|
2014-04-23 06:21:35 +00:00
|
|
|
void setOpenGLPlatformInterface(int interface);
|
2016-08-26 06:56:42 +00:00
|
|
|
void setWindowsBlockCompositing(bool set);
|
2013-12-02 12:25:28 +00:00
|
|
|
|
|
|
|
void save();
|
|
|
|
|
2019-09-25 13:49:52 +00:00
|
|
|
static bool isRunningPlasma();
|
|
|
|
|
2013-12-02 12:25:28 +00:00
|
|
|
public Q_SLOTS:
|
|
|
|
void reset();
|
2013-12-02 14:59:31 +00:00
|
|
|
void defaults();
|
2013-12-02 12:25:28 +00:00
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void changed();
|
2019-09-25 13:49:52 +00:00
|
|
|
void animationSpeedChanged(qreal);
|
2014-05-30 06:18:25 +00:00
|
|
|
void windowThumbnailChanged(int);
|
|
|
|
void glScaleFilterChanged(int);
|
|
|
|
void xrScaleFilterChanged(int);
|
|
|
|
void glSwapStrategyChanged(int);
|
|
|
|
void compositingTypeChanged(int);
|
|
|
|
void compositingEnabledChanged(bool);
|
|
|
|
void openGLPlatformInterfaceChanged(int);
|
2016-08-26 06:56:42 +00:00
|
|
|
void windowsBlockCompositingChanged(bool);
|
2013-08-22 15:49:49 +00:00
|
|
|
|
2013-12-02 12:25:28 +00:00
|
|
|
private:
|
2019-09-25 13:49:52 +00:00
|
|
|
qreal m_animationSpeed;
|
2013-12-02 12:25:28 +00:00
|
|
|
int m_windowThumbnail;
|
|
|
|
int m_glScaleFilter;
|
|
|
|
bool m_xrScaleFilter;
|
|
|
|
int m_glSwapStrategy;
|
2013-12-02 14:24:43 +00:00
|
|
|
int m_compositingType;
|
2013-12-15 14:20:06 +00:00
|
|
|
bool m_compositingEnabled;
|
2013-12-03 06:13:44 +00:00
|
|
|
bool m_changed;
|
2014-04-23 06:21:35 +00:00
|
|
|
OpenGLPlatformInterfaceModel *m_openGLPlatformInterfaceModel;
|
|
|
|
int m_openGLPlatformInterface;
|
2016-08-26 06:56:42 +00:00
|
|
|
bool m_windowsBlockCompositing;
|
2016-08-26 10:56:25 +00:00
|
|
|
bool m_windowsBlockingCompositing;
|
|
|
|
OrgKdeKwinCompositingInterface *m_compositingInterface;
|
2019-09-25 13:49:52 +00:00
|
|
|
KSharedConfigPtr m_config;
|
2013-08-17 08:28:09 +00:00
|
|
|
};
|
2013-08-29 16:58:51 +00:00
|
|
|
|
|
|
|
|
|
|
|
struct CompositingData;
|
|
|
|
|
|
|
|
class CompositingType : public QAbstractItemModel
|
|
|
|
{
|
|
|
|
|
|
|
|
Q_OBJECT
|
2014-03-10 08:37:17 +00:00
|
|
|
Q_ENUMS(CompositingTypeIndex)
|
2013-08-29 16:58:51 +00:00
|
|
|
|
|
|
|
public:
|
|
|
|
|
|
|
|
enum CompositingTypeIndex {
|
|
|
|
OPENGL31_INDEX = 0,
|
|
|
|
OPENGL20_INDEX,
|
|
|
|
XRENDER_INDEX
|
|
|
|
};
|
|
|
|
|
|
|
|
enum CompositingTypeRoles {
|
|
|
|
NameRole = Qt::UserRole +1,
|
2013-12-02 14:24:43 +00:00
|
|
|
TypeRole = Qt::UserRole +2
|
2013-08-29 16:58:51 +00:00
|
|
|
};
|
|
|
|
|
Use nullptr everywhere
Summary:
Because KWin is a very old project, we use three kinds of null pointer
literals: 0, NULL, and nullptr. Since C++11, it's recommended to use
nullptr keyword.
This change converts all usages of 0 and NULL literal to nullptr. Even
though it breaks git history, we need to do it in order to have consistent
code as well to ease code reviews (it's very tempting for some people to
add unrelated changes to their patches, e.g. converting NULL to nullptr).
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson, romangg
Reviewed By: #kwin, davidedmundson, romangg
Subscribers: romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
|
|
|
explicit CompositingType(QObject *parent = nullptr);
|
2013-08-29 16:58:51 +00:00
|
|
|
|
|
|
|
QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
QModelIndex parent(const QModelIndex &child) const override;
|
|
|
|
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
int columnCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
|
|
|
|
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
QHash< int, QByteArray > roleNames() const override;
|
2013-08-29 16:58:51 +00:00
|
|
|
|
2013-12-02 14:24:43 +00:00
|
|
|
Q_INVOKABLE int compositingTypeForIndex(int row) const;
|
|
|
|
Q_INVOKABLE int indexForCompositingType(int type) const;
|
2013-08-29 16:58:51 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void generateCompositing();
|
|
|
|
QList<CompositingData> m_compositingList;
|
|
|
|
|
|
|
|
};
|
|
|
|
|
|
|
|
struct CompositingData {
|
|
|
|
QString name;
|
|
|
|
CompositingType::CompositingTypeIndex type;
|
|
|
|
};
|
|
|
|
|
2014-04-23 06:21:35 +00:00
|
|
|
class OpenGLPlatformInterfaceModel : public QAbstractListModel
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
|
|
|
explicit OpenGLPlatformInterfaceModel(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~OpenGLPlatformInterfaceModel() override;
|
2014-04-23 06:21:35 +00:00
|
|
|
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
|
|
|
|
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
|
|
|
|
QModelIndex indexForKey(const QString &key) const;
|
|
|
|
|
|
|
|
QHash< int, QByteArray > roleNames() const override;
|
|
|
|
|
|
|
|
private:
|
|
|
|
QStringList m_keys;
|
|
|
|
QStringList m_names;
|
|
|
|
};
|
2013-08-29 16:58:51 +00:00
|
|
|
|
2013-08-17 08:28:09 +00:00
|
|
|
}//end namespace Compositing
|
|
|
|
}//end namespace KWin
|
2014-04-23 06:21:35 +00:00
|
|
|
|
|
|
|
Q_DECLARE_METATYPE(KWin::Compositing::OpenGLPlatformInterfaceModel*)
|
2013-08-17 08:28:09 +00:00
|
|
|
#endif
|