2015-10-26 08:17:46 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2015-10-26 08:17:46 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
|
2015-10-26 08:17:46 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2015-10-26 08:17:46 +00:00
|
|
|
#include "kwin_wayland_test.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
|
|
|
|
#include "abstract_client.h"
|
2016-11-02 10:28:54 +00:00
|
|
|
#include "atoms.h"
|
2015-10-26 08:17:46 +00:00
|
|
|
#include "cursor.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
#include "deleted.h"
|
2015-10-26 09:43:36 +00:00
|
|
|
#include "effects.h"
|
2022-04-14 12:33:28 +00:00
|
|
|
#include "output.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
#include "platform.h"
|
2015-10-26 08:17:46 +00:00
|
|
|
#include "screens.h"
|
|
|
|
#include "wayland_server.h"
|
|
|
|
#include "workspace.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
#include "x11client.h"
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
#include <KWayland/Client/compositor.h>
|
2022-03-23 10:13:38 +00:00
|
|
|
#include <KWayland/Client/connection_thread.h>
|
2016-03-16 14:35:24 +00:00
|
|
|
#include <KWayland/Client/plasmashell.h>
|
2022-03-23 10:13:38 +00:00
|
|
|
#include <KWayland/Client/pointer.h>
|
2016-10-24 15:09:40 +00:00
|
|
|
#include <KWayland/Client/seat.h>
|
2015-10-26 08:17:46 +00:00
|
|
|
#include <KWayland/Client/surface.h>
|
|
|
|
|
2016-02-17 10:00:58 +00:00
|
|
|
#include <linux/input.h>
|
2016-04-15 14:07:39 +00:00
|
|
|
#include <xcb/xcb_icccm.h>
|
2016-02-17 10:00:58 +00:00
|
|
|
|
2017-07-18 19:12:37 +00:00
|
|
|
Q_DECLARE_METATYPE(KWin::QuickTileMode)
|
2015-10-26 08:17:46 +00:00
|
|
|
Q_DECLARE_METATYPE(KWin::MaximizeMode)
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_quick_tiling-0");
|
|
|
|
|
|
|
|
class MoveResizeWindowTest : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
private Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void init();
|
|
|
|
void cleanup();
|
|
|
|
void testMove();
|
2017-01-29 13:01:15 +00:00
|
|
|
void testResize();
|
2015-10-26 10:30:34 +00:00
|
|
|
void testPackTo_data();
|
|
|
|
void testPackTo();
|
2015-10-26 12:25:47 +00:00
|
|
|
void testPackAgainstClient_data();
|
|
|
|
void testPackAgainstClient();
|
2015-10-26 14:49:03 +00:00
|
|
|
void testGrowShrink_data();
|
|
|
|
void testGrowShrink();
|
2016-02-17 10:00:58 +00:00
|
|
|
void testPointerMoveEnd_data();
|
|
|
|
void testPointerMoveEnd();
|
2016-10-24 15:09:40 +00:00
|
|
|
void testClientSideMove();
|
2016-03-16 14:35:24 +00:00
|
|
|
void testPlasmaShellSurfaceMovable_data();
|
|
|
|
void testPlasmaShellSurfaceMovable();
|
2016-04-15 14:07:39 +00:00
|
|
|
void testNetMove();
|
2016-11-02 10:28:54 +00:00
|
|
|
void testAdjustClientGeometryOfAutohidingX11Panel_data();
|
|
|
|
void testAdjustClientGeometryOfAutohidingX11Panel();
|
2016-11-02 10:51:01 +00:00
|
|
|
void testAdjustClientGeometryOfAutohidingWaylandPanel_data();
|
|
|
|
void testAdjustClientGeometryOfAutohidingWaylandPanel();
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
void testResizeForVirtualKeyboard();
|
|
|
|
void testResizeForVirtualKeyboardWithMaximize();
|
|
|
|
void testResizeForVirtualKeyboardWithFullScreen();
|
2019-03-12 09:35:17 +00:00
|
|
|
void testDestroyMoveClient();
|
|
|
|
void testDestroyResizeClient();
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
KWayland::Client::ConnectionThread *m_connection = nullptr;
|
|
|
|
KWayland::Client::Compositor *m_compositor = nullptr;
|
|
|
|
};
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::initTestCase()
|
|
|
|
{
|
2019-07-30 19:08:28 +00:00
|
|
|
qRegisterMetaType<KWin::AbstractClient *>();
|
|
|
|
qRegisterMetaType<KWin::Deleted *>();
|
2015-10-26 08:17:46 +00:00
|
|
|
qRegisterMetaType<KWin::MaximizeMode>("MaximizeMode");
|
2020-07-07 09:32:29 +00:00
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
|
|
|
QVERIFY(applicationStartedSpy.isValid());
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
2020-12-09 13:06:15 +00:00
|
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
2015-10-26 08:17:46 +00:00
|
|
|
kwinApp()->start();
|
2020-07-07 09:32:29 +00:00
|
|
|
QVERIFY(applicationStartedSpy.wait());
|
2021-08-31 07:03:05 +00:00
|
|
|
const auto outputs = kwinApp()->platform()->enabledOutputs();
|
2021-09-07 17:51:48 +00:00
|
|
|
QCOMPARE(outputs.count(), 1);
|
2021-08-31 07:03:05 +00:00
|
|
|
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
|
2015-10-26 08:17:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::init()
|
|
|
|
{
|
2016-12-03 13:31:14 +00:00
|
|
|
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::PlasmaShell | Test::AdditionalWaylandInterface::Seat));
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(Test::waitForWaylandPointer());
|
2016-06-30 11:32:54 +00:00
|
|
|
m_connection = Test::waylandConnection();
|
|
|
|
m_compositor = Test::waylandCompositor();
|
2015-10-26 08:17:46 +00:00
|
|
|
|
2021-08-28 18:58:29 +00:00
|
|
|
workspace()->setActiveOutput(QPoint(640, 512));
|
2015-10-26 08:17:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::cleanup()
|
|
|
|
{
|
2016-06-30 11:32:54 +00:00
|
|
|
Test::destroyWaylandConnection();
|
2015-10-26 08:17:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testMove()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2015-10-26 08:17:46 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2015-10-26 08:17:46 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(0, 0, 100, 50));
|
2015-10-26 08:17:46 +00:00
|
|
|
QSignalSpy startMoveResizedSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(startMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy moveResizedChangedSpy(c, &AbstractClient::moveResizedChanged);
|
|
|
|
QVERIFY(moveResizedChangedSpy.isValid());
|
|
|
|
QSignalSpy clientStepUserMovedResizedSpy(c, &AbstractClient::clientStepUserMovedResized);
|
|
|
|
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(c, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
2015-10-26 09:43:36 +00:00
|
|
|
// effects signal handlers
|
|
|
|
QSignalSpy windowStartUserMovedResizedSpy(effects, &EffectsHandler::windowStartUserMovedResized);
|
|
|
|
QVERIFY(windowStartUserMovedResizedSpy.isValid());
|
|
|
|
QSignalSpy windowStepUserMovedResizedSpy(effects, &EffectsHandler::windowStepUserMovedResized);
|
|
|
|
QVERIFY(windowStepUserMovedResizedSpy.isValid());
|
|
|
|
QSignalSpy windowFinishUserMovedResizedSpy(effects, &EffectsHandler::windowFinishUserMovedResized);
|
|
|
|
QVERIFY(windowFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
2015-10-26 08:17:46 +00:00
|
|
|
// begin move
|
2019-04-18 12:28:11 +00:00
|
|
|
QVERIFY(workspace()->moveResizeClient() == nullptr);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), false);
|
2015-10-26 08:17:46 +00:00
|
|
|
workspace()->slotWindowMove();
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), c);
|
2015-10-26 08:17:46 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 1);
|
|
|
|
QCOMPARE(moveResizedChangedSpy.count(), 1);
|
2015-10-26 09:43:36 +00:00
|
|
|
QCOMPARE(windowStartUserMovedResizedSpy.count(), 1);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), true);
|
2021-10-31 19:26:01 +00:00
|
|
|
QCOMPARE(c->geometryRestore(), QRect());
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
// send some key events, not going through input redirection
|
2020-04-02 16:18:01 +00:00
|
|
|
const QPoint cursorPos = Cursors::self()->mouse()->pos();
|
2015-10-26 08:17:46 +00:00
|
|
|
c->keyPressEvent(Qt::Key_Right);
|
2021-04-30 18:06:58 +00:00
|
|
|
c->updateInteractiveMoveResize(Cursors::self()->mouse()->pos());
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
2015-10-26 08:17:46 +00:00
|
|
|
QEXPECT_FAIL("", "First event is ignored", Continue);
|
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
2017-01-26 19:41:58 +00:00
|
|
|
clientStepUserMovedResizedSpy.clear();
|
|
|
|
windowStepUserMovedResizedSpy.clear();
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
c->keyPressEvent(Qt::Key_Right);
|
2021-04-30 18:06:58 +00:00
|
|
|
c->updateInteractiveMoveResize(Cursors::self()->mouse()->pos());
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), cursorPos + QPoint(16, 0));
|
2017-01-26 19:41:58 +00:00
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
|
|
|
QCOMPARE(windowStepUserMovedResizedSpy.count(), 1);
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
c->keyPressEvent(Qt::Key_Down | Qt::ALT);
|
2021-04-30 18:06:58 +00:00
|
|
|
c->updateInteractiveMoveResize(Cursors::self()->mouse()->pos());
|
2017-01-26 19:41:58 +00:00
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
|
|
|
QCOMPARE(windowStepUserMovedResizedSpy.count(), 2);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(16, 32, 100, 50));
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), cursorPos + QPoint(16, 32));
|
2015-10-26 08:17:46 +00:00
|
|
|
|
|
|
|
// let's end
|
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
|
|
|
c->keyPressEvent(Qt::Key_Enter);
|
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
2015-10-26 09:14:54 +00:00
|
|
|
QCOMPARE(moveResizedChangedSpy.count(), 2);
|
2015-10-26 09:43:36 +00:00
|
|
|
QCOMPARE(windowFinishUserMovedResizedSpy.count(), 1);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(16, 32, 100, 50));
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), false);
|
2019-04-18 12:28:11 +00:00
|
|
|
QVERIFY(workspace()->moveResizeClient() == nullptr);
|
2016-07-01 10:37:09 +00:00
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(c));
|
2015-10-26 08:17:46 +00:00
|
|
|
}
|
|
|
|
|
2017-01-29 13:01:15 +00:00
|
|
|
void MoveResizeWindowTest::testResize()
|
|
|
|
{
|
|
|
|
// a test case which manually resizes a window
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2017-01-29 13:01:15 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-12-09 07:47:55 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data(), Test::CreationSetup::CreateOnly));
|
2017-01-29 13:01:15 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// Wait for the initial configure event.
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::XdgToplevel::States states;
|
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested);
|
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.isValid());
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.isValid());
|
2021-09-03 17:54:03 +00:00
|
|
|
surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 1);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 1);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Resizing));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// Let's render.
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2017-01-29 13:01:15 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
|
|
|
|
2019-07-30 19:05:50 +00:00
|
|
|
// We have to receive a configure event when the client becomes active.
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 2);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 2);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Resizing));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
2017-01-29 13:01:15 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(0, 0, 100, 50));
|
2020-02-05 09:28:50 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(c, &AbstractClient::frameGeometryChanged);
|
|
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
2017-01-29 13:01:15 +00:00
|
|
|
QSignalSpy startMoveResizedSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(startMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy moveResizedChangedSpy(c, &AbstractClient::moveResizedChanged);
|
|
|
|
QVERIFY(moveResizedChangedSpy.isValid());
|
|
|
|
QSignalSpy clientStepUserMovedResizedSpy(c, &AbstractClient::clientStepUserMovedResized);
|
|
|
|
QVERIFY(clientStepUserMovedResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(c, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
|
|
|
// begin resize
|
2019-07-30 19:05:50 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), false);
|
|
|
|
QCOMPARE(c->isInteractiveResize(), false);
|
2017-01-29 13:01:15 +00:00
|
|
|
workspace()->slotWindowResize();
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), c);
|
2017-01-29 13:01:15 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 1);
|
|
|
|
QCOMPARE(moveResizedChangedSpy.count(), 1);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveResize(), true);
|
2021-10-31 19:26:01 +00:00
|
|
|
QCOMPARE(c->geometryRestore(), QRect());
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 3);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 3);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Resizing));
|
2017-01-29 13:01:15 +00:00
|
|
|
|
2019-07-30 19:05:50 +00:00
|
|
|
// Trigger a change.
|
2020-04-02 16:18:01 +00:00
|
|
|
const QPoint cursorPos = Cursors::self()->mouse()->pos();
|
2017-01-29 13:01:15 +00:00
|
|
|
c->keyPressEvent(Qt::Key_Right);
|
2021-04-30 18:06:58 +00:00
|
|
|
c->updateInteractiveMoveResize(Cursors::self()->mouse()->pos());
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// The client should receive a configure event with the new size.
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 4);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 4);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Resizing));
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(108, 50));
|
2021-12-24 09:20:00 +00:00
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// Now render new size.
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2017-01-29 13:01:15 +00:00
|
|
|
Test::render(surface.data(), QSize(108, 50), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(0, 0, 108, 50));
|
2017-01-29 13:01:15 +00:00
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
|
|
|
|
|
2019-07-30 19:05:50 +00:00
|
|
|
// Go down.
|
2017-01-29 13:01:15 +00:00
|
|
|
c->keyPressEvent(Qt::Key_Down);
|
2021-04-30 18:06:58 +00:00
|
|
|
c->updateInteractiveMoveResize(Cursors::self()->mouse()->pos());
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// The client should receive another configure event.
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 5);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 5);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Resizing));
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(108, 58));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// Now render new size.
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2017-01-29 13:01:15 +00:00
|
|
|
Test::render(surface.data(), QSize(108, 58), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(0, 0, 108, 58));
|
2017-01-29 13:01:15 +00:00
|
|
|
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
|
|
|
|
|
2019-07-30 19:05:50 +00:00
|
|
|
// Let's finalize the resize operation.
|
2017-01-29 13:01:15 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
|
|
|
|
c->keyPressEvent(Qt::Key_Enter);
|
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
|
|
|
QCOMPARE(moveResizedChangedSpy.count(), 2);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveResize(), false);
|
2019-07-30 19:05:50 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 6);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.count(), 6);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Resizing));
|
2019-07-30 19:05:50 +00:00
|
|
|
|
|
|
|
// Destroy the client.
|
2020-02-17 18:39:17 +00:00
|
|
|
shellSurface.reset();
|
2017-01-29 13:01:15 +00:00
|
|
|
QVERIFY(Test::waitForWindowDestroyed(c));
|
|
|
|
}
|
|
|
|
|
2015-10-26 10:30:34 +00:00
|
|
|
void MoveResizeWindowTest::testPackTo_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QString>("methodCall");
|
|
|
|
QTest::addColumn<QRect>("expectedGeometry");
|
|
|
|
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("left") << QStringLiteral("slotWindowMoveLeft") << QRect(0, 487, 100, 50);
|
|
|
|
QTest::newRow("up") << QStringLiteral("slotWindowMoveUp") << QRect(590, 0, 100, 50);
|
2021-10-04 16:20:10 +00:00
|
|
|
QTest::newRow("right") << QStringLiteral("slotWindowMoveRight") << QRect(1180, 487, 100, 50);
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("down") << QStringLiteral("slotWindowMoveDown") << QRect(590, 974, 100, 50);
|
2015-10-26 10:30:34 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testPackTo()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2015-10-26 10:30:34 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2015-10-26 10:30:34 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2015-10-26 10:30:34 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(0, 0, 100, 50));
|
2015-10-26 10:30:34 +00:00
|
|
|
|
|
|
|
// let's place it centered
|
|
|
|
Placement::self()->placeCentered(c, QRect(0, 0, 1280, 1024));
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(590, 487, 100, 50));
|
2015-10-26 10:30:34 +00:00
|
|
|
|
|
|
|
QFETCH(QString, methodCall);
|
|
|
|
QMetaObject::invokeMethod(workspace(), methodCall.toLocal8Bit().constData());
|
2019-09-27 10:01:10 +00:00
|
|
|
QTEST(c->frameGeometry(), "expectedGeometry");
|
2016-07-01 10:37:09 +00:00
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(c));
|
2015-10-26 10:30:34 +00:00
|
|
|
}
|
|
|
|
|
2015-10-26 12:25:47 +00:00
|
|
|
void MoveResizeWindowTest::testPackAgainstClient_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QString>("methodCall");
|
|
|
|
QTest::addColumn<QRect>("expectedGeometry");
|
|
|
|
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("left") << QStringLiteral("slotWindowMoveLeft") << QRect(10, 487, 100, 50);
|
|
|
|
QTest::newRow("up") << QStringLiteral("slotWindowMoveUp") << QRect(590, 10, 100, 50);
|
2021-10-04 16:20:10 +00:00
|
|
|
QTest::newRow("right") << QStringLiteral("slotWindowMoveRight") << QRect(1170, 487, 100, 50);
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("down") << QStringLiteral("slotWindowMoveDown") << QRect(590, 964, 100, 50);
|
2015-10-26 12:25:47 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testPackAgainstClient()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface1(Test::createSurface());
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!surface1.isNull());
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface2(Test::createSurface());
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!surface2.isNull());
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface3(Test::createSurface());
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!surface3.isNull());
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface4(Test::createSurface());
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!surface4.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface1(Test::createXdgToplevelSurface(surface1.data()));
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!shellSurface1.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface2(Test::createXdgToplevelSurface(surface2.data()));
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!shellSurface2.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface3(Test::createXdgToplevelSurface(surface3.data()));
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!shellSurface3.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface4(Test::createXdgToplevelSurface(surface4.data()));
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!shellSurface4.isNull());
|
2022-03-23 10:13:38 +00:00
|
|
|
auto renderWindow = [](KWayland::Client::Surface *surface, const QString &methodCall, const QRect &expectedGeometry) {
|
2015-10-26 12:25:47 +00:00
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface, QSize(10, 10), Qt::blue);
|
2015-10-26 12:25:47 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry().size(), QSize(10, 10));
|
2015-10-26 12:25:47 +00:00
|
|
|
// let's place it centered
|
|
|
|
Placement::self()->placeCentered(c, QRect(0, 0, 1280, 1024));
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(635, 507, 10, 10));
|
2015-10-26 12:25:47 +00:00
|
|
|
QMetaObject::invokeMethod(workspace(), methodCall.toLocal8Bit().constData());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), expectedGeometry);
|
2015-10-26 12:25:47 +00:00
|
|
|
};
|
2022-03-23 10:13:38 +00:00
|
|
|
renderWindow(surface1.data(), QStringLiteral("slotWindowMoveLeft"), QRect(0, 507, 10, 10));
|
|
|
|
renderWindow(surface2.data(), QStringLiteral("slotWindowMoveUp"), QRect(635, 0, 10, 10));
|
2021-10-04 16:20:10 +00:00
|
|
|
renderWindow(surface3.data(), QStringLiteral("slotWindowMoveRight"), QRect(1270, 507, 10, 10));
|
2022-03-23 10:13:38 +00:00
|
|
|
renderWindow(surface4.data(), QStringLiteral("slotWindowMoveDown"), QRect(635, 1014, 10, 10));
|
2015-10-26 12:25:47 +00:00
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2015-10-26 12:25:47 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2015-10-26 12:25:47 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2015-10-26 12:25:47 +00:00
|
|
|
// let's place it centered
|
|
|
|
Placement::self()->placeCentered(c, QRect(0, 0, 1280, 1024));
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(590, 487, 100, 50));
|
2015-10-26 12:25:47 +00:00
|
|
|
|
|
|
|
QFETCH(QString, methodCall);
|
|
|
|
QMetaObject::invokeMethod(workspace(), methodCall.toLocal8Bit().constData());
|
2019-09-27 10:01:10 +00:00
|
|
|
QTEST(c->frameGeometry(), "expectedGeometry");
|
2015-10-26 12:25:47 +00:00
|
|
|
}
|
|
|
|
|
2015-10-26 14:49:03 +00:00
|
|
|
void MoveResizeWindowTest::testGrowShrink_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QString>("methodCall");
|
|
|
|
QTest::addColumn<QRect>("expectedGeometry");
|
|
|
|
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("grow vertical") << QStringLiteral("slotWindowExpandVertical") << QRect(590, 487, 100, 537);
|
|
|
|
QTest::newRow("grow horizontal") << QStringLiteral("slotWindowExpandHorizontal") << QRect(590, 487, 690, 50);
|
|
|
|
QTest::newRow("shrink vertical") << QStringLiteral("slotWindowShrinkVertical") << QRect(590, 487, 100, 23);
|
2015-10-26 14:49:03 +00:00
|
|
|
QTest::newRow("shrink horizontal") << QStringLiteral("slotWindowShrinkHorizontal") << QRect(590, 487, 40, 50);
|
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testGrowShrink()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
|
|
|
// block geometry helper
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface1(Test::createSurface());
|
2015-10-26 14:49:03 +00:00
|
|
|
QVERIFY(!surface1.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface1(Test::createXdgToplevelSurface(surface1.data()));
|
2015-10-26 14:49:03 +00:00
|
|
|
QVERIFY(!shellSurface1.isNull());
|
2016-06-30 11:32:54 +00:00
|
|
|
Test::render(surface1.data(), QSize(650, 514), Qt::blue);
|
2016-07-01 07:54:44 +00:00
|
|
|
QVERIFY(Test::waitForWaylandWindowShown());
|
2021-10-04 16:20:10 +00:00
|
|
|
workspace()->slotWindowMoveRight();
|
|
|
|
workspace()->slotWindowMoveDown();
|
2015-10-26 14:49:03 +00:00
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2015-10-26 14:49:03 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2015-10-26 14:49:03 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested);
|
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.isValid());
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.isValid());
|
2015-10-26 14:49:03 +00:00
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2021-05-11 17:32:24 +00:00
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.wait());
|
2015-10-26 14:49:03 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(workspace()->activeClient(), c);
|
2015-10-26 14:49:03 +00:00
|
|
|
|
|
|
|
// let's place it centered
|
|
|
|
Placement::self()->placeCentered(c, QRect(0, 0, 1280, 1024));
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), QRect(590, 487, 100, 50));
|
2015-10-26 14:49:03 +00:00
|
|
|
|
|
|
|
QFETCH(QString, methodCall);
|
|
|
|
QMetaObject::invokeMethod(workspace(), methodCall.toLocal8Bit().constData());
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::red);
|
2015-10-26 14:49:03 +00:00
|
|
|
|
2020-02-05 09:28:50 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(c, &AbstractClient::frameGeometryChanged);
|
|
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
2015-10-26 14:49:03 +00:00
|
|
|
m_connection->flush();
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QTEST(c->frameGeometry(), "expectedGeometry");
|
2015-10-26 14:49:03 +00:00
|
|
|
}
|
|
|
|
|
2016-02-17 10:00:58 +00:00
|
|
|
void MoveResizeWindowTest::testPointerMoveEnd_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<int>("additionalButton");
|
|
|
|
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("BTN_RIGHT") << BTN_RIGHT;
|
|
|
|
QTest::newRow("BTN_MIDDLE") << BTN_MIDDLE;
|
|
|
|
QTest::newRow("BTN_SIDE") << BTN_SIDE;
|
|
|
|
QTest::newRow("BTN_EXTRA") << BTN_EXTRA;
|
2016-02-17 10:00:58 +00:00
|
|
|
QTest::newRow("BTN_FORWARD") << BTN_FORWARD;
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("BTN_BACK") << BTN_BACK;
|
|
|
|
QTest::newRow("BTN_TASK") << BTN_TASK;
|
|
|
|
for (int i = BTN_TASK + 1; i < BTN_JOYSTICK; i++) {
|
2016-02-17 10:00:58 +00:00
|
|
|
QTest::newRow(QByteArray::number(i, 16).constData()) << i;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testPointerMoveEnd()
|
|
|
|
{
|
|
|
|
// this test verifies that moving a window through pointer only ends if all buttons are released
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2016-02-17 10:00:58 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2016-02-17 10:00:58 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2016-02-17 10:00:58 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
QCOMPARE(c, workspace()->activeClient());
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-02-17 10:00:58 +00:00
|
|
|
|
|
|
|
// let's trigger the left button
|
|
|
|
quint32 timestamp = 1;
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonPressed(BTN_LEFT, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-02-17 10:00:58 +00:00
|
|
|
workspace()->slotWindowMove();
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-02-17 10:00:58 +00:00
|
|
|
|
|
|
|
// let's press another button
|
|
|
|
QFETCH(int, additionalButton);
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonPressed(additionalButton, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-02-17 10:00:58 +00:00
|
|
|
|
|
|
|
// release the left button, should still have the window moving
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonReleased(BTN_LEFT, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-02-17 10:00:58 +00:00
|
|
|
|
|
|
|
// but releasing the other button should now end moving
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonReleased(additionalButton, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-07-01 13:21:37 +00:00
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(c));
|
2016-02-17 10:00:58 +00:00
|
|
|
}
|
2016-10-24 15:09:40 +00:00
|
|
|
void MoveResizeWindowTest::testClientSideMove()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(640, 512);
|
2016-10-24 15:09:40 +00:00
|
|
|
QScopedPointer<Pointer> pointer(Test::waylandSeat()->createPointer());
|
|
|
|
QSignalSpy pointerEnteredSpy(pointer.data(), &Pointer::entered);
|
|
|
|
QVERIFY(pointerEnteredSpy.isValid());
|
|
|
|
QSignalSpy pointerLeftSpy(pointer.data(), &Pointer::left);
|
|
|
|
QVERIFY(pointerLeftSpy.isValid());
|
|
|
|
QSignalSpy buttonSpy(pointer.data(), &Pointer::buttonStateChanged);
|
|
|
|
QVERIFY(buttonSpy.isValid());
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2016-10-24 15:09:40 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
|
|
|
QVERIFY(c);
|
|
|
|
|
|
|
|
// move pointer into center of geometry
|
2019-09-27 10:01:10 +00:00
|
|
|
const QRect startGeometry = c->frameGeometry();
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(startGeometry.center());
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(pointerEnteredSpy.wait());
|
|
|
|
QCOMPARE(pointerEnteredSpy.first().last().toPoint(), QPoint(49, 24));
|
|
|
|
// simulate press
|
|
|
|
quint32 timestamp = 1;
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonPressed(BTN_LEFT, timestamp++);
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(buttonSpy.wait());
|
|
|
|
QSignalSpy moveStartSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(moveStartSpy.isValid());
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->move(*Test::waylandSeat(), buttonSpy.first().first().value<quint32>());
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(moveStartSpy.wait());
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), true);
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(pointerLeftSpy.wait());
|
|
|
|
|
|
|
|
// move a bit
|
|
|
|
QSignalSpy clientMoveStepSpy(c, &AbstractClient::clientStepUserMovedResized);
|
|
|
|
QVERIFY(clientMoveStepSpy.isValid());
|
|
|
|
const QPoint startPoint = startGeometry.center();
|
|
|
|
const int dragDistance = QApplication::startDragDistance();
|
|
|
|
// Why?
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerMotion(startPoint + QPoint(dragDistance, dragDistance) + QPoint(6, 6), timestamp++);
|
2016-10-24 15:09:40 +00:00
|
|
|
QCOMPARE(clientMoveStepSpy.count(), 1);
|
|
|
|
|
|
|
|
// and release again
|
2022-03-10 10:27:35 +00:00
|
|
|
Test::pointerButtonReleased(BTN_LEFT, timestamp++);
|
2016-10-24 15:09:40 +00:00
|
|
|
QVERIFY(pointerEnteredSpy.wait());
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), false);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(c->frameGeometry(), startGeometry.translated(QPoint(dragDistance, dragDistance) + QPoint(6, 6)));
|
2016-10-24 15:09:40 +00:00
|
|
|
QCOMPARE(pointerEnteredSpy.last().last().toPoint(), QPoint(49, 24));
|
|
|
|
}
|
2016-02-17 10:00:58 +00:00
|
|
|
|
2016-03-16 14:35:24 +00:00
|
|
|
void MoveResizeWindowTest::testPlasmaShellSurfaceMovable_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<KWayland::Client::PlasmaShellSurface::Role>("role");
|
|
|
|
QTest::addColumn<bool>("movable");
|
|
|
|
QTest::addColumn<bool>("movableAcrossScreens");
|
|
|
|
QTest::addColumn<bool>("resizable");
|
|
|
|
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("normal") << KWayland::Client::PlasmaShellSurface::Role::Normal << true << true << true;
|
|
|
|
QTest::newRow("desktop") << KWayland::Client::PlasmaShellSurface::Role::Desktop << false << false << false;
|
|
|
|
QTest::newRow("panel") << KWayland::Client::PlasmaShellSurface::Role::Panel << false << false << false;
|
|
|
|
QTest::newRow("osd") << KWayland::Client::PlasmaShellSurface::Role::OnScreenDisplay << false << false << false;
|
2016-03-16 14:35:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testPlasmaShellSurfaceMovable()
|
|
|
|
{
|
|
|
|
// this test verifies that certain window types from PlasmaShellSurface are not moveable or resizable
|
|
|
|
using namespace KWayland::Client;
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2016-03-16 14:35:24 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2016-03-16 14:35:24 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
// and a PlasmaShellSurface
|
2016-06-30 11:32:54 +00:00
|
|
|
QScopedPointer<PlasmaShellSurface> plasmaSurface(Test::waylandPlasmaShell()->createSurface(surface.data()));
|
2016-03-16 14:35:24 +00:00
|
|
|
QVERIFY(!plasmaSurface.isNull());
|
|
|
|
QFETCH(KWayland::Client::PlasmaShellSurface::Role, role);
|
|
|
|
plasmaSurface->setRole(role);
|
|
|
|
// let's render
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2016-03-16 14:35:24 +00:00
|
|
|
|
|
|
|
QVERIFY(c);
|
|
|
|
QTEST(c->isMovable(), "movable");
|
|
|
|
QTEST(c->isMovableAcrossScreens(), "movableAcrossScreens");
|
|
|
|
QTEST(c->isResizable(), "resizable");
|
2016-07-01 13:21:37 +00:00
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(c));
|
2016-03-16 14:35:24 +00:00
|
|
|
}
|
|
|
|
|
2016-11-02 10:28:54 +00:00
|
|
|
struct XcbConnectionDeleter
|
|
|
|
{
|
|
|
|
static inline void cleanup(xcb_connection_t *pointer)
|
|
|
|
{
|
|
|
|
xcb_disconnect(pointer);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2016-04-15 14:07:39 +00:00
|
|
|
void MoveResizeWindowTest::testNetMove()
|
|
|
|
{
|
|
|
|
// this test verifies that a move request for an X11 window through NET API works
|
|
|
|
// create an xcb window
|
|
|
|
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
|
|
|
QVERIFY(!xcb_connection_has_error(c.data()));
|
|
|
|
|
|
|
|
xcb_window_t w = xcb_generate_id(c.data());
|
|
|
|
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
|
|
|
0, 0, 100, 100,
|
|
|
|
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
|
|
|
xcb_size_hints_t hints;
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
|
|
xcb_icccm_size_hints_set_position(&hints, 1, 0, 0);
|
|
|
|
xcb_icccm_size_hints_set_size(&hints, 1, 100, 100);
|
|
|
|
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
|
|
|
// let's set a no-border
|
|
|
|
NETWinInfo winInfo(c.data(), w, rootWindow(), NET::WMWindowType, NET::Properties2());
|
|
|
|
winInfo.setWindowType(NET::Override);
|
|
|
|
xcb_map_window(c.data(), w);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
|
|
|
|
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
|
|
|
QVERIFY(windowCreatedSpy.isValid());
|
|
|
|
QVERIFY(windowCreatedSpy.wait());
|
2019-09-24 08:48:08 +00:00
|
|
|
X11Client *client = windowCreatedSpy.first().first().value<X11Client *>();
|
2016-04-15 14:07:39 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
QCOMPARE(client->window(), w);
|
2019-09-27 10:01:10 +00:00
|
|
|
const QRect origGeo = client->frameGeometry();
|
2016-04-15 14:07:39 +00:00
|
|
|
|
|
|
|
// let's move the cursor outside the window
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(screens()->geometry(0).center());
|
|
|
|
QVERIFY(!origGeo.contains(Cursors::self()->mouse()->pos()));
|
2016-04-15 14:07:39 +00:00
|
|
|
|
2019-09-24 08:48:08 +00:00
|
|
|
QSignalSpy moveStartSpy(client, &X11Client::clientStartUserMovedResized);
|
2016-04-15 14:07:39 +00:00
|
|
|
QVERIFY(moveStartSpy.isValid());
|
2019-09-24 08:48:08 +00:00
|
|
|
QSignalSpy moveEndSpy(client, &X11Client::clientFinishUserMovedResized);
|
2016-04-15 14:07:39 +00:00
|
|
|
QVERIFY(moveEndSpy.isValid());
|
2019-09-24 08:48:08 +00:00
|
|
|
QSignalSpy moveStepSpy(client, &X11Client::clientStepUserMovedResized);
|
2016-04-15 14:07:39 +00:00
|
|
|
QVERIFY(moveStepSpy.isValid());
|
2019-04-18 12:28:11 +00:00
|
|
|
QVERIFY(!workspace()->moveResizeClient());
|
2016-04-15 14:07:39 +00:00
|
|
|
|
|
|
|
// use NETRootInfo to trigger a move request
|
|
|
|
NETRootInfo root(c.data(), NET::Properties());
|
|
|
|
root.moveResizeRequest(w, origGeo.center().x(), origGeo.center().y(), NET::Move);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
|
|
|
|
QVERIFY(moveStartSpy.wait());
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), client);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(client->isInteractiveMove());
|
2016-04-15 14:07:39 +00:00
|
|
|
QCOMPARE(client->geometryRestore(), origGeo);
|
2020-04-02 16:18:01 +00:00
|
|
|
QCOMPARE(Cursors::self()->mouse()->pos(), origGeo.center());
|
2016-04-15 14:07:39 +00:00
|
|
|
|
|
|
|
// let's move a step
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(Cursors::self()->mouse()->pos() + QPoint(10, 10));
|
2016-04-15 14:07:39 +00:00
|
|
|
QCOMPARE(moveStepSpy.count(), 1);
|
|
|
|
QCOMPARE(moveStepSpy.first().last().toRect(), origGeo.translated(10, 10));
|
|
|
|
|
|
|
|
// let's cancel the move resize again through the net API
|
2019-09-27 10:01:10 +00:00
|
|
|
root.moveResizeRequest(w, client->frameGeometry().center().x(), client->frameGeometry().center().y(), NET::MoveResizeCancel);
|
2016-04-15 14:07:39 +00:00
|
|
|
xcb_flush(c.data());
|
|
|
|
QVERIFY(moveEndSpy.wait());
|
|
|
|
|
|
|
|
// and destroy the window again
|
|
|
|
xcb_unmap_window(c.data(), w);
|
|
|
|
xcb_destroy_window(c.data(), w);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
c.reset();
|
|
|
|
|
2019-09-24 08:48:08 +00:00
|
|
|
QSignalSpy windowClosedSpy(client, &X11Client::windowClosed);
|
2016-04-15 14:07:39 +00:00
|
|
|
QVERIFY(windowClosedSpy.isValid());
|
|
|
|
QVERIFY(windowClosedSpy.wait());
|
|
|
|
}
|
|
|
|
|
2016-11-02 10:28:54 +00:00
|
|
|
void MoveResizeWindowTest::testAdjustClientGeometryOfAutohidingX11Panel_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QRect>("panelGeometry");
|
|
|
|
QTest::addColumn<QPoint>("targetPoint");
|
|
|
|
QTest::addColumn<QPoint>("expectedAdjustedPoint");
|
|
|
|
QTest::addColumn<quint32>("hideLocation");
|
|
|
|
|
|
|
|
QTest::newRow("top") << QRect(0, 0, 100, 20) << QPoint(50, 25) << QPoint(50, 20) << 0u;
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("bottom") << QRect(0, 1024 - 20, 100, 20) << QPoint(50, 1024 - 25 - 50) << QPoint(50, 1024 - 20 - 50) << 2u;
|
2016-11-02 10:28:54 +00:00
|
|
|
QTest::newRow("left") << QRect(0, 0, 20, 100) << QPoint(25, 50) << QPoint(20, 50) << 3u;
|
|
|
|
QTest::newRow("right") << QRect(1280 - 20, 0, 20, 100) << QPoint(1280 - 25 - 100, 50) << QPoint(1280 - 20 - 100, 50) << 1u;
|
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testAdjustClientGeometryOfAutohidingX11Panel()
|
|
|
|
{
|
|
|
|
// this test verifies that auto hiding panels are ignored when adjusting client geometry
|
|
|
|
// see BUG 365892
|
|
|
|
|
|
|
|
// first create our panel
|
|
|
|
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
|
|
|
QVERIFY(!xcb_connection_has_error(c.data()));
|
|
|
|
|
|
|
|
xcb_window_t w = xcb_generate_id(c.data());
|
|
|
|
QFETCH(QRect, panelGeometry);
|
|
|
|
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
|
|
|
|
panelGeometry.x(), panelGeometry.y(), panelGeometry.width(), panelGeometry.height(),
|
|
|
|
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
|
|
|
|
xcb_size_hints_t hints;
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
|
|
xcb_icccm_size_hints_set_position(&hints, 1, panelGeometry.x(), panelGeometry.y());
|
|
|
|
xcb_icccm_size_hints_set_size(&hints, 1, panelGeometry.width(), panelGeometry.height());
|
|
|
|
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
|
|
|
|
NETWinInfo winInfo(c.data(), w, rootWindow(), NET::WMWindowType, NET::Properties2());
|
|
|
|
winInfo.setWindowType(NET::Dock);
|
|
|
|
xcb_map_window(c.data(), w);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
|
|
|
|
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
|
|
|
|
QVERIFY(windowCreatedSpy.isValid());
|
|
|
|
QVERIFY(windowCreatedSpy.wait());
|
2019-09-24 08:48:08 +00:00
|
|
|
X11Client *panel = windowCreatedSpy.first().first().value<X11Client *>();
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(panel);
|
|
|
|
QCOMPARE(panel->window(), w);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(panel->frameGeometry(), panelGeometry);
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(panel->isDock());
|
|
|
|
|
|
|
|
// let's create a window
|
|
|
|
using namespace KWayland::Client;
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
auto testWindow = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
|
|
|
|
|
|
|
QVERIFY(testWindow);
|
|
|
|
QVERIFY(testWindow->isMovable());
|
|
|
|
// panel is not yet hidden, we should snap against it
|
|
|
|
QFETCH(QPoint, targetPoint);
|
|
|
|
QTEST(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), "expectedAdjustedPoint");
|
|
|
|
|
|
|
|
// now let's hide the panel
|
|
|
|
QSignalSpy panelHiddenSpy(panel, &AbstractClient::windowHidden);
|
|
|
|
QVERIFY(panelHiddenSpy.isValid());
|
|
|
|
QFETCH(quint32, hideLocation);
|
|
|
|
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w, atoms->kde_screen_edge_show, XCB_ATOM_CARDINAL, 32, 1, &hideLocation);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
QVERIFY(panelHiddenSpy.wait());
|
|
|
|
|
|
|
|
// now try to snap again
|
|
|
|
QCOMPARE(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), targetPoint);
|
|
|
|
|
|
|
|
// and destroy the panel again
|
|
|
|
xcb_unmap_window(c.data(), w);
|
|
|
|
xcb_destroy_window(c.data(), w);
|
|
|
|
xcb_flush(c.data());
|
|
|
|
c.reset();
|
|
|
|
|
2019-09-24 08:48:08 +00:00
|
|
|
QSignalSpy panelClosedSpy(panel, &X11Client::windowClosed);
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(panelClosedSpy.isValid());
|
|
|
|
QVERIFY(panelClosedSpy.wait());
|
|
|
|
|
|
|
|
// snap once more
|
|
|
|
QCOMPARE(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), targetPoint);
|
|
|
|
|
|
|
|
// and close
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy windowClosedSpy(testWindow, &AbstractClient::windowClosed);
|
2016-11-02 10:28:54 +00:00
|
|
|
QVERIFY(windowClosedSpy.isValid());
|
|
|
|
shellSurface.reset();
|
|
|
|
surface.reset();
|
|
|
|
QVERIFY(windowClosedSpy.wait());
|
|
|
|
}
|
|
|
|
|
2016-11-02 10:51:01 +00:00
|
|
|
void MoveResizeWindowTest::testAdjustClientGeometryOfAutohidingWaylandPanel_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QRect>("panelGeometry");
|
|
|
|
QTest::addColumn<QPoint>("targetPoint");
|
|
|
|
QTest::addColumn<QPoint>("expectedAdjustedPoint");
|
|
|
|
|
|
|
|
QTest::newRow("top") << QRect(0, 0, 100, 20) << QPoint(50, 25) << QPoint(50, 20);
|
2022-03-23 10:13:38 +00:00
|
|
|
QTest::newRow("bottom") << QRect(0, 1024 - 20, 100, 20) << QPoint(50, 1024 - 25 - 50) << QPoint(50, 1024 - 20 - 50);
|
2016-11-02 10:51:01 +00:00
|
|
|
QTest::newRow("left") << QRect(0, 0, 20, 100) << QPoint(25, 50) << QPoint(20, 50);
|
|
|
|
QTest::newRow("right") << QRect(1280 - 20, 0, 20, 100) << QPoint(1280 - 25 - 100, 50) << QPoint(1280 - 20 - 100, 50);
|
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testAdjustClientGeometryOfAutohidingWaylandPanel()
|
|
|
|
{
|
|
|
|
// this test verifies that auto hiding panels are ignored when adjusting client geometry
|
|
|
|
// see BUG 365892
|
|
|
|
|
|
|
|
// first create our panel
|
|
|
|
using namespace KWayland::Client;
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> panelSurface(Test::createSurface());
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(!panelSurface.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> panelShellSurface(Test::createXdgToplevelSurface(panelSurface.data()));
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(!panelShellSurface.isNull());
|
|
|
|
QScopedPointer<PlasmaShellSurface> plasmaSurface(Test::waylandPlasmaShell()->createSurface(panelSurface.data()));
|
|
|
|
QVERIFY(!plasmaSurface.isNull());
|
|
|
|
plasmaSurface->setRole(PlasmaShellSurface::Role::Panel);
|
|
|
|
plasmaSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::AutoHide);
|
|
|
|
QFETCH(QRect, panelGeometry);
|
|
|
|
plasmaSurface->setPosition(panelGeometry.topLeft());
|
|
|
|
// let's render
|
|
|
|
auto panel = Test::renderAndWaitForShown(panelSurface.data(), panelGeometry.size(), Qt::blue);
|
|
|
|
QVERIFY(panel);
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(panel->frameGeometry(), panelGeometry);
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(panel->isDock());
|
|
|
|
|
|
|
|
// let's create a window
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
auto testWindow = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
|
|
|
|
|
|
|
QVERIFY(testWindow);
|
|
|
|
QVERIFY(testWindow->isMovable());
|
|
|
|
// panel is not yet hidden, we should snap against it
|
|
|
|
QFETCH(QPoint, targetPoint);
|
|
|
|
QTEST(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), "expectedAdjustedPoint");
|
|
|
|
|
|
|
|
// now let's hide the panel
|
|
|
|
QSignalSpy panelHiddenSpy(panel, &AbstractClient::windowHidden);
|
|
|
|
QVERIFY(panelHiddenSpy.isValid());
|
|
|
|
plasmaSurface->requestHideAutoHidingPanel();
|
|
|
|
QVERIFY(panelHiddenSpy.wait());
|
|
|
|
|
|
|
|
// now try to snap again
|
|
|
|
QCOMPARE(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), targetPoint);
|
|
|
|
|
|
|
|
// and destroy the panel again
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy panelClosedSpy(panel, &AbstractClient::windowClosed);
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(panelClosedSpy.isValid());
|
|
|
|
plasmaSurface.reset();
|
|
|
|
panelShellSurface.reset();
|
|
|
|
panelSurface.reset();
|
|
|
|
QVERIFY(panelClosedSpy.wait());
|
|
|
|
|
|
|
|
// snap once more
|
|
|
|
QCOMPARE(Workspace::self()->adjustClientPosition(testWindow, targetPoint, false), targetPoint);
|
|
|
|
|
|
|
|
// and close
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy windowClosedSpy(testWindow, &AbstractClient::windowClosed);
|
2016-11-02 10:51:01 +00:00
|
|
|
QVERIFY(windowClosedSpy.isValid());
|
|
|
|
shellSurface.reset();
|
|
|
|
surface.reset();
|
|
|
|
QVERIFY(windowClosedSpy.wait());
|
|
|
|
}
|
|
|
|
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
void MoveResizeWindowTest::testResizeForVirtualKeyboard()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
|
|
|
|
// let's render
|
|
|
|
auto client = Test::renderAndWaitForShown(surface.data(), QSize(500, 800), Qt::blue);
|
2019-09-12 17:18:14 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
|
|
|
|
// The client should receive a configure event upon becoming active.
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested);
|
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.isValid());
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.isValid());
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
2019-09-12 17:18:14 +00:00
|
|
|
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
client->move(QPoint(100, 300));
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 300, 500, 800));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
client->setVirtualKeyboardGeometry(QRect(0, 100, 1280, 500));
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
// render at the new size
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 0, 500, 101));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
client->setVirtualKeyboardGeometry(QRect());
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
// render at the new size
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 300, 500, 800));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testResizeForVirtualKeyboardWithMaximize()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
|
|
|
|
// let's render
|
|
|
|
auto client = Test::renderAndWaitForShown(surface.data(), QSize(500, 800), Qt::blue);
|
2019-09-12 17:18:14 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
|
|
|
|
// The client should receive a configure event upon becoming active.
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested);
|
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.isValid());
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.isValid());
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
2019-09-12 17:18:14 +00:00
|
|
|
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
client->move(QPoint(100, 300));
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 300, 500, 800));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
client->setVirtualKeyboardGeometry(QRect(0, 100, 1280, 500));
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
// render at the new size
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 0, 500, 101));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
client->setMaximize(true, true);
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
client->setVirtualKeyboardGeometry(QRect());
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(!surfaceConfigureRequestedSpy.wait(10));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
// render at the size of the configureRequested.. it won't have changed
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(!frameGeometryChangedSpy.wait(10));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
// Size will NOT be restored
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testResizeForVirtualKeyboardWithFullScreen()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
|
|
|
|
|
|
|
// let's render
|
|
|
|
auto client = Test::renderAndWaitForShown(surface.data(), QSize(500, 800), Qt::blue);
|
2019-09-12 17:18:14 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
|
|
|
|
// The client should receive a configure event upon becoming active.
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.data(), &Test::XdgToplevel::configureRequested);
|
|
|
|
QVERIFY(toplevelConfigureRequestedSpy.isValid());
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.isValid());
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
|
|
|
|
client->move(QPoint(100, 300));
|
2020-03-04 07:55:26 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(client, &AbstractClient::frameGeometryChanged);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.isValid());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 300, 500, 800));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
client->setVirtualKeyboardGeometry(QRect(0, 100, 1280, 500));
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
// render at the new size
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(100, 0, 500, 101));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
client->setFullScreen(true, true);
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last()[0].toInt());
|
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
client->setVirtualKeyboardGeometry(QRect());
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(!surfaceConfigureRequestedSpy.wait(10));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
|
|
|
|
// render at the size of the configureRequested.. it won't have changed
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().toSize(), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(!frameGeometryChangedSpy.wait(10));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
// Size will NOT be restored
|
2019-09-27 10:01:10 +00:00
|
|
|
QCOMPARE(client->frameGeometry(), QRect(0, 0, 1280, 1024));
|
virtualkeyboard: resize the focused window to make room for the keyboard
Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)
in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless
what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes
Test Plan: tested with test QML code
Reviewers: #plasma, #kwin, bshah, graesslin, romangg, davidedmundson
Reviewed By: #plasma, #kwin, romangg, davidedmundson
Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin
Tags: #kwin
Maniphest Tasks: T9815
Differential Revision: https://phabricator.kde.org/D18818
2019-03-20 10:04:51 +00:00
|
|
|
}
|
|
|
|
|
2019-03-12 09:35:17 +00:00
|
|
|
void MoveResizeWindowTest::testDestroyMoveClient()
|
|
|
|
{
|
|
|
|
// This test verifies that active move operation gets finished when
|
|
|
|
// the associated client is destroyed.
|
|
|
|
|
|
|
|
// Create the test client.
|
|
|
|
using namespace KWayland::Client;
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
2020-03-04 07:55:26 +00:00
|
|
|
AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
|
|
|
|
// Start moving the client.
|
|
|
|
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(clientStartMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(client->isInteractiveMove(), false);
|
|
|
|
QCOMPARE(client->isInteractiveResize(), false);
|
2019-03-12 09:35:17 +00:00
|
|
|
workspace()->slotWindowMove();
|
|
|
|
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), client);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(client->isInteractiveMove(), true);
|
|
|
|
QCOMPARE(client->isInteractiveResize(), false);
|
2019-03-12 09:35:17 +00:00
|
|
|
|
|
|
|
// Let's pretend that the client crashed.
|
|
|
|
shellSurface.reset();
|
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(client));
|
2021-05-14 05:32:49 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2019-03-12 09:35:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void MoveResizeWindowTest::testDestroyResizeClient()
|
|
|
|
{
|
|
|
|
// This test verifies that active resize operation gets finished when
|
|
|
|
// the associated client is destroyed.
|
|
|
|
|
|
|
|
// Create the test client.
|
|
|
|
using namespace KWayland::Client;
|
2021-09-03 17:54:03 +00:00
|
|
|
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(!surface.isNull());
|
2021-05-11 05:26:51 +00:00
|
|
|
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(!shellSurface.isNull());
|
2020-03-04 07:55:26 +00:00
|
|
|
AbstractClient *client = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
|
2019-03-12 09:35:17 +00:00
|
|
|
QVERIFY(client);
|
|
|
|
|
|
|
|
// Start resizing the client.
|
|
|
|
QSignalSpy clientStartMoveResizedSpy(client, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(clientStartMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(client, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(client->isInteractiveMove(), false);
|
|
|
|
QCOMPARE(client->isInteractiveResize(), false);
|
2019-03-12 09:35:17 +00:00
|
|
|
workspace()->slotWindowResize();
|
|
|
|
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), client);
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(client->isInteractiveMove(), false);
|
|
|
|
QCOMPARE(client->isInteractiveResize(), true);
|
2019-03-12 09:35:17 +00:00
|
|
|
|
|
|
|
// Let's pretend that the client crashed.
|
|
|
|
shellSurface.reset();
|
|
|
|
surface.reset();
|
|
|
|
QVERIFY(Test::waitForWindowDestroyed(client));
|
2021-05-14 05:32:49 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
2019-04-18 12:28:11 +00:00
|
|
|
QCOMPARE(workspace()->moveResizeClient(), nullptr);
|
2019-03-12 09:35:17 +00:00
|
|
|
}
|
|
|
|
|
2015-10-26 08:17:46 +00:00
|
|
|
}
|
|
|
|
|
2016-02-11 08:34:19 +00:00
|
|
|
WAYLANDTEST_MAIN(KWin::MoveResizeWindowTest)
|
2015-10-26 08:17:46 +00:00
|
|
|
#include "move_resize_window_test.moc"
|