yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/x11_window_test.cpp

1105 lines
47 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
#include "kwin_wayland_test.h"
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
#include "atoms.h"
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
#include "composite.h"
#include "cursor.h"
Introduce the concept of an internal window system independent id Summary: For supporting Wayland windows in the kwin_rules_dialog we need a way to pass a window id for Wayland windows to the dialog. This id needs to be sent to the dbus interface to query window information just like the interactive query. For Wayland windows we don't really have a window id and it would require to also pass the windowing system to kwin_rules_dialog and back through the dbus interface. To not complicate things this change introduces a windowing system independent id based on UUID. This could in future also be used internally for areas where it's window id based and used in both windowing systems. Test Plan: Adjusted test cases to verify the uuid is generated and passed to Deleted Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16986
2018-11-18 19:13:55 +00:00
#include "deleted.h"
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
#include "effectloader.h"
#include "effects.h"
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
#include "platform.h"
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
#include "screens.h"
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
#include "wayland_server.h"
#include "workspace.h"
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
#include "x11window.h"
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
#include <KWayland/Client/surface.h>
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
#include <netwm.h>
#include <xcb/xcb_icccm.h>
using namespace KWin;
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
using namespace KWayland::Client;
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
static const QString s_socketName = QStringLiteral("wayland_test_x11_window-0");
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
class X11WindowTest : public QObject
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
{
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
Q_OBJECT
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
private Q_SLOTS:
void initTestCase();
void init();
void cleanup();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
void testMinimumSize();
void testMaximumSize();
void testResizeIncrements();
void testResizeIncrementsNoBaseSize();
Fix captions with non-BMP characters KWin replaces any non-printable character with a space. This check does not handle surrogate pairs correctly. Additionally, translators sometimes insert non-printable soft-hyphens into titles, which also cause KWin to display a space instead. This code adds the missing surrogate handling, and (to fix both issues), also removes non-printable characters instead of replacing them with a space. Also moved the changed test after these changes, so that changes in non- printable characters do not cause unneeded redraws. Unit tests adapted by Vlad Zagorodniy. Test Plan: kwrite /tmp/Test😣.txt shows correct title. I also tested actual non-printable characters, such as 0x1A, and these are correctly omitted. BUG: 376813 FIXED-IN: 5.15.5 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, grasslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19052
2019-04-26 08:52:57 +00:00
void testTrimCaption_data();
void testTrimCaption();
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
void testFullscreenLayerWithActiveWaylandWindow();
Reset last_active_client when a ShellClient is removed Summary: The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager Test Plan: test case no longer crashes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6852
2017-07-23 14:18:09 +00:00
void testFocusInWithWaylandLastActiveWindow();
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
void testX11WindowId();
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
void testCaptionChanges();
Use xcb-icccm to read the name property Summary: The KWindowSystem call which we used doesn't work on Wayland as it's only implemented in the xcb variant and cannot be made available for Wayland in an easy way as it is still XLib based. This change turns the optional XCB-ICCCM dependency in a required one and thus can use the functionality provided by said library to implement what KWindowSystem provided. BUG: 382789 Test Plan: New test case which failed with old code Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7046
2017-08-01 19:28:36 +00:00
void testCaptionWmName();
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
void testCaptionMultipleWindows();
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
void testFullscreenWindowGroups();
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
void testActivateFocusedWindow();
Rework async geometry updates Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
void testReentrantMoveResize();
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
};
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::initTestCase()
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
{
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
qRegisterMetaType<KWin::Deleted *>();
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
qRegisterMetaType<KWin::Window *>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
QVERIFY(applicationStartedSpy.isValid());
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
Avoid converting socket name between QString and QByteArray back and forth It only contributes overhead.
2020-12-09 13:06:15 +00:00
QVERIFY(waylandServer()->init(s_socketName));
Reset last_active_client when a ShellClient is removed Summary: The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager Test Plan: test case no longer crashes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6852
2017-07-23 14:18:09 +00:00
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
QVERIFY(KWin::Compositor::self());
Ensure we start our tests with wayland already initialised When debugging modifier_only_shortcut_test in _waylandonly mode I saw that it was failing, among other things, because some aspects were not initialised. This changes every test we have to run the new Test::initWaylandWorkspace() that calls waylandServer()->initWorkspace() but also makes sure that WaylandServer::initialized is emitted before we proceed.
2021-05-08 00:08:22 +00:00
Test::initWaylandWorkspace();
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::init()
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
{
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
QVERIFY(Test::setupWaylandConnection());
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::cleanup()
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
{
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
Test::destroyWaylandConnection();
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
}
struct XcbConnectionDeleter
{
static inline void cleanup(xcb_connection_t *pointer)
{
xcb_disconnect(pointer);
}
};
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testMinimumSize()
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
{
// This test verifies that the minimum size constraint is correctly applied.
// Create an xcb window.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_min_size(&hints, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.last().first().value<X11Window *>();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(client);
QVERIFY(client->isDecorated());
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
QSignalSpy clientStartMoveResizedSpy(client, &Window::clientStartUserMovedResized);
QSignalSpy clientStepUserMovedResizedSpy(client, &Window::clientStepUserMovedResized);
QSignalSpy clientFinishUserMovedResizedSpy(client, &Window::clientFinishUserMovedResized);
QSignalSpy frameGeometryChangedSpy(client, &Window::frameGeometryChanged);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Begin resize.
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
workspace()->slotWindowResize();
QCOMPARE(workspace()->moveResizeClient(), client);
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
client->keyPressEvent(Qt::Key_Left);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().width(), 100);
client->keyPressEvent(Qt::Key_Right);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().width(), 100);
client->keyPressEvent(Qt::Key_Right);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().width(), 108);
client->keyPressEvent(Qt::Key_Up);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, -8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 200);
client->keyPressEvent(Qt::Key_Down);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 200);
client->keyPressEvent(Qt::Key_Down);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 208);
// Finish the resize operation.
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
client->keyPressEvent(Qt::Key_Enter);
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Destroy the window.
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(windowClosedSpy.isValid());
xcb_unmap_window(c.data(), w);
xcb_destroy_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(windowClosedSpy.wait());
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testMaximumSize()
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
{
// This test verifies that the maximum size constraint is correctly applied.
// Create an xcb window.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_max_size(&hints, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.last().first().value<X11Window *>();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(client);
QVERIFY(client->isDecorated());
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
QSignalSpy clientStartMoveResizedSpy(client, &Window::clientStartUserMovedResized);
QSignalSpy clientStepUserMovedResizedSpy(client, &Window::clientStepUserMovedResized);
QSignalSpy clientFinishUserMovedResizedSpy(client, &Window::clientFinishUserMovedResized);
QSignalSpy frameGeometryChangedSpy(client, &Window::frameGeometryChanged);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Begin resize.
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
workspace()->slotWindowResize();
QCOMPARE(workspace()->moveResizeClient(), client);
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
client->keyPressEvent(Qt::Key_Right);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().width(), 100);
client->keyPressEvent(Qt::Key_Left);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(!clientStepUserMovedResizedSpy.wait(1000));
QCOMPARE(clientStepUserMovedResizedSpy.count(), 0);
QCOMPARE(client->clientSize().width(), 100);
client->keyPressEvent(Qt::Key_Left);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().width(), 92);
client->keyPressEvent(Qt::Key_Down);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 200);
client->keyPressEvent(Qt::Key_Up);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(!frameGeometryChangedSpy.wait(1000));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 200);
client->keyPressEvent(Qt::Key_Up);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(-8, -8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize().height(), 192);
// Finish the resize operation.
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
client->keyPressEvent(Qt::Key_Enter);
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Destroy the window.
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(windowClosedSpy.isValid());
xcb_unmap_window(c.data(), w);
xcb_destroy_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(windowClosedSpy.wait());
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testResizeIncrements()
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
{
// This test verifies that the resize increments constraint is correctly applied.
// Create an xcb window.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_base_size(&hints, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_resize_inc(&hints, 3, 5);
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.last().first().value<X11Window *>();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(client);
QVERIFY(client->isDecorated());
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
QSignalSpy clientStartMoveResizedSpy(client, &Window::clientStartUserMovedResized);
QSignalSpy clientStepUserMovedResizedSpy(client, &Window::clientStepUserMovedResized);
QSignalSpy clientFinishUserMovedResizedSpy(client, &Window::clientFinishUserMovedResized);
QSignalSpy frameGeometryChangedSpy(client, &Window::frameGeometryChanged);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Begin resize.
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
workspace()->slotWindowResize();
QCOMPARE(workspace()->moveResizeClient(), client);
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
client->keyPressEvent(Qt::Key_Right);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize(), QSize(106, 200));
client->keyPressEvent(Qt::Key_Down);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize(), QSize(106, 205));
// Finish the resize operation.
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
client->keyPressEvent(Qt::Key_Enter);
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Destroy the window.
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(windowClosedSpy.isValid());
xcb_unmap_window(c.data(), w);
xcb_destroy_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(windowClosedSpy.wait());
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testResizeIncrementsNoBaseSize()
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
{
// Create an xcb window.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_min_size(&hints, windowGeometry.width(), windowGeometry.height());
xcb_icccm_size_hints_set_resize_inc(&hints, 3, 5);
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.last().first().value<X11Window *>();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(client);
QVERIFY(client->isDecorated());
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
QSignalSpy clientStartMoveResizedSpy(client, &Window::clientStartUserMovedResized);
QSignalSpy clientStepUserMovedResizedSpy(client, &Window::clientStepUserMovedResized);
QSignalSpy clientFinishUserMovedResizedSpy(client, &Window::clientFinishUserMovedResized);
QSignalSpy frameGeometryChangedSpy(client, &Window::frameGeometryChanged);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Begin resize.
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
workspace()->slotWindowResize();
QCOMPARE(workspace()->moveResizeClient(), client);
QCOMPARE(clientStartMoveResizedSpy.count(), 1);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
const QPoint cursorPos = KWin::Cursors::self()->mouse()->pos();
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
client->keyPressEvent(Qt::Key_Right);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 0));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 1);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize(), QSize(106, 200));
client->keyPressEvent(Qt::Key_Down);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
client->updateInteractiveMoveResize(KWin::Cursors::self()->mouse()->pos());
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
QCOMPARE(KWin::Cursors::self()->mouse()->pos(), cursorPos + QPoint(8, 8));
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(clientStepUserMovedResizedSpy.count(), 2);
Lock clientStepUserMovedResized to move resize geometry changes On Wayland, the move resize geometry and the frame geometry are completely out of sync. This change synchronizes emitting of the clientStepUserMovedResized signal to the move resize geometry changes. It simplifies code of InternalClient and XdgSurfaceClient, and makes adding support for other shell surface protocols easier as there's less boilerplate stuff that you would need to take care of.
2021-12-24 09:20:00 +00:00
QVERIFY(frameGeometryChangedSpy.wait());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QCOMPARE(client->clientSize(), QSize(106, 205));
// Finish the resize operation.
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 0);
client->keyPressEvent(Qt::Key_Enter);
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
QCOMPARE(workspace()->moveResizeClient(), nullptr);
Prepend "Interactive" to interactive move resize methods This is to improve code readability and make it easier to differentiate between methods that are used during interactive move-resize and normal move-resize methods in the future.
2021-04-30 18:06:58 +00:00
QVERIFY(!client->isInteractiveResize());
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
// Destroy the window.
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotests] Add tests for PMinSize, PMaxSize, and PResizeInc geometry hints Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27400
2020-02-14 11:59:58 +00:00
QVERIFY(windowClosedSpy.isValid());
xcb_unmap_window(c.data(), w);
xcb_destroy_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(windowClosedSpy.wait());
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testTrimCaption_data()
Fix captions with non-BMP characters KWin replaces any non-printable character with a space. This check does not handle surrogate pairs correctly. Additionally, translators sometimes insert non-printable soft-hyphens into titles, which also cause KWin to display a space instead. This code adds the missing surrogate handling, and (to fix both issues), also removes non-printable characters instead of replacing them with a space. Also moved the changed test after these changes, so that changes in non- printable characters do not cause unneeded redraws. Unit tests adapted by Vlad Zagorodniy. Test Plan: kwrite /tmp/Test😣.txt shows correct title. I also tested actual non-printable characters, such as 0x1A, and these are correctly omitted. BUG: 376813 FIXED-IN: 5.15.5 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, grasslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19052
2019-04-26 08:52:57 +00:00
{
QTest::addColumn<QByteArray>("originalTitle");
QTest::addColumn<QByteArray>("expectedTitle");
QTest::newRow("simplified")
<< QByteArrayLiteral("Was tun, wenn Schüler Autismus haben?\342\200\250\342\200\250\342\200\250 – Marlies Hübner - Mozilla Firefox")
<< QByteArrayLiteral("Was tun, wenn Schüler Autismus haben? – Marlies Hübner - Mozilla Firefox");
QTest::newRow("with emojis")
<< QByteArrayLiteral("\bTesting non\302\255printable:\177, emoij:\360\237\230\203, non-characters:\357\277\276")
<< QByteArrayLiteral("Testing nonprintable:, emoij:\360\237\230\203, non-characters:");
}
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testTrimCaption()
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
{
// this test verifies that caption is properly trimmed
// create an xcb window
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
NETWinInfo winInfo(c.data(), w, rootWindow(), NET::Properties(), NET::Properties2());
Fix captions with non-BMP characters KWin replaces any non-printable character with a space. This check does not handle surrogate pairs correctly. Additionally, translators sometimes insert non-printable soft-hyphens into titles, which also cause KWin to display a space instead. This code adds the missing surrogate handling, and (to fix both issues), also removes non-printable characters instead of replacing them with a space. Also moved the changed test after these changes, so that changes in non- printable characters do not cause unneeded redraws. Unit tests adapted by Vlad Zagorodniy. Test Plan: kwrite /tmp/Test😣.txt shows correct title. I also tested actual non-printable characters, such as 0x1A, and these are correctly omitted. BUG: 376813 FIXED-IN: 5.15.5 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, grasslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19052
2019-04-26 08:52:57 +00:00
QFETCH(QByteArray, originalTitle);
winInfo.setName(originalTitle);
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
xcb_map_window(c.data(), w);
xcb_flush(c.data());
// we should get a client for it
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
QVERIFY(client);
QCOMPARE(client->window(), w);
Fix captions with non-BMP characters KWin replaces any non-printable character with a space. This check does not handle surrogate pairs correctly. Additionally, translators sometimes insert non-printable soft-hyphens into titles, which also cause KWin to display a space instead. This code adds the missing surrogate handling, and (to fix both issues), also removes non-printable characters instead of replacing them with a space. Also moved the changed test after these changes, so that changes in non- printable characters do not cause unneeded redraws. Unit tests adapted by Vlad Zagorodniy. Test Plan: kwrite /tmp/Test😣.txt shows correct title. I also tested actual non-printable characters, such as 0x1A, and these are correctly omitted. BUG: 376813 FIXED-IN: 5.15.5 Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: zzag, grasslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19052
2019-04-26 08:52:57 +00:00
QFETCH(QByteArray, expectedTitle);
QCOMPARE(client->caption(), QString::fromUtf8(expectedTitle));
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
// and destroy the window again
xcb_unmap_window(c.data(), w);
xcb_flush(c.data());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotest] Add test case for window caption need to be simplified The test illustrates that special characters like a line break are not removed from the window caption, which results in a line break added in the window decoration. Test case uses a title from a web page triggering it in Firefox. CCBUG: 323798
2016-10-31 14:50:14 +00:00
QVERIFY(windowClosedSpy.isValid());
QVERIFY(windowClosedSpy.wait());
xcb_destroy_window(c.data(), w);
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testFullscreenLayerWithActiveWaylandWindow()
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
{
// this test verifies that an X11 fullscreen window does not stay in the active layer
// when a Wayland window is active, see BUG: 375759
QCOMPARE(screens()->count(), 1);
// first create an X11 window
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
// we should get a client for it
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
QVERIFY(client);
QCOMPARE(client->window(), w);
QVERIFY(!client->isFullScreen());
QVERIFY(client->isActive());
QCOMPARE(client->layer(), NormalLayer);
workspace()->slotWindowFullScreen();
QVERIFY(client->isFullScreen());
QCOMPARE(client->layer(), ActiveLayer);
QCOMPARE(workspace()->stackingOrder().last(), client);
// now let's open a Wayland window
autotests: Prepend KWayland::Client:: to Surface With a "Surface" type in kwin, KWayland::Client::Surface without fully specified namespace will conflict with kwin's Surface type. In some way, it also improves readability as it's clear where Surface comes from.
2021-09-03 17:54:03 +00:00
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
autotests: Port the tests to new xdg-shell helpers
2021-05-11 05:26:51 +00:00
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
QVERIFY(waylandClient);
QVERIFY(waylandClient->isActive());
QCOMPARE(waylandClient->layer(), NormalLayer);
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
QCOMPARE(client->layer(), NormalLayer);
// now activate fullscreen again
workspace()->activateClient(client);
QTRY_VERIFY(client->isActive());
QCOMPARE(client->layer(), ActiveLayer);
QCOMPARE(workspace()->stackingOrder().last(), client);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), client);
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
// activate wayland window again
workspace()->activateClient(waylandClient);
QTRY_VERIFY(waylandClient->isActive());
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
[autotests] Extend X11ClientTest::testFullscreenLayerWithActiveWaylandWindow Unfortunately still doesn't trigger the actual bug.
2017-07-23 18:02:57 +00:00
// back to x window
workspace()->activateClient(client);
QTRY_VERIFY(client->isActive());
// remove fullscreen
QVERIFY(client->isFullScreen());
workspace()->slotWindowFullScreen();
QVERIFY(!client->isFullScreen());
// and fullscreen again
workspace()->slotWindowFullScreen();
QVERIFY(client->isFullScreen());
QCOMPARE(workspace()->stackingOrder().last(), client);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), client);
[autotests] Extend X11ClientTest::testFullscreenLayerWithActiveWaylandWindow Unfortunately still doesn't trigger the actual bug.
2017-07-23 18:02:57 +00:00
// activate wayland window again
workspace()->activateClient(waylandClient);
QTRY_VERIFY(waylandClient->isActive());
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
[autotests] Extend X11ClientTest::testFullscreenLayerWithActiveWaylandWindow Unfortunately still doesn't trigger the actual bug.
2017-07-23 18:02:57 +00:00
// back to X11 window
workspace()->activateClient(client);
QTRY_VERIFY(client->isActive());
// remove fullscreen
QVERIFY(client->isFullScreen());
workspace()->slotWindowFullScreen();
QVERIFY(!client->isFullScreen());
// and fullscreen through X API
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
info.setState(NET::FullScreen, NET::FullScreen);
NETRootInfo rootInfo(c.data(), NET::Properties());
rootInfo.setActiveWindow(w, NET::FromApplication, XCB_CURRENT_TIME, XCB_WINDOW_NONE);
xcb_flush(c.data());
QTRY_VERIFY(client->isFullScreen());
QCOMPARE(workspace()->stackingOrder().last(), client);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), client);
[autotests] Extend X11ClientTest::testFullscreenLayerWithActiveWaylandWindow Unfortunately still doesn't trigger the actual bug.
2017-07-23 18:02:57 +00:00
// activate wayland window again
workspace()->activateClient(waylandClient);
QTRY_VERIFY(waylandClient->isActive());
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
autotests: Prefer stackingOrder() over xStackingOrder() This reduces the number of usages of xStackingOrder(), which simplifies the reasoning about when it can be marked as dirty. Since internal windows are now in the regular stack, InternalWindowTest can use stackingOrder(). As for X11ClientTest, there's no specific reason why it uses the x stack instead of the regular one.
2021-05-12 18:07:08 +00:00
QCOMPARE(workspace()->stackingOrder().last(), waylandClient);
[autotests] Extend X11ClientTest::testFullscreenLayerWithActiveWaylandWindow Unfortunately still doesn't trigger the actual bug.
2017-07-23 18:02:57 +00:00
QCOMPARE(client->layer(), NormalLayer);
[autotest] Add a test case for X11 fullscreen windows when an Wayland window is there KWin cannot handle the layering correctly when a Wayland window is active and there is a fullscreen X11 window. This test tries to simulate the situation, but it does not show it. Nevertheless it's a good test, so let's add it. CCBUG: 375759
2017-07-23 09:50:58 +00:00
// close the window
shellSurface.reset();
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
QTRY_VERIFY(client->isActive());
QCOMPARE(client->layer(), ActiveLayer);
// and destroy the window again
xcb_unmap_window(c.data(), w);
xcb_flush(c.data());
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testFocusInWithWaylandLastActiveWindow()
Reset last_active_client when a ShellClient is removed Summary: The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager Test Plan: test case no longer crashes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6852
2017-07-23 14:18:09 +00:00
{
// this test verifies that Workspace::allowClientActivation does not crash if last client was a Wayland client
// create an X11 window
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
// we should get a client for it
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
Reset last_active_client when a ShellClient is removed Summary: The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager Test Plan: test case no longer crashes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6852
2017-07-23 14:18:09 +00:00
QVERIFY(client);
QCOMPARE(client->window(), w);
QVERIFY(client->isActive());
// create Wayland window
autotests: Prepend KWayland::Client:: to Surface With a "Surface" type in kwin, KWayland::Client::Surface without fully specified namespace will conflict with kwin's Surface type. In some way, it also improves readability as it's clear where Surface comes from.
2021-09-03 17:54:03 +00:00
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
autotests: Port the tests to new xdg-shell helpers
2021-05-11 05:26:51 +00:00
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
Reset last_active_client when a ShellClient is removed Summary: The last_active_client is set when an AbstractClient gets activated. For the X11 case the last_active_client was getting reset to nullptr when the last_active_client gets destroyed. But for the ShellClient that did not yet happen. This could result in a crash. This change addresses the problem and adds a test case which triggered the crash. The condition of the crash are difficult to generate though - it took me about an hour to write the test for the crash. 1. Wayland client must be active 2. Explicit focus to null (no active client) 3. destroy Wayland window 4. X11 client which sets focus on itself without interaction with window manager Test Plan: test case no longer crashes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6852
2017-07-23 14:18:09 +00:00
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
QVERIFY(waylandClient);
QVERIFY(waylandClient->isActive());
// activate no window
workspace()->setActiveClient(nullptr);
QVERIFY(!waylandClient->isActive());
QVERIFY(!workspace()->activeClient());
// and close Wayland window again
shellSurface.reset();
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
// and try to activate the x11 client through X11 api
const auto cookie = xcb_set_input_focus_checked(c.data(), XCB_INPUT_FOCUS_NONE, w, XCB_CURRENT_TIME);
auto error = xcb_request_check(c.data(), cookie);
QVERIFY(!error);
// this accesses last_active_client on trying to activate
QTRY_VERIFY(client->isActive());
// and destroy the window again
xcb_unmap_window(c.data(), w);
xcb_flush(c.data());
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testX11WindowId()
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
{
// create an X11 window
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
// we should get a client for it
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
QVERIFY(client);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client->window(), w);
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
QVERIFY(client->isActive());
QCOMPARE(client->window(), w);
Introduce the concept of an internal window system independent id Summary: For supporting Wayland windows in the kwin_rules_dialog we need a way to pass a window id for Wayland windows to the dialog. This id needs to be sent to the dbus interface to query window information just like the interactive query. For Wayland windows we don't really have a window id and it would require to also pass the windowing system to kwin_rules_dialog and back through the dbus interface. To not complicate things this change introduces a windowing system independent id based on UUID. This could in future also be used internally for areas where it's window id based and used in both windowing systems. Test Plan: Adjusted test cases to verify the uuid is generated and passed to Deleted Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16986
2018-11-18 19:13:55 +00:00
QCOMPARE(client->internalId().isNull(), false);
const auto uuid = client->internalId();
QUuid deletedUuid;
QCOMPARE(deletedUuid.isNull(), true);
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
connect(client, &X11Window::windowClosed, this, [&deletedUuid](Window *, Deleted *d) {
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
deletedUuid = d->internalId();
});
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
NETRootInfo rootInfo(c.data(), NET::WMAllProperties);
QCOMPARE(rootInfo.activeWindow(), client->window());
// activate a wayland window
autotests: Prepend KWayland::Client:: to Surface With a "Surface" type in kwin, KWayland::Client::Surface without fully specified namespace will conflict with kwin's Surface type. In some way, it also improves readability as it's clear where Surface comes from.
2021-09-03 17:54:03 +00:00
QScopedPointer<KWayland::Client::Surface> surface(Test::createSurface());
autotests: Port the tests to new xdg-shell helpers
2021-05-11 05:26:51 +00:00
QScopedPointer<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.data()));
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
auto waylandClient = Test::renderAndWaitForShown(surface.data(), QSize(100, 50), Qt::blue);
QVERIFY(waylandClient);
QVERIFY(waylandClient->isActive());
xcb_flush(kwinApp()->x11Connection());
NETRootInfo rootInfo2(c.data(), NET::WMAllProperties);
QCOMPARE(rootInfo2.activeWindow(), 0u);
// back to X11 client
shellSurface.reset();
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(waylandClient));
QTRY_VERIFY(client->isActive());
NETRootInfo rootInfo3(c.data(), NET::WMAllProperties);
QCOMPARE(rootInfo3.activeWindow(), client->window());
// and destroy the window again
xcb_unmap_window(c.data(), w);
xcb_flush(c.data());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
Introduce the concept of an internal window system independent id Summary: For supporting Wayland windows in the kwin_rules_dialog we need a way to pass a window id for Wayland windows to the dialog. This id needs to be sent to the dbus interface to query window information just like the interactive query. For Wayland windows we don't really have a window id and it would require to also pass the windowing system to kwin_rules_dialog and back through the dbus interface. To not complicate things this change introduces a windowing system independent id based on UUID. This could in future also be used internally for areas where it's window id based and used in both windowing systems. Test Plan: Adjusted test cases to verify the uuid is generated and passed to Deleted Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16986
2018-11-18 19:13:55 +00:00
QVERIFY(windowClosedSpy.isValid());
QVERIFY(windowClosedSpy.wait());
QCOMPARE(deletedUuid.isNull(), false);
QCOMPARE(deletedUuid, uuid);
[autotests] Add test cases for verifying that Toplevel::window() is only set for X11 Also at the same time verifies that root info active client is only set on X11.
2017-07-26 05:08:27 +00:00
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testCaptionChanges()
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
{
// verifies that caption is updated correctly when the X11 window updates it
// BUG: 383444
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
info.setName("foo");
xcb_map_window(c.data(), w);
xcb_flush(c.data());
// we should get a client for it
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
QVERIFY(client);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client->window(), w);
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
QCOMPARE(client->caption(), QStringLiteral("foo"));
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy captionChangedSpy(client, &X11Window::captionChanged);
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
QVERIFY(captionChangedSpy.isValid());
info.setName("bar");
xcb_flush(c.data());
QVERIFY(captionChangedSpy.wait());
QCOMPARE(client->caption(), QStringLiteral("bar"));
// and destroy the window again
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy windowClosedSpy(client, &X11Window::windowClosed);
[autotests] Add test case for updating X11 client captions CCBUG: 383444
2017-08-13 14:52:14 +00:00
QVERIFY(windowClosedSpy.isValid());
xcb_unmap_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(windowClosedSpy.wait());
xcb_destroy_window(c.data(), w);
c.reset();
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testCaptionWmName()
Use xcb-icccm to read the name property Summary: The KWindowSystem call which we used doesn't work on Wayland as it's only implemented in the xcb variant and cannot be made available for Wayland in an easy way as it is still XLib based. This change turns the optional XCB-ICCCM dependency in a required one and thus can use the functionality provided by said library to implement what KWindowSystem provided. BUG: 382789 Test Plan: New test case which failed with old code Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7046
2017-08-01 19:28:36 +00:00
{
// this test verifies that a caption set through WM_NAME is read correctly
// open glxgears as that one only uses WM_NAME
QSignalSpy clientAddedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(clientAddedSpy.isValid());
QProcess glxgears;
Port some tests away from a deprecated QProcess::start() overload
2020-09-10 07:15:31 +00:00
glxgears.setProgram(QStringLiteral("glxgears"));
glxgears.start();
Use xcb-icccm to read the name property Summary: The KWindowSystem call which we used doesn't work on Wayland as it's only implemented in the xcb variant and cannot be made available for Wayland in an easy way as it is still XLib based. This change turns the optional XCB-ICCCM dependency in a required one and thus can use the functionality provided by said library to implement what KWindowSystem provided. BUG: 382789 Test Plan: New test case which failed with old code Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7046
2017-08-01 19:28:36 +00:00
QVERIFY(glxgears.waitForStarted());
QVERIFY(clientAddedSpy.wait());
QCOMPARE(clientAddedSpy.count(), 1);
QCOMPARE(workspace()->clientList().count(), 1);
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *glxgearsClient = workspace()->clientList().first();
Use xcb-icccm to read the name property Summary: The KWindowSystem call which we used doesn't work on Wayland as it's only implemented in the xcb variant and cannot be made available for Wayland in an easy way as it is still XLib based. This change turns the optional XCB-ICCCM dependency in a required one and thus can use the functionality provided by said library to implement what KWindowSystem provided. BUG: 382789 Test Plan: New test case which failed with old code Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7046
2017-08-01 19:28:36 +00:00
QCOMPARE(glxgearsClient->caption(), QStringLiteral("glxgears"));
glxgears.terminate();
QVERIFY(glxgears.waitForFinished());
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testCaptionMultipleWindows()
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
{
// BUG 384760
// create first window
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
NETWinInfo info(c.data(), w, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
info.setName("foo");
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
QVERIFY(client);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client->window(), w);
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
QCOMPARE(client->caption(), QStringLiteral("foo"));
// create second window with same caption
xcb_window_t w2 = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w2, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_icccm_set_wm_normal_hints(c.data(), w2, &hints);
NETWinInfo info2(c.data(), w2, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
info2.setName("foo");
info2.setIconName("foo");
xcb_map_window(c.data(), w2);
xcb_flush(c.data());
windowCreatedSpy.clear();
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client2 = windowCreatedSpy.first().first().value<X11Window *>();
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
QVERIFY(client2);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client2->window(), w2);
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
QCOMPARE(client2->caption(), QStringLiteral("foo <2>\u200E"));
NETWinInfo info3(kwinApp()->x11Connection(), w2, kwinApp()->x11RootWindow(), NET::WMVisibleName | NET::WMVisibleIconName, NET::Properties2());
QCOMPARE(QByteArray(info3.visibleName()), QByteArrayLiteral("foo <2>\u200E"));
QCOMPARE(QByteArray(info3.visibleIconName()), QByteArrayLiteral("foo <2>\u200E"));
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
QSignalSpy captionChangedSpy(client2, &X11Window::captionChanged);
Properly update the visible (icon) name when the caption changes Summary: It was possible that we performed an early exit when the caption changes and this results in the visible name being wrong. E.g if we have two windows called foo, the second one has the visible name "foo <2>". After changing that to "bar" the bug resulted in it still being the foo variant instead of getting cleared. BUG: 384760 FIXED-IN: 5.11.0 Test Plan: Created new test case exposing the problem Reviewers: #kwin, #plasma, hein Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7871
2017-09-18 16:37:45 +00:00
QVERIFY(captionChangedSpy.isValid());
NETWinInfo info4(c.data(), w2, kwinApp()->x11RootWindow(), NET::Properties(), NET::Properties2());
info4.setName("foobar");
info4.setIconName("foobar");
xcb_map_window(c.data(), w2);
xcb_flush(c.data());
QVERIFY(captionChangedSpy.wait());
QCOMPARE(client2->caption(), QStringLiteral("foobar"));
NETWinInfo info5(kwinApp()->x11Connection(), w2, kwinApp()->x11RootWindow(), NET::WMVisibleName | NET::WMVisibleIconName, NET::Properties2());
QCOMPARE(QByteArray(info5.visibleName()), QByteArray());
QTRY_COMPARE(QByteArray(info5.visibleIconName()), QByteArray());
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testFullscreenWindowGroups()
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
{
// this test creates an X11 window and puts it to full screen
// then a second window is created which is in the same window group
// BUG: 388310
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
QVERIFY(client);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client->window(), w);
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
QCOMPARE(client->isActive(), true);
QCOMPARE(client->isFullScreen(), false);
QCOMPARE(client->layer(), NormalLayer);
workspace()->slotWindowFullScreen();
QCOMPARE(client->isFullScreen(), true);
QCOMPARE(client->layer(), ActiveLayer);
// now let's create a second window
windowCreatedSpy.clear();
xcb_window_t w2 = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w2, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints2;
memset(&hints2, 0, sizeof(hints2));
xcb_icccm_size_hints_set_position(&hints2, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints2, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w2, &hints2);
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w2, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
xcb_map_window(c.data(), w2);
xcb_flush(c.data());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client2 = windowCreatedSpy.first().first().value<X11Window *>();
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
QVERIFY(client2);
QVERIFY(client != client2);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client2->window(), w2);
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
QCOMPARE(client2->isActive(), true);
QCOMPARE(client2->group(), client->group());
// first client should be moved back to normal layer
QCOMPARE(client->isActive(), false);
QCOMPARE(client->isFullScreen(), true);
QCOMPARE(client->layer(), NormalLayer);
Keep fullscreen windows in active layer based on transients not the group Summary: So far a not-active fullscreen X11 window was kept in the active layer if the newly activated window is in the same group (that is same client leader). For example a fullscreen X11 kwrite window is in the active layer if another kwrite window is active. The two kwrite windows obviously don't have anything to do with each other, but are in the same group. This creates problems as it's not possible to raise other windows above the active not-fullscreen kwrite window. E.g. the panel is stacked below. The idea behind the check makes sense: if a fullscreen window opens another window (e.g. a configuration dialog) it should not be put back to normal layer. Thus the check is adjusted whether the new active window is a transient to the fullscreen window. Thus the intention is still the same, but does not cause the problems. As the code now does not need to differentiate between X11 and Wayland windows (group only on X11) the Client specific implementation is removed and the method unvirtual'ed. BUG: 388310 FIXED-IN: 5.12.0 Test Plan: Test passes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D9699
2018-01-06 10:24:31 +00:00
// activating the fullscreen window again, should move it to active layer
workspace()->activateClient(client);
QTRY_COMPARE(client->layer(), ActiveLayer);
[autotests] Add test case for fullscreen window with groups When an X11 window is raised to fullscreen it gets set to active layer. When another window gets activated then it goes back to normal layer. But when a window of the same group gets activated the fullscreen window stays in the active layer. Due to that it is not possible to raise other windows above the fullscreen window. This just adds a test case exposing the problematic area. CCBUG: 388310
2018-01-06 09:45:44 +00:00
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testActivateFocusedWindow()
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
{
// The window manager may call XSetInputFocus() on a window that already has focus, in which
// case no FocusIn event will be generated and the window won't be marked as active. This test
// verifies that we handle that subtle case properly.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> connection(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(connection.data()));
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
const QRect windowGeometry(0, 0, 100, 200);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
// Create the first test window.
const xcb_window_t window1 = xcb_generate_id(connection.data());
xcb_create_window(connection.data(), XCB_COPY_FROM_PARENT, window1, rootWindow(),
windowGeometry.x(), windowGeometry.y(),
windowGeometry.width(), windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_icccm_set_wm_normal_hints(connection.data(), window1, &hints);
xcb_change_property(connection.data(), XCB_PROP_MODE_REPLACE, window1,
atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &window1);
xcb_map_window(connection.data(), window1);
xcb_flush(connection.data());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client1 = windowCreatedSpy.first().first().value<X11Window *>();
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
QVERIFY(client1);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client1->window(), window1);
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
QCOMPARE(client1->isActive(), true);
// Create the second test window.
const xcb_window_t window2 = xcb_generate_id(connection.data());
xcb_create_window(connection.data(), XCB_COPY_FROM_PARENT, window2, rootWindow(),
windowGeometry.x(), windowGeometry.y(),
windowGeometry.width(), windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_icccm_set_wm_normal_hints(connection.data(), window2, &hints);
xcb_change_property(connection.data(), XCB_PROP_MODE_REPLACE, window2,
atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &window2);
xcb_map_window(connection.data(), window2);
xcb_flush(connection.data());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client2 = windowCreatedSpy.last().first().value<X11Window *>();
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
QVERIFY(client2);
Drop Toplevel::windowId() A window id generated by WaylandServer may reference an X11 window with the same id, which can result in undefined behavior. The main reason why we needed windowId() was because of the task switcher. However, since tabbox uses internal ids now, the window id property can be dropped.
2020-11-04 15:49:10 +00:00
QCOMPARE(client2->window(), window2);
[x11] Force FocusIn events for already focused windows Depending on the current focus stealing prevention level, it's possible for kwin to call XSetInputFocus() on a window that already has the input focus. In which case, we won't receive the corresponding FocusIn event and the client will remain inactive from kwin's perspective even though it isn't. In order to work around this issue, we can move the input focus to the null window. By doing so, it's guaranteed that we're going to receive the matching FocusIn event for the client. This commit indirectly fixes a bug where fullscreen games are displayed below panels.
2020-06-16 08:03:25 +00:00
QCOMPARE(client2->isActive(), true);
// When the second test window is destroyed, the window manager will attempt to activate the
// next client in the focus chain, which is the first window.
xcb_set_input_focus(connection.data(), XCB_INPUT_FOCUS_POINTER_ROOT, window1, XCB_CURRENT_TIME);
xcb_destroy_window(connection.data(), window2);
xcb_flush(connection.data());
QVERIFY(Test::waitForWindowDestroyed(client2));
QVERIFY(client1->isActive());
// Destroy the first test window.
xcb_destroy_window(connection.data(), window1);
xcb_flush(connection.data());
QVERIFY(Test::waitForWindowDestroyed(client1));
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
void X11WindowTest::testReentrantMoveResize()
Make setFrameGeometry() re-entrant for X and internal clients If AbstractClient::setFrameGeometry() is called from a slot connected directly to the frameGeometryChanged() signal, then is there a good chance that kwin will fall into an infinite recursion. However, that's the case with only X11 and internal clients. The root cause of the infinite recursion is that both X11Client and InternalClient compare the new geometry against the geometry before update blocking. In order to fix the bug, we simply need to ensure that updateGeometryBeforeUpdateBlocking() has been called before we start emitting the frameGeometryChanged() signal. Furthermore, a couple of tests were added to ensure that we won't hit this subtle bug again.
2020-07-20 19:33:19 +00:00
{
Rework async geometry updates Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
// This test verifies that calling moveResize() from a slot connected directly
Make setFrameGeometry() re-entrant for X and internal clients If AbstractClient::setFrameGeometry() is called from a slot connected directly to the frameGeometryChanged() signal, then is there a good chance that kwin will fall into an infinite recursion. However, that's the case with only X11 and internal clients. The root cause of the infinite recursion is that both X11Client and InternalClient compare the new geometry against the geometry before update blocking. In order to fix the bug, we simply need to ensure that updateGeometryBeforeUpdateBlocking() has been called before we start emitting the frameGeometryChanged() signal. Furthermore, a couple of tests were added to ensure that we won't hit this subtle bug again.
2020-07-20 19:33:19 +00:00
// to the frameGeometryChanged() signal won't cause an infinite recursion.
// Create a test window.
QScopedPointer<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
QVERIFY(!xcb_connection_has_error(c.data()));
const QRect windowGeometry(0, 0, 100, 200);
xcb_window_t w = xcb_generate_id(c.data());
xcb_create_window(c.data(), XCB_COPY_FROM_PARENT, w, rootWindow(),
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
xcb_icccm_set_wm_normal_hints(c.data(), w, &hints);
xcb_change_property(c.data(), XCB_PROP_MODE_REPLACE, w, atoms->wm_client_leader, XCB_ATOM_WINDOW, 32, 1, &w);
xcb_map_window(c.data(), w);
xcb_flush(c.data());
QSignalSpy windowCreatedSpy(workspace(), &Workspace::clientAdded);
QVERIFY(windowCreatedSpy.isValid());
QVERIFY(windowCreatedSpy.wait());
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
X11Window *client = windowCreatedSpy.first().first().value<X11Window *>();
Make setFrameGeometry() re-entrant for X and internal clients If AbstractClient::setFrameGeometry() is called from a slot connected directly to the frameGeometryChanged() signal, then is there a good chance that kwin will fall into an infinite recursion. However, that's the case with only X11 and internal clients. The root cause of the infinite recursion is that both X11Client and InternalClient compare the new geometry against the geometry before update blocking. In order to fix the bug, we simply need to ensure that updateGeometryBeforeUpdateBlocking() has been called before we start emitting the frameGeometryChanged() signal. Furthermore, a couple of tests were added to ensure that we won't hit this subtle bug again.
2020-07-20 19:33:19 +00:00
QVERIFY(client);
QCOMPARE(client->pos(), QPoint(0, 0));
// Let's pretend that there is a script that really wants the client to be at (100, 100).
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
connect(client, &Window::frameGeometryChanged, this, [client]() {
Rework async geometry updates Window management features were written with synchronous geometry updates in mind. Currently, this poses a big problem on Wayland because geometry updates are done in asynchronous fashion there. At the moment, geometry is updated in a so called pseudo-asynchronous fashion, meaning that the frame geometry will be reset to the old value once geometry updates are unblocked. The main drawback of this approach is that it is too error prone, the data flow is hard to comprehend, etc. It is worth noting that there is already a machinery to perform async geometry which is used during interactive move/resize operations. This change extends the move/resize geometry usage beyond interactive move/resize to make asynchronous geometry updates less error prone and easier to comprehend. With the proposed solution, all geometry updates must be done on the move/resize geometry first. After that, the new geometry is passed on to the Client-specific implementation of moveResizeInternal(). To be more specific, the frameGeometry() returns the current frame geometry, it is primarily useful only to the scene. If you want to move or resize a window, you need to use moveResizeGeometry() because it corresponds to the last requested frame geometry. It is worth noting that the moveResizeGeometry() returns the desired bounding geometry. The client may commit the xdg_toplevel surface with a slightly smaller window geometry, for example to enforce a specific aspect ratio. The client is not allowed to resize beyond the size as indicated in moveResizeGeometry(). The data flow is very simple: moveResize() updates the move/resize geometry and calls the client-specific implementation of the moveResizeInternal() method. Based on whether a configure event is needed, moveResizeInternal() will update the frameGeometry() either immediately or after the client commits a new buffer. Unfortunately, both the compositor and xdg-shell clients try to update the window geometry. It means that it's possible to have conflicts between the two. With this change, the compositor's move resize geometry will be synced only if there are no pending configure events, meaning that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
client->moveResize(QRect(QPoint(100, 100), client->size()));
Make setFrameGeometry() re-entrant for X and internal clients If AbstractClient::setFrameGeometry() is called from a slot connected directly to the frameGeometryChanged() signal, then is there a good chance that kwin will fall into an infinite recursion. However, that's the case with only X11 and internal clients. The root cause of the infinite recursion is that both X11Client and InternalClient compare the new geometry against the geometry before update blocking. In order to fix the bug, we simply need to ensure that updateGeometryBeforeUpdateBlocking() has been called before we start emitting the frameGeometryChanged() signal. Furthermore, a couple of tests were added to ensure that we won't hit this subtle bug again.
2020-07-20 19:33:19 +00:00
});
// Trigger the lambda above.
client->move(QPoint(40, 50));
// Eventually, the client will end up at (100, 100).
QCOMPARE(client->pos(), QPoint(100, 100));
// Destroy the test window.
xcb_destroy_window(c.data(), w);
xcb_flush(c.data());
QVERIFY(Test::waitForWindowDestroyed(client));
}
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
WAYLANDTEST_MAIN(X11WindowTest)
#include "x11_window_test.moc"
Reference in a new issue Copy permalink