yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/struts_test.cpp

696 lines
33 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
#include "kwin_wayland_test.h"
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
Move multi-purpose code in its own directory Things such as Output, InputDevice and so on are made to be multi-purpose. In order to make this separation more clear, this change moves that code in the core directory. Some things still link to the abstraction level above (kwin), they can be tackled in future refactors. Ideally code in core/ should depend either on other code in core/ or system libs.
2022-08-29 07:55:49 +00:00
#include "core/output.h"
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
#include "pointer_input.h"
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
#include "screenedge.h"
Port Workspace::clientArea() to VirtualDesktop This makes Workspace APIs that take virtual desktops more consistent.
2021-08-21 17:46:51 +00:00
#include "virtualdesktops.h"
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
#include "wayland_server.h"
#include "workspace.h"
Rename X11Client to X11Window The word "client" means different things in wayland and kwin. Use a better word to refer to windows.
2022-04-22 17:54:31 +00:00
#include "x11window.h"
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
#include <KWayland/Client/compositor.h>
#include <KWayland/Client/surface.h>
#include <KDecoration2/Decoration>
#include <netwm.h>
#include <xcb/xcb_icccm.h>
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
Q_DECLARE_METATYPE(KWin::StrutRects)
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
namespace KWin
{
static const QString s_socketName = QStringLiteral("wayland_test_kwin_struts-0");
class StrutsTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase();
void init();
void cleanup();
void testX11Struts_data();
void testX11Struts();
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
void test363804();
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
void testLeftScreenSmallerBottomAligned();
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
void testWindowMoveWithPanelBetweenScreens();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
private:
KWayland::Client::Compositor *m_compositor = nullptr;
};
void StrutsTest::initTestCase()
{
Rename AbstractClient to Window
2022-04-22 17:39:12 +00:00
qRegisterMetaType<KWin::Window *>();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
Avoid converting socket name between QString and QByteArray back and forth It only contributes overhead.
2020-12-09 13:06:15 +00:00
QVERIFY(waylandServer()->init(s_socketName));
autotests: directly call setVirtualOutputs
2023-05-08 10:16:00 +00:00
Test::setOutputConfig({
QRect(0, 0, 1280, 1024),
QRect(1280, 0, 1280, 1024),
});
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
[autotests] Disable Outline in StrutsTest The StrutsTest is constantly aborting on build.kde.org and lots of OpenGL stuff in output. This could indicate a problem with the Outline as the failing test could trigger the Outline. So let's try to disable it.
2017-08-08 17:56:24 +00:00
// set custom config which disables the Outline
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
Port away from deprecated KConfigBase::group() api
2023-11-27 13:11:22 +00:00
KConfigGroup group = config->group(QStringLiteral("Outline"));
[autotests] Disable Outline in StrutsTest The StrutsTest is constantly aborting on build.kde.org and lots of OpenGL stuff in output. This could indicate a problem with the Outline as the failing test could trigger the Outline. So let's try to disable it.
2017-08-08 17:56:24 +00:00
group.writeEntry(QStringLiteral("QmlPath"), QString("/does/not/exist.qml"));
group.sync();
kwinApp()->setConfig(config);
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
kwinApp()->start();
Introduce started signal in Application The new signal is emitted when the Application has fully been initialized. It allows us to change the startup sequence, for example create workspace before starting the Xwayland server, without making any adjustments in our test suit.
2020-07-07 09:32:29 +00:00
QVERIFY(applicationStartedSpy.wait());
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const auto outputs = workspace()->outputs();
autotests: Port common screen check preamble to AbstractOutput
2021-08-31 07:03:05 +00:00
QCOMPARE(outputs.count(), 2);
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
setenv("QT_QPA_PLATFORM", "wayland", true);
}
void StrutsTest::init()
{
wayland: Drop strut support in XdgToplevelWindow Use layer_surface.set_exclusive_zone instead.
2023-05-23 08:02:59 +00:00
QVERIFY(Test::setupWaylandConnection());
[autotest/integration] Introduce a Test helper library to have less code duplication Summary: A new namespace KWin::Test is added which provides a few helper functions. It makes it easy to setup a KWayland client connection with the base set to be able to create a Surface and flags to create additional interfaces. This replaces the KWayland connection dance in init() methods. For cleanup() there is also a dedicated helper function. In addition there are helper functions to: * render a surface * create a surface * create a shell surface * flush the wayland client connection * access to the created interfaces - for compatibility with existing code The idea is to extend this Test library also for other common use cases like creating an X11 connection and X11 windows, etc. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2053
2016-06-30 11:32:54 +00:00
m_compositor = Test::waylandCompositor();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
Move active output tracking to workspace Active output is a window management concept. It indicates what output new windows have to be placed on if they have no output hint. So Workspace seems to be a better place for it than the Screens class, which is obsolete.
2021-08-28 18:58:29 +00:00
workspace()->setActiveOutput(QPoint(640, 512));
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(QPoint(640, 512));
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QVERIFY(waylandServer()->windows().isEmpty());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
}
void StrutsTest::cleanup()
{
[autotest/integration] Introduce a Test helper library to have less code duplication Summary: A new namespace KWin::Test is added which provides a few helper functions. It makes it easy to setup a KWayland client connection with the base set to be able to create a Surface and flags to create additional interfaces. This replaces the KWayland connection dance in init() methods. For cleanup() there is also a dedicated helper function. In addition there are helper functions to: * render a surface * create a surface * create a shell surface * flush the wayland client connection * access to the created interfaces - for compatibility with existing code The idea is to extend this Test library also for other common use cases like creating an X11 connection and X11 windows, etc. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2053
2016-06-30 11:32:54 +00:00
Test::destroyWaylandConnection();
Fix the strut handling for wayland clients Summary: The implementation was broken as it transformed the QRects into QRegions, subtracted the geometries and took the bounding rect again. In several setups this could result in the strut getting ignored. This change improves the calculation of the struts by creating a QMargin which describes the area which needs to be subtracted from a screen rect. The QMargin is only adjusted for the edge the window borders. We can assume that a window with a strut needs to border a screen on Wayland. With this change we are also able to support panels between screens. On Wayland a panel placed on the right of a left screen affects the maximization area of the left screen, but does not affect the overall workarea. CCBUG: 167852 Reviewers: #plasma_on_wayland, #kwin Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1803
2016-06-09 08:01:05 +00:00
}
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
void StrutsTest::testX11Struts_data()
{
QTest::addColumn<QRect>("windowGeometry");
QTest::addColumn<int>("leftStrut");
QTest::addColumn<int>("rightStrut");
QTest::addColumn<int>("topStrut");
QTest::addColumn<int>("bottomStrut");
QTest::addColumn<int>("leftStrutStart");
QTest::addColumn<int>("leftStrutEnd");
QTest::addColumn<int>("rightStrutStart");
QTest::addColumn<int>("rightStrutEnd");
QTest::addColumn<int>("topStrutStart");
QTest::addColumn<int>("topStrutEnd");
QTest::addColumn<int>("bottomStrutStart");
QTest::addColumn<int>("bottomStrutEnd");
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
QTest::addColumn<QRectF>("screen0Maximized");
QTest::addColumn<QRectF>("screen1Maximized");
QTest::addColumn<QRectF>("workArea");
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
QTest::addColumn<StrutRects>("restrictedMoveArea");
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("bottom panel/no strut") << QRect(0, 980, 1280, 44)
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("bottom panel/strut") << QRect(0, 980, 1280, 44)
<< 0 << 0 << 0 << 44
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 1279
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 980)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 980)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(0, 980, 1279, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel/no strut") << QRect(0, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel/strut") << QRect(0, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 44 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 1279
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 44, 1280, 980)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 44, 2560, 980)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(0, 0, 1279, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("left panel/no strut") << QRect(0, 0, 60, 1024)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("left panel/strut") << QRect(0, 0, 60, 1024)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 60 << 0 << 0 << 0
<< 0 << 1023
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(60, 0, 1220, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(60, 0, 2500, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(0, 0, 60, 1023)};
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
QTest::newRow("right panel/no strut") << QRect(1220, 0, 60, 1024)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
QTest::newRow("right panel/strut") << QRect(1220, 0, 60, 1024)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 1340 << 0 << 0
<< 0 << 0
<< 0 << 1023
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1220, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(1220, 0, 60, 1023)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// second screen
QTest::newRow("bottom panel 1/no strut") << QRect(1280, 980, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("bottom panel 1/strut") << QRect(1280, 980, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 44
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 1280 << 2559
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 980)
<< QRectF(0, 0, 2560, 980)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(1280, 980, 1279, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel 1/no strut") << QRect(1280, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel 1 /strut") << QRect(1280, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 44 << 0
<< 0 << 0
<< 0 << 0
<< 1280 << 2559
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 44, 1280, 980)
<< QRectF(0, 44, 2560, 980)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(1280, 0, 1279, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("left panel 1/no strut") << QRect(1280, 0, 60, 1024)
<< 0 << 0 << 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("left panel 1/strut") << QRect(1280, 0, 60, 1024)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 1340 << 0 << 0 << 0
<< 0 << 1023
<< 0 << 0
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
<< 0 << 0
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1340, 0, 1220, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(1280, 0, 60, 1023)};
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
// invalid struts
QTest::newRow("bottom panel/ invalid strut") << QRect(0, 980, 1280, 44)
<< 1280 << 0 << 0 << 44
<< 980 << 1024
<< 0 << 0
<< 0 << 0
<< 0 << 1279
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(0, 980, 1279, 44), StrutRect(0, 980, 1280, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel/ invalid strut") << QRect(0, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 1280 << 0 << 44 << 0
<< 0 << 44
<< 0 << 0
<< 0 << 1279
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects{StrutRect(0, 0, 1279, 44), StrutRect(0, 0, 1280, 44)};
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QTest::newRow("top panel/invalid strut 2") << QRect(0, 0, 1280, 44)
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
<< 0 << 0 << 1024 << 0
<< 0 << 0
<< 0 << 0
<< 0 << 1279
<< 0 << 0
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
<< QRectF(0, 0, 1280, 1024)
<< QRectF(1280, 0, 1280, 1024)
<< QRectF(0, 0, 2560, 1024)
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
<< StrutRects();
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
}
void StrutsTest::testX11Struts()
{
// this test verifies that struts are applied correctly for X11 windows
Port Workspace::clientArea() to VirtualDesktop This makes Workspace APIs that take virtual desktops more consistent.
2021-08-21 17:46:51 +00:00
VirtualDesktop *desktop = VirtualDesktopManager::self()->currentDesktop();
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const QList<Output *> outputs = workspace()->outputs();
Port Workspace::clientArea() to VirtualDesktop This makes Workspace APIs that take virtual desktops more consistent.
2021-08-21 17:46:51 +00:00
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// no, struts yet
// first screen
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MovementArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// second screen
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MovementArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// combined
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(WorkArea, outputs[0], desktop), QRect(0, 0, 2560, 1024));
QCOMPARE(workspace()->clientArea(FullArea, outputs[0], desktop), QRect(0, 0, 2560, 1024));
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
QCOMPARE(workspace()->restrictedMoveArea(desktop), StrutRects());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// create an xcb window
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QFETCH(QRect, windowGeometry);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
info.setWindowType(NET::Dock);
// set the extended strut
QFETCH(int, leftStrut);
QFETCH(int, rightStrut);
QFETCH(int, topStrut);
QFETCH(int, bottomStrut);
QFETCH(int, leftStrutStart);
QFETCH(int, leftStrutEnd);
QFETCH(int, rightStrutStart);
QFETCH(int, rightStrutEnd);
QFETCH(int, topStrutStart);
QFETCH(int, topStrutEnd);
QFETCH(int, bottomStrutStart);
QFETCH(int, bottomStrutEnd);
NETExtendedStrut strut;
strut.left_start = leftStrutStart;
strut.left_end = leftStrutEnd;
strut.left_width = leftStrut;
strut.right_start = rightStrutStart;
strut.right_end = rightStrutEnd;
strut.right_width = rightStrut;
strut.top_start = topStrutStart;
strut.top_end = topStrutEnd;
strut.top_width = topStrut;
strut.bottom_start = bottomStrutStart;
strut.bottom_end = bottomStrutEnd;
strut.bottom_width = bottomStrut;
info.setExtendedStrut(strut);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
autotests: client -> window
2022-04-23 19:51:16 +00:00
// we should get a window for it
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.first().first().value<X11Window *>();
QVERIFY(window);
QCOMPARE(window->window(), windowId);
QVERIFY(!window->isDecorated());
Do not rely on NETWM for the main Window class NETWM forces a weird X11 dependency on KWin that doesn't necessarily match what we want to do. Instead we decouple such a central class in KWin like it's Window from KWindowSystem X11 support. Signed-off-by: Falko Becker <falko.becker@mbition.io>
2024-02-20 18:04:06 +00:00
QCOMPARE(window->windowType(), WindowType::Dock);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QCOMPARE(window->frameGeometry(), windowGeometry);
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// this should have affected the client area
// some props are independent of struts - those first
// screen 0
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(MovementArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// screen 1
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(MovementArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// combined
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(FullArea, outputs[0], desktop), QRect(0, 0, 2560, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// now verify the actual updated client areas
autotests: Use less QRectF::toRect()
2022-07-15 07:38:00 +00:00
QTEST(workspace()->clientArea(PlacementArea, outputs[0], desktop), "screen0Maximized");
QTEST(workspace()->clientArea(MaximizeArea, outputs[0], desktop), "screen0Maximized");
QTEST(workspace()->clientArea(PlacementArea, outputs[1], desktop), "screen1Maximized");
QTEST(workspace()->clientArea(MaximizeArea, outputs[1], desktop), "screen1Maximized");
QTEST(workspace()->clientArea(WorkArea, outputs[0], desktop), "workArea");
Port Workspace::clientArea() to VirtualDesktop This makes Workspace APIs that take virtual desktops more consistent.
2021-08-21 17:46:51 +00:00
QTEST(workspace()->restrictedMoveArea(desktop), "restrictedMoveArea");
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// and destroy the window again
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_unmap_window(c.get(), windowId);
xcb_destroy_window(c.get(), windowId);
xcb_flush(c.get());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
c.reset();
Tidy Window::windowClosed() signal "window" is redundant, so remove it. Also remove the original window argument to improve the API consistency.
2023-03-13 19:21:11 +00:00
QSignalSpy windowClosedSpy(window, &X11Window::closed);
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
QVERIFY(windowClosedSpy.wait());
// now struts should be removed again
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MovementArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[0], desktop), QRect(0, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// second screen
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MovementArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(MaximizeFullArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(FullScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
QCOMPARE(workspace()->clientArea(ScreenArea, outputs[1], desktop), QRect(1280, 0, 1280, 1024));
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
// combined
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(WorkArea, outputs[0], desktop), QRect(0, 0, 2560, 1024));
QCOMPARE(workspace()->clientArea(FullArea, outputs[0], desktop), QRect(0, 0, 2560, 1024));
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
QCOMPARE(workspace()->restrictedMoveArea(desktop), StrutRects());
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
}
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
void StrutsTest::test363804()
{
// this test verifies the condition described in BUG 363804
// two screens in a vertical setup, aligned to right border with panel on the bottom screen
There's no QVector anymore, QList is the QVector in Qt6
2023-10-19 06:50:15 +00:00
const QList<QRect> geometries{QRect(0, 0, 1920, 1080), QRect(554, 1080, 1366, 768)};
autotests: directly call setVirtualOutputs
2023-05-08 10:16:00 +00:00
Test::setOutputConfig(geometries);
autotests: Port more tests from obsolete Screens
2022-07-11 12:20:35 +00:00
QCOMPARE(workspace()->geometry(), QRect(0, 0, 1920, 1848));
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
VirtualDesktop *desktop = VirtualDesktopManager::self()->currentDesktop();
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const QList<Output *> outputs = workspace()->outputs();
autotests: Port common screen check preamble to AbstractOutput
2021-08-31 07:03:05 +00:00
QCOMPARE(outputs.count(), 2);
QCOMPARE(outputs[0]->geometry(), geometries[0]);
QCOMPARE(outputs[1]->geometry(), geometries[1]);
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
// create an xcb window
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
const QRect windowGeometry(554, 1812, 1366, 36);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
info.setWindowType(NET::Dock);
NETExtendedStrut strut;
strut.left_start = 0;
strut.left_end = 0;
strut.left_width = 0;
strut.right_start = 0;
strut.right_end = 0;
strut.right_width = 0;
strut.top_start = 0;
strut.top_end = 0;
strut.top_width = 0;
strut.bottom_start = 554;
strut.bottom_end = 1919;
strut.bottom_width = 36;
info.setExtendedStrut(strut);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
autotests: client -> window
2022-04-23 19:51:16 +00:00
// we should get a window for it
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.first().first().value<X11Window *>();
QVERIFY(window);
QCOMPARE(window->window(), windowId);
QVERIFY(!window->isDecorated());
Do not rely on NETWM for the main Window class NETWM forces a weird X11 dependency on KWin that doesn't necessarily match what we want to do. Instead we decouple such a central class in KWin like it's Window from KWindowSystem X11 support. Signed-off-by: Falko Becker <falko.becker@mbition.io>
2024-02-20 18:04:06 +00:00
QCOMPARE(window->windowType(), WindowType::Dock);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QCOMPARE(window->frameGeometry(), windowGeometry);
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
// now verify the actual updated client areas
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[0], desktop), geometries.at(0));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[0], desktop), geometries.at(0));
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[1], desktop), QRect(554, 1080, 1366, 732));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[1], desktop), QRect(554, 1080, 1366, 732));
QCOMPARE(workspace()->clientArea(WorkArea, outputs[0], desktop), QRect(0, 0, 1920, 1812));
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
// and destroy the window again
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_unmap_window(c.get(), windowId);
xcb_destroy_window(c.get(), windowId);
xcb_flush(c.get());
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
c.reset();
Tidy Window::windowClosed() signal "window" is redundant, so remove it. Also remove the original window argument to improve the API consistency.
2023-03-13 19:21:11 +00:00
QSignalSpy windowClosedSpy(window, &X11Window::closed);
[autotest] Add test case exposing problem of bug 363804 The test case sets up apol's screen setup and the panel as described in the attachements in bug 363804. As the test shows the panel's strut is incorrectly ignored. CCBUG: 363804
2016-06-02 07:29:53 +00:00
QVERIFY(windowClosedSpy.wait());
}
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
void StrutsTest::testLeftScreenSmallerBottomAligned()
{
// this test verifies a two screen setup with the left screen smaller than the right and bottom aligned
// the panel is on the top of the left screen, thus not at 0/0
There's no QVector anymore, QList is the QVector in Qt6
2023-10-19 06:50:15 +00:00
const QList<QRect> geometries{QRect(0, 282, 1366, 768), QRect(1366, 0, 1680, 1050)};
autotests: directly call setVirtualOutputs
2023-05-08 10:16:00 +00:00
Test::setOutputConfig(geometries);
autotests: Port more tests from obsolete Screens
2022-07-11 12:20:35 +00:00
QCOMPARE(workspace()->geometry(), QRect(0, 0, 3046, 1050));
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const QList<Output *> outputs = workspace()->outputs();
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(outputs[0]->geometry(), geometries.at(0));
QCOMPARE(outputs[1]->geometry(), geometries.at(1));
// the test window will be on the current desktop
VirtualDesktop *desktop = VirtualDesktopManager::self()->currentDesktop();
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
// create the panel
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
const QRect windowGeometry(0, 282, 1366, 24);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
info.setWindowType(NET::Dock);
NETExtendedStrut strut;
strut.left_start = 0;
strut.left_end = 0;
strut.left_width = 0;
strut.right_start = 0;
strut.right_end = 0;
strut.right_width = 0;
strut.top_start = 0;
strut.top_end = 1365;
strut.top_width = 306;
strut.bottom_start = 0;
strut.bottom_end = 0;
strut.bottom_width = 0;
info.setExtendedStrut(strut);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
autotests: client -> window
2022-04-23 19:51:16 +00:00
// we should get a window for it
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.first().first().value<X11Window *>();
QVERIFY(window);
QCOMPARE(window->window(), windowId);
QVERIFY(!window->isDecorated());
Do not rely on NETWM for the main Window class NETWM forces a weird X11 dependency on KWin that doesn't necessarily match what we want to do. Instead we decouple such a central class in KWin like it's Window from KWindowSystem X11 support. Signed-off-by: Falko Becker <falko.becker@mbition.io>
2024-02-20 18:04:06 +00:00
QCOMPARE(window->windowType(), WindowType::Dock);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QCOMPARE(window->frameGeometry(), windowGeometry);
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
// now verify the actual updated client areas
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[0], desktop), QRect(0, 306, 1366, 744));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[0], desktop), QRect(0, 306, 1366, 744));
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[1], desktop), geometries.at(1));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[1], desktop), geometries.at(1));
QCOMPARE(workspace()->clientArea(WorkArea, outputs[0], desktop), QRect(0, 0, 3046, 1050));
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
// and destroy the window again
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_unmap_window(c.get(), windowId);
xcb_destroy_window(c.get(), windowId);
xcb_flush(c.get());
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
c.reset();
Tidy Window::windowClosed() signal "window" is redundant, so remove it. Also remove the original window argument to improve the API consistency.
2023-03-13 19:21:11 +00:00
QSignalSpy windowClosedSpy(window, &X11Window::closed);
[autotests/integration] Test another multi-screen setup The struts test is extended by a setup containing two horizontal screens, bottom aligned with the left screen smaller than the right. Thus there is a dead area in the top left corner. In addition there's a panel on top left screen. Apparently KWin allowed windows to open in the dead area. The test case reconstructs this by opening a window with the same size hints, but in the test it's working correctly.
2016-07-13 05:59:18 +00:00
QVERIFY(windowClosedSpy.wait());
}
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
void StrutsTest::testWindowMoveWithPanelBetweenScreens()
{
// this test verifies the condition of BUG
// when moving a window with decorations in a restricted way it should pass from one screen
// to the other even if there is a panel in between.
// left screen must be smaller than right screen
There's no QVector anymore, QList is the QVector in Qt6
2023-10-19 06:50:15 +00:00
const QList<QRect> geometries{QRect(0, 282, 1366, 768), QRect(1366, 0, 1680, 1050)};
autotests: directly call setVirtualOutputs
2023-05-08 10:16:00 +00:00
Test::setOutputConfig(geometries);
autotests: Port more tests from obsolete Screens
2022-07-11 12:20:35 +00:00
QCOMPARE(workspace()->geometry(), QRect(0, 0, 3046, 1050));
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
Make Workspace track managed outputs This change adjusts the window management abstractions in kwin for the drm backend providing more than just "desktop" outputs. Besides that, it has other potential benefits - for example, the Workspace could start managing allocation of the placeholder output by itself, thus leading to some simplifications in the drm backend. Another is that it lets us move wayland code from the drm backend.
2022-07-11 10:41:15 +00:00
const QList<Output *> outputs = workspace()->outputs();
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(outputs[0]->geometry(), geometries.at(0));
QCOMPARE(outputs[1]->geometry(), geometries.at(1));
// all windows will be placed on the current desktop
VirtualDesktop *desktop = VirtualDesktopManager::self()->currentDesktop();
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
// create the panel on the right screen, left edge
Autotests: Use a helper method to create X11 connection
2023-02-03 13:29:21 +00:00
Test::XcbConnectionPtr c = Test::createX11Connection();
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
QVERIFY(!xcb_connection_has_error(c.get()));
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t windowId = xcb_generate_id(c.get());
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
const QRect windowGeometry(1366, 0, 24, 1050);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
windowGeometry.x(),
windowGeometry.y(),
windowGeometry.width(),
windowGeometry.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints;
memset(&hints, 0, sizeof(hints));
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
info.setWindowType(NET::Dock);
NETExtendedStrut strut;
strut.left_start = 0;
strut.left_end = 1050;
Run clang-format The .clang-format file is based on the one in ECM except the following style options: - AlwaysBreakBeforeMultilineStrings - BinPackArguments - BinPackParameters - ColumnLimit - BreakBeforeBraces - KeepEmptyLinesAtTheStartOfBlocks
2022-03-23 10:13:38 +00:00
strut.left_width = 1366 + 24;
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
strut.right_start = 0;
strut.right_end = 0;
strut.right_width = 0;
strut.top_start = 0;
strut.top_end = 0;
strut.top_width = 0;
strut.bottom_start = 0;
strut.bottom_end = 0;
strut.bottom_width = 0;
info.setExtendedStrut(strut);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_map_window(c.get(), windowId);
xcb_flush(c.get());
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
autotests: client -> window
2022-04-23 19:51:16 +00:00
// we should get a window for it
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window = windowCreatedSpy.first().first().value<X11Window *>();
QVERIFY(window);
QCOMPARE(window->window(), windowId);
QVERIFY(!window->isDecorated());
Do not rely on NETWM for the main Window class NETWM forces a weird X11 dependency on KWin that doesn't necessarily match what we want to do. Instead we decouple such a central class in KWin like it's Window from KWindowSystem X11 support. Signed-off-by: Falko Becker <falko.becker@mbition.io>
2024-02-20 18:04:06 +00:00
QCOMPARE(window->windowType(), WindowType::Dock);
autotests: client -> window
2022-04-23 19:51:16 +00:00
QCOMPARE(window->frameGeometry(), windowGeometry);
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
// now verify the actual updated client areas
autotests: Port away from deprecated clientArea() overloads
2021-08-25 15:12:50 +00:00
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[0], desktop), QRect(0, 282, 1366, 768));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[0], desktop), QRect(0, 282, 1366, 768));
QCOMPARE(workspace()->clientArea(PlacementArea, outputs[1], desktop), QRect(1390, 0, 1656, 1050));
QCOMPARE(workspace()->clientArea(MaximizeArea, outputs[1], desktop), QRect(1390, 0, 1656, 1050));
QCOMPARE(workspace()->clientArea(WorkArea, outputs[0], desktop), QRect(0, 0, 3046, 1050));
Use StrutRects to represent restricted areas This saves us some StrutRects -> QRegion conversions and it might be useful for floating point struts.
2022-11-02 16:20:37 +00:00
QCOMPARE(workspace()->restrictedMoveArea(desktop), StrutRects{StrutRect(1366, 0, 24, 1050)});
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
// create another window and try to move it
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_window_t w2 = xcb_generate_id(c.get());
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
const QRect windowGeometry2(1500, 400, 200, 300);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, w2, rootWindow(),
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
windowGeometry2.x(),
windowGeometry2.y(),
windowGeometry2.width(),
windowGeometry2.height(),
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, 0, nullptr);
xcb_size_hints_t hints2;
memset(&hints2, 0, sizeof(hints2));
xcb_icccm_size_hints_set_position(&hints2, 1, windowGeometry2.x(), windowGeometry2.y());
xcb_icccm_size_hints_set_min_size(&hints2, 200, 300);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
xcb_icccm_set_wm_normal_hints(c.get(), w2, &hints2);
xcb_map_window(c.get(), w2);
xcb_flush(c.get());
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
QVERIFY(windowCreatedSpy.wait());
autotests: client -> window
2022-04-23 19:51:16 +00:00
X11Window *window2 = windowCreatedSpy.last().first().value<X11Window *>();
QVERIFY(window2);
QVERIFY(window2 != window);
QVERIFY(window2->isDecorated());
QCOMPARE(window2->clientSize(), QSize(200, 300));
QCOMPARE(window2->pos(), QPoint(1500, 400));
Use floating geometry throughout With fractional scaling integer based logical geometry may not match device pixels. Once we have a floating point base we can fix that. This also is important for our X11 scale override, with a scale of 2 we could get logical sizes with halves. We already have all input being floating point, this doubles down on it for all remaining geometry. - Outputs remain integer to ensure that any screen on the right remains aligned. - Placement also remains integer based for now. - Repainting is untouched as we always expand outwards (QRectF::toAdjustedRect(). - Decoration is untouched for now - Rules are integer in the config, but floating in the adjusting/API This should also be fine. At some point we'll add a method to snap to the device pixel grid. Effectively `round(value * dpr) / dpr` though right now things mostly work. This also gets rid of a lot of hacks for QRect right and bottom which are very confusing. Parts to watch out in the port are: QRectF::contains now includes edges QRectF::right and bottom are now sane so previous hacks have to be removed QRectF(QPoint, QPoint) behaves differently for the same reason QRectF::center too In test results some adjusted values which are the result of QRect.center because using QRectF's center should behave the same to the user.
2022-05-16 20:13:39 +00:00
const QRectF origGeo = window2->frameGeometry();
Port away from Cursor::setPos() Use input device specific apis to change the position of the cursor. The main reason to do so is to break the assumption that Cursor position is the same as pointer position, which I would like to rely on later to merge tablet and pointer cursors.
2023-02-09 13:07:56 +00:00
input()->pointer()->warp(origGeo.center());
autotests: client -> window
2022-04-23 19:51:16 +00:00
workspace()->performWindowOperation(window2, Options::MoveOp);
QTRY_COMPARE(workspace()->moveResizeWindow(), window2);
QVERIFY(window2->isInteractiveMove());
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
// move to next screen - step is 8 pixel, so 800 pixel
for (int i = 0; i < 100; i++) {
autotests: client -> window
2022-04-23 19:51:16 +00:00
window2->keyPressEvent(Qt::Key_Left);
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
}
autotests: client -> window
2022-04-23 19:51:16 +00:00
window2->keyPressEvent(Qt::Key_Enter);
QCOMPARE(window2->isInteractiveMove(), false);
Prefer the term "window" over "client" in Workspace
2022-04-23 08:33:23 +00:00
QVERIFY(workspace()->moveResizeWindow() == nullptr);
Use floating geometry throughout With fractional scaling integer based logical geometry may not match device pixels. Once we have a floating point base we can fix that. This also is important for our X11 scale override, with a scale of 2 we could get logical sizes with halves. We already have all input being floating point, this doubles down on it for all remaining geometry. - Outputs remain integer to ensure that any screen on the right remains aligned. - Placement also remains integer based for now. - Repainting is untouched as we always expand outwards (QRectF::toAdjustedRect(). - Decoration is untouched for now - Rules are integer in the config, but floating in the adjusting/API This should also be fine. At some point we'll add a method to snap to the device pixel grid. Effectively `round(value * dpr) / dpr` though right now things mostly work. This also gets rid of a lot of hacks for QRect right and bottom which are very confusing. Parts to watch out in the port are: QRectF::contains now includes edges QRectF::right and bottom are now sane so previous hacks have to be removed QRectF(QPoint, QPoint) behaves differently for the same reason QRectF::center too In test results some adjusted values which are the result of QRect.center because using QRectF's center should behave the same to the user.
2022-05-16 20:13:39 +00:00
QCOMPARE(window2->frameGeometry(), QRectF(origGeo.translated(-800, 0)));
Restrict move resize area only on the screen the strut window is on Summary: By allowing panels between screens in 5.8 to have a strut we created a "regression" in KWin. KWin always was wrong, just we didn't notice as neither Plasma nor previously Kicker set a strut on panels between shared screen edges. The strut is created from the edge of the overall screen setup. This means a panel on the left edge of a screen on the right has the strut starting from the left screen. KWin uses the strut to restrict the move resize area: a window decoration is not allowed to go below a strut. Thus it becomes impossible to move the window from the right to the left screen. This change tries to solve this problem by only restricting the move area on the screen the window with the strut is on. E.g. if the window is on the right screen, the left screen is not affected. Thus it's possible again to move a window from one screen to the other as the added test case shows. Unfortunately there are still corner cases where this won't work correctly. If the window is on both screens this won't work. It is also a rather heavy change for KWin and thus it's targeted for master and not for the 5.10 or the 5.8 branch. If we notice that the patch works well and doesn't create further issues, it should be considered for backporting. BUG: 371199 CCBUG: 370510 FIXED-IN: 5.11 Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6562
2017-07-08 06:41:16 +00:00
}
Strut sanity checking: ignore struts which would exclude a complete screen Summary: Mostly meant for multi-screen setups: we don't want that a strut set on a window on screen 0 results in screen 1 completely being excluded. Even if that's strictly seen a client bug, it's better to just ignore the strut from KWin's side. The sanity check is implemented in Client::adjustedClientArea. From a pure standard point of view this change is a EWMH violation and thus can cause regressions: struts by clients no longer working. A test case for struts is added, including some invalid combinations whose strut is ignored with this change. Reviewers: #plasma Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1386
2016-04-11 15:24:08 +00:00
}
WAYLANDTEST_MAIN(KWin::StrutsTest)
#include "struts_test.moc"
Reference in a new issue Copy permalink