2018-08-21 20:06:42 +00:00
|
|
|
/********************************************************************
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
|
|
|
Copyright 2018 Roman Gilg <subdiff@gmail.com>
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_XWL_DATABRIDGE
|
|
|
|
#define KWIN_XWL_DATABRIDGE
|
|
|
|
|
|
|
|
#include <QObject>
|
2018-08-22 12:56:48 +00:00
|
|
|
#include <QPoint>
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
#include <xcb/xcb.h>
|
|
|
|
|
|
|
|
class xcb_xfixes_selection_notify_event_t;
|
|
|
|
|
2019-07-02 19:56:03 +00:00
|
|
|
namespace KWayland
|
|
|
|
{
|
|
|
|
namespace Client
|
|
|
|
{
|
2018-08-21 20:06:42 +00:00
|
|
|
class DataDevice;
|
|
|
|
}
|
2019-07-02 19:56:03 +00:00
|
|
|
namespace Server
|
|
|
|
{
|
2018-08-21 20:06:42 +00:00
|
|
|
class DataDeviceInterface;
|
|
|
|
class SurfaceInterface;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
2018-08-22 12:56:48 +00:00
|
|
|
class Toplevel;
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
namespace Xwl
|
|
|
|
{
|
|
|
|
class Xwayland;
|
|
|
|
class Clipboard;
|
2018-08-22 12:56:48 +00:00
|
|
|
class Dnd;
|
|
|
|
enum class DragEventReply;
|
2018-08-21 20:06:42 +00:00
|
|
|
|
2019-07-02 19:56:03 +00:00
|
|
|
/**
|
2018-08-21 20:06:42 +00:00
|
|
|
* Interface class for all data sharing in the context of X selections
|
|
|
|
* and Wayland's internal mechanism.
|
|
|
|
*
|
|
|
|
* Exists only once per Xwayland session.
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2018-08-21 20:06:42 +00:00
|
|
|
class DataBridge : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
2019-07-02 19:56:03 +00:00
|
|
|
|
2018-08-21 20:06:42 +00:00
|
|
|
public:
|
2019-07-02 19:56:03 +00:00
|
|
|
static DataBridge *self();
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
explicit DataBridge(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~DataBridge() override;
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
bool filterEvent(xcb_generic_event_t *event);
|
2019-07-02 19:56:03 +00:00
|
|
|
DragEventReply dragMoveFilter(Toplevel *target, const QPoint &pos);
|
2018-08-21 20:06:42 +00:00
|
|
|
|
2018-08-22 12:56:48 +00:00
|
|
|
KWayland::Client::DataDevice *dataDevice() const
|
|
|
|
{
|
2019-07-02 19:56:03 +00:00
|
|
|
return m_dataDevice;
|
2018-08-21 20:06:42 +00:00
|
|
|
}
|
2018-08-22 12:56:48 +00:00
|
|
|
KWayland::Server::DataDeviceInterface *dataDeviceIface() const
|
|
|
|
{
|
2019-07-02 19:56:03 +00:00
|
|
|
return m_dataDeviceInterface;
|
2018-08-21 20:06:42 +00:00
|
|
|
}
|
2019-07-02 19:56:03 +00:00
|
|
|
Dnd *dnd() const
|
2018-08-22 12:56:48 +00:00
|
|
|
{
|
|
|
|
return m_dnd;
|
|
|
|
}
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void init();
|
|
|
|
|
|
|
|
bool handleXfixesNotify(xcb_xfixes_selection_notify_event_t *event);
|
|
|
|
|
|
|
|
Clipboard *m_clipboard = nullptr;
|
2018-08-22 12:56:48 +00:00
|
|
|
Dnd *m_dnd = nullptr;
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
/* Internal data device interface */
|
2019-07-02 19:56:03 +00:00
|
|
|
KWayland::Client::DataDevice *m_dataDevice = nullptr;
|
|
|
|
KWayland::Server::DataDeviceInterface *m_dataDeviceInterface = nullptr;
|
|
|
|
|
|
|
|
Q_DISABLE_COPY(DataBridge)
|
2018-08-21 20:06:42 +00:00
|
|
|
};
|
|
|
|
|
2019-07-02 19:56:03 +00:00
|
|
|
} // namespace Xwl
|
|
|
|
} // namespace KWin
|
2018-08-21 20:06:42 +00:00
|
|
|
|
|
|
|
#endif
|