kwin/scripting/screenedgeitem.h

116 lines
2.5 KiB
C
Raw Normal View History

2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2013 Martin Gräßlin <mgraesslin@kde.org>
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_SCREENEDGEITEM_H
#define KWIN_SCREENEDGEITEM_H
#include <QObject>
#include <kwinglobals.h>
class QAction;
namespace KWin
{
/**
* @brief Qml export for reserving a Screen Edge.
*
* The edge is controlled by the @c enabled property and the @c edge
2019-01-12 10:31:32 +00:00
* property. If the edge is enabled and gets triggered the @ref activated()
* signal gets emitted.
*
* Example usage:
* @code
* ScreenEdgeItem {
* edge: ScreenEdgeItem.LeftEdge
* onActivated: doSomething()
* }
* @endcode
*/
class ScreenEdgeItem : public QObject
{
Q_OBJECT
Q_ENUMS(Edge)
Q_ENUMS(Mode)
/**
* @brief Whether the edge is currently enabled, that is reserved. Default value is @c true.
*/
Q_PROPERTY(bool enabled READ isEnabled WRITE setEnabled NOTIFY enabledChanged)
/**
* @brief Which of the screen edges is to be reserved. Default value is @c NoEdge.
*/
Q_PROPERTY(Edge edge READ edge WRITE setEdge NOTIFY edgeChanged)
/**
* @brief The operation mode for this edge. Default value is @c Mode::Pointer
*/
Q_PROPERTY(Mode mode READ mode WRITE setMode NOTIFY modeChanged)
public:
enum Edge {
TopEdge,
TopRightEdge,
RightEdge,
BottomRightEdge,
BottomEdge,
BottomLeftEdge,
LeftEdge,
TopLeftEdge,
EDGE_COUNT,
NoEdge
};
/**
* Enum describing the operation modes of the edge.
*/
enum class Mode {
Pointer,
Touch
};
explicit ScreenEdgeItem(QObject *parent = nullptr);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~ScreenEdgeItem() override;
bool isEnabled() const;
Edge edge() const;
Mode mode() const {
return m_mode;
}
public Q_SLOTS:
void setEnabled(bool enabled);
void setEdge(Edge edge);
void setMode(Mode mode);
Q_SIGNALS:
void enabledChanged();
void edgeChanged();
void modeChanged();
void activated();
private Q_SLOTS:
bool borderActivated(ElectricBorder edge);
private:
void enableEdge();
void disableEdge();
bool m_enabled;
Edge m_edge;
Mode m_mode = Mode::Pointer;
QAction *m_action;
};
inline bool ScreenEdgeItem::isEnabled() const
{
return m_enabled;
}
inline ScreenEdgeItem::Edge ScreenEdgeItem::edge() const
{
return m_edge;
}
} // namespace KWin
#endif // KWIN_SCREENEDGEITEM_H