kwin/plugins/scenes/xrender/CMakeLists.txt

set(SCENE_XRENDER_SRCS scene_xrender.cpp)

include(ECMQtDeclareLoggingCategory)
ecm_qt_declare_logging_category(
    SCENE_XRENDER_SRCS HEADER
        logging.h
    IDENTIFIER
        KWIN_XRENDER
    CATEGORY_NAME
        kwin_scene_xrender
    DEFAULT_SEVERITY
        Critical
)

add_library(KWinSceneXRender MODULE ${SCENE_XRENDER_SRCS})
target_link_libraries(KWinSceneXRender
    kwin
)

install(
    TARGETS
        KWinSceneXRender
    DESTINATION
        ${PLUGIN_INSTALL_DIR}/org.kde.kwin.scenes/
)
Move SceneXRender into a plugin Summary: First step for loading the compositor Scenes through plugins. The general idea is that we currently needlessly pull in all the Scenes although only one will be used. E.g. on X11 we pull in QPainter, although they are not compatible. On Wayland we pull in XRender although they are not compatible. Furthermore our current Scene creation strategy is not really fault tolerant and can create situations where we don't get a compositor. E.g on fbdev backend the default settings won't work as it does not support OpenGL. Long term I want to tackle those conceptional problems together: we try to load all plugins supported by the current platform till we have a scene which works. Thus on Wayland we don't end up in a situation where we don't have a working compositor because the configuration is bad. To make this possible the switch statement in the Scene needs to go and needs to be replaced by a for loop iterating over all the available scenes on the platform. If we go there it makes sense to replace it directly with a plugin based approach. So this is a change which tackles the problem by first introducing the plugin loading. The xrender based scene (as it's the most simple one) is moved into a plugin. It is first tried to find a scene plugin and only if there is none the existing code is used. Test Plan: Tested all scenes Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7232 2017-08-10 16:13:42 +00:00			`set(SCENE_XRENDER_SRCS scene_xrender.cpp)`

			`include(ECMQtDeclareLoggingCategory)`
			`ecm_qt_declare_logging_category(`
			`SCENE_XRENDER_SRCS HEADER`
			`logging.h`
			`IDENTIFIER`
			`KWIN_XRENDER`
			`CATEGORY_NAME`
			`kwin_scene_xrender`
			`DEFAULT_SEVERITY`
			`Critical`
			`)`

			`add_library(KWinSceneXRender MODULE ${SCENE_XRENDER_SRCS})`
			`target_link_libraries(KWinSceneXRender`
			`kwin`
			`)`

			`install(`
			`TARGETS`
			`KWinSceneXRender`
			`DESTINATION`
			`${PLUGIN_INSTALL_DIR}/org.kde.kwin.scenes/`
			`)`