yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/integration/CMakeLists.txt

170 lines
9 KiB
CMake
Raw Normal View History

Support for syncing the clipboard from X11 to Wayland and vice versa Summary: The clipboard sync is done by a dedicated helper binary launched by KWin. This helper binary is forced to xcb platform to piggy-back on Qt's implementation of the X11 clipboard. In addition it implements the Wayland clipboard - which is much simpler. Reading the Wayland clipboard is based on the implementation in QtWayland. KWin internally knows the DataDeviceInterface belonging to the helper application. Whenever an xwayland client is focussed, this DataDevice is allowed to set the selection and KWin manually updates the current selection in the SeatInterface. By that the sync from X11 to Wayland is implemented. When afterwards a Wayland client is selected, it's sent the current selection which references the X clipboard and a data transfer can be initiated in the normal Wayland way. For the other direction KWin sends the current selection to the helper's DataDevice whenever an xwayland window is focused. The helper application reads the Wayland clipboard and sets it on the X11 clipboard. Thus the Wayland clipboard is synced to X11. The approach used here will also be useful for implementing a clipboard manager (aka klipper). Currently the implementation is not yet fully completed. We need to make sure that the helper application gets restarted in case of a crash. Test Plan: See added test case Reviewers: #plasma_on_wayland, #kwin Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D1973
2016-06-20 09:21:16 +00:00
add_subdirectory(helper)
[wayland] Honor ShellSurfaceInterface::acceptsKeyboardFocus in ::wantsInput If the surface indicates that it doesn't want keyboard focus we shouldn't give it keyboard focus. This was a problem with Kate's autocompletion tool tip windows. REVIEW: 125553
2015-10-07 17:06:34 +00:00
autotests: Make test framework a static lib again Static plugins being linked with shared libraries doesn't work smoothly. POSITION_INDEPENDENT_CODE target property needs to be set for every such plugin. However, there can be targets that we have no control over, which need POSITION_INDEPENDENT_CODE to be set too. Asking such projects to add this property and them refusing to do so would be reasonable because kwin's entire static plugin pipeline is weird. The test framework was made a shared library because kwin build directory used to get really big (in 10s of gigabytes). Due to the -fPIC issues, this change makes the test framework a static lib again. Obviously, this brings back the big build directory problem. But, it's not as terrible as it used to be. With this change, kwin build directory is a couple of gigabytes in debug build, which is a lot but not as bad as it used to be before.
2023-06-20 18:38:36 +00:00
add_library(KWinIntegrationTestFramework STATIC)
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
Generate wayland code with PRIVATE_CODE
2024-08-14 08:46:19 +00:00
if (Qt6_VERSION VERSION_GREATER_EQUAL "6.8.0")
set(private_code_option "PRIVATE_CODE")
endif()
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
qt6_generate_wayland_protocol_client_sources(KWinIntegrationTestFramework
Generate wayland code with PRIVATE_CODE
2024-08-14 08:46:19 +00:00
${private_code_option}
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
NO_INCLUDE_CORE_ONLY
FILES
${WaylandProtocols_DATADIR}/unstable/input-method/input-method-unstable-v1.xml
)
qt6_generate_wayland_protocol_client_sources(KWinIntegrationTestFramework
Generate wayland code with PRIVATE_CODE
2024-08-14 08:46:19 +00:00
${private_code_option}
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
FILES
${WaylandProtocols_DATADIR}/unstable/text-input/text-input-unstable-v3.xml
wayland: Fix none keyboard interactivity in LayerShellV1Window Window::acceptsFocus() is not taken into account when a window is activated using Workspace::activateWindow(). The main reason is because of different input models on X11. Instead, Window::takeFocus() should check itself if the window accepts focus.
2023-10-26 14:03:27 +00:00
${CMAKE_SOURCE_DIR}/src/wayland/protocols/wlr-layer-shell-unstable-v1.xml
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
${WaylandProtocols_DATADIR}/stable/xdg-shell/xdg-shell.xml
${WaylandProtocols_DATADIR}/unstable/xdg-decoration/xdg-decoration-unstable-v1.xml
${WaylandProtocols_DATADIR}/unstable/idle-inhibit/idle-inhibit-unstable-v1.xml
wayland: Pass private-code to waylandscanner The main goal is to avoid leaking our private xyz_interface objects.
2024-08-12 12:10:14 +00:00
${WaylandProtocols_DATADIR}/unstable/tablet/tablet-unstable-v2.xml
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
${WaylandProtocols_DATADIR}/staging/fractional-scale/fractional-scale-v1.xml
wayland: Implement cursor-shape-v1 References: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/194
2023-05-05 11:14:34 +00:00
${WaylandProtocols_DATADIR}/staging/cursor-shape/cursor-shape-v1.xml
Support SecurityContextManagerV1 This allows KWin to securely identify the client for a given connection, without relying on the process name. This patch does not do anything meaningful with the application ID other than store it. This first version does not support kwin restarts, it can come afterwards. Testing done: With latest flatpak, running `WAYLAND_DEBUG=1 flatpak run org.telegram.desktop |& grep security` shows that flatpak itself bound the security context, and the client did not see it advertised.
2023-11-13 09:51:28 +00:00
${WaylandProtocols_DATADIR}/staging/security-context/security-context-v1.xml
wayland: remove workaround for xdg-dialog base name with wayland-protocols <= 1.35 We require 1.36 now, so the workaround is no longer necessary
2024-05-07 15:03:58 +00:00
${WaylandProtocols_DATADIR}/staging/xdg-dialog/xdg-dialog-v1.xml
Support SecurityContextManagerV1 This allows KWin to securely identify the client for a given connection, without relying on the process name. This patch does not do anything meaningful with the application ID other than store it. This first version does not support kwin restarts, it can come afterwards. Testing done: With latest flatpak, running `WAYLAND_DEBUG=1 flatpak run org.telegram.desktop |& grep security` shows that flatpak itself bound the security context, and the client did not see it advertised.
2023-11-13 09:51:28 +00:00
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
${PLASMA_WAYLAND_PROTOCOLS_DIR}/kde-output-device-v2.xml
${PLASMA_WAYLAND_PROTOCOLS_DIR}/kde-output-management-v2.xml
wayland: Implement kde-screen-edge-v1 It's needed to port the plasma panel to the layer shell protocol.
2023-03-08 08:07:39 +00:00
${PLASMA_WAYLAND_PROTOCOLS_DIR}/kde-screen-edge-v1.xml
screencasting: Add an autotest Adds an autotest that makes sure a screencasting stream works as expected. Adds an optional dependency to KPipeWire only effective to run the test.
2023-02-21 02:37:30 +00:00
${PLASMA_WAYLAND_PROTOCOLS_DIR}/zkde-screencast-unstable-v1.xml
backends/fakeinput: Implement fake input protocol in backend The interface is redundant now since there's an abstract input backend abstraction.
2023-09-21 13:35:41 +00:00
${PLASMA_WAYLAND_PROTOCOLS_DIR}/fake-input.xml
Remove Qt 5 specific code
2023-02-25 20:21:59 +00:00
)
autotests: Port KWinFrameworkIntegration from source vars to target based apis
2022-04-22 10:38:30 +00:00
target_sources(KWinIntegrationTestFramework PRIVATE
generic_scene_opengl_test.cpp
kwin_wayland_test.cpp
test_helpers.cpp
)
wayland: Link statically KGlobalAccel integration plugin Without the KGlobalAccel integration plugin, Wayland experience will be negatively affected. Therefore it makes little sense to load it at run- time.
2020-11-21 10:16:59 +00:00
target_link_libraries(KWinIntegrationTestFramework
autotests: Use a shared library for the integration test framework Ever since the effects were changed to static, each test of the integration tests includes all the effects. The result of this is that when doing a debug build each test is now 60MiB or more. With the amount of tests, this results in ~8 GiB of diskspace used just for KWin's binary output directory, which is rather excessive. Since the tests all share a common framework library, we can change that library to a shared library and that way avoid linking all the effects into each test. Most of this is shuffling around some link libraries in the integration test CMakeLists, however, I needed to export the Xwayland class as it is used by one of the tests but wasn't exported.
2021-11-29 13:47:16 +00:00
PUBLIC
Qt::Test
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
Qt::Concurrent
Port to renamed kwayland https://invent.kde.org/plasma/kwayland/-/merge_requests/107 use renamed kwayland
2023-11-23 19:34:24 +00:00
Plasma::KWaylandClient
autotests: Use a shared library for the integration test framework Ever since the effects were changed to static, each test of the integration tests includes all the effects. The result of this is that when doing a debug build each test is now 60MiB or more. With the amount of tests, this results in ~8 GiB of diskspace used just for KWin's binary output directory, which is rather excessive. Since the tests all share a common framework library, we can change that library to a shared library and that way avoid linking all the effects into each test. Most of this is shuffling around some link libraries in the integration test CMakeLists, however, I needed to export the Xwayland class as it is used by one of the tests but wasn't exported.
2021-11-29 13:47:16 +00:00
Wayland::Client
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
Libdrm::Libdrm
autotests: Use a shared library for the integration test framework Ever since the effects were changed to static, each test of the integration tests includes all the effects. The result of this is that when doing a debug build each test is now 60MiB or more. With the amount of tests, this results in ~8 GiB of diskspace used just for KWin's binary output directory, which is rather excessive. Since the tests all share a common framework library, we can change that library to a shared library and that way avoid linking all the effects into each test. Most of this is shuffling around some link libraries in the integration test CMakeLists, however, I needed to export the Xwayland class as it is used by one of the tests but wasn't exported.
2021-11-29 13:47:16 +00:00
kwin
wayland: Link statically KGlobalAccel integration plugin Without the KGlobalAccel integration plugin, Wayland experience will be negatively affected. Therefore it makes little sense to load it at run- time.
2020-11-21 10:16:59 +00:00
autotests: Use a shared library for the integration test framework Ever since the effects were changed to static, each test of the integration tests includes all the effects. The result of this is that when doing a debug build each test is now 60MiB or more. With the amount of tests, this results in ~8 GiB of diskspace used just for KWin's binary output directory, which is rather excessive. Since the tests all share a common framework library, we can change that library to a shared library and that way avoid linking all the effects into each test. Most of this is shuffling around some link libraries in the integration test CMakeLists, however, I needed to export the Xwayland class as it is used by one of the tests but wasn't exported.
2021-11-29 13:47:16 +00:00
PRIVATE
# Static plugins
KWinQpaPlugin
Port to KF6
2023-02-24 18:22:37 +00:00
KF6WindowSystemKWinPlugin
KF6IdleTimeKWinPlugin
wayland: Link statically KGlobalAccel integration plugin Without the KGlobalAccel integration plugin, Wayland experience will be negatively affected. Therefore it makes little sense to load it at run- time.
2020-11-21 10:16:59 +00:00
)
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
if(KWIN_BUILD_X11)
target_link_libraries(KWinIntegrationTestFramework PRIVATE KWinXwaylandServerModule)
endif()
Allow building KWin without KGlobalAccel Signed-off-by: Falko Becker <falko.becker@mbition.io>
2023-11-20 22:28:23 +00:00
if(TARGET KF6GlobalAccelKWinPlugin)
target_link_libraries(KWinIntegrationTestFramework PUBLIC KF6GlobalAccelKWinPlugin)
endif()
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
if(TARGET PW::KScreenLocker)
target_link_libraries(KWinIntegrationTestFramework PUBLIC PW::KScreenLocker)
endif()
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
function(integrationTest)
autotests: Make test framework a static lib again Static plugins being linked with shared libraries doesn't work smoothly. POSITION_INDEPENDENT_CODE target property needs to be set for every such plugin. However, there can be targets that we have no control over, which need POSITION_INDEPENDENT_CODE to be set too. Asking such projects to add this property and them refusing to do so would be reasonable because kwin's entire static plugin pipeline is weird. The test framework was made a shared library because kwin build directory used to get really big (in 10s of gigabytes). Due to the -fPIC issues, this change makes the test framework a static lib again. Obviously, this brings back the big build directory problem. But, it's not as terrible as it used to be. With this change, kwin build directory is a couple of gigabytes in debug build, which is a lot but not as bad as it used to be before.
2023-06-20 18:38:36 +00:00
set(optionArgs BUILTIN_EFFECTS)
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
set(oneValueArgs NAME)
set(multiValueArgs SRCS LIBS)
[autotests] Support Wayland Only in addition to XWayland The integrationTest function takes a new optional argument whether the test supports a Wayland Only mode. If that's the case the test is compiled twice, once (as always) as "foo" with XWayland support and once as "foo_waylandonly" without XWayland support. This way we can ensure that our code always supports both modes. The tests found multiple issues. At the moment fast running tests are sporadically crashing on tear down. This needs further investigation.
2017-09-30 14:35:52 +00:00
cmake_parse_arguments(ARGS "${optionArgs}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
if (NOT KWIN_BUILD_X11 AND ARGS_LIBS MATCHES XCB::)
return()
endif()
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
add_executable(${ARGS_NAME} ${ARGS_SRCS})
autotests: Use a shared library for the integration test framework Ever since the effects were changed to static, each test of the integration tests includes all the effects. The result of this is that when doing a debug build each test is now 60MiB or more. With the amount of tests, this results in ~8 GiB of diskspace used just for KWin's binary output directory, which is rather excessive. Since the tests all share a common framework library, we can change that library to a shared library and that way avoid linking all the effects into each test. Most of this is shuffling around some link libraries in the integration test CMakeLists, however, I needed to export the Xwayland class as it is used by one of the tests but wasn't exported.
2021-11-29 13:47:16 +00:00
target_link_libraries(${ARGS_NAME} KWinIntegrationTestFramework Qt::Test ${ARGS_LIBS})
autotests: Make test framework a static lib again Static plugins being linked with shared libraries doesn't work smoothly. POSITION_INDEPENDENT_CODE target property needs to be set for every such plugin. However, there can be targets that we have no control over, which need POSITION_INDEPENDENT_CODE to be set too. Asking such projects to add this property and them refusing to do so would be reasonable because kwin's entire static plugin pipeline is weird. The test framework was made a shared library because kwin build directory used to get really big (in 10s of gigabytes). Due to the -fPIC issues, this change makes the test framework a static lib again. Obviously, this brings back the big build directory problem. But, it's not as terrible as it used to be. With this change, kwin build directory is a couple of gigabytes in debug build, which is a lot but not as bad as it used to be before.
2023-06-20 18:38:36 +00:00
if(${ARGS_BUILTIN_EFFECTS})
Adjust to changed signature of kcoreaddons_target_static_plugins Depends on https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/360
2023-08-27 10:09:56 +00:00
kcoreaddons_target_static_plugins(${ARGS_NAME} NAMESPACE "kwin/effects/plugins")
autotests: Make test framework a static lib again Static plugins being linked with shared libraries doesn't work smoothly. POSITION_INDEPENDENT_CODE target property needs to be set for every such plugin. However, there can be targets that we have no control over, which need POSITION_INDEPENDENT_CODE to be set too. Asking such projects to add this property and them refusing to do so would be reasonable because kwin's entire static plugin pipeline is weird. The test framework was made a shared library because kwin build directory used to get really big (in 10s of gigabytes). Due to the -fPIC issues, this change makes the test framework a static lib again. Obviously, this brings back the big build directory problem. But, it's not as terrible as it used to be. With this change, kwin build directory is a couple of gigabytes in debug build, which is a lot but not as bad as it used to be before.
2023-06-20 18:38:36 +00:00
endif()
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-${ARGS_NAME} COMMAND dbus-run-session ${CMAKE_BINARY_DIR}/bin/${ARGS_NAME})
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
endfunction()
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
if(KWIN_BUILD_X11)
integrationTest(NAME testDontCrashGlxgears SRCS dont_crash_glxgears.cpp LIBS KF6::I18n KDecoration2::KDecoration)
endif()
Add KWIN_BUILD_SCREENLOCKER option Allows to build KWin without lockscreen support and thus drops the kscreenlocker dependency. Signed-off-by: Eike Hein <eike.hein@mbition.io>
2022-02-23 13:27:05 +00:00
if (KWIN_BUILD_SCREENLOCKER)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testLockScreen SRCS lockscreen.cpp LIBS KF6::GlobalAccel)
Add KWIN_BUILD_SCREENLOCKER option Allows to build KWin without lockscreen support and thus drops the kscreenlocker dependency. Signed-off-by: Eike Hein <eike.hein@mbition.io>
2022-02-23 13:27:05 +00:00
endif()
Implement bounce keys on Wayland Bouce keys suppresses additional key presses during a given interval This is used by people with motor impairments or bad keyboards It works by remembering the last input timestamp for a key If an event's timestamp is too close to the last timestamp for that key the event is rejected BUG: 474752
2023-11-23 13:07:35 +00:00
integrationTest(NAME testBounceKeys SRCS bounce_keys_test.cpp)
buttonrebinds: Introduce tests Should help make sure the rebind feature stays working.
2024-03-11 01:27:14 +00:00
integrationTest(NAME testButtonRebind SRCS buttonrebind_test.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testDecorationInput SRCS decoration_input_test.cpp LIBS KDecoration2::KDecoration KDecoration2::KDecoration2Private)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testInternalWindow SRCS internal_window.cpp)
integrationTest(NAME testTouchInput SRCS touch_input_test.cpp)
integrationTest(NAME testInputStackingOrder SRCS input_stacking_order.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testPointerInput SRCS pointer_input.cpp LIBS Libdrm::Libdrm XCB::ICCCM)
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
integrationTest(NAME testPlatformCursor SRCS platformcursor.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testDontCrashCancelAnimation SRCS dont_crash_cancel_animation.cpp LIBS KDecoration2::KDecoration)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testTransientPlacement SRCS transient_placement.cpp)
[autotests/integration] Simplify the cmake for creating a test Summary: A dedicated cmake function is added to create a test case. It takes a NAME, the SRCS and additional LIBS. Thus it's integrationTest(NAME myTestCase SRCS test.cpp) to create a standard integration test. In addition kwin_wayland_test.cpp is compiled into a static library to decrease the compile time a little bit. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2052
2016-06-30 06:37:50 +00:00
integrationTest(NAME testDebugConsole SRCS debug_console_test.cpp)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testPlasmaSurface SRCS plasma_surface_test.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testMaximized SRCS maximize_test.cpp LIBS KDecoration2::KDecoration KF6::Package)
integrationTest(NAME testXdgShellWindow SRCS xdgshellwindow_test.cpp LIBS KDecoration2::KDecoration)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testSceneOpenGL SRCS scene_opengl_test.cpp )
integrationTest(NAME testSceneOpenGLES SRCS scene_opengl_es_test.cpp )
integrationTest(NAME testScreenChanges SRCS screen_changes_test.cpp)
autotests: Guard tabbox_test by KWIN_BUILD_TABBOX Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2022-03-03 14:20:20 +00:00
if (KWIN_BUILD_TABBOX)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testTabBox SRCS tabbox_test.cpp)
autotests: Guard tabbox_test by KWIN_BUILD_TABBOX Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2022-03-03 14:20:20 +00:00
endif()
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testWindowSelection SRCS window_selection_test.cpp)
integrationTest(NAME testPointerConstraints SRCS pointer_constraints_test.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testKeyboardLayout SRCS keyboard_layout_test.cpp LIBS KF6::GlobalAccel XKB::XKB)
integrationTest(NAME testKeymapCreationFailure SRCS keymap_creation_failure_test.cpp LIBS KF6::GlobalAccel)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testShowingDesktop SRCS showing_desktop_test.cpp)
Link KI18n with libkwin privately
2023-10-24 21:30:03 +00:00
integrationTest(NAME testDontCrashUseractionsMenu SRCS dont_crash_useractions_menu.cpp LIBS KF6::I18n)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testLayerShellV1Window SRCS layershellv1window_test.cpp)
integrationTest(NAME testVirtualDesktop SRCS virtual_desktop_test.cpp)
integrationTest(NAME testXdgShellWindowRules SRCS xdgshellwindow_rules_test.cpp)
integrationTest(NAME testIdleInhibition SRCS idle_inhibition_test.cpp)
autotests: Make test framework a static lib again Static plugins being linked with shared libraries doesn't work smoothly. POSITION_INDEPENDENT_CODE target property needs to be set for every such plugin. However, there can be targets that we have no control over, which need POSITION_INDEPENDENT_CODE to be set too. Asking such projects to add this property and them refusing to do so would be reasonable because kwin's entire static plugin pipeline is weird. The test framework was made a shared library because kwin build directory used to get really big (in 10s of gigabytes). Due to the -fPIC issues, this change makes the test framework a static lib again. Obviously, this brings back the big build directory problem. But, it's not as terrible as it used to be. With this change, kwin build directory is a couple of gigabytes in debug build, which is a lot but not as bad as it used to be before.
2023-06-20 18:38:36 +00:00
integrationTest(NAME testDontCrashReinitializeCompositor SRCS dont_crash_reinitialize_compositor.cpp BUILTIN_EFFECTS)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testNoGlobalShortcuts SRCS no_global_shortcuts_test.cpp LIBS KF6::GlobalAccel)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testPlacement SRCS placement_test.cpp)
activation: fix X11 windows being stuck in should_get_focus more properly amends d01e20b6a9b455c209fea0e1e4eba7976a8a051f, and adds an autotest for the bug
2024-07-30 15:50:54 +00:00
integrationTest(NAME testActivation SRCS activation_test.cpp LIBS XCB::ICCCM)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testInputMethod SRCS inputmethod_test.cpp LIBS XKB::XKB)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testScreens SRCS screens_test.cpp)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testScreenEdges SRCS screenedges_test.cpp LIBS XCB::ICCCM)
autotests: add Xwayland scale changes to the output changes test CCBUG: 487409
2024-06-12 14:16:54 +00:00
integrationTest(NAME testOutputChanges SRCS outputchanges_test.cpp LIBS XCB::ICCCM)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testTiles SRCS tiles_test.cpp)
integrationTest(NAME testFractionalScaling SRCS fractional_scaling_test.cpp)
Drop XCB_ICCCM_FOUND checks Qt requires xcb-icccm 0.3.9. On the other hand, 0.3.9 contains all the types and functions used by kwin, so remove the corresponding XCB_ICCM_FOUND checks to simplify the code.
2023-05-02 12:06:17 +00:00
integrationTest(NAME testMoveResize SRCS move_resize_window_test.cpp LIBS XCB::ICCCM)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testStruts SRCS struts_test.cpp LIBS XCB::ICCCM KDecoration2::KDecoration)
integrationTest(NAME testShade SRCS shade_test.cpp LIBS XCB::ICCCM KDecoration2::KDecoration)
integrationTest(NAME testDontCrashAuroraeDestroyDeco SRCS dont_crash_aurorae_destroy_deco.cpp LIBS XCB::ICCCM KDecoration2::KDecoration)
Drop XCB_ICCCM_FOUND checks Qt requires xcb-icccm 0.3.9. On the other hand, 0.3.9 contains all the types and functions used by kwin, so remove the corresponding XCB_ICCM_FOUND checks to simplify the code.
2023-05-02 12:06:17 +00:00
integrationTest(NAME testPlasmaWindow SRCS plasmawindow_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testX11DesktopWindow SRCS desktop_window_x11_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testXwaylandInput SRCS xwayland_input_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testWindowRules SRCS window_rules_test.cpp LIBS XCB::ICCCM)
Revert "Temporarily disable testXkb and testX11Window" This reverts commit 6bad553f05f459cd0f0d206db22215f1b049ddcc
2023-11-01 17:26:45 +00:00
integrationTest(NAME testX11Window SRCS x11_window_test.cpp LIBS XCB::ICCCM)
Install KWaylandServer headers There are use cases for the headers to be used, e.g. when implementing wayland-specific workflows from an Effect. In order to be able to use these, we also need to expose libkwin to be imported as it carries the interfaces' symbols. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-06-19 11:19:29 +00:00
integrationTest(NAME testQuickTiling SRCS quick_tiling_test.cpp LIBS XCB::ICCCM KDecoration2::KDecoration)
Drop XCB_ICCCM_FOUND checks Qt requires xcb-icccm 0.3.9. On the other hand, 0.3.9 contains all the types and functions used by kwin, so remove the corresponding XCB_ICCM_FOUND checks to simplify the code.
2023-05-02 12:06:17 +00:00
integrationTest(NAME testStackingOrder SRCS stacking_order_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testDbusInterface SRCS dbus_interface_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testXwaylandServerCrash SRCS xwaylandserver_crash_test.cpp LIBS XCB::ICCCM)
integrationTest(NAME testXwaylandServerRestart SRCS xwaylandserver_restart_test.cpp LIBS XCB::ICCCM)
backends/fakeinput: Implement fake input protocol in backend The interface is redundant now since there's an abstract input backend abstraction.
2023-09-21 13:35:41 +00:00
integrationTest(NAME testFakeInput SRCS fakeinput_test.cpp)
Support SecurityContextManagerV1 This allows KWin to securely identify the client for a given connection, without relying on the process name. This patch does not do anything meaningful with the application ID other than store it. This first version does not support kwin restarts, it can come afterwards. Testing done: With latest flatpak, running `WAYLAND_DEBUG=1 flatpak run org.telegram.desktop |& grep security` shows that flatpak itself bound the security context, and the client did not see it advertised.
2023-11-13 09:51:28 +00:00
integrationTest(NAME testSecurityContext SRCS security_context_test.cpp)
Implement locking sticky keys on Wayland When pressing a latched modifier a second time lock it When pressing a locked modifier release it BUG: 464452
2023-11-23 08:17:00 +00:00
integrationTest(NAME testStickyKeys SRCS sticky_keys_test.cpp)
Make Workspace::desktopResized() reassign outputs of uninitialized windows If an output is deleted, the Workspace::desktopResized() is going to re-assign windows to the new outputs. It is done so so the workspace re-arrangement procedure is deterministic and has concrete order. However, with the current Window lifecycle management, it's possible to encounter the follwing case: - xdg_toplevel gets created on output A - xdg_toplevel initial state is committed - output A is removed - a wl_buffer is attached to the xdg_toplevel, which results in a geometry change and an output change - Window::setMoveResizeOutput() is called, but the previous output is a dangling pointer CCBUG: 489632
2024-07-22 12:11:25 +00:00
integrationTest(NAME testWorkspace SRCS workspace_test.cpp)
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
if(KWIN_BUILD_X11)
integrationTest(NAME testDontCrashEmptyDeco SRCS dont_crash_empty_deco.cpp LIBS KDecoration2::KDecoration)
integrationTest(NAME testXwaylandSelections SRCS xwayland_selections_test.cpp)
integrationTest(NAME testXinerama SRCS xinerama_test.cpp)
xwayland: Add unit test for XWayland key tracking
2024-02-27 14:02:20 +00:00
integrationTest(NAME testX11KeyRead SRCS x11keyread.cpp LIBS XCB::XINPUT)
Make it possible to build KWin without libxcb Now that we have Wayland around, there's a whole branch of dependencies that shouldn't be necessary anymore. This allows to build KWin without all of it, allowing us to have a much more compact alignment for cases where all the legacy software isn't necessary anymore. Bundle KWindowSystem X11-specific headers into it too, since it's part of the same process. Signed-off-by: Victoria Fischer <victoria.fischer@mbition.io>
2023-12-15 16:58:46 +00:00
endif()
[autotest/wayland] Add a test for quick tiling Wayland clients Base test verifies the quick tile positions. No maximization or direct state changes tested yet. Required to have Toplevel and AbstractClient exported. Otherwise we cannot use the SignalSpy.
2015-10-14 07:58:16 +00:00
Use version-less qt DBus macros They work with both Qt5 and Qt6
2021-05-30 23:00:35 +00:00
qt_add_dbus_interfaces(DBUS_SRCS ${CMAKE_BINARY_DIR}/src/org.kde.kwin.VirtualKeyboard.xml)
autotests: Remove WAYLAND_ONLY tests WAYLAND_ONLY will create two tests: one with Xwayland, the other without Xwayland. This is somewhat wasteful and it results in higher CI times. On the other hand, Xwayland is started on demand. If a test doesn't need Xwayland, it won't start. So let's remove WAYLAND_ONLY in order to lighten kwin on CI resources. If wayland only tests are needed, we can consider passing the operation mode to the WAYLANDTEST_MAIN helper, but there aren't such tests afaik.
2023-04-21 11:07:49 +00:00
integrationTest(NAME testVirtualKeyboardDBus SRCS test_virtualkeyboard_dbus.cpp ${DBUS_SRCS})
Introduce ColorManager component This change introduces a new component - ColorManager that is responsible for color management stuff. At the moment, it's very naive. It is useful only for updating gamma ramps. But in the future, it will be extended with more CMS-related features. The ColorManager depends on lcms2 library. This is an optional dependency. If lcms2 is not installed, the color manager won't be built. This also fixes the issue where colord and nightcolor overwrite each other's gamma ramps. With this change, the ColorManager will resolve the conflict between two.
2020-11-27 19:37:40 +00:00
Allow building KWin without KGlobalAccel Signed-off-by: Falko Becker <falko.becker@mbition.io>
2023-11-20 22:28:23 +00:00
if (KWIN_BUILD_GLOBALSHORTCUTS)
integrationTest(NAME testGlobalShortcuts SRCS globalshortcuts_test.cpp LIBS XCB::ICCCM KF6::GlobalAccel KF6::I18n XKB::XKB)
integrationTest(NAME testKWinBindings SRCS kwinbindings_test.cpp LIBS KF6::I18n)
endif()
Drop XCB_ICCCM_FOUND checks Qt requires xcb-icccm 0.3.9. On the other hand, 0.3.9 contains all the types and functions used by kwin, so remove the corresponding XCB_ICCM_FOUND checks to simplify the code.
2023-05-02 12:06:17 +00:00
if (TARGET K::KPipeWire)
integrationTest(NAME testScreencasting SRCS screencasting_test.cpp LIBS K::KPipeWire)
endif()
[autotests/integration] Add a first test case for activities Verifies the condition from D1982 with expected_fail. That is sets a Client on non existing activities and expects that it should be on all activities.
2016-08-12 10:52:47 +00:00
Drop XCB_ICCCM_FOUND checks Qt requires xcb-icccm 0.3.9. On the other hand, 0.3.9 contains all the types and functions used by kwin, so remove the corresponding XCB_ICCM_FOUND checks to simplify the code.
2023-05-02 12:06:17 +00:00
if (KWIN_BUILD_ACTIVITIES)
Adjust to renamed activities libraries
2023-11-23 20:48:01 +00:00
integrationTest(NAME testActivities SRCS activities_test.cpp LIBS XCB::ICCCM Plasma::Activities)
Conditionally compile tests which depend on XCB_ICCCM Summary: Move/Resize and Strut tests Wayland tests are affected. Test Plan: Successful compilation when XCB_ICCCM is not found Reviewers: graesslin Reviewed By: graesslin Subscribers: plasma-devel Projects: #plasma Differential Revision: https://phabricator.kde.org/D1476
2016-04-25 09:27:00 +00:00
endif()
[autotest/integration] Add a test case for screenedge usage in Scripts A new sub-directory scripting is added in autotests/integration to gather all test cases related to scripting. The first added test case verifies the activation of screen edges. For that it loads a helper script, which reserves an edge based on config. When the edge is triggered showing desktop is activated.
2016-08-02 07:12:57 +00:00
add_subdirectory(scripting)
Ensure that EffectsHandlerImpl::slotClientShown is only invoked once per Window Summary: This fixes a regression introduced with a1afeded6ae63e47d39fc08480e929c0451c51e8. The connections were setup every the windowShown signal got emitted. This caused effects to get multiple singals and start multiple animations which then do not get cancelled correctly. The incorrect behavior was most visible in the translucency effect which did not cancel the move animation and the window stayed translucent. BUG: 366081 Test Plan: New test case which simulates the behavior of the translucency effect. Reviewers: #kwin, #plasma, sebas Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2346
2016-08-03 14:12:23 +00:00
add_subdirectory(effects)
[scenes/opengl] Fix overlapping shadow tiles Summary: This problem appears if shadow corner tiles are too big and some window has size smaller than 2 * shadowTileSize. This change tries to address the problem above by exclusing overlapping tile parts. If there are any two overlapping corners then tile between them(top/right/bottom/left) is not rendered. Also, because some corner tile parts can be excluded, corner tiles are expected to be symmetrical(i.e. if we remove right half from the top-left tile and left half from the top-right tile and stick them together, they still look fine, there are no misalignments, etc). Most shadows(e.g. shadows from Breeze) have such behaviour. No tiles are overlapping {F5728514, layout=center, size=full} Overlapping tiles {F5728516, layout=center, size=full} And this is how it supposed to be {F5728517, layout=center, size=full} Test Plan: * apply D11069 to Breeze * in System Settings/Application Style/Window Decorations, choose "Very Large" shadow size * open Konsole * resize it to a minimum possible size Reviewers: #kwin, graesslin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, ngraham, anemeth, abetts, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D10811
2018-06-07 08:48:05 +00:00
add_subdirectory(fakes)
Reference in a new issue Copy permalink