2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2016-02-04 10:18:45 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
2016-02-04 10:18:45 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2016-02-04 10:18:45 +00:00
|
|
|
#include "kwin_wayland_test.h"
|
|
|
|
#include "abstract_client.h"
|
2021-08-31 07:03:05 +00:00
|
|
|
#include "abstract_output.h"
|
2016-02-04 10:18:45 +00:00
|
|
|
#include "cursor.h"
|
2019-08-26 07:44:04 +00:00
|
|
|
#include "internal_client.h"
|
|
|
|
#include "platform.h"
|
2016-05-12 08:28:40 +00:00
|
|
|
#include "pointer_input.h"
|
2016-05-12 14:33:03 +00:00
|
|
|
#include "touch_input.h"
|
2016-02-04 10:18:45 +00:00
|
|
|
#include "screenedge.h"
|
|
|
|
#include "screens.h"
|
|
|
|
#include "wayland_server.h"
|
|
|
|
#include "workspace.h"
|
|
|
|
#include <kwineffects.h>
|
2019-06-07 09:55:11 +00:00
|
|
|
|
2016-05-12 08:28:40 +00:00
|
|
|
#include "decorations/decoratedclient.h"
|
2019-06-07 09:55:11 +00:00
|
|
|
#include "decorations/decorationbridge.h"
|
|
|
|
#include "decorations/settings.h"
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
#include <KWayland/Client/connection_thread.h>
|
|
|
|
#include <KWayland/Client/compositor.h>
|
2018-05-01 14:21:12 +00:00
|
|
|
#include <KWayland/Client/keyboard.h>
|
2016-02-04 10:18:45 +00:00
|
|
|
#include <KWayland/Client/pointer.h>
|
|
|
|
#include <KWayland/Client/seat.h>
|
|
|
|
#include <KWayland/Client/shm_pool.h>
|
|
|
|
#include <KWayland/Client/surface.h>
|
|
|
|
|
2016-02-04 13:20:36 +00:00
|
|
|
#include <KDecoration2/Decoration>
|
2019-06-07 09:55:11 +00:00
|
|
|
#include <KDecoration2/DecorationSettings>
|
2016-02-04 13:20:36 +00:00
|
|
|
|
2016-02-04 10:18:45 +00:00
|
|
|
#include <linux/input.h>
|
|
|
|
|
2016-05-12 08:28:40 +00:00
|
|
|
Q_DECLARE_METATYPE(Qt::WindowFrameSection)
|
|
|
|
|
2016-02-04 10:18:45 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_decoration_input-0");
|
|
|
|
|
|
|
|
class DecorationInputTest : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
private Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void init();
|
|
|
|
void cleanup();
|
2016-05-12 08:28:40 +00:00
|
|
|
void testAxis_data();
|
2016-02-04 10:18:45 +00:00
|
|
|
void testAxis();
|
2016-05-12 08:28:40 +00:00
|
|
|
void testDoubleClick_data();
|
2016-02-04 10:56:45 +00:00
|
|
|
void testDoubleClick();
|
2016-05-12 14:33:03 +00:00
|
|
|
void testDoubleTap_data();
|
|
|
|
void testDoubleTap();
|
2016-02-04 13:20:36 +00:00
|
|
|
void testHover();
|
2016-03-11 11:48:01 +00:00
|
|
|
void testPressToMove_data();
|
2016-02-04 14:07:03 +00:00
|
|
|
void testPressToMove();
|
2016-05-12 14:33:03 +00:00
|
|
|
void testTapToMove_data();
|
|
|
|
void testTapToMove();
|
2016-09-15 09:44:32 +00:00
|
|
|
void testResizeOutsideWindow_data();
|
|
|
|
void testResizeOutsideWindow();
|
2017-11-11 11:28:10 +00:00
|
|
|
void testModifierClickUnrestrictedMove_data();
|
|
|
|
void testModifierClickUnrestrictedMove();
|
|
|
|
void testModifierScrollOpacity_data();
|
|
|
|
void testModifierScrollOpacity();
|
2018-02-04 20:21:54 +00:00
|
|
|
void testTouchEvents();
|
2018-05-01 14:21:12 +00:00
|
|
|
void testTooltipDoesntEatKeyEvents();
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
private:
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *showWindow();
|
2016-02-04 10:18:45 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
#define MOTION(target) \
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerMotion(target, timestamp++)
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
#define PRESS \
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerButtonPressed(BTN_LEFT, timestamp++)
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
#define RELEASE \
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerButtonReleased(BTN_LEFT, timestamp++)
|
2016-02-04 10:18:45 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *DecorationInputTest::showWindow()
|
2016-02-04 10:18:45 +00:00
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
|
|
|
#define VERIFY(statement) \
|
|
|
|
if (!QTest::qVerify((statement), #statement, "", __FILE__, __LINE__))\
|
|
|
|
return nullptr;
|
|
|
|
#define COMPARE(actual, expected) \
|
|
|
|
if (!QTest::qCompare(actual, expected, #actual, #expected, __FILE__, __LINE__))\
|
|
|
|
return nullptr;
|
|
|
|
|
2021-09-03 17:54:03 +00:00
|
|
|
KWayland::Client::Surface *surface = Test::createSurface(Test::waylandCompositor());
|
2016-02-04 10:18:45 +00:00
|
|
|
VERIFY(surface);
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
Test::XdgToplevel *shellSurface = Test::createXdgToplevelSurface(surface, Test::CreationSetup::CreateOnly, surface);
|
2016-02-04 10:18:45 +00:00
|
|
|
VERIFY(shellSurface);
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
Test::XdgToplevelDecorationV1 *decoration = Test::createXdgToplevelDecorationV1(shellSurface, shellSurface);
|
|
|
|
VERIFY(decoration);
|
|
|
|
|
|
|
|
QSignalSpy decorationConfigureRequestedSpy(decoration, &Test::XdgToplevelDecorationV1::configureRequested);
|
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
|
|
|
|
decoration->set_mode(Test::XdgToplevelDecorationV1::mode_server_side);
|
|
|
|
surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
|
|
|
VERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
COMPARE(decorationConfigureRequestedSpy.last().at(0).value<Test::XdgToplevelDecorationV1::mode>(), Test::XdgToplevelDecorationV1::mode_server_side);
|
|
|
|
|
2016-02-04 10:18:45 +00:00
|
|
|
// let's render
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2016-07-01 07:54:44 +00:00
|
|
|
auto c = Test::renderAndWaitForShown(surface, QSize(500, 50), Qt::blue);
|
2016-02-04 10:18:45 +00:00
|
|
|
VERIFY(c);
|
2016-07-01 07:54:44 +00:00
|
|
|
COMPARE(workspace()->activeClient(), c);
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
#undef VERIFY
|
|
|
|
#undef COMPARE
|
|
|
|
|
|
|
|
return c;
|
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::initTestCase()
|
|
|
|
{
|
2019-08-26 07:44:04 +00:00
|
|
|
qRegisterMetaType<KWin::AbstractClient *>();
|
|
|
|
qRegisterMetaType<KWin::InternalClient *>();
|
2020-07-07 09:32:29 +00:00
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
|
|
|
QVERIFY(applicationStartedSpy.isValid());
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
2020-12-09 13:06:15 +00:00
|
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
2019-08-26 21:16:53 +00:00
|
|
|
QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
// change some options
|
|
|
|
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
|
|
|
|
config->group(QStringLiteral("MouseBindings")).writeEntry("CommandTitlebarWheel", QStringLiteral("above/below"));
|
2016-02-04 10:56:45 +00:00
|
|
|
config->group(QStringLiteral("Windows")).writeEntry("TitlebarDoubleClickCommand", QStringLiteral("OnAllDesktops"));
|
|
|
|
config->group(QStringLiteral("Desktops")).writeEntry("Number", 2);
|
2016-02-04 10:18:45 +00:00
|
|
|
config->sync();
|
|
|
|
|
|
|
|
kwinApp()->setConfig(config);
|
|
|
|
|
|
|
|
kwinApp()->start();
|
2020-07-07 09:32:29 +00:00
|
|
|
QVERIFY(applicationStartedSpy.wait());
|
2021-08-31 07:03:05 +00:00
|
|
|
const auto outputs = kwinApp()->platform()->enabledOutputs();
|
|
|
|
QCOMPARE(outputs.count(), 2);
|
|
|
|
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
|
|
|
|
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
|
2016-02-04 10:18:45 +00:00
|
|
|
setenv("QT_QPA_PLATFORM", "wayland", true);
|
2021-05-08 00:08:22 +00:00
|
|
|
Test::initWaylandWorkspace();
|
2016-02-04 10:18:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::init()
|
|
|
|
{
|
|
|
|
using namespace KWayland::Client;
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::Seat | Test::AdditionalWaylandInterface::XdgDecorationV1));
|
2016-06-30 11:32:54 +00:00
|
|
|
QVERIFY(Test::waitForWaylandPointer());
|
2016-02-04 10:18:45 +00:00
|
|
|
|
2021-08-28 18:58:29 +00:00
|
|
|
workspace()->setActiveOutput(QPoint(640, 512));
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(QPoint(640, 512));
|
2016-02-04 10:18:45 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::cleanup()
|
|
|
|
{
|
2016-06-30 11:32:54 +00:00
|
|
|
Test::destroyWaylandConnection();
|
2016-02-04 10:18:45 +00:00
|
|
|
}
|
|
|
|
|
2016-05-12 08:28:40 +00:00
|
|
|
void DecorationInputTest::testAxis_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QPoint>("decoPoint");
|
|
|
|
QTest::addColumn<Qt::WindowFrameSection>("expectedSection");
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("topLeft") << QPoint(0, 0) << Qt::TopLeftSection;
|
|
|
|
QTest::newRow("top") << QPoint(250, 0) << Qt::TopSection;
|
|
|
|
QTest::newRow("topRight") << QPoint(499, 0) << Qt::TopRightSection;
|
2016-05-12 08:28:40 +00:00
|
|
|
}
|
|
|
|
|
2016-02-04 10:18:45 +00:00
|
|
|
void DecorationInputTest::testAxis()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-02-04 10:18:45 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
QCOMPARE(c->titlebarPosition(), AbstractClient::PositionTop);
|
|
|
|
QVERIFY(!c->keepAbove());
|
|
|
|
QVERIFY(!c->keepBelow());
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->clientPos().y() / 2));
|
2021-01-28 14:45:57 +00:00
|
|
|
QVERIFY(input()->pointer()->decoration());
|
2016-05-12 08:28:40 +00:00
|
|
|
QCOMPARE(input()->pointer()->decoration()->decoration()->sectionUnderMouse(), Qt::TitleBarArea);
|
2016-02-04 10:18:45 +00:00
|
|
|
|
|
|
|
// TODO: mouse wheel direction looks wrong to me
|
|
|
|
// simulate wheel
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerAxisVertical(5.0, timestamp++);
|
2016-02-04 10:18:45 +00:00
|
|
|
QVERIFY(c->keepBelow());
|
|
|
|
QVERIFY(!c->keepAbove());
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerAxisVertical(-5.0, timestamp++);
|
2016-02-04 10:18:45 +00:00
|
|
|
QVERIFY(!c->keepBelow());
|
|
|
|
QVERIFY(!c->keepAbove());
|
2016-04-07 06:28:35 +00:00
|
|
|
kwinApp()->platform()->pointerAxisVertical(-5.0, timestamp++);
|
2016-02-04 10:18:45 +00:00
|
|
|
QVERIFY(!c->keepBelow());
|
|
|
|
QVERIFY(c->keepAbove());
|
2016-05-12 08:28:40 +00:00
|
|
|
|
|
|
|
// test top most deco pixel, BUG: 362860
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
c->move(QPoint(0, 0));
|
2016-05-12 08:28:40 +00:00
|
|
|
QFETCH(QPoint, decoPoint);
|
|
|
|
MOTION(decoPoint);
|
2021-01-28 14:45:57 +00:00
|
|
|
QVERIFY(input()->pointer()->decoration());
|
2016-05-12 08:28:40 +00:00
|
|
|
QCOMPARE(input()->pointer()->decoration()->client(), c);
|
|
|
|
QTEST(input()->pointer()->decoration()->decoration()->sectionUnderMouse(), "expectedSection");
|
|
|
|
kwinApp()->platform()->pointerAxisVertical(5.0, timestamp++);
|
|
|
|
QVERIFY(!c->keepBelow());
|
|
|
|
QVERIFY(!c->keepAbove());
|
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testDoubleClick_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QPoint>("decoPoint");
|
|
|
|
QTest::addColumn<Qt::WindowFrameSection>("expectedSection");
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("topLeft") << QPoint(0, 0) << Qt::TopLeftSection;
|
|
|
|
QTest::newRow("top") << QPoint(250, 0) << Qt::TopSection;
|
|
|
|
QTest::newRow("topRight") << QPoint(499, 0) << Qt::TopRightSection;
|
2016-02-04 10:18:45 +00:00
|
|
|
}
|
|
|
|
|
2016-02-04 10:56:45 +00:00
|
|
|
void KWin::DecorationInputTest::testDoubleClick()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-02-04 10:56:45 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->clientPos().y() / 2));
|
2016-02-04 10:56:45 +00:00
|
|
|
|
|
|
|
// double click
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
|
|
|
// double click again
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
2016-05-12 08:28:40 +00:00
|
|
|
|
|
|
|
// test top most deco pixel, BUG: 362860
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
c->move(QPoint(0, 0));
|
2016-05-12 08:28:40 +00:00
|
|
|
QFETCH(QPoint, decoPoint);
|
|
|
|
MOTION(decoPoint);
|
2021-01-28 14:45:57 +00:00
|
|
|
QVERIFY(input()->pointer()->decoration());
|
2016-05-12 08:28:40 +00:00
|
|
|
QCOMPARE(input()->pointer()->decoration()->client(), c);
|
|
|
|
QTEST(input()->pointer()->decoration()->decoration()->sectionUnderMouse(), "expectedSection");
|
|
|
|
// double click
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
|
|
|
PRESS;
|
|
|
|
RELEASE;
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
2016-02-04 10:56:45 +00:00
|
|
|
}
|
|
|
|
|
2016-05-12 14:33:03 +00:00
|
|
|
void DecorationInputTest::testDoubleTap_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QPoint>("decoPoint");
|
|
|
|
QTest::addColumn<Qt::WindowFrameSection>("expectedSection");
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("topLeft") << QPoint(10, 10) << Qt::TopLeftSection;
|
|
|
|
QTest::newRow("top") << QPoint(260, 10) << Qt::TopSection;
|
|
|
|
QTest::newRow("topRight") << QPoint(509, 10) << Qt::TopRightSection;
|
2016-05-12 14:33:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void KWin::DecorationInputTest::testDoubleTap()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-05-12 14:33:03 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
const QPoint tapPoint(c->frameGeometry().center().x(), c->clientPos().y() / 2);
|
2016-05-12 14:33:03 +00:00
|
|
|
|
|
|
|
// double tap
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
|
|
|
// double tap again
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
|
|
|
|
|
|
|
// test top most deco pixel, BUG: 362860
|
2018-03-29 16:38:27 +00:00
|
|
|
//
|
|
|
|
// Not directly at (0, 0), otherwise ScreenEdgeInputFilter catches
|
|
|
|
// event before DecorationEventFilter.
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
c->move(QPoint(10, 10));
|
2016-05-12 14:33:03 +00:00
|
|
|
QFETCH(QPoint, decoPoint);
|
|
|
|
// double click
|
|
|
|
kwinApp()->platform()->touchDown(0, decoPoint, timestamp++);
|
2021-01-28 14:45:57 +00:00
|
|
|
QVERIFY(input()->touch()->decoration());
|
2016-05-12 14:33:03 +00:00
|
|
|
QCOMPARE(input()->touch()->decoration()->client(), c);
|
|
|
|
QTEST(input()->touch()->decoration()->decoration()->sectionUnderMouse(), "expectedSection");
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QVERIFY(!c->isOnAllDesktops());
|
|
|
|
kwinApp()->platform()->touchDown(0, decoPoint, timestamp++);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QVERIFY(c->isOnAllDesktops());
|
|
|
|
}
|
|
|
|
|
2016-02-04 13:20:36 +00:00
|
|
|
void DecorationInputTest::testHover()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-02-04 13:20:36 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
|
|
|
|
// our left border is moved out of the visible area, so move the window to a better place
|
|
|
|
c->move(QPoint(20, 0));
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->clientPos().y() / 2));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(Qt::ArrowCursor));
|
2016-02-04 13:20:36 +00:00
|
|
|
|
2019-06-07 09:55:11 +00:00
|
|
|
// There is a mismatch of the cursor key positions between windows
|
|
|
|
// with and without borders (with borders one can move inside a bit and still
|
|
|
|
// be on an edge, without not). We should make this consistent in KWin's core.
|
|
|
|
//
|
|
|
|
// TODO: Test input position with different border sizes.
|
|
|
|
// TODO: We should test with the fake decoration to have a fixed test environment.
|
|
|
|
const bool hasBorders = Decoration::DecorationBridge::self()->settings()->borderSize() != KDecoration2::BorderSize::None;
|
|
|
|
auto deviation = [hasBorders] {
|
|
|
|
return hasBorders ? -1 : 0;
|
|
|
|
};
|
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x(), 0));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeNorthWest));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() / 2, 0));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeNorth));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() - 1, 0));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeNorthEast));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() + deviation(), c->height() / 2));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeEast));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() + deviation(), c->height() - 1));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeSouthEast));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() / 2, c->height() + deviation()));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeSouth));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x(), c->height() + deviation()));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeSouthWest));
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() - 1, c->height() / 2));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(KWin::ExtendedCursor::SizeWest));
|
2016-02-04 13:20:36 +00:00
|
|
|
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(c->frameGeometry().center());
|
2016-02-04 13:20:36 +00:00
|
|
|
QEXPECT_FAIL("", "Cursor not set back on leave", Continue);
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(Qt::ArrowCursor));
|
2016-02-04 13:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-03-11 11:48:01 +00:00
|
|
|
void DecorationInputTest::testPressToMove_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QPoint>("offset");
|
|
|
|
QTest::addColumn<QPoint>("offset2");
|
|
|
|
QTest::addColumn<QPoint>("offset3");
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("To right") << QPoint(10, 0) << QPoint(20, 0) << QPoint(30, 0);
|
|
|
|
QTest::newRow("To left") << QPoint(-10, 0) << QPoint(-20, 0) << QPoint(-30, 0);
|
|
|
|
QTest::newRow("To bottom") << QPoint(0, 10) << QPoint(0, 20) << QPoint(0, 30);
|
|
|
|
QTest::newRow("To top") << QPoint(0, -10) << QPoint(0, -20) << QPoint(0, -30);
|
2016-03-11 11:48:01 +00:00
|
|
|
}
|
|
|
|
|
2016-02-04 14:07:03 +00:00
|
|
|
void DecorationInputTest::testPressToMove()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-02-04 14:07:03 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
2016-03-11 11:48:01 +00:00
|
|
|
c->move(screens()->geometry(0).center() - QPoint(c->width()/2, c->height()/2));
|
2016-02-04 14:07:03 +00:00
|
|
|
QSignalSpy startMoveResizedSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(startMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(c, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2));
|
2018-06-07 00:33:54 +00:00
|
|
|
QCOMPARE(c->cursor(), CursorShape(Qt::ArrowCursor));
|
2016-02-04 14:07:03 +00:00
|
|
|
|
|
|
|
PRESS;
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-03-11 11:48:01 +00:00
|
|
|
QFETCH(QPoint, offset);
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2) + offset);
|
2016-03-11 11:48:01 +00:00
|
|
|
const QPoint oldPos = c->pos();
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-02-04 14:07:03 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 1);
|
|
|
|
|
|
|
|
RELEASE;
|
2021-04-30 18:06:58 +00:00
|
|
|
QTRY_VERIFY(!c->isInteractiveMove());
|
2016-02-04 14:07:03 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
|
|
|
QEXPECT_FAIL("", "Just trigger move doesn't move the window", Continue);
|
2016-03-11 11:48:01 +00:00
|
|
|
QCOMPARE(c->pos(), oldPos + offset);
|
2016-02-04 14:07:03 +00:00
|
|
|
|
|
|
|
// again
|
|
|
|
PRESS;
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-03-11 11:48:01 +00:00
|
|
|
QFETCH(QPoint, offset2);
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2) + offset2);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-02-04 14:07:03 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 2);
|
2016-03-11 11:48:01 +00:00
|
|
|
QFETCH(QPoint, offset3);
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2) + offset3);
|
2016-02-04 14:07:03 +00:00
|
|
|
|
|
|
|
RELEASE;
|
2021-04-30 18:06:58 +00:00
|
|
|
QTRY_VERIFY(!c->isInteractiveMove());
|
2016-02-04 14:07:03 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 2);
|
2016-03-11 11:48:01 +00:00
|
|
|
// TODO: the offset should also be included
|
|
|
|
QCOMPARE(c->pos(), oldPos + offset2 + offset3);
|
2016-02-04 14:07:03 +00:00
|
|
|
}
|
|
|
|
|
2016-05-12 14:33:03 +00:00
|
|
|
void DecorationInputTest::testTapToMove_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QPoint>("offset");
|
|
|
|
QTest::addColumn<QPoint>("offset2");
|
|
|
|
QTest::addColumn<QPoint>("offset3");
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("To right") << QPoint(10, 0) << QPoint(20, 0) << QPoint(30, 0);
|
|
|
|
QTest::newRow("To left") << QPoint(-10, 0) << QPoint(-20, 0) << QPoint(-30, 0);
|
|
|
|
QTest::newRow("To bottom") << QPoint(0, 10) << QPoint(0, 20) << QPoint(0, 30);
|
|
|
|
QTest::newRow("To top") << QPoint(0, -10) << QPoint(0, -20) << QPoint(0, -30);
|
2016-05-12 14:33:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testTapToMove()
|
|
|
|
{
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-05-12 14:33:03 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
c->move(screens()->geometry(0).center() - QPoint(c->width()/2, c->height()/2));
|
|
|
|
QSignalSpy startMoveResizedSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(startMoveResizedSpy.isValid());
|
|
|
|
QSignalSpy clientFinishUserMovedResizedSpy(c, &AbstractClient::clientFinishUserMovedResized);
|
|
|
|
QVERIFY(clientFinishUserMovedResizedSpy.isValid());
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
QPoint p = QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2);
|
2016-05-12 14:33:03 +00:00
|
|
|
|
|
|
|
kwinApp()->platform()->touchDown(0, p, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QFETCH(QPoint, offset);
|
|
|
|
QCOMPARE(input()->touch()->decorationPressId(), 0);
|
|
|
|
kwinApp()->platform()->touchMotion(0, p + offset, timestamp++);
|
|
|
|
const QPoint oldPos = c->pos();
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 1);
|
|
|
|
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QTRY_VERIFY(!c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 1);
|
|
|
|
QEXPECT_FAIL("", "Just trigger move doesn't move the window", Continue);
|
|
|
|
QCOMPARE(c->pos(), oldPos + offset);
|
|
|
|
|
|
|
|
// again
|
|
|
|
kwinApp()->platform()->touchDown(1, p + offset, timestamp++);
|
|
|
|
QCOMPARE(input()->touch()->decorationPressId(), 1);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QFETCH(QPoint, offset2);
|
2019-09-27 10:01:10 +00:00
|
|
|
kwinApp()->platform()->touchMotion(1, QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2) + offset2, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QCOMPARE(startMoveResizedSpy.count(), 2);
|
|
|
|
QFETCH(QPoint, offset3);
|
2019-09-27 10:01:10 +00:00
|
|
|
kwinApp()->platform()->touchMotion(1, QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2) + offset3, timestamp++);
|
2016-05-12 14:33:03 +00:00
|
|
|
|
|
|
|
kwinApp()->platform()->touchUp(1, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QTRY_VERIFY(!c->isInteractiveMove());
|
2016-05-12 14:33:03 +00:00
|
|
|
QCOMPARE(clientFinishUserMovedResizedSpy.count(), 2);
|
|
|
|
// TODO: the offset should also be included
|
|
|
|
QCOMPARE(c->pos(), oldPos + offset2 + offset3);
|
|
|
|
}
|
|
|
|
|
2016-09-15 09:44:32 +00:00
|
|
|
void DecorationInputTest::testResizeOutsideWindow_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<Qt::Edge>("edge");
|
|
|
|
QTest::addColumn<Qt::CursorShape>("expectedCursor");
|
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("left") << Qt::LeftEdge << Qt::SizeHorCursor;
|
|
|
|
QTest::newRow("right") << Qt::RightEdge << Qt::SizeHorCursor;
|
|
|
|
QTest::newRow("bottom") << Qt::BottomEdge << Qt::SizeVerCursor;
|
2016-09-15 09:44:32 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testResizeOutsideWindow()
|
|
|
|
{
|
|
|
|
// this test verifies that one can resize the window outside the decoration with NoSideBorder
|
|
|
|
|
|
|
|
// first adjust config
|
|
|
|
kwinApp()->config()->group("org.kde.kdecoration2").writeEntry("BorderSize", QStringLiteral("None"));
|
|
|
|
kwinApp()->config()->sync();
|
|
|
|
workspace()->slotReconfigure();
|
|
|
|
|
|
|
|
// now create window
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2016-09-15 09:44:32 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
c->move(screens()->geometry(0).center() - QPoint(c->width()/2, c->height()/2));
|
2019-09-27 10:01:10 +00:00
|
|
|
QVERIFY(c->frameGeometry() != c->inputGeometry());
|
|
|
|
QVERIFY(c->inputGeometry().contains(c->frameGeometry()));
|
2016-09-15 09:44:32 +00:00
|
|
|
QSignalSpy startMoveResizedSpy(c, &AbstractClient::clientStartUserMovedResized);
|
|
|
|
QVERIFY(startMoveResizedSpy.isValid());
|
|
|
|
|
|
|
|
// go to border
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
QFETCH(Qt::Edge, edge);
|
|
|
|
switch (edge) {
|
|
|
|
case Qt::LeftEdge:
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() -1, c->frameGeometry().center().y()));
|
2016-09-15 09:44:32 +00:00
|
|
|
break;
|
|
|
|
case Qt::RightEdge:
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().x() + c->frameGeometry().width() +1, c->frameGeometry().center().y()));
|
2016-09-15 09:44:32 +00:00
|
|
|
break;
|
|
|
|
case Qt::BottomEdge:
|
2019-09-27 10:01:10 +00:00
|
|
|
MOTION(QPoint(c->frameGeometry().center().x(), c->frameGeometry().y() + c->frameGeometry().height() + 1));
|
2016-09-15 09:44:32 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2020-04-02 16:18:01 +00:00
|
|
|
QVERIFY(!c->frameGeometry().contains(KWin::Cursors::self()->mouse()->pos()));
|
2016-09-15 09:44:32 +00:00
|
|
|
|
|
|
|
// pressing should trigger resize
|
|
|
|
PRESS;
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveResize());
|
2016-09-15 09:44:32 +00:00
|
|
|
QVERIFY(startMoveResizedSpy.wait());
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveResize());
|
2016-09-15 09:44:32 +00:00
|
|
|
|
|
|
|
RELEASE;
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveResize());
|
2016-09-15 09:44:32 +00:00
|
|
|
}
|
|
|
|
|
2017-11-11 11:28:10 +00:00
|
|
|
void DecorationInputTest::testModifierClickUnrestrictedMove_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<int>("modifierKey");
|
|
|
|
QTest::addColumn<int>("mouseButton");
|
|
|
|
QTest::addColumn<QString>("modKey");
|
|
|
|
QTest::addColumn<bool>("capsLock");
|
|
|
|
|
|
|
|
const QString alt = QStringLiteral("Alt");
|
|
|
|
const QString meta = QStringLiteral("Meta");
|
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("Left Alt + Left Click") << KEY_LEFTALT << BTN_LEFT << alt << false;
|
|
|
|
QTest::newRow("Left Alt + Right Click") << KEY_LEFTALT << BTN_RIGHT << alt << false;
|
|
|
|
QTest::newRow("Left Alt + Middle Click") << KEY_LEFTALT << BTN_MIDDLE << alt << false;
|
|
|
|
QTest::newRow("Right Alt + Left Click") << KEY_RIGHTALT << BTN_LEFT << alt << false;
|
|
|
|
QTest::newRow("Right Alt + Right Click") << KEY_RIGHTALT << BTN_RIGHT << alt << false;
|
|
|
|
QTest::newRow("Right Alt + Middle Click") << KEY_RIGHTALT << BTN_MIDDLE << alt << false;
|
|
|
|
// now everything with meta
|
|
|
|
QTest::newRow("Left Meta + Left Click") << KEY_LEFTMETA << BTN_LEFT << meta << false;
|
|
|
|
QTest::newRow("Left Meta + Right Click") << KEY_LEFTMETA << BTN_RIGHT << meta << false;
|
|
|
|
QTest::newRow("Left Meta + Middle Click") << KEY_LEFTMETA << BTN_MIDDLE << meta << false;
|
|
|
|
QTest::newRow("Right Meta + Left Click") << KEY_RIGHTMETA << BTN_LEFT << meta << false;
|
|
|
|
QTest::newRow("Right Meta + Right Click") << KEY_RIGHTMETA << BTN_RIGHT << meta << false;
|
|
|
|
QTest::newRow("Right Meta + Middle Click") << KEY_RIGHTMETA << BTN_MIDDLE << meta << false;
|
|
|
|
|
|
|
|
// and with capslock
|
|
|
|
QTest::newRow("Left Alt + Left Click/CapsLock") << KEY_LEFTALT << BTN_LEFT << alt << true;
|
|
|
|
QTest::newRow("Left Alt + Right Click/CapsLock") << KEY_LEFTALT << BTN_RIGHT << alt << true;
|
|
|
|
QTest::newRow("Left Alt + Middle Click/CapsLock") << KEY_LEFTALT << BTN_MIDDLE << alt << true;
|
|
|
|
QTest::newRow("Right Alt + Left Click/CapsLock") << KEY_RIGHTALT << BTN_LEFT << alt << true;
|
|
|
|
QTest::newRow("Right Alt + Right Click/CapsLock") << KEY_RIGHTALT << BTN_RIGHT << alt << true;
|
|
|
|
QTest::newRow("Right Alt + Middle Click/CapsLock") << KEY_RIGHTALT << BTN_MIDDLE << alt << true;
|
|
|
|
// now everything with meta
|
|
|
|
QTest::newRow("Left Meta + Left Click/CapsLock") << KEY_LEFTMETA << BTN_LEFT << meta << true;
|
|
|
|
QTest::newRow("Left Meta + Right Click/CapsLock") << KEY_LEFTMETA << BTN_RIGHT << meta << true;
|
|
|
|
QTest::newRow("Left Meta + Middle Click/CapsLock") << KEY_LEFTMETA << BTN_MIDDLE << meta << true;
|
|
|
|
QTest::newRow("Right Meta + Left Click/CapsLock") << KEY_RIGHTMETA << BTN_LEFT << meta << true;
|
|
|
|
QTest::newRow("Right Meta + Right Click/CapsLock") << KEY_RIGHTMETA << BTN_RIGHT << meta << true;
|
|
|
|
QTest::newRow("Right Meta + Middle Click/CapsLock") << KEY_RIGHTMETA << BTN_MIDDLE << meta << true;
|
2017-11-11 11:28:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testModifierClickUnrestrictedMove()
|
|
|
|
{
|
|
|
|
// this test ensures that Alt+mouse button press triggers unrestricted move
|
|
|
|
|
|
|
|
// first modify the config for this run
|
|
|
|
QFETCH(QString, modKey);
|
|
|
|
KConfigGroup group = kwinApp()->config()->group("MouseBindings");
|
|
|
|
group.writeEntry("CommandAllKey", modKey);
|
|
|
|
group.writeEntry("CommandAll1", "Move");
|
|
|
|
group.writeEntry("CommandAll2", "Move");
|
|
|
|
group.writeEntry("CommandAll3", "Move");
|
|
|
|
group.sync();
|
|
|
|
workspace()->slotReconfigure();
|
|
|
|
QCOMPARE(options->commandAllModifier(), modKey == QStringLiteral("Alt") ? Qt::AltModifier : Qt::MetaModifier);
|
|
|
|
QCOMPARE(options->commandAll1(), Options::MouseUnrestrictedMove);
|
|
|
|
QCOMPARE(options->commandAll2(), Options::MouseUnrestrictedMove);
|
|
|
|
QCOMPARE(options->commandAll3(), Options::MouseUnrestrictedMove);
|
|
|
|
|
|
|
|
// create a window
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2017-11-11 11:28:10 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
c->move(screens()->geometry(0).center() - QPoint(c->width()/2, c->height()/2));
|
|
|
|
// move cursor on window
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2));
|
2017-11-11 11:28:10 +00:00
|
|
|
|
|
|
|
// simulate modifier+click
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
QFETCH(bool, capsLock);
|
|
|
|
if (capsLock) {
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_CAPSLOCK, timestamp++);
|
|
|
|
}
|
|
|
|
QFETCH(int, modifierKey);
|
|
|
|
QFETCH(int, mouseButton);
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(modifierKey, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2017-11-11 11:28:10 +00:00
|
|
|
kwinApp()->platform()->pointerButtonPressed(mouseButton, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2017-11-11 11:28:10 +00:00
|
|
|
// release modifier should not change it
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(modifierKey, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(c->isInteractiveMove());
|
2017-11-11 11:28:10 +00:00
|
|
|
// but releasing the key should end move/resize
|
|
|
|
kwinApp()->platform()->pointerButtonReleased(mouseButton, timestamp++);
|
2021-04-30 18:06:58 +00:00
|
|
|
QVERIFY(!c->isInteractiveMove());
|
2017-11-11 11:28:10 +00:00
|
|
|
if (capsLock) {
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_CAPSLOCK, timestamp++);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testModifierScrollOpacity_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<int>("modifierKey");
|
|
|
|
QTest::addColumn<QString>("modKey");
|
|
|
|
QTest::addColumn<bool>("capsLock");
|
|
|
|
|
|
|
|
const QString alt = QStringLiteral("Alt");
|
|
|
|
const QString meta = QStringLiteral("Meta");
|
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
QTest::newRow("Left Alt") << KEY_LEFTALT << alt << false;
|
|
|
|
QTest::newRow("Right Alt") << KEY_RIGHTALT << alt << false;
|
|
|
|
QTest::newRow("Left Meta") << KEY_LEFTMETA << meta << false;
|
|
|
|
QTest::newRow("Right Meta") << KEY_RIGHTMETA << meta << false;
|
|
|
|
QTest::newRow("Left Alt/CapsLock") << KEY_LEFTALT << alt << true;
|
|
|
|
QTest::newRow("Right Alt/CapsLock") << KEY_RIGHTALT << alt << true;
|
|
|
|
QTest::newRow("Left Meta/CapsLock") << KEY_LEFTMETA << meta << true;
|
|
|
|
QTest::newRow("Right Meta/CapsLock") << KEY_RIGHTMETA << meta << true;
|
2017-11-11 11:28:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void DecorationInputTest::testModifierScrollOpacity()
|
|
|
|
{
|
|
|
|
// this test verifies that mod+wheel performs a window operation
|
|
|
|
|
|
|
|
// first modify the config for this run
|
|
|
|
QFETCH(QString, modKey);
|
|
|
|
KConfigGroup group = kwinApp()->config()->group("MouseBindings");
|
|
|
|
group.writeEntry("CommandAllKey", modKey);
|
|
|
|
group.writeEntry("CommandAllWheel", "change opacity");
|
|
|
|
group.sync();
|
|
|
|
workspace()->slotReconfigure();
|
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2017-11-11 11:28:10 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
c->move(screens()->geometry(0).center() - QPoint(c->width()/2, c->height()/2));
|
|
|
|
// move cursor on window
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(QPoint(c->frameGeometry().center().x(), c->y() + c->clientPos().y() / 2));
|
2017-11-11 11:28:10 +00:00
|
|
|
// set the opacity to 0.5
|
|
|
|
c->setOpacity(0.5);
|
|
|
|
QCOMPARE(c->opacity(), 0.5);
|
|
|
|
|
|
|
|
// simulate modifier+wheel
|
|
|
|
quint32 timestamp = 1;
|
|
|
|
QFETCH(bool, capsLock);
|
|
|
|
if (capsLock) {
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_CAPSLOCK, timestamp++);
|
|
|
|
}
|
|
|
|
QFETCH(int, modifierKey);
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(modifierKey, timestamp++);
|
|
|
|
kwinApp()->platform()->pointerAxisVertical(-5, timestamp++);
|
|
|
|
QCOMPARE(c->opacity(), 0.6);
|
|
|
|
kwinApp()->platform()->pointerAxisVertical(5, timestamp++);
|
|
|
|
QCOMPARE(c->opacity(), 0.5);
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(modifierKey, timestamp++);
|
|
|
|
if (capsLock) {
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_CAPSLOCK, timestamp++);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-04 20:21:54 +00:00
|
|
|
class EventHelper : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
|
|
|
EventHelper() : QObject() {}
|
|
|
|
~EventHelper() override = default;
|
|
|
|
|
|
|
|
bool eventFilter(QObject *watched, QEvent *event) override
|
|
|
|
{
|
|
|
|
Q_UNUSED(watched)
|
|
|
|
if (event->type() == QEvent::HoverMove) {
|
2021-06-08 07:02:14 +00:00
|
|
|
Q_EMIT hoverMove();
|
2018-02-04 20:21:54 +00:00
|
|
|
} else if (event->type() == QEvent::HoverLeave) {
|
2021-06-08 07:02:14 +00:00
|
|
|
Q_EMIT hoverLeave();
|
2018-02-04 20:21:54 +00:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void hoverMove();
|
|
|
|
void hoverLeave();
|
|
|
|
};
|
|
|
|
|
|
|
|
void DecorationInputTest::testTouchEvents()
|
|
|
|
{
|
|
|
|
// this test verifies that the decoration gets a hover leave event on touch release
|
|
|
|
// see BUG 386231
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2018-02-04 20:21:54 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
|
|
|
|
|
|
|
EventHelper helper;
|
|
|
|
c->decoration()->installEventFilter(&helper);
|
|
|
|
QSignalSpy hoverMoveSpy(&helper, &EventHelper::hoverMove);
|
|
|
|
QVERIFY(hoverMoveSpy.isValid());
|
|
|
|
QSignalSpy hoverLeaveSpy(&helper, &EventHelper::hoverLeave);
|
|
|
|
QVERIFY(hoverLeaveSpy.isValid());
|
|
|
|
|
|
|
|
quint32 timestamp = 1;
|
2019-09-27 10:01:10 +00:00
|
|
|
const QPoint tapPoint(c->frameGeometry().center().x(), c->clientPos().y() / 2);
|
2018-02-04 20:21:54 +00:00
|
|
|
|
|
|
|
QVERIFY(!input()->touch()->decoration());
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
QVERIFY(input()->touch()->decoration());
|
|
|
|
QCOMPARE(input()->touch()->decoration()->decoration(), c->decoration());
|
|
|
|
QCOMPARE(hoverMoveSpy.count(), 1);
|
|
|
|
QCOMPARE(hoverLeaveSpy.count(), 0);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
|
|
|
QCOMPARE(hoverMoveSpy.count(), 1);
|
|
|
|
QCOMPARE(hoverLeaveSpy.count(), 1);
|
|
|
|
|
2021-04-30 18:06:58 +00:00
|
|
|
QCOMPARE(c->isInteractiveMove(), false);
|
2018-02-04 20:21:54 +00:00
|
|
|
|
|
|
|
// let's check that a hover motion is sent if the pointer is on deco, when touch release
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(tapPoint);
|
2018-02-04 20:21:54 +00:00
|
|
|
QCOMPARE(hoverMoveSpy.count(), 2);
|
|
|
|
kwinApp()->platform()->touchDown(0, tapPoint, timestamp++);
|
|
|
|
QCOMPARE(hoverMoveSpy.count(), 3);
|
|
|
|
QCOMPARE(hoverLeaveSpy.count(), 1);
|
|
|
|
kwinApp()->platform()->touchUp(0, timestamp++);
|
2018-09-15 00:00:24 +00:00
|
|
|
QCOMPARE(hoverMoveSpy.count(), 3);
|
|
|
|
QCOMPARE(hoverLeaveSpy.count(), 2);
|
2018-02-04 20:21:54 +00:00
|
|
|
}
|
|
|
|
|
2018-05-01 14:21:12 +00:00
|
|
|
void DecorationInputTest::testTooltipDoesntEatKeyEvents()
|
|
|
|
{
|
|
|
|
// this test verifies that a tooltip on the decoration does not steal key events
|
|
|
|
// BUG: 393253
|
|
|
|
|
|
|
|
// first create a keyboard
|
|
|
|
auto keyboard = Test::waylandSeat()->createKeyboard(Test::waylandSeat());
|
|
|
|
QVERIFY(keyboard);
|
|
|
|
QSignalSpy enteredSpy(keyboard, &KWayland::Client::Keyboard::entered);
|
|
|
|
QVERIFY(enteredSpy.isValid());
|
|
|
|
|
2020-09-09 09:54:44 +00:00
|
|
|
AbstractClient *c = showWindow();
|
2018-05-01 14:21:12 +00:00
|
|
|
QVERIFY(c);
|
|
|
|
QVERIFY(c->isDecorated());
|
|
|
|
QVERIFY(!c->noBorder());
|
2020-11-22 23:56:44 +00:00
|
|
|
QVERIFY(enteredSpy.wait());
|
2018-05-01 14:21:12 +00:00
|
|
|
|
|
|
|
QSignalSpy keyEvent(keyboard, &KWayland::Client::Keyboard::keyChanged);
|
|
|
|
QVERIFY(keyEvent.isValid());
|
|
|
|
|
2019-08-26 07:44:04 +00:00
|
|
|
QSignalSpy clientAddedSpy(workspace(), &Workspace::internalClientAdded);
|
2018-05-01 14:21:12 +00:00
|
|
|
QVERIFY(clientAddedSpy.isValid());
|
|
|
|
c->decoratedClient()->requestShowToolTip(QStringLiteral("test"));
|
|
|
|
// now we should get an internal window
|
|
|
|
QVERIFY(clientAddedSpy.wait());
|
2019-08-26 07:44:04 +00:00
|
|
|
InternalClient *internal = clientAddedSpy.first().first().value<InternalClient *>();
|
2018-05-01 14:21:12 +00:00
|
|
|
QVERIFY(internal->isInternal());
|
|
|
|
QVERIFY(internal->internalWindow()->flags().testFlag(Qt::ToolTip));
|
|
|
|
|
|
|
|
// now send a key
|
|
|
|
quint32 timestamp = 0;
|
|
|
|
kwinApp()->platform()->keyboardKeyPressed(KEY_A, timestamp++);
|
|
|
|
QVERIFY(keyEvent.wait());
|
|
|
|
kwinApp()->platform()->keyboardKeyReleased(KEY_A, timestamp++);
|
|
|
|
QVERIFY(keyEvent.wait());
|
|
|
|
|
|
|
|
c->decoratedClient()->requestHideToolTip();
|
|
|
|
Test::waitForWindowDestroyed(internal);
|
|
|
|
}
|
|
|
|
|
2016-02-04 10:18:45 +00:00
|
|
|
}
|
|
|
|
|
2016-02-11 08:34:19 +00:00
|
|
|
WAYLANDTEST_MAIN(KWin::DecorationInputTest)
|
2016-02-04 10:18:45 +00:00
|
|
|
#include "decoration_input_test.moc"
|