kwin/plugins/platforms/x11/standalone/x11_output.h

81 lines
2 KiB
C
Raw Normal View History

/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright 2019 Roman Gilg <subdiff@gmail.com>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_X11_OUTPUT_H
#define KWIN_X11_OUTPUT_H
#include "abstract_output.h"
#include <kwin_export.h>
#include <QObject>
#include <QRect>
#include <xcb/randr.h>
namespace KWin
{
/**
* X11 output representation
*/
class KWIN_EXPORT X11Output : public AbstractOutput
{
Q_OBJECT
public:
explicit X11Output(QObject *parent = nullptr);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~X11Output() override = default;
QString name() const override;
void setName(QString set);
/**
* The geometry of this output in global compositor co-ordinates (i.e scaled)
*/
QRect geometry() const override;
void setGeometry(QRect set);
/**
* Current refresh rate in 1/ms.
*/
int refreshRate() const override;
void setRefreshRate(int set);
/**
* The size of gamma lookup table.
*/
int gammaRampSize() const override;
bool setGammaRamp(const GammaRamp &gamma) override;
private:
void setCrtc(xcb_randr_crtc_t crtc);
void setGammaRampSize(int size);
xcb_randr_crtc_t m_crtc = XCB_NONE;
QString m_name;
QRect m_geometry;
int m_gammaRampSize;
int m_refreshRate;
friend class X11StandalonePlatform;
};
}
#endif