2007-11-27 19:40:25 +00:00
|
|
|
/********************************************************************
|
2007-04-29 17:35:43 +00:00
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
2007-11-27 19:40:25 +00:00
|
|
|
Copyright (C) 2006 Lubos Lunak <l.lunak@kde.org>
|
2010-01-21 14:56:24 +00:00
|
|
|
Copyright (C) 2010 Jorge Mata <matamax123@gmail.com>
|
2019-09-29 14:03:25 +00:00
|
|
|
Copyright (C) 2018 Vlad Zahorodnii <vladzzag@gmail.com>
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2007-11-27 19:40:25 +00:00
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
#ifndef KWIN_TRACKMOUSE_H
|
|
|
|
#define KWIN_TRACKMOUSE_H
|
|
|
|
|
|
|
|
#include <kwineffects.h>
|
|
|
|
|
2013-08-14 19:13:12 +00:00
|
|
|
class QAction;
|
2010-01-21 14:56:24 +00:00
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
2010-12-08 18:35:38 +00:00
|
|
|
class GLTexture;
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
class TrackMouseEffect
|
2011-02-25 19:25:21 +00:00
|
|
|
: public Effect
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2010-01-21 14:56:24 +00:00
|
|
|
Q_OBJECT
|
2012-08-11 09:24:37 +00:00
|
|
|
Q_PROPERTY(Qt::KeyboardModifiers modifiers READ modifiers)
|
|
|
|
Q_PROPERTY(bool mousePolling READ isMousePolling)
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
|
|
|
TrackMouseEffect();
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~TrackMouseEffect() override;
|
|
|
|
void prePaintScreen(ScreenPrePaintData& data, int time) override;
|
2019-10-29 22:04:15 +00:00
|
|
|
void paintScreen(int mask, const QRegion ®ion, ScreenPaintData& data) override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void postPaintScreen() override;
|
|
|
|
void reconfigure(ReconfigureFlags) override;
|
|
|
|
bool isActive() const override;
|
2012-08-11 09:24:37 +00:00
|
|
|
|
|
|
|
// for properties
|
|
|
|
Qt::KeyboardModifiers modifiers() const {
|
|
|
|
return m_modifiers;
|
|
|
|
}
|
|
|
|
bool isMousePolling() const {
|
|
|
|
return m_mousePolling;
|
|
|
|
}
|
2013-07-22 14:07:39 +00:00
|
|
|
private Q_SLOTS:
|
2011-01-30 14:34:42 +00:00
|
|
|
void toggle();
|
2011-03-12 13:37:30 +00:00
|
|
|
void slotMouseChanged(const QPoint& pos, const QPoint& old,
|
|
|
|
Qt::MouseButtons buttons, Qt::MouseButtons oldbuttons,
|
|
|
|
Qt::KeyboardModifiers modifiers, Qt::KeyboardModifiers oldmodifiers);
|
2011-01-30 14:34:42 +00:00
|
|
|
private:
|
2012-04-19 19:06:11 +00:00
|
|
|
bool init();
|
2011-01-30 14:34:42 +00:00
|
|
|
void loadTexture();
|
2012-04-19 19:06:11 +00:00
|
|
|
QRect m_lastRect[2];
|
[effects/trackmouse] Allow to use both modifiers and shortcut
Summary:
The Track Mouse effect can be toggled either by pressing modifier keys
and moving mouse or by pressing a shortcut. It's not possible to use
the latter and then the former without changing config.
But there is one caveat, in order to use shortcut, you have to uncheck
all modifier keys. This seems to be not very intuitive.
In addition to that, the KCM allows to change shortcut even if there is
some checked modifier.
As the title says, this change makes possible to use both modifier keys
and shortcut to activate this effect without changing config.
KCM:
{F6237308, layout=center, size=full}
BUG: 398124
FIXED-IN: 5.14.0
Reviewers: #kwin, #plasma, #vdg, davidedmundson
Reviewed By: #kwin, #plasma, #vdg, davidedmundson
Subscribers: broulik, abetts, ngraham, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D15272
2018-09-04 12:08:27 +00:00
|
|
|
bool m_mousePolling;
|
2012-04-19 19:06:11 +00:00
|
|
|
float m_angle;
|
|
|
|
float m_angleBase;
|
|
|
|
GLTexture* m_texture[2];
|
|
|
|
#ifdef KWIN_HAVE_XRENDER_COMPOSITING
|
2013-02-12 11:34:51 +00:00
|
|
|
QSize m_size[2];
|
|
|
|
XRenderPicture *m_picture[2];
|
2012-04-19 19:06:11 +00:00
|
|
|
#endif
|
2013-08-14 19:13:12 +00:00
|
|
|
QAction* m_action;
|
2013-06-21 12:57:37 +00:00
|
|
|
QImage m_image[2];
|
2012-04-19 19:06:11 +00:00
|
|
|
Qt::KeyboardModifiers m_modifiers;
|
[effects/trackmouse] Allow to use both modifiers and shortcut
Summary:
The Track Mouse effect can be toggled either by pressing modifier keys
and moving mouse or by pressing a shortcut. It's not possible to use
the latter and then the former without changing config.
But there is one caveat, in order to use shortcut, you have to uncheck
all modifier keys. This seems to be not very intuitive.
In addition to that, the KCM allows to change shortcut even if there is
some checked modifier.
As the title says, this change makes possible to use both modifier keys
and shortcut to activate this effect without changing config.
KCM:
{F6237308, layout=center, size=full}
BUG: 398124
FIXED-IN: 5.14.0
Reviewers: #kwin, #plasma, #vdg, davidedmundson
Reviewed By: #kwin, #plasma, #vdg, davidedmundson
Subscribers: broulik, abetts, ngraham, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D15272
2018-09-04 12:08:27 +00:00
|
|
|
|
|
|
|
enum class State {
|
|
|
|
ActivatedByModifiers,
|
|
|
|
ActivatedByShortcut,
|
|
|
|
Inactive
|
|
|
|
};
|
|
|
|
State m_state = State::Inactive;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
#endif
|