kwin/src/deleted.h

142 lines
3.2 KiB
C
Raw Normal View History

2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2006 Lubos Lunak <l.lunak@kde.org>
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_DELETED_H
#define KWIN_DELETED_H
#include "toplevel.h"
namespace KWin
{
class AbstractClient;
2019-10-02 09:57:59 +00:00
class KWIN_EXPORT Deleted : public Toplevel
2011-01-30 14:34:42 +00:00
{
Q_OBJECT
2019-02-06 17:06:08 +00:00
2011-01-30 14:34:42 +00:00
public:
static Deleted* create(Toplevel* c);
// used by effects to keep the window around for e.g. fadeout effects when it's destroyed
void refWindow();
void unrefWindow();
void discard();
QMargins frameMargins() const override;
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
int desktop() const override;
QStringList activities() const override;
QVector<VirtualDesktop *> desktops() const override;
QPoint clientPos() const override;
bool isDeleted() const override;
xcb_window_t frameId() const override;
void layoutDecorationRects(QRect &left, QRect &top, QRect &right, QRect &bottom) const;
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
Layer layer() const override {
return m_layer;
}
bool isShade() const override {
return m_shade;
}
bool isMinimized() const {
return m_minimized;
}
bool isModal() const {
return m_modal;
}
QList<AbstractClient*> mainClients() const {
return m_mainClients;
}
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
NET::WindowType windowType(bool direct = false, int supported_types = 0) const override;
bool wasClient() const {
return m_wasClient;
}
QByteArray windowRole() const override;
bool isFullScreen() const {
return m_fullscreen;
}
bool keepAbove() const {
return m_keepAbove;
}
bool keepBelow() const {
return m_keepBelow;
}
QString caption() const {
return m_caption;
}
/**
* Returns whether the client was a popup.
*
* @returns @c true if the client was a popup, @c false otherwise.
*/
bool isPopupWindow() const override {
return m_wasPopupWindow;
}
QVector<uint> x11DesktopIds() const;
/**
* Whether this Deleted represents the outline.
*/
bool isOutline() const override {
return m_wasOutline;
}
bool isLockScreen() const override {
return m_wasLockScreen;
}
private Q_SLOTS:
void mainClientClosed(KWin::Toplevel *client);
2011-01-30 14:34:42 +00:00
private:
Deleted(); // use create()
2011-01-30 14:34:42 +00:00
void copyToDeleted(Toplevel* c);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~Deleted() override; // deleted only using unrefWindow()
QMargins m_frameMargins;
2011-01-30 14:34:42 +00:00
int delete_refcount;
int desk;
QStringList activityList;
QRect contentsRect; // for clientPos()/clientSize()
xcb_window_t m_frame;
QVector <VirtualDesktop *> m_desktops;
2011-01-30 14:34:42 +00:00
QRect decoration_left;
QRect decoration_right;
QRect decoration_top;
QRect decoration_bottom;
Layer m_layer;
bool m_shade;
bool m_minimized;
bool m_modal;
QList<AbstractClient*> m_mainClients;
bool m_wasClient;
NET::WindowType m_type = NET::Unknown;
QByteArray m_windowRole;
bool m_fullscreen;
bool m_keepAbove;
bool m_keepBelow;
QString m_caption;
bool m_wasPopupWindow;
bool m_wasOutline;
bool m_wasLockScreen;
2011-01-30 14:34:42 +00:00
};
inline void Deleted::refWindow()
2011-01-30 14:34:42 +00:00
{
++delete_refcount;
2011-01-30 14:34:42 +00:00
}
} // namespace
Q_DECLARE_METATYPE(KWin::Deleted*)
#endif