2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2016-02-15 08:36:59 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2013, 2016 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
SPDX-FileCopyrightText: 2018 Roman Gilg <subdiff@gmail.com>
|
2016-02-15 08:36:59 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2016-02-15 08:36:59 +00:00
|
|
|
#ifndef KWIN_TOUCH_INPUT_H
|
|
|
|
#define KWIN_TOUCH_INPUT_H
|
2016-05-12 14:33:03 +00:00
|
|
|
#include "input.h"
|
2016-02-15 08:36:59 +00:00
|
|
|
|
|
|
|
#include <QHash>
|
|
|
|
#include <QObject>
|
|
|
|
#include <QPointer>
|
|
|
|
#include <QPointF>
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
|
|
|
class InputRedirection;
|
|
|
|
class Toplevel;
|
|
|
|
|
2016-05-12 14:33:03 +00:00
|
|
|
namespace Decoration
|
|
|
|
{
|
|
|
|
class DecoratedClientImpl;
|
|
|
|
}
|
|
|
|
|
2016-05-24 08:57:57 +00:00
|
|
|
namespace LibInput
|
|
|
|
{
|
|
|
|
class Device;
|
|
|
|
}
|
|
|
|
|
2016-05-12 14:33:03 +00:00
|
|
|
class TouchInputRedirection : public InputDeviceHandler
|
2016-02-15 08:36:59 +00:00
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
|
|
|
explicit TouchInputRedirection(InputRedirection *parent);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~TouchInputRedirection() override;
|
2016-02-15 08:36:59 +00:00
|
|
|
|
2018-12-13 09:46:21 +00:00
|
|
|
bool positionValid() const override;
|
2018-09-15 00:00:24 +00:00
|
|
|
bool focusUpdatesBlocked() override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void init() override;
|
2016-02-15 08:36:59 +00:00
|
|
|
|
2016-05-24 08:57:57 +00:00
|
|
|
void processDown(qint32 id, const QPointF &pos, quint32 time, LibInput::Device *device = nullptr);
|
|
|
|
void processUp(qint32 id, quint32 time, LibInput::Device *device = nullptr);
|
|
|
|
void processMotion(qint32 id, const QPointF &pos, quint32 time, LibInput::Device *device = nullptr);
|
2016-02-15 08:36:59 +00:00
|
|
|
void cancel();
|
|
|
|
void frame();
|
|
|
|
|
2016-05-12 14:33:03 +00:00
|
|
|
void setDecorationPressId(qint32 id) {
|
|
|
|
m_decorationId = id;
|
|
|
|
}
|
|
|
|
qint32 decorationPressId() const {
|
|
|
|
return m_decorationId;
|
2016-02-15 08:36:59 +00:00
|
|
|
}
|
2016-05-23 15:07:08 +00:00
|
|
|
void setInternalPressId(qint32 id) {
|
|
|
|
m_internalId = id;
|
|
|
|
}
|
|
|
|
qint32 internalPressId() const {
|
|
|
|
return m_internalId;
|
|
|
|
}
|
2016-02-15 08:36:59 +00:00
|
|
|
|
2018-09-15 00:00:24 +00:00
|
|
|
QPointF position() const override {
|
|
|
|
return m_lastPosition;
|
|
|
|
}
|
|
|
|
|
2021-01-17 22:18:08 +00:00
|
|
|
int touchPointCount() const {
|
2021-02-16 11:51:23 +00:00
|
|
|
return m_activeTouchPoints.count();
|
2021-01-17 22:18:08 +00:00
|
|
|
}
|
|
|
|
|
2016-02-15 08:36:59 +00:00
|
|
|
private:
|
2018-09-15 00:00:24 +00:00
|
|
|
void cleanupInternalWindow(QWindow *old, QWindow *now) override;
|
|
|
|
void cleanupDecoration(Decoration::DecoratedClientImpl *old, Decoration::DecoratedClientImpl *now) override;
|
|
|
|
|
|
|
|
void focusUpdate(Toplevel *focusOld, Toplevel *focusNow) override;
|
|
|
|
|
2021-02-16 11:51:23 +00:00
|
|
|
QSet<qint32> m_activeTouchPoints;
|
2016-02-15 08:36:59 +00:00
|
|
|
bool m_inited = false;
|
2016-05-12 14:33:03 +00:00
|
|
|
qint32 m_decorationId = -1;
|
2016-05-23 15:07:08 +00:00
|
|
|
qint32 m_internalId = -1;
|
2018-09-15 00:00:24 +00:00
|
|
|
QMetaObject::Connection m_focusGeometryConnection;
|
2016-05-23 15:07:08 +00:00
|
|
|
bool m_windowUpdatedInCycle = false;
|
2018-09-15 00:00:24 +00:00
|
|
|
QPointF m_lastPosition;
|
2016-02-15 08:36:59 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|