2009-09-13 11:36:45 +00:00
|
|
|
/********************************************************************
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
2011-10-31 07:41:07 +00:00
|
|
|
Copyright (C) 2009, 2011 Martin Gräßlin <mgraesslin@kde.org>
|
2009-09-13 11:36:45 +00:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
2012-04-09 16:59:26 +00:00
|
|
|
#ifndef KWIN_TABBOX_LAYOUTPREVIEW_H
|
|
|
|
#define KWIN_TABBOX_LAYOUTPREVIEW_H
|
2009-09-13 11:36:45 +00:00
|
|
|
|
2015-01-20 14:16:38 +00:00
|
|
|
#include <KService>
|
2013-02-26 08:00:51 +00:00
|
|
|
#include <QAbstractListModel>
|
2013-10-01 05:15:11 +00:00
|
|
|
#include <QQuickView>
|
2013-12-12 10:13:11 +00:00
|
|
|
#include <QRect>
|
2009-09-13 11:36:45 +00:00
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
|
|
|
namespace TabBox
|
|
|
|
{
|
|
|
|
|
2013-12-12 10:13:11 +00:00
|
|
|
class SwitcherItem;
|
|
|
|
|
|
|
|
class LayoutPreview : public QObject
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2009-09-13 11:36:45 +00:00
|
|
|
Q_OBJECT
|
2011-10-31 07:41:07 +00:00
|
|
|
public:
|
2013-12-12 10:13:11 +00:00
|
|
|
explicit LayoutPreview(const QString &path, QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~LayoutPreview() override;
|
2011-10-31 07:41:07 +00:00
|
|
|
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
bool eventFilter(QObject *object, QEvent *event) override;
|
2011-10-31 07:41:07 +00:00
|
|
|
private:
|
2013-12-12 10:13:11 +00:00
|
|
|
SwitcherItem *m_item;
|
2011-10-31 07:41:07 +00:00
|
|
|
};
|
2009-09-13 11:36:45 +00:00
|
|
|
|
2011-10-31 07:41:07 +00:00
|
|
|
class ExampleClientModel : public QAbstractListModel
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
2014-01-07 10:22:24 +00:00
|
|
|
explicit ExampleClientModel(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~ExampleClientModel() override;
|
2011-10-31 07:41:07 +00:00
|
|
|
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
|
|
|
|
int rowCount(const QModelIndex &parent = QModelIndex()) const override;
|
|
|
|
QHash<int, QByteArray> roleNames() const override;
|
2013-12-22 11:01:05 +00:00
|
|
|
Q_INVOKABLE QString longestCaption() const;
|
2011-10-31 07:41:07 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void init();
|
2015-01-20 14:16:38 +00:00
|
|
|
QList<KService::Ptr> m_services;
|
|
|
|
KService::Ptr m_fileManager;
|
|
|
|
KService::Ptr m_browser;
|
|
|
|
KService::Ptr m_email;
|
|
|
|
KService::Ptr m_systemSettings;
|
2011-10-31 07:41:07 +00:00
|
|
|
};
|
|
|
|
|
2013-12-12 10:13:11 +00:00
|
|
|
|
|
|
|
class SwitcherItem : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
Q_PROPERTY(QAbstractItemModel *model READ model NOTIFY modelChanged)
|
|
|
|
Q_PROPERTY(QRect screenGeometry READ screenGeometry NOTIFY screenGeometryChanged)
|
|
|
|
Q_PROPERTY(bool visible READ isVisible NOTIFY visibleChanged)
|
|
|
|
Q_PROPERTY(bool allDesktops READ isAllDesktops NOTIFY allDesktopsChanged)
|
|
|
|
Q_PROPERTY(int currentIndex READ currentIndex WRITE setCurrentIndex NOTIFY currentIndexChanged)
|
|
|
|
|
|
|
|
/**
|
|
|
|
* The main QML item that will be displayed in the Dialog
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2013-12-12 10:13:11 +00:00
|
|
|
Q_PROPERTY(QObject *item READ item WRITE setItem NOTIFY itemChanged)
|
|
|
|
|
|
|
|
Q_CLASSINFO("DefaultProperty", "item")
|
|
|
|
public:
|
|
|
|
SwitcherItem(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SwitcherItem() override;
|
2013-12-12 10:13:11 +00:00
|
|
|
|
|
|
|
QAbstractItemModel *model() const;
|
|
|
|
QRect screenGeometry() const;
|
|
|
|
bool isVisible() const;
|
|
|
|
bool isAllDesktops() const;
|
|
|
|
int currentIndex() const;
|
|
|
|
void setCurrentIndex(int index);
|
|
|
|
QObject *item() const;
|
|
|
|
void setItem(QObject *item);
|
|
|
|
|
|
|
|
void setVisible(bool visible);
|
|
|
|
void incrementIndex();
|
|
|
|
void decrementIndex();
|
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void visibleChanged();
|
|
|
|
void currentIndexChanged(int index);
|
|
|
|
void modelChanged();
|
|
|
|
void allDesktopsChanged();
|
|
|
|
void screenGeometryChanged();
|
|
|
|
void itemChanged();
|
|
|
|
|
|
|
|
private:
|
|
|
|
QAbstractItemModel *m_model;
|
|
|
|
QObject *m_item;
|
|
|
|
int m_currentIndex;
|
|
|
|
bool m_visible;
|
|
|
|
};
|
|
|
|
|
|
|
|
inline QAbstractItemModel *SwitcherItem::model() const
|
|
|
|
{
|
|
|
|
return m_model;
|
|
|
|
}
|
|
|
|
|
|
|
|
inline bool SwitcherItem::isVisible() const
|
|
|
|
{
|
|
|
|
return m_visible;
|
|
|
|
}
|
|
|
|
|
|
|
|
inline bool SwitcherItem::isAllDesktops() const
|
|
|
|
{
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
inline int SwitcherItem::currentIndex() const
|
|
|
|
{
|
|
|
|
return m_currentIndex;
|
|
|
|
}
|
|
|
|
|
|
|
|
inline QObject *SwitcherItem::item() const
|
|
|
|
{
|
|
|
|
return m_item;
|
|
|
|
}
|
|
|
|
|
2009-09-13 11:36:45 +00:00
|
|
|
} // namespace TabBox
|
|
|
|
} // namespace KWin
|
|
|
|
|
2012-04-09 16:59:26 +00:00
|
|
|
#endif // KWIN_TABBOX_LAYOUTPREVIEW_H
|