2014-10-31 06:53:04 +00:00
|
|
|
/*
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
|
|
|
|
SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
|
|
|
|
*/
|
2014-10-31 06:53:04 +00:00
|
|
|
#ifndef KDECOARTIONS_PREVIEW_SETTINGS_H
|
|
|
|
#define KDECOARTIONS_PREVIEW_SETTINGS_H
|
|
|
|
|
|
|
|
#include <KDecoration2/Private/DecorationSettingsPrivate>
|
|
|
|
#include <KDecoration2/DecorationSettings>
|
|
|
|
#include <QObject>
|
|
|
|
#include <QAbstractListModel>
|
|
|
|
|
|
|
|
namespace KDecoration2
|
|
|
|
{
|
|
|
|
|
|
|
|
namespace Preview
|
|
|
|
{
|
2014-12-09 15:07:27 +00:00
|
|
|
class ButtonsModel;
|
2014-10-31 06:53:04 +00:00
|
|
|
class PreviewBridge;
|
|
|
|
|
|
|
|
class BorderSizesModel : public QAbstractListModel
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
Use nullptr everywhere
Summary:
Because KWin is a very old project, we use three kinds of null pointer
literals: 0, NULL, and nullptr. Since C++11, it's recommended to use
nullptr keyword.
This change converts all usages of 0 and NULL literal to nullptr. Even
though it breaks git history, we need to do it in order to have consistent
code as well to ease code reviews (it's very tempting for some people to
add unrelated changes to their patches, e.g. converting NULL to nullptr).
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson, romangg
Reviewed By: #kwin, davidedmundson, romangg
Subscribers: romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
|
|
|
explicit BorderSizesModel(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~BorderSizesModel() override;
|
2014-10-31 06:53:04 +00:00
|
|
|
QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const override;
|
|
|
|
int rowCount(const QModelIndex& parent = QModelIndex()) const override;
|
|
|
|
QHash< int, QByteArray > roleNames() const override;
|
|
|
|
private:
|
|
|
|
QList<BorderSize> m_borders = QList<BorderSize>({
|
|
|
|
BorderSize::None,
|
|
|
|
BorderSize::NoSides,
|
|
|
|
BorderSize::Tiny,
|
|
|
|
BorderSize::Normal,
|
|
|
|
BorderSize::Large,
|
|
|
|
BorderSize::VeryLarge,
|
|
|
|
BorderSize::Huge,
|
|
|
|
BorderSize::VeryHuge,
|
|
|
|
BorderSize::Oversized
|
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
class PreviewSettings : public QObject, public DecorationSettingsPrivate
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
Q_PROPERTY(bool onAllDesktopsAvailable READ isOnAllDesktopsAvailable WRITE setOnAllDesktopsAvailable NOTIFY onAllDesktopsAvailableChanged)
|
|
|
|
Q_PROPERTY(bool alphaChannelSupported READ isAlphaChannelSupported WRITE setAlphaChannelSupported NOTIFY alphaChannelSupportedChanged)
|
|
|
|
Q_PROPERTY(bool closeOnDoubleClickOnMenu READ isCloseOnDoubleClickOnMenu WRITE setCloseOnDoubleClickOnMenu NOTIFY closeOnDoubleClickOnMenuChanged)
|
|
|
|
Q_PROPERTY(QAbstractItemModel *leftButtonsModel READ leftButtonsModel CONSTANT)
|
|
|
|
Q_PROPERTY(QAbstractItemModel *rightButtonsModel READ rightButtonsModel CONSTANT)
|
|
|
|
Q_PROPERTY(QAbstractItemModel *availableButtonsModel READ availableButtonsModel CONSTANT)
|
|
|
|
Q_PROPERTY(QAbstractItemModel *borderSizesModel READ borderSizesModel CONSTANT)
|
|
|
|
Q_PROPERTY(int borderSizesIndex READ borderSizesIndex WRITE setBorderSizesIndex NOTIFY borderSizesIndexChanged)
|
|
|
|
Q_PROPERTY(QFont font READ font WRITE setFont NOTIFY fontChanged)
|
|
|
|
public:
|
|
|
|
explicit PreviewSettings(DecorationSettings *parent);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~PreviewSettings() override;
|
2014-10-31 06:53:04 +00:00
|
|
|
bool isAlphaChannelSupported() const override;
|
|
|
|
bool isOnAllDesktopsAvailable() const override;
|
|
|
|
bool isCloseOnDoubleClickOnMenu() const override {
|
|
|
|
return m_closeOnDoubleClick;
|
|
|
|
}
|
|
|
|
BorderSize borderSize() const override;
|
|
|
|
|
|
|
|
void setOnAllDesktopsAvailable(bool available);
|
|
|
|
void setAlphaChannelSupported(bool supported);
|
|
|
|
void setCloseOnDoubleClickOnMenu(bool enabled);
|
|
|
|
|
2014-12-09 15:07:27 +00:00
|
|
|
QAbstractItemModel *leftButtonsModel() const;
|
|
|
|
QAbstractItemModel *rightButtonsModel() const;
|
|
|
|
QAbstractItemModel *availableButtonsModel() const;
|
2014-10-31 06:53:04 +00:00
|
|
|
QAbstractItemModel *borderSizesModel() const {
|
|
|
|
return m_borderSizes;
|
|
|
|
}
|
|
|
|
|
2014-12-01 10:53:44 +00:00
|
|
|
QVector< DecorationButtonType > decorationButtonsLeft() const override;
|
|
|
|
QVector< DecorationButtonType > decorationButtonsRight() const override;
|
2014-10-31 06:53:04 +00:00
|
|
|
|
|
|
|
Q_INVOKABLE void addButtonToLeft(int row);
|
|
|
|
Q_INVOKABLE void addButtonToRight(int row);
|
|
|
|
|
|
|
|
int borderSizesIndex() const {
|
|
|
|
return m_borderSize;
|
|
|
|
}
|
|
|
|
void setBorderSizesIndex(int index);
|
|
|
|
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
QFont font() const override {
|
2014-10-31 06:53:04 +00:00
|
|
|
return m_font;
|
|
|
|
}
|
|
|
|
void setFont(const QFont &font);
|
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void onAllDesktopsAvailableChanged(bool);
|
|
|
|
void alphaChannelSupportedChanged(bool);
|
|
|
|
void closeOnDoubleClickOnMenuChanged(bool);
|
|
|
|
void borderSizesIndexChanged(int);
|
|
|
|
void fontChanged(const QFont &);
|
|
|
|
|
|
|
|
private:
|
|
|
|
bool m_alphaChannelSupported;
|
|
|
|
bool m_onAllDesktopsAvailable;
|
|
|
|
bool m_closeOnDoubleClick;
|
|
|
|
ButtonsModel *m_leftButtons;
|
|
|
|
ButtonsModel *m_rightButtons;
|
|
|
|
ButtonsModel *m_availableButtons;
|
|
|
|
BorderSizesModel *m_borderSizes;
|
|
|
|
int m_borderSize;
|
|
|
|
QFont m_font;
|
|
|
|
};
|
|
|
|
|
|
|
|
class Settings : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
Q_PROPERTY(KDecoration2::Preview::PreviewBridge *bridge READ bridge WRITE setBridge NOTIFY bridgeChanged)
|
|
|
|
Q_PROPERTY(KDecoration2::DecorationSettings *settings READ settingsPointer NOTIFY settingsChanged)
|
2014-12-04 15:28:06 +00:00
|
|
|
Q_PROPERTY(int borderSizesIndex READ borderSizesIndex WRITE setBorderSizesIndex NOTIFY borderSizesIndexChanged)
|
2014-10-31 06:53:04 +00:00
|
|
|
public:
|
|
|
|
explicit Settings(QObject *parent = nullptr);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~Settings() override;
|
2014-10-31 06:53:04 +00:00
|
|
|
|
|
|
|
PreviewBridge *bridge() const;
|
|
|
|
void setBridge(PreviewBridge *bridge);
|
|
|
|
|
|
|
|
QSharedPointer<DecorationSettings> settings() const;
|
|
|
|
DecorationSettings *settingsPointer() const;
|
2014-12-04 15:28:06 +00:00
|
|
|
int borderSizesIndex() const {
|
|
|
|
return m_borderSize;
|
|
|
|
}
|
|
|
|
void setBorderSizesIndex(int index);
|
2014-10-31 06:53:04 +00:00
|
|
|
|
|
|
|
Q_SIGNALS:
|
|
|
|
void bridgeChanged();
|
|
|
|
void settingsChanged();
|
2014-12-04 15:28:06 +00:00
|
|
|
void borderSizesIndexChanged(int);
|
2014-10-31 06:53:04 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void createSettings();
|
|
|
|
QPointer<PreviewBridge> m_bridge;
|
|
|
|
QSharedPointer<KDecoration2::DecorationSettings> m_settings;
|
2014-12-04 15:28:06 +00:00
|
|
|
PreviewSettings *m_previewSettings = nullptr;
|
|
|
|
int m_borderSize = 3;
|
2014-10-31 06:53:04 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|