kwin/src/backends/drm/drm_buffer.h

68 lines
1.3 KiB
C
Raw Normal View History

2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
#ifndef KWIN_DRM_BUFFER_H
#define KWIN_DRM_BUFFER_H
#include <QImage>
#include <QSize>
namespace KWin
{
class DrmGpu;
class DrmBuffer
{
public:
DrmBuffer(DrmGpu *gpu, uint32_t format, uint64_t modifier);
virtual ~DrmBuffer() = default;
virtual bool needsModeChange(DrmBuffer *b) const {Q_UNUSED(b) return false;}
quint32 bufferId() const;
const QSize &size() const;
DrmGpu *gpu() const;
uint32_t format() const;
uint64_t modifier() const;
protected:
quint32 m_bufferId = 0;
QSize m_size;
DrmGpu *m_gpu;
uint32_t m_format;
uint64_t m_modifier;
};
class DrmDumbBuffer : public DrmBuffer
{
public:
DrmDumbBuffer(DrmGpu *gpu, const QSize &size, uint32_t drmFormat);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~DrmDumbBuffer() override;
bool needsModeChange(DrmBuffer *b) const override;
bool map(QImage::Format format = QImage::Format_RGB32);
quint32 handle() const;
QImage *image() const;
void *data() const;
quint32 stride() const;
private:
quint32 m_handle = 0;
quint64 m_bufferSize = 0;
void *m_memory = nullptr;
QImage *m_image = nullptr;
quint32 m_stride = 0;
};
}
#endif