2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2016-03-21 14:11:17 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2015 Martin Gräßlin <mgraesslin@kde.org>
|
2016-03-21 14:11:17 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2016-03-21 14:11:17 +00:00
|
|
|
#ifndef KWIN_DRM_BUFFER_H
|
|
|
|
#define KWIN_DRM_BUFFER_H
|
|
|
|
|
|
|
|
#include <QImage>
|
|
|
|
#include <QSize>
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
2021-03-22 10:43:24 +00:00
|
|
|
class DrmGpu;
|
|
|
|
|
2021-03-29 11:17:44 +00:00
|
|
|
class DrmBuffer
|
2016-03-21 14:11:17 +00:00
|
|
|
{
|
|
|
|
public:
|
2021-09-17 09:01:18 +00:00
|
|
|
DrmBuffer(DrmGpu *gpu, uint32_t format, uint64_t modifier);
|
2017-05-09 19:00:33 +00:00
|
|
|
virtual ~DrmBuffer() = default;
|
2016-03-21 14:11:17 +00:00
|
|
|
|
2017-05-09 19:00:33 +00:00
|
|
|
virtual bool needsModeChange(DrmBuffer *b) const {Q_UNUSED(b) return false;}
|
|
|
|
|
2021-12-14 15:32:55 +00:00
|
|
|
quint32 bufferId() const;
|
|
|
|
const QSize &size() const;
|
|
|
|
DrmGpu *gpu() const;
|
|
|
|
uint32_t format() const;
|
|
|
|
uint64_t modifier() const;
|
2017-11-12 20:00:02 +00:00
|
|
|
|
2017-05-09 19:00:33 +00:00
|
|
|
protected:
|
|
|
|
quint32 m_bufferId = 0;
|
|
|
|
QSize m_size;
|
2021-03-22 10:43:24 +00:00
|
|
|
DrmGpu *m_gpu;
|
2021-09-17 09:01:18 +00:00
|
|
|
uint32_t m_format;
|
|
|
|
uint64_t m_modifier;
|
2017-05-09 19:00:33 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
class DrmDumbBuffer : public DrmBuffer
|
|
|
|
{
|
|
|
|
public:
|
2021-12-02 16:51:08 +00:00
|
|
|
DrmDumbBuffer(DrmGpu *gpu, const QSize &size, uint32_t drmFormat);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~DrmDumbBuffer() override;
|
2017-05-09 19:00:33 +00:00
|
|
|
|
|
|
|
bool needsModeChange(DrmBuffer *b) const override;
|
|
|
|
|
|
|
|
bool map(QImage::Format format = QImage::Format_RGB32);
|
2021-12-14 15:32:55 +00:00
|
|
|
quint32 handle() const;
|
|
|
|
QImage *image() const;
|
|
|
|
void *data() const;
|
|
|
|
quint32 stride() const;
|
2016-03-21 14:11:17 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
quint32 m_handle = 0;
|
|
|
|
quint64 m_bufferSize = 0;
|
|
|
|
void *m_memory = nullptr;
|
|
|
|
QImage *m_image = nullptr;
|
2017-05-09 19:00:33 +00:00
|
|
|
quint32 m_stride = 0;
|
2016-03-21 14:11:17 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|