yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/test_scripted_effectloader.cpp

465 lines
22 KiB
C++
Raw Normal View History

Prettify license headers
2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2014 Martin Gräßlin <mgraesslin@kde.org>
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
Prettify license headers
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
#include "../effectloader.h"
#include "mock_effectshandler.h"
#include "../scripting/scriptedeffect.h"
// for mocking
Port some displayWidth/displayHeight usages to Screens::size() Summary: KWin::displayWidth and KWin::displayHeight are bound to X11 which doesn't make much sense on X11. In addition KWin internally knows the overall display dimensions through the Screens singleton class. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D1798
2016-06-08 10:46:02 +00:00
#include "../cursor.h"
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
#include "../input.h"
#include "../screenedge.h"
// KDE
#include <KConfig>
#include <KConfigGroup>
Port scripted effect loading from KService to KPackage Advantage: no more ksycoca cache for loading scripted effects.
2015-07-06 14:50:33 +00:00
#include <KPackage/PackageLoader>
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// Qt
Remove Qt module declarations in includes Summary: Test Plan: Compiles Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13359
2018-06-05 10:52:57 +00:00
#include <QtTest>
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
#include <QStringList>
Q_DECLARE_METATYPE(KWin::LoadEffectFlag)
Q_DECLARE_METATYPE(KWin::LoadEffectFlags)
Q_DECLARE_METATYPE(KWin::Effect*)
Fix for failing testScriptedEffectsLoader By changing the loading of scripted effect config to interact with kwinApp we broke the tests which do not use a kwinApp. This change turns the access to the KSharedConfigPtr go through the property system, so that the tests can also install a dummy KSharedConfigPtr. With that scripted effects loader test passes and no longer crashes and the integration/effects tests also still pass.
2016-11-16 15:53:17 +00:00
Q_DECLARE_METATYPE(KSharedConfigPtr)
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
Introduce categorized logging for kwin core Done by Daniel Pastushchak for KDE during GCI-2014.
2014-12-05 10:42:15 +00:00
Q_LOGGING_CATEGORY(KWIN_CORE, "kwin_core")
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
namespace KWin
{
ScreenEdges *ScreenEdges::s_self = nullptr;
void ScreenEdges::reserve(ElectricBorder, QObject *, const char *)
{
}
Add support for new touch screen callbacks to KWin scripts and scripted effects Summary: Exposes two new global JS functions to register and unregister touch screen edges. Test Plan: Added test case Reviewers: #kwin, #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D5277
2017-04-02 13:42:18 +00:00
void ScreenEdges::reserveTouch(ElectricBorder, QAction *)
{
}
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
InputRedirection *InputRedirection::s_self = nullptr;
void InputRedirection::registerShortcut(const QKeySequence &, QAction *)
{
}
namespace MetaScripting
{
void registration(QScriptEngine *)
{
}
}
}
class TestScriptedEffectLoader : public QObject
{
Q_OBJECT
private Q_SLOTS:
Fix for failing testScriptedEffectsLoader By changing the loading of scripted effect config to interact with kwinApp we broke the tests which do not use a kwinApp. This change turns the access to the KSharedConfigPtr go through the property system, so that the tests can also install a dummy KSharedConfigPtr. With that scripted effects loader test passes and no longer crashes and the integration/effects tests also still pass.
2016-11-16 15:53:17 +00:00
void initTestCase();
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
void testHasEffect_data();
void testHasEffect();
void testKnownEffects();
void testLoadEffect_data();
void testLoadEffect();
void testLoadScriptedEffect_data();
void testLoadScriptedEffect();
void testLoadAllEffects();
Cancel the EffectLoader query on clear The Scripted and PluginEffectLoader perform locating all effects which are to be loaded in a thread. When the EffectLoader gets cleared so far the query did not get canceled. This resulted in effects maybe getting loaded. This problems shows on build.kde.org if the test is too fast and tears down the Effect system while effects are still being queried. Reviewed-By: David Edmundson
2016-04-26 12:55:47 +00:00
void testCancelLoadAllEffects();
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
};
Fix for failing testScriptedEffectsLoader By changing the loading of scripted effect config to interact with kwinApp we broke the tests which do not use a kwinApp. This change turns the access to the KSharedConfigPtr go through the property system, so that the tests can also install a dummy KSharedConfigPtr. With that scripted effects loader test passes and no longer crashes and the integration/effects tests also still pass.
2016-11-16 15:53:17 +00:00
void TestScriptedEffectLoader::initTestCase()
{
Fix test of scriptedeffectsloader when run from build directory without install Summary: On build.kde.org all tests loading scripted effects are failing. This seems to be because the effects are not installed. To make this work, this change introduces the following changes: * scripted effects are copied to ${build}/bin, like all binaries * the test sets XDG_DATA_DIRS env variable to point to ${build}/bin This change also needs to be added to further tests once this is accepted. Furthermore it could be considered whether KPackageLoader should consider the QCoreApplication::applicationDirPath in addition to the GenericDataLocation. This would make KPackageLoader work much better in a build tree only setup. Test Plan: Test passes locally, obviously not tried on build.kde.org Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16682
2018-11-05 13:08:12 +00:00
qputenv("XDG_DATA_DIRS", QCoreApplication::applicationDirPath().toUtf8());
Fix for failing testScriptedEffectsLoader By changing the loading of scripted effect config to interact with kwinApp we broke the tests which do not use a kwinApp. This change turns the access to the KSharedConfigPtr go through the property system, so that the tests can also install a dummy KSharedConfigPtr. With that scripted effects loader test passes and no longer crashes and the integration/effects tests also still pass.
2016-11-16 15:53:17 +00:00
auto config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
QCoreApplication::instance()->setProperty("config", QVariant::fromValue(config));
Make it possible to have a separate cursor for the tablet Summary: As is KWin only had 1 Cursor which was a singleton. This made it impossible for us to properly implement the tablet (as in drawing tablets) support and show where we're drawing. This patch makes it possible to have different Cursors in KWin, it makes all the current code still follow the mouse but the tablet can still render a cursor. Test Plan: Tests pass, been using it and works as well as before but with beautiful tablet cursors. Reviewers: #kwin, cblack, davidedmundson Reviewed By: #kwin, cblack, davidedmundson Subscribers: davidedmundson, cblack, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D28155
2020-04-02 16:18:01 +00:00
KWin::Cursors::self()->setMouse(new KWin::Cursor(this));
Fix for failing testScriptedEffectsLoader By changing the loading of scripted effect config to interact with kwinApp we broke the tests which do not use a kwinApp. This change turns the access to the KSharedConfigPtr go through the property system, so that the tests can also install a dummy KSharedConfigPtr. With that scripted effects loader test passes and no longer crashes and the integration/effects tests also still pass.
2016-11-16 15:53:17 +00:00
}
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
void TestScriptedEffectLoader::testHasEffect_data()
{
QTest::addColumn<QString>("name");
QTest::addColumn<bool>("expected");
// all the built-in effects should fail
QTest::newRow("blur") << QStringLiteral("blur") << false;
[effects] Add a colorpicker effect Summary: The effect exports itself to DBus as object "/ColorPicker" and provides an own interface "org.kde.kwin.ColorPicker". It has one exported method to DBus "pick" which returns a QColor. When invoked an interactive position picking selection is started. If it ends the effect reads the color value at the picked position from the OpenGL color buffer. This implements T4568. Reviewers: #kwin, #plasma_on_wayland, broulik Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3480
2016-11-24 07:07:51 +00:00
QTest::newRow("Colorpicker") << QStringLiteral("colorpicker") << false;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
QTest::newRow("Contrast") << QStringLiteral("contrast") << false;
QTest::newRow("CoverSwitch") << QStringLiteral("coverswitch") << false;
QTest::newRow("Cube") << QStringLiteral("cube") << false;
QTest::newRow("CubeSlide") << QStringLiteral("cubeslide") << false;
QTest::newRow("DesktopGrid") << QStringLiteral("desktopgrid") << false;
QTest::newRow("DimInactive") << QStringLiteral("diminactive") << false;
QTest::newRow("FallApart") << QStringLiteral("fallapart") << false;
QTest::newRow("FlipSwitch") << QStringLiteral("flipswitch") << false;
QTest::newRow("Glide") << QStringLiteral("glide") << false;
QTest::newRow("HighlightWindow") << QStringLiteral("highlightwindow") << false;
QTest::newRow("Invert") << QStringLiteral("invert") << false;
QTest::newRow("Kscreen") << QStringLiteral("kscreen") << false;
QTest::newRow("Logout") << QStringLiteral("logout") << false;
QTest::newRow("LookingGlass") << QStringLiteral("lookingglass") << false;
QTest::newRow("MagicLamp") << QStringLiteral("magiclamp") << false;
QTest::newRow("Magnifier") << QStringLiteral("magnifier") << false;
QTest::newRow("MouseClick") << QStringLiteral("mouseclick") << false;
QTest::newRow("MouseMark") << QStringLiteral("mousemark") << false;
QTest::newRow("PresentWindows") << QStringLiteral("presentwindows") << false;
QTest::newRow("Resize") << QStringLiteral("resize") << false;
QTest::newRow("ScreenEdge") << QStringLiteral("screenedge") << false;
QTest::newRow("ScreenShot") << QStringLiteral("screenshot") << false;
QTest::newRow("Sheet") << QStringLiteral("sheet") << false;
QTest::newRow("ShowFps") << QStringLiteral("showfps") << false;
QTest::newRow("ShowPaint") << QStringLiteral("showpaint") << false;
QTest::newRow("Slide") << QStringLiteral("slide") << false;
QTest::newRow("SlideBack") << QStringLiteral("slideback") << false;
QTest::newRow("SlidingPopups") << QStringLiteral("slidingpopups") << false;
QTest::newRow("SnapHelper") << QStringLiteral("snaphelper") << false;
QTest::newRow("StartupFeedback") << QStringLiteral("startupfeedback") << false;
QTest::newRow("ThumbnailAside") << QStringLiteral("thumbnailaside") << false;
QTest::newRow("TrackMouse") << QStringLiteral("trackmouse") << false;
QTest::newRow("WindowGeometry") << QStringLiteral("windowgeometry") << false;
QTest::newRow("WobblyWindows") << QStringLiteral("wobblywindows") << false;
QTest::newRow("Zoom") << QStringLiteral("zoom") << false;
QTest::newRow("Non Existing") << QStringLiteral("InvalidName") << false;
QTest::newRow("Fade - without kwin4_effect") << QStringLiteral("fade") << false;
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
QTest::newRow("DialogParent") << QStringLiteral("kwin4_effect_dialogparent") << true;
QTest::newRow("DimScreen") << QStringLiteral("kwin4_effect_dimscreen") << true;
QTest::newRow("EyeOnScreen") << QStringLiteral("kwin4_effect_eyeonscreen") << true;
QTest::newRow("Fade + kwin4_effect") << QStringLiteral("kwin4_effect_fade") << true;
QTest::newRow("Fade + kwin4_effect + CS") << QStringLiteral("kwin4_eFfect_fAde") << true;
QTest::newRow("FadeDesktop") << QStringLiteral("kwin4_effect_fadedesktop") << true;
QTest::newRow("FadingPopups") << QStringLiteral("kwin4_effect_fadingpopups") << true;
QTest::newRow("FrozenApp") << QStringLiteral("kwin4_effect_frozenapp") << true;
[effects/fullscreen] Add effect that animates full screen changes Just a slightly altered copy of the maximize effect
2020-08-05 20:33:01 +00:00
QTest::newRow("FullScreen") << QStringLiteral("kwin4_effect_fullscreen") << true;
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
QTest::newRow("Login") << QStringLiteral("kwin4_effect_login") << true;
QTest::newRow("Logout") << QStringLiteral("kwin4_effect_logout") << true;
QTest::newRow("Maximize") << QStringLiteral("kwin4_effect_maximize") << true;
QTest::newRow("MorphingPopups") << QStringLiteral("kwin4_effect_morphingpopups") << true;
QTest::newRow("Scale") << QStringLiteral("kwin4_effect_scale") << true;
QTest::newRow("Squash") << QStringLiteral("kwin4_effect_squash") << true;
QTest::newRow("Translucency") << QStringLiteral("kwin4_effect_translucency") << true;
QTest::newRow("WindowAperture") << QStringLiteral("kwin4_effect_windowaperture") << true;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
}
void TestScriptedEffectLoader::testHasEffect()
{
QFETCH(QString, name);
QFETCH(bool, expected);
[autotests] Make lifespan of EffectsHandler outlive Effect Summary: In loading tests. Effects are deleted in a deleteLater potentially outside the scope of our test. Our MockEffectsHandler (which contains the global static "effects") has the lifespan of the test. Fixes failing unit test. Test Plan: Ran test Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15167
2018-08-30 11:48:23 +00:00
QScopedPointer<MockEffectsHandler, QScopedPointerDeleteLater> mockHandler(new MockEffectsHandler(KWin::XRenderCompositing));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
KWin::ScriptedEffectLoader loader;
QCOMPARE(loader.hasEffect(name), expected);
// each available effect should also be supported
QCOMPARE(loader.isEffectSupported(name), expected);
Introduce an EffectsHandler::animationsSupported -> bool Summary: A new method to tell the effects system whether the compositor scene is able to drive animations. E.g. on software emulation (llvmpipe) it's better to not do any animations at all. This information can be used by effects to adjust their behavior, e.g. PresentWindows could skip transitions or effects can use it in their supported check to completely disable themselves. As a first step all scripted effects are considered to be unsupported if animations are not supported. They inherit AnimationEffect and are all about driving animations. The information whether animations are supported comes from the Scene. It's implemented in the following way: * XRender: animations are always supported * QPainter: animations are never supported * OpenGL: animations are supported, except for software emulation In addition - for easier testing - there is a new env variable KWIN_EFFECTS_FORCE_ANIMATIONS to overwrite the selection. Reviewers: #kwin, #plasma Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2386
2016-08-10 07:24:53 +00:00
if (expected) {
[autotests] Make lifespan of EffectsHandler outlive Effect Summary: In loading tests. Effects are deleted in a deleteLater potentially outside the scope of our test. Our MockEffectsHandler (which contains the global static "effects") has the lifespan of the test. Fixes failing unit test. Test Plan: Ran test Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15167
2018-08-30 11:48:23 +00:00
mockHandler->setAnimationsSupported(false);
Introduce an EffectsHandler::animationsSupported -> bool Summary: A new method to tell the effects system whether the compositor scene is able to drive animations. E.g. on software emulation (llvmpipe) it's better to not do any animations at all. This information can be used by effects to adjust their behavior, e.g. PresentWindows could skip transitions or effects can use it in their supported check to completely disable themselves. As a first step all scripted effects are considered to be unsupported if animations are not supported. They inherit AnimationEffect and are all about driving animations. The information whether animations are supported comes from the Scene. It's implemented in the following way: * XRender: animations are always supported * QPainter: animations are never supported * OpenGL: animations are supported, except for software emulation In addition - for easier testing - there is a new env variable KWIN_EFFECTS_FORCE_ANIMATIONS to overwrite the selection. Reviewers: #kwin, #plasma Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D2386
2016-08-10 07:24:53 +00:00
QVERIFY(!loader.isEffectSupported(name));
}
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
}
void TestScriptedEffectLoader::testKnownEffects()
{
QStringList expectedEffects;
expectedEffects << QStringLiteral("kwin4_effect_dialogparent")
[effects/dimscreen] Port to JavaScript Summary: The ported effect looks quite similar to the C++ version except one thing: it works correctly when user activates/deactivates a full screen effect, for example the Desktop Cube effect. Other than that, there are no behavioral or visual differences. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16452
2018-10-25 13:48:47 +00:00
<< QStringLiteral("kwin4_effect_dimscreen")
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
<< QStringLiteral("kwin4_effect_eyeonscreen")
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
<< QStringLiteral("kwin4_effect_fade")
<< QStringLiteral("kwin4_effect_fadedesktop")
[effects] Split the Fade effect Summary: Currently, we have three effects that can be used to animate the appearing of toplevel windows(fade, glide, scale) and one can enable all three of them, which seems to be wrong. It doesn't make sense to have glide and scale effect enabled, for example. We couldn't put all three effects into an exclusive group before because the fade effect animates not only toplevel windows but also popups. So, if all three effects are in an exclusive group and you enable glide effect, for example, then tooltips and other popups won't be faded in/out. This patch splits the fade effect into two: the first effect (called Fade) animates toplevel windows and the other one (called Fading Popups) animates popup windows. Test Plan: Have been using the Fading Popups effect in combination with the Scale effect for a couple of days. Haven't noticed any significant differences between the new combination (Fading Popups + Scale) and the old combination (Fade + Scale). Reviewers: #kwin, #plasma, #vdg, graesslin Reviewed By: #kwin, #plasma, graesslin Subscribers: graesslin, abetts, ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16836
2018-11-03 15:42:31 +00:00
<< QStringLiteral("kwin4_effect_fadingpopups")
Desaturate non-responsive windows When an application is not responding, its window is desaturated to communicate this. Also "(Not Responding)" is added to the title bar. Differential Revision: https://phabricator.kde.org/D5245
2017-04-05 09:16:23 +00:00
<< QStringLiteral("kwin4_effect_frozenapp")
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
<< QStringLiteral("kwin4_effect_login")
new logout effect Summary: new logout effect: it's just a slow fade in of the logout greeter (window is usable immediately tough Test Plan: logout greeter now fades in without setting the window opacity manually Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: broulik, plasma-devel, kwin, #kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D5045
2017-03-15 16:47:13 +00:00
<< QStringLiteral("kwin4_effect_logout")
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
<< QStringLiteral("kwin4_effect_maximize")
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
<< QStringLiteral("kwin4_effect_morphingpopups")
[effects/scale] Port to JavaScript Summary: Now, when the scripting effects API has all required ingredients to port the Scale effect to JavaScript we finally can do it. The main rationale for porting this effect to JavaScript is that scripted effects API lets us focus more on what we want instead of "how". Visually, the ported version doesn't deviate from the C++ version. Test Plan: * Enable the Scale effect; * Open/close a window. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: graesslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16478
2018-10-27 21:27:25 +00:00
<< QStringLiteral("kwin4_effect_scale")
Update tests to include newly added session quit effect
2019-11-05 15:02:59 +00:00
<< QStringLiteral("kwin4_effect_sessionquit")
[effects] Re-implement the Minimize Animation effect in JavaScript Summary: There were several reasons to rewrite the Minimize Animation effect in JavaScript: to simplify code and to get rid of full repaints. One could say that nothing prevents us from calculating the dirty region in postPaintScreen or postPaintWindow and it is correct, but with the scripting effects API the dirty region will be calculated for us, so we can focus more on "what we want" instead of "how". Visually, the "old" effect and the rewritten one look quite the same. Except one tiny bit: if a window doesn't have an icon in the task manager, it won't be animated. The reason for that is the purpose of this effect is to show where the window will be after it's minimized, if the window doesn't have icon in the task manager, one can't click at the center of the screen to unminimize the window. There is one significant change, the name of the effect was changed to "Squash". If we put this effect and the Magic lamp effect under "Window Minimize Animation" category (or if we add some "heading" label), then the old name and the name of the category would "conflict". The new name was suggested by Nate Graham and it very closely describes what the effect does. "Scale" doesn't fit this effect because while a window is being animated, its aspect ratio is not preserved. Reviewers: #kwin, #plasma, davidedmundson Reviewed By: #kwin, #plasma, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16372
2018-09-23 17:07:48 +00:00
<< QStringLiteral("kwin4_effect_squash")
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
<< QStringLiteral("kwin4_effect_translucency")
<< QStringLiteral("kwin4_effect_windowaperture");
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
KWin::ScriptedEffectLoader loader;
QStringList result = loader.listOfKnownEffects();
// at least as many effects as we expect - system running the test could have more effects
QVERIFY(result.size() >= expectedEffects.size());
for (const QString &effect : expectedEffects) {
QVERIFY(result.contains(effect));
}
}
void TestScriptedEffectLoader::testLoadEffect_data()
{
QTest::addColumn<QString>("name");
QTest::addColumn<bool>("expected");
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
QTest::newRow("Non Existing") << QStringLiteral("InvalidName") << false;
QTest::newRow("Fade - without kwin4_effect") << QStringLiteral("fade") << false;
QTest::newRow("DialogParent") << QStringLiteral("kwin4_effect_dialogparent") << true;
QTest::newRow("DimScreen") << QStringLiteral("kwin4_effect_dimscreen") << true;
QTest::newRow("EyeOnScreen") << QStringLiteral("kwin4_effect_eyeonscreen") << true;
QTest::newRow("Fade + kwin4_effect") << QStringLiteral("kwin4_effect_fade") << true;
QTest::newRow("Fade + kwin4_effect + CS") << QStringLiteral("kwin4_eFfect_fAde") << true;
QTest::newRow("FadeDesktop") << QStringLiteral("kwin4_effect_fadedesktop") << true;
QTest::newRow("FadingPopups") << QStringLiteral("kwin4_effect_fadingpopups") << true;
QTest::newRow("FrozenApp") << QStringLiteral("kwin4_effect_frozenapp") << true;
[effects/fullscreen] Add effect that animates full screen changes Just a slightly altered copy of the maximize effect
2020-08-05 20:33:01 +00:00
QTest::newRow("FullScreen") << QStringLiteral("kwin4_effect_fullscreen") << true;
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
QTest::newRow("Login") << QStringLiteral("kwin4_effect_login") << true;
QTest::newRow("Logout") << QStringLiteral("kwin4_effect_logout") << true;
QTest::newRow("Maximize") << QStringLiteral("kwin4_effect_maximize") << true;
QTest::newRow("MorphingPopups") << QStringLiteral("kwin4_effect_morphingpopups") << true;
QTest::newRow("Scale") << QStringLiteral("kwin4_effect_scale") << true;
Update tests to include newly added session quit effect
2019-11-05 15:02:59 +00:00
QTest::newRow("SessionQuit") << QStringLiteral("kwin4_effect_sessionquit") << true;
[autotests] Test all scripted effects Summary: TestPluginEffectLoader and TestScriptedEffectLoader don't check some scripted effects (eye on screen, morphing popups, and window aperture). Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D17072
2018-11-21 12:22:32 +00:00
QTest::newRow("Squash") << QStringLiteral("kwin4_effect_squash") << true;
QTest::newRow("Translucency") << QStringLiteral("kwin4_effect_translucency") << true;
QTest::newRow("WindowAperture") << QStringLiteral("kwin4_effect_windowaperture") << true;
Update tests to include newly added session quit effect
2019-11-05 15:02:59 +00:00
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
}
void TestScriptedEffectLoader::testLoadEffect()
{
QFETCH(QString, name);
QFETCH(bool, expected);
[autotests] Make lifespan of EffectsHandler outlive Effect Summary: In loading tests. Effects are deleted in a deleteLater potentially outside the scope of our test. Our MockEffectsHandler (which contains the global static "effects") has the lifespan of the test. Fixes failing unit test. Test Plan: Ran test Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15167
2018-08-30 11:48:23 +00:00
QScopedPointer<MockEffectsHandler, QScopedPointerDeleteLater> mockHandler(new MockEffectsHandler(KWin::XRenderCompositing));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
KWin::ScriptedEffectLoader loader;
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
loader.setConfig(config);
qRegisterMetaType<KWin::Effect*>();
autotests: Port QSignalSpies to new connect syntax
2019-07-29 19:45:19 +00:00
QSignalSpy spy(&loader, &KWin::ScriptedEffectLoader::effectLoaded);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// connect to signal to ensure that we delete the Effect again as the Effect doesn't have a parent
connect(&loader, &KWin::ScriptedEffectLoader::effectLoaded,
[&name](KWin::Effect *effect, const QString &effectName) {
QCOMPARE(effectName, name.toLower());
effect->deleteLater();
}
);
// try to load the Effect
QCOMPARE(loader.loadEffect(name), expected);
// loading again should fail
QVERIFY(!loader.loadEffect(name));
// signal spy should have got the signal if it was expected
QCOMPARE(spy.isEmpty(), !expected);
if (!spy.isEmpty()) {
QCOMPARE(spy.count(), 1);
// if we caught a signal it should have the effect name we passed in
QList<QVariant> arguments = spy.takeFirst();
QCOMPARE(arguments.count(), 2);
QCOMPARE(arguments.at(1).toString(), name.toLower());
}
spy.clear();
QVERIFY(spy.isEmpty());
// now if we wait for the events being processed, the effect will get deleted and it should load again
QTest::qWait(1);
QCOMPARE(loader.loadEffect(name), expected);
// signal spy should have got the signal if it was expected
QCOMPARE(spy.isEmpty(), !expected);
if (!spy.isEmpty()) {
QCOMPARE(spy.count(), 1);
// if we caught a signal it should have the effect name we passed in
QList<QVariant> arguments = spy.takeFirst();
QCOMPARE(arguments.count(), 2);
QCOMPARE(arguments.at(1).toString(), name.toLower());
}
}
void TestScriptedEffectLoader::testLoadScriptedEffect_data()
{
QTest::addColumn<QString>("name");
QTest::addColumn<bool>("expected");
QTest::addColumn<KWin::LoadEffectFlags>("loadFlags");
const KWin::LoadEffectFlags checkDefault = KWin::LoadEffectFlag::Load | KWin::LoadEffectFlag::CheckDefaultFunction;
const KWin::LoadEffectFlags forceFlags = KWin::LoadEffectFlag::Load;
const KWin::LoadEffectFlags dontLoadFlags = KWin::LoadEffectFlags();
// enabled by default
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QTest::newRow("Fade") << QStringLiteral("kwin4_effect_fade") << true << checkDefault;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// not enabled by default
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QTest::newRow("EyeOnScreen") << QStringLiteral("kwin4_effect_eyeonscreen") << true << checkDefault;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// Force an Effect which will load
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QTest::newRow("EyeOnScreen-Force") << QStringLiteral("kwin4_effect_eyeonscreen") << true << forceFlags;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// Enforce no load of effect which is enabled by default
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QTest::newRow("Fade-DontLoad") << QStringLiteral("kwin4_effect_fade") << false << dontLoadFlags;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// Enforce no load of effect which is not enabled by default, but enforced
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QTest::newRow("EyeOnScreen-DontLoad") << QStringLiteral("kwin4_effect_eyeonscreen") << false << dontLoadFlags;
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
}
void TestScriptedEffectLoader::testLoadScriptedEffect()
{
QFETCH(QString, name);
QFETCH(bool, expected);
QFETCH(KWin::LoadEffectFlags, loadFlags);
[autotests] Make lifespan of EffectsHandler outlive Effect Summary: In loading tests. Effects are deleted in a deleteLater potentially outside the scope of our test. Our MockEffectsHandler (which contains the global static "effects") has the lifespan of the test. Fixes failing unit test. Test Plan: Ran test Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15167
2018-08-30 11:48:23 +00:00
QScopedPointer<MockEffectsHandler, QScopedPointerDeleteLater> mockHandler(new MockEffectsHandler(KWin::XRenderCompositing));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
KWin::ScriptedEffectLoader loader;
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
loader.setConfig(config);
Port scripted effect loading from KService to KPackage Advantage: no more ksycoca cache for loading scripted effects.
2015-07-06 14:50:33 +00:00
const auto services = KPackage::PackageLoader::self()->findPackages(QStringLiteral("KWin/Effect"), QStringLiteral("kwin/effects"),
[name] (const KPluginMetaData &metadata) {
return metadata.pluginId().compare(name, Qt::CaseInsensitive) == 0;
}
);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
QCOMPARE(services.count(), 1);
qRegisterMetaType<KWin::Effect*>();
autotests: Port QSignalSpies to new connect syntax
2019-07-29 19:45:19 +00:00
QSignalSpy spy(&loader, &KWin::ScriptedEffectLoader::effectLoaded);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// connect to signal to ensure that we delete the Effect again as the Effect doesn't have a parent
connect(&loader, &KWin::ScriptedEffectLoader::effectLoaded,
[&name](KWin::Effect *effect, const QString &effectName) {
QCOMPARE(effectName, name.toLower());
effect->deleteLater();
}
);
// try to load the Effect
QCOMPARE(loader.loadEffect(services.first(), loadFlags), expected);
// loading again should fail
QVERIFY(!loader.loadEffect(services.first(), loadFlags));
// signal spy should have got the signal if it was expected
QCOMPARE(spy.isEmpty(), !expected);
if (!spy.isEmpty()) {
QCOMPARE(spy.count(), 1);
// if we caught a signal it should have the effect name we passed in
QList<QVariant> arguments = spy.takeFirst();
QCOMPARE(arguments.count(), 2);
QCOMPARE(arguments.at(1).toString(), name.toLower());
}
spy.clear();
QVERIFY(spy.isEmpty());
// now if we wait for the events being processed, the effect will get deleted and it should load again
QTest::qWait(1);
QCOMPARE(loader.loadEffect(services.first(), loadFlags), expected);
// signal spy should have got the signal if it was expected
QCOMPARE(spy.isEmpty(), !expected);
if (!spy.isEmpty()) {
QCOMPARE(spy.count(), 1);
// if we caught a signal it should have the effect name we passed in
QList<QVariant> arguments = spy.takeFirst();
QCOMPARE(arguments.count(), 2);
QCOMPARE(arguments.at(1).toString(), name.toLower());
}
}
void TestScriptedEffectLoader::testLoadAllEffects()
{
[autotests] Make lifespan of EffectsHandler outlive Effect Summary: In loading tests. Effects are deleted in a deleteLater potentially outside the scope of our test. Our MockEffectsHandler (which contains the global static "effects") has the lifespan of the test. Fixes failing unit test. Test Plan: Ran test Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D15167
2018-08-30 11:48:23 +00:00
QScopedPointer<MockEffectsHandler, QScopedPointerDeleteLater> mockHandler(new MockEffectsHandler(KWin::XRenderCompositing));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
KWin::ScriptedEffectLoader loader;
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
const QString kwin4 = QStringLiteral("kwin4_effect_");
// prepare the configuration to hard enable/disable the effects we want to load
KConfigGroup plugins = config->group("Plugins");
plugins.writeEntry(kwin4 + QStringLiteral("dialogparentEnabled"), false);
[effects/dimscreen] Port to JavaScript Summary: The ported effect looks quite similar to the C++ version except one thing: it works correctly when user activates/deactivates a full screen effect, for example the Desktop Cube effect. Other than that, there are no behavioral or visual differences. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16452
2018-10-25 13:48:47 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("dimscreenEnabled"), false);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("fadeEnabled"), false);
plugins.writeEntry(kwin4 + QStringLiteral("fadedesktopEnabled"), false);
[effects] Split the Fade effect Summary: Currently, we have three effects that can be used to animate the appearing of toplevel windows(fade, glide, scale) and one can enable all three of them, which seems to be wrong. It doesn't make sense to have glide and scale effect enabled, for example. We couldn't put all three effects into an exclusive group before because the fade effect animates not only toplevel windows but also popups. So, if all three effects are in an exclusive group and you enable glide effect, for example, then tooltips and other popups won't be faded in/out. This patch splits the fade effect into two: the first effect (called Fade) animates toplevel windows and the other one (called Fading Popups) animates popup windows. Test Plan: Have been using the Fading Popups effect in combination with the Scale effect for a couple of days. Haven't noticed any significant differences between the new combination (Fading Popups + Scale) and the old combination (Fade + Scale). Reviewers: #kwin, #plasma, #vdg, graesslin Reviewed By: #kwin, #plasma, graesslin Subscribers: graesslin, abetts, ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16836
2018-11-03 15:42:31 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("fadingpopupsEnabled"), false);
Desaturate non-responsive windows When an application is not responding, its window is desaturated to communicate this. Also "(Not Responding)" is added to the title bar. Differential Revision: https://phabricator.kde.org/D5245
2017-04-05 09:16:23 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("frozenappEnabled"), false);
[effects/fullscreen] Add effect that animates full screen changes Just a slightly altered copy of the maximize effect
2020-08-05 20:33:01 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("fullscreenEnabled"), false);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("loginEnabled"), false);
new logout effect Summary: new logout effect: it's just a slow fade in of the logout greeter (window is usable immediately tough Test Plan: logout greeter now fades in without setting the window opacity manually Reviewers: graesslin, #plasma Reviewed By: graesslin, #plasma Subscribers: broulik, plasma-devel, kwin, #kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D5045
2017-03-15 16:47:13 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("logoutEnabled"), false);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("maximizeEnabled"), false);
[effects/scale] Port to JavaScript Summary: Now, when the scripting effects API has all required ingredients to port the Scale effect to JavaScript we finally can do it. The main rationale for porting this effect to JavaScript is that scripted effects API lets us focus more on what we want instead of "how". Visually, the ported version doesn't deviate from the C++ version. Test Plan: * Enable the Scale effect; * Open/close a window. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: graesslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16478
2018-10-27 21:27:25 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("scaleEnabled"), false);
[effects] Re-implement the Minimize Animation effect in JavaScript Summary: There were several reasons to rewrite the Minimize Animation effect in JavaScript: to simplify code and to get rid of full repaints. One could say that nothing prevents us from calculating the dirty region in postPaintScreen or postPaintWindow and it is correct, but with the scripting effects API the dirty region will be calculated for us, so we can focus more on "what we want" instead of "how". Visually, the "old" effect and the rewritten one look quite the same. Except one tiny bit: if a window doesn't have an icon in the task manager, it won't be animated. The reason for that is the purpose of this effect is to show where the window will be after it's minimized, if the window doesn't have icon in the task manager, one can't click at the center of the screen to unminimize the window. There is one significant change, the name of the effect was changed to "Squash". If we put this effect and the Magic lamp effect under "Window Minimize Animation" category (or if we add some "heading" label), then the old name and the name of the category would "conflict". The new name was suggested by Nate Graham and it very closely describes what the effect does. "Scale" doesn't fit this effect because while a window is being animated, its aspect ratio is not preserved. Reviewers: #kwin, #plasma, davidedmundson Reviewed By: #kwin, #plasma, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16372
2018-09-23 17:07:48 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("squashEnabled"), false);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("translucencyEnabled"), false);
[autotests] Fix TestScriptedEffectLoader::testLoadAllEffects
2015-04-09 12:58:05 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("eyeonscreenEnabled"), false);
plugins.writeEntry(kwin4 + QStringLiteral("windowapertureEnabled"), false);
[autotest] Adjust TestScriptedEffectLoader::testLoadAllEffects for morphingpopups A new default effect means a new line in the mock config.
2016-02-17 14:27:06 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("morphingpopupsEnabled"), false);
Update tests to include newly added session quit effect
2019-11-05 15:02:59 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("sessionquitEnabled"), false);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.sync();
loader.setConfig(config);
qRegisterMetaType<KWin::Effect*>();
autotests: Port QSignalSpies to new connect syntax
2019-07-29 19:45:19 +00:00
QSignalSpy spy(&loader, &KWin::ScriptedEffectLoader::effectLoaded);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
// connect to signal to ensure that we delete the Effect again as the Effect doesn't have a parent
connect(&loader, &KWin::ScriptedEffectLoader::effectLoaded,
[](KWin::Effect *effect) {
effect->deleteLater();
}
);
// the config is prepared so that no Effect gets loaded!
loader.queryAndLoadAll();
// we need to wait some time because it's queued and in a thread
QVERIFY(!spy.wait(100));
// now let's prepare a config which has one effect explicitly enabled
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("eyeonscreenEnabled"), true);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
plugins.sync();
loader.queryAndLoadAll();
// should load one effect in first go
QVERIFY(spy.wait(100));
// and afterwards it should not load another one
QVERIFY(!spy.wait(10));
QCOMPARE(spy.size(), 1);
// if we caught a signal it should have the effect name we passed in
QList<QVariant> arguments = spy.takeFirst();
QCOMPARE(arguments.count(), 2);
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QCOMPARE(arguments.at(1).toString(), kwin4 + QStringLiteral("eyeonscreen"));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
spy.clear();
// let's delete one of the default entries
plugins.deleteEntry(kwin4 + QStringLiteral("fadeEnabled"));
plugins.sync();
QVERIFY(spy.isEmpty());
loader.queryAndLoadAll();
// let's use qWait as we need to wait for two signals to be emitted
[autotests] Use QTR_COMPARE instead of QTest::qWait in TestScriptedEffectLoader Hopefully makes the test more reliable on build.kde.org.
2016-08-16 12:07:14 +00:00
QTRY_COMPARE(spy.size(), 2);
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
QStringList loadedEffects;
for (auto &list : spy) {
QCOMPARE(list.size(), 2);
loadedEffects << list.at(1).toString();
}
Port away from deprecated qSort function Reviewers: #kwin, romangg Reviewed By: #kwin, romangg Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22354
2019-07-09 21:00:07 +00:00
std::sort(loadedEffects.begin(), loadedEffects.end());
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
QCOMPARE(loadedEffects.at(0), kwin4 + QStringLiteral("eyeonscreen"));
QCOMPARE(loadedEffects.at(1), kwin4 + QStringLiteral("fade"));
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
}
Cancel the EffectLoader query on clear The Scripted and PluginEffectLoader perform locating all effects which are to be loaded in a thread. When the EffectLoader gets cleared so far the query did not get canceled. This resulted in effects maybe getting loaded. This problems shows on build.kde.org if the test is too fast and tears down the Effect system while effects are still being queried. Reviewed-By: David Edmundson
2016-04-26 12:55:47 +00:00
void TestScriptedEffectLoader::testCancelLoadAllEffects()
{
// this test verifies that no test gets loaded when the loader gets cleared
MockEffectsHandler mockHandler(KWin::XRenderCompositing);
KWin::ScriptedEffectLoader loader;
// prepare the configuration to hard enable/disable the effects we want to load
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
const QString kwin4 = QStringLiteral("kwin4_effect_");
KConfigGroup plugins = config->group("Plugins");
[effects] Drop the Scale in effect Summary: It's superseded by the new scale effect(D13461). Existing users of this effect will be migrated to the new scale effect. Depends on D13461 Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13462
2018-06-10 11:02:57 +00:00
plugins.writeEntry(kwin4 + QStringLiteral("eyeonscreenEnabled"), true);
Cancel the EffectLoader query on clear The Scripted and PluginEffectLoader perform locating all effects which are to be loaded in a thread. When the EffectLoader gets cleared so far the query did not get canceled. This resulted in effects maybe getting loaded. This problems shows on build.kde.org if the test is too fast and tears down the Effect system while effects are still being queried. Reviewed-By: David Edmundson
2016-04-26 12:55:47 +00:00
plugins.sync();
loader.setConfig(config);
qRegisterMetaType<KWin::Effect*>();
QSignalSpy spy(&loader, &KWin::ScriptedEffectLoader::effectLoaded);
QVERIFY(spy.isValid());
loader.queryAndLoadAll();
loader.clear();
// Should not load any effect
QVERIFY(!spy.wait(100));
QVERIFY(spy.isEmpty());
}
[kwin] Add a ScriptedEffectLoader This implementation of the AbstractEffectLoader is able to to load the scripted KWin Effects. It uses KServiceTypeTrader to find all the candidates to load.
2014-03-23 08:23:30 +00:00
QTEST_MAIN(TestScriptedEffectLoader)
#include "test_scripted_effectloader.moc"
Reference in a new issue Copy permalink