2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2016-06-07 08:27:02 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
2016-06-07 08:27:02 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2016-06-07 08:27:02 +00:00
|
|
|
#include "kwin_wayland_test.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
|
2022-08-29 07:55:49 +00:00
|
|
|
#include "core/output.h"
|
2019-06-11 13:24:24 +00:00
|
|
|
#include "decorations/decorationbridge.h"
|
|
|
|
#include "decorations/settings.h"
|
2023-02-09 13:07:56 +00:00
|
|
|
#include "pointer_input.h"
|
2016-06-07 08:27:02 +00:00
|
|
|
#include "wayland_server.h"
|
2022-04-22 17:39:12 +00:00
|
|
|
#include "window.h"
|
2016-06-09 11:32:41 +00:00
|
|
|
#include "workspace.h"
|
2016-06-07 08:27:02 +00:00
|
|
|
|
|
|
|
#include <KWayland/Client/compositor.h>
|
|
|
|
#include <KWayland/Client/shm_pool.h>
|
|
|
|
#include <KWayland/Client/surface.h>
|
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
#include <KDecoration2/DecoratedClient>
|
2019-06-11 13:24:24 +00:00
|
|
|
#include <KDecoration2/Decoration>
|
|
|
|
#include <KDecoration2/DecorationSettings>
|
2016-06-09 11:32:41 +00:00
|
|
|
|
2023-07-03 19:28:19 +00:00
|
|
|
#include <QSignalSpy>
|
|
|
|
|
2016-06-07 08:27:02 +00:00
|
|
|
using namespace KWin;
|
|
|
|
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_maximized-0");
|
|
|
|
|
|
|
|
class TestMaximized : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
private Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void init();
|
|
|
|
void cleanup();
|
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
void testMaximizedPassedToDeco();
|
2020-05-13 10:53:43 +00:00
|
|
|
void testInitiallyMaximizedBorderless();
|
2016-11-25 15:45:40 +00:00
|
|
|
void testBorderlessMaximizedWindow();
|
2020-07-17 09:19:38 +00:00
|
|
|
void testMaximizedGainFocusAndBeActivated();
|
2016-06-07 08:27:02 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
void TestMaximized::initTestCase()
|
|
|
|
{
|
2022-04-22 17:39:12 +00:00
|
|
|
qRegisterMetaType<KWin::Window *>();
|
2020-07-07 09:32:29 +00:00
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
2020-12-09 13:06:15 +00:00
|
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
2023-05-08 10:16:00 +00:00
|
|
|
Test::setOutputConfig({
|
|
|
|
QRect(0, 0, 1280, 1024),
|
|
|
|
QRect(1280, 0, 1280, 1024),
|
|
|
|
});
|
2016-06-07 08:27:02 +00:00
|
|
|
|
2016-11-25 15:45:40 +00:00
|
|
|
kwinApp()->setConfig(KSharedConfig::openConfig(QString(), KConfig::SimpleConfig));
|
|
|
|
|
2016-06-07 08:27:02 +00:00
|
|
|
kwinApp()->start();
|
2020-07-07 09:32:29 +00:00
|
|
|
QVERIFY(applicationStartedSpy.wait());
|
2022-07-11 10:41:15 +00:00
|
|
|
const auto outputs = workspace()->outputs();
|
2021-08-31 07:03:05 +00:00
|
|
|
QCOMPARE(outputs.count(), 2);
|
|
|
|
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
|
|
|
|
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
|
2016-06-07 08:27:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void TestMaximized::init()
|
|
|
|
{
|
2023-05-23 11:30:04 +00:00
|
|
|
QVERIFY(Test::setupWaylandConnection(Test::AdditionalWaylandInterface::XdgDecorationV1));
|
2016-06-07 08:27:02 +00:00
|
|
|
|
2021-08-28 18:58:29 +00:00
|
|
|
workspace()->setActiveOutput(QPoint(640, 512));
|
2023-02-09 13:07:56 +00:00
|
|
|
KWin::input()->pointer()->warp(QPoint(640, 512));
|
2016-06-07 08:27:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void TestMaximized::cleanup()
|
|
|
|
{
|
2016-06-30 11:32:54 +00:00
|
|
|
Test::destroyWaylandConnection();
|
2016-11-25 15:45:40 +00:00
|
|
|
|
|
|
|
// adjust config
|
2023-11-27 13:11:22 +00:00
|
|
|
auto group = kwinApp()->config()->group(QStringLiteral("Windows"));
|
2016-11-25 15:45:40 +00:00
|
|
|
group.writeEntry("BorderlessMaximizedWindows", false);
|
|
|
|
group.sync();
|
|
|
|
Workspace::self()->slotReconfigure();
|
|
|
|
QCOMPARE(options->borderlessMaximizedWindows(), false);
|
2016-06-07 08:27:02 +00:00
|
|
|
}
|
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
void TestMaximized::testMaximizedPassedToDeco()
|
|
|
|
{
|
2019-08-30 21:36:58 +00:00
|
|
|
// this test verifies that when a XdgShellClient gets maximized the Decoration receives the signal
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Create the test window.
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<KWayland::Client::Surface> surface(Test::createSurface());
|
|
|
|
std::unique_ptr<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.get(), Test::CreationSetup::CreateOnly));
|
|
|
|
std::unique_ptr<Test::XdgToplevelDecorationV1> xdgDecoration(Test::createXdgToplevelDecorationV1(shellSurface.get()));
|
2016-06-09 11:32:41 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.get(), &Test::XdgToplevel::configureRequested);
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
auto window = Test::renderAndWaitForShown(surface.get(), QSize(100, 50), Qt::blue);
|
2022-04-23 19:51:16 +00:00
|
|
|
QVERIFY(window);
|
|
|
|
QVERIFY(window->isDecorated());
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
auto decoration = window->decoration();
|
2016-06-09 11:32:41 +00:00
|
|
|
QVERIFY(decoration);
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeRestore);
|
2016-06-09 11:32:41 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Wait for configure event that signals the window is active now.
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 2);
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2019-06-11 13:24:24 +00:00
|
|
|
// When there are no borders, there is no change to them when maximizing.
|
|
|
|
// TODO: we should test both cases with fixed fake decoration for autotests.
|
2022-07-20 11:46:41 +00:00
|
|
|
const bool hasBorders = Workspace::self()->decorationBridge()->settings()->borderSize() != KDecoration2::BorderSize::None;
|
2019-06-11 13:24:24 +00:00
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
// now maximize
|
2016-06-09 14:50:48 +00:00
|
|
|
QSignalSpy bordersChangedSpy(decoration, &KDecoration2::Decoration::bordersChanged);
|
2023-03-11 12:35:02 +00:00
|
|
|
QSignalSpy maximizedChangedSpy(decoration->client(), &KDecoration2::DecoratedClient::maximizedChanged);
|
2022-04-23 19:51:16 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(window, &Window::frameGeometryChanged);
|
2018-11-08 10:33:57 +00:00
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
workspace()->slotWindowMaximize();
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 3);
|
2021-05-11 05:26:51 +00:00
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024 - decoration->borderTop()));
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Test::render(surface.get(), toplevelConfigureRequestedSpy.last().at(0).toSize(), Qt::red);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2019-06-11 13:24:24 +00:00
|
|
|
|
|
|
|
// If no borders, there is only the initial geometry shape change, but none through border resizing.
|
2020-02-05 09:28:50 +00:00
|
|
|
QCOMPARE(frameGeometryChangedSpy.count(), hasBorders ? 2 : 1);
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeFull);
|
2016-06-09 11:32:41 +00:00
|
|
|
QCOMPARE(maximizedChangedSpy.count(), 1);
|
|
|
|
QCOMPARE(maximizedChangedSpy.last().first().toBool(), true);
|
2019-06-11 13:24:24 +00:00
|
|
|
QCOMPARE(bordersChangedSpy.count(), hasBorders ? 1 : 0);
|
2016-06-09 14:50:48 +00:00
|
|
|
QCOMPARE(decoration->borderLeft(), 0);
|
|
|
|
QCOMPARE(decoration->borderBottom(), 0);
|
|
|
|
QCOMPARE(decoration->borderRight(), 0);
|
|
|
|
QVERIFY(decoration->borderTop() != 0);
|
|
|
|
|
2016-06-09 11:32:41 +00:00
|
|
|
// now unmaximize again
|
|
|
|
workspace()->slotWindowMaximize();
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
wayland: Properly handle async xdg-decoration updates
Currently, if a window switches between SSD and CSD, it is possible to
encounter a "corrupted" state where the server-side decoration is wrapped
around the window while it still has the client-side decoration.
The xdg-decoration protocol fixes this problem by saying that decoration
updates are bound to xdg_surface configure events.
At the moment, kwin sort of applies decoration updates immediately. With
this change, decoration updates will be done according to the spec.
If the compositor wants to create a decoration, it will send a configure
event and apply the decoration when the configure event is acked by the
client. In order to send the configure event with a good window geometry
size, kwin will create the decoration to query the border size but not
assign it to the client yet. As is, KDecoration api doesn't make
querying the border size ahead of time easy. The decoration plugin can
assign arbitrary border sizes to windows as it pleases it. We could change
that, but it effectively means starting KDecoration3 and setting existing
window deco ecosystem around kwin on fire the second time, that's off the
table.
If the compositor wants to remove the decoration, it will send a
configure event. When the configure event is acked and the surface is
committed, the window decoration will be destroyed.
Sync'ing decoration updates to configure events ensures that we cannot
end up with having both client-side and server-side decoration. It also
helps us to fix a bunch of geometry related issues caused by creating
and destroying the decoration without any surface buffer attached yet.
BUG: 445259
2021-01-27 15:35:13 +00:00
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 4);
|
2021-05-11 05:26:51 +00:00
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(100, 50));
|
2018-11-08 10:33:57 +00:00
|
|
|
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Test::render(surface.get(), QSize(100, 50), Qt::red);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
|
|
|
QCOMPARE(frameGeometryChangedSpy.count(), hasBorders ? 4 : 2);
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeRestore);
|
2016-06-09 11:32:41 +00:00
|
|
|
QCOMPARE(maximizedChangedSpy.count(), 2);
|
|
|
|
QCOMPARE(maximizedChangedSpy.last().first().toBool(), false);
|
2019-06-11 13:24:24 +00:00
|
|
|
QCOMPARE(bordersChangedSpy.count(), hasBorders ? 2 : 0);
|
2016-06-09 14:54:06 +00:00
|
|
|
QVERIFY(decoration->borderTop() != 0);
|
2019-06-11 13:24:24 +00:00
|
|
|
QVERIFY(decoration->borderLeft() != !hasBorders);
|
|
|
|
QVERIFY(decoration->borderRight() != !hasBorders);
|
|
|
|
QVERIFY(decoration->borderBottom() != !hasBorders);
|
2016-06-09 14:54:06 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Destroy the test window.
|
2019-08-27 15:01:14 +00:00
|
|
|
shellSurface.reset();
|
2023-04-21 20:28:48 +00:00
|
|
|
QVERIFY(Test::waitForWindowClosed(window));
|
2016-06-09 11:32:41 +00:00
|
|
|
}
|
|
|
|
|
2020-05-13 10:53:43 +00:00
|
|
|
void TestMaximized::testInitiallyMaximizedBorderless()
|
|
|
|
{
|
|
|
|
// This test verifies that a window created as maximized, will be maximized and without Border with BorderlessMaximizedWindows
|
|
|
|
|
|
|
|
// adjust config
|
2023-11-27 13:11:22 +00:00
|
|
|
auto group = kwinApp()->config()->group(QStringLiteral("Windows"));
|
2020-05-13 10:53:43 +00:00
|
|
|
group.writeEntry("BorderlessMaximizedWindows", true);
|
|
|
|
group.sync();
|
|
|
|
Workspace::self()->slotReconfigure();
|
|
|
|
QCOMPARE(options->borderlessMaximizedWindows(), true);
|
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Create the test window.
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<KWayland::Client::Surface> surface(Test::createSurface());
|
|
|
|
std::unique_ptr<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.get(), Test::CreationSetup::CreateOnly));
|
|
|
|
std::unique_ptr<Test::XdgToplevelDecorationV1> decoration(Test::createXdgToplevelDecorationV1(shellSurface.get()));
|
2021-05-11 05:26:51 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.get(), &Test::XdgToplevel::configureRequested);
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
|
|
|
shellSurface->set_maximized();
|
2022-08-01 21:29:02 +00:00
|
|
|
QSignalSpy decorationConfigureRequestedSpy(decoration.get(), &Test::XdgToplevelDecorationV1::configureRequested);
|
2021-05-11 05:26:51 +00:00
|
|
|
decoration->set_mode(Test::XdgToplevelDecorationV1::mode_server_side);
|
2021-09-03 17:54:03 +00:00
|
|
|
surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
2020-05-13 10:53:43 +00:00
|
|
|
|
|
|
|
// Wait for the initial configure event.
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::XdgToplevel::States states;
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 1);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024));
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Maximized));
|
|
|
|
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Window *window = Test::renderAndWaitForShown(surface.get(), QSize(1280, 1024), Qt::blue);
|
2022-04-23 19:51:16 +00:00
|
|
|
QVERIFY(window);
|
|
|
|
QVERIFY(!window->isDecorated());
|
|
|
|
QVERIFY(window->isActive());
|
|
|
|
QVERIFY(window->isMaximizable());
|
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeFull);
|
|
|
|
QCOMPARE(window->requestedMaximizeMode(), MaximizeMode::MaximizeFull);
|
|
|
|
QCOMPARE(window->frameGeometry(), QRect(0, 0, 1280, 1024));
|
2021-05-11 05:26:51 +00:00
|
|
|
QCOMPARE(decorationConfigureRequestedSpy.last().at(0).value<Test::XdgToplevelDecorationV1::mode>(),
|
|
|
|
Test::XdgToplevelDecorationV1::mode_server_side);
|
2020-05-13 10:53:43 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Destroy the window.
|
2020-05-13 10:53:43 +00:00
|
|
|
shellSurface.reset();
|
|
|
|
surface.reset();
|
2023-04-21 20:28:48 +00:00
|
|
|
QVERIFY(Test::waitForWindowClosed(window));
|
2020-05-13 10:53:43 +00:00
|
|
|
}
|
2016-11-25 15:45:40 +00:00
|
|
|
void TestMaximized::testBorderlessMaximizedWindow()
|
|
|
|
{
|
2022-04-23 19:51:16 +00:00
|
|
|
// This test verifies that a maximized window looses it's server-side
|
2019-08-27 15:01:14 +00:00
|
|
|
// decoration when the borderless maximized option is on.
|
2016-11-25 15:45:40 +00:00
|
|
|
|
2019-08-27 15:01:14 +00:00
|
|
|
// Enable the borderless maximized windows option.
|
2023-11-27 13:11:22 +00:00
|
|
|
auto group = kwinApp()->config()->group(QStringLiteral("Windows"));
|
2016-11-25 15:45:40 +00:00
|
|
|
group.writeEntry("BorderlessMaximizedWindows", true);
|
|
|
|
group.sync();
|
|
|
|
Workspace::self()->slotReconfigure();
|
|
|
|
QCOMPARE(options->borderlessMaximizedWindows(), true);
|
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Create the test window.
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<KWayland::Client::Surface> surface(Test::createSurface());
|
|
|
|
std::unique_ptr<Test::XdgToplevel> shellSurface(Test::createXdgToplevelSurface(surface.get(), Test::CreationSetup::CreateOnly));
|
|
|
|
std::unique_ptr<Test::XdgToplevelDecorationV1> decoration(Test::createXdgToplevelDecorationV1(shellSurface.get()));
|
2021-05-11 05:26:51 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
QSignalSpy toplevelConfigureRequestedSpy(shellSurface.get(), &Test::XdgToplevel::configureRequested);
|
2021-05-11 05:26:51 +00:00
|
|
|
QSignalSpy surfaceConfigureRequestedSpy(shellSurface->xdgSurface(), &Test::XdgSurface::configureRequested);
|
2022-08-01 21:29:02 +00:00
|
|
|
QSignalSpy decorationConfigureRequestedSpy(decoration.get(), &Test::XdgToplevelDecorationV1::configureRequested);
|
2021-05-11 05:26:51 +00:00
|
|
|
decoration->set_mode(Test::XdgToplevelDecorationV1::mode_server_side);
|
2021-09-03 17:54:03 +00:00
|
|
|
surface->commit(KWayland::Client::Surface::CommitFlag::None);
|
2019-08-27 15:01:14 +00:00
|
|
|
|
|
|
|
// Wait for the initial configure event.
|
2021-05-11 05:26:51 +00:00
|
|
|
Test::XdgToplevel::States states;
|
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 1);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(0, 0));
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Maximized));
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Map the window.
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Window *window = Test::renderAndWaitForShown(surface.get(), QSize(100, 50), Qt::blue);
|
2022-04-23 19:51:16 +00:00
|
|
|
QVERIFY(window);
|
|
|
|
QVERIFY(window->isActive());
|
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeRestore);
|
|
|
|
QCOMPARE(window->requestedMaximizeMode(), MaximizeMode::MaximizeRestore);
|
|
|
|
QCOMPARE(window->isDecorated(), true);
|
|
|
|
|
|
|
|
// We should receive a configure event when the window becomes active.
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 2);
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Maximized));
|
2016-11-25 15:45:40 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Maximize the window.
|
2022-05-16 20:13:39 +00:00
|
|
|
const QRectF maximizeRestoreGeometry = window->frameGeometry();
|
2019-08-27 15:01:14 +00:00
|
|
|
workspace()->slotWindowMaximize();
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 3);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(1280, 1024));
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Maximized));
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
QSignalSpy frameGeometryChangedSpy(window, &Window::frameGeometryChanged);
|
2021-05-11 05:26:51 +00:00
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Test::render(surface.get(), QSize(1280, 1024), Qt::blue);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->frameGeometry(), QRect(0, 0, 1280, 1024));
|
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeFull);
|
|
|
|
QCOMPARE(window->requestedMaximizeMode(), MaximizeMode::MaximizeFull);
|
|
|
|
QCOMPARE(window->isDecorated(), false);
|
2016-11-25 15:45:40 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Restore the window.
|
2019-08-27 15:01:14 +00:00
|
|
|
workspace()->slotWindowMaximize();
|
2021-05-11 05:26:51 +00:00
|
|
|
QVERIFY(surfaceConfigureRequestedSpy.wait());
|
|
|
|
QCOMPARE(surfaceConfigureRequestedSpy.count(), 4);
|
|
|
|
QCOMPARE(toplevelConfigureRequestedSpy.last().at(0).toSize(), QSize(100, 50));
|
|
|
|
states = toplevelConfigureRequestedSpy.last().at(1).value<Test::XdgToplevel::States>();
|
|
|
|
QVERIFY(states.testFlag(Test::XdgToplevel::State::Activated));
|
|
|
|
QVERIFY(!states.testFlag(Test::XdgToplevel::State::Maximized));
|
|
|
|
|
|
|
|
shellSurface->xdgSurface()->ack_configure(surfaceConfigureRequestedSpy.last().at(0).value<quint32>());
|
2022-08-01 21:29:02 +00:00
|
|
|
Test::render(surface.get(), QSize(100, 50), Qt::red);
|
2020-02-05 09:28:50 +00:00
|
|
|
QVERIFY(frameGeometryChangedSpy.wait());
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->frameGeometry(), maximizeRestoreGeometry);
|
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeMode::MaximizeRestore);
|
|
|
|
QCOMPARE(window->requestedMaximizeMode(), MaximizeMode::MaximizeRestore);
|
|
|
|
QCOMPARE(window->isDecorated(), true);
|
2019-08-27 15:01:14 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
// Destroy the window.
|
2019-08-27 15:01:14 +00:00
|
|
|
shellSurface.reset();
|
2023-04-21 20:28:48 +00:00
|
|
|
QVERIFY(Test::waitForWindowClosed(window));
|
2016-11-25 15:45:40 +00:00
|
|
|
}
|
|
|
|
|
2020-07-17 09:19:38 +00:00
|
|
|
void TestMaximized::testMaximizedGainFocusAndBeActivated()
|
|
|
|
{
|
|
|
|
// This test verifies that a window will be raised and gain focus when it's maximized
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<KWayland::Client::Surface> surface(Test::createSurface());
|
|
|
|
std::unique_ptr<Test::XdgToplevel> xdgShellSurface(Test::createXdgToplevelSurface(surface.get()));
|
|
|
|
auto window = Test::renderAndWaitForShown(surface.get(), QSize(100, 50), Qt::blue);
|
|
|
|
std::unique_ptr<KWayland::Client::Surface> surface2(Test::createSurface());
|
|
|
|
std::unique_ptr<Test::XdgToplevel> xdgShellSurface2(Test::createXdgToplevelSurface(surface2.get()));
|
|
|
|
auto window2 = Test::renderAndWaitForShown(surface2.get(), QSize(100, 50), Qt::blue);
|
2020-07-17 09:19:38 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
QVERIFY(!window->isActive());
|
|
|
|
QVERIFY(window2->isActive());
|
|
|
|
QCOMPARE(workspace()->stackingOrder(), (QList<Window *>{window, window2}));
|
2020-07-17 09:19:38 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
workspace()->performWindowOperation(window, Options::MaximizeOp);
|
2020-07-17 09:19:38 +00:00
|
|
|
|
2022-04-23 19:51:16 +00:00
|
|
|
QVERIFY(window->isActive());
|
|
|
|
QVERIFY(!window2->isActive());
|
|
|
|
QCOMPARE(workspace()->stackingOrder(), (QList<Window *>{window2, window}));
|
2020-07-17 09:19:38 +00:00
|
|
|
|
|
|
|
xdgShellSurface.reset();
|
2023-04-21 20:28:48 +00:00
|
|
|
QVERIFY(Test::waitForWindowClosed(window));
|
2020-07-17 09:19:38 +00:00
|
|
|
xdgShellSurface2.reset();
|
2023-04-21 20:28:48 +00:00
|
|
|
QVERIFY(Test::waitForWindowClosed(window2));
|
2020-07-17 09:19:38 +00:00
|
|
|
}
|
|
|
|
|
2016-06-07 08:27:02 +00:00
|
|
|
WAYLANDTEST_MAIN(TestMaximized)
|
|
|
|
#include "maximize_test.moc"
|