2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2006 Lubos Lunak <l.lunak@kde.org>
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
#ifndef KWIN_SCENE_XRENDER_H
|
|
|
|
#define KWIN_SCENE_XRENDER_H
|
|
|
|
|
|
|
|
#include "scene.h"
|
2011-04-28 15:22:17 +00:00
|
|
|
#include "shadow.h"
|
2014-07-22 11:11:19 +00:00
|
|
|
#include "decorations/decorationrenderer.h"
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2007-12-17 14:14:53 +00:00
|
|
|
#ifdef KWIN_HAVE_XRENDER_COMPOSITING
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
2020-12-05 15:54:19 +00:00
|
|
|
class XRenderBackend;
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
class SceneXrender
|
|
|
|
: public Scene
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2011-06-15 16:35:00 +00:00
|
|
|
Q_OBJECT
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
|
|
|
class EffectFrame;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SceneXrender() override;
|
|
|
|
bool initFailed() const override;
|
|
|
|
CompositingType compositingType() const override {
|
2011-01-30 14:34:42 +00:00
|
|
|
return XRenderCompositing;
|
|
|
|
}
|
Provide expected presentation time to effects
Effects are given the interval between two consecutive frames. The main
flaw of this approach is that if the Compositor transitions from the idle
state to "active" state, i.e. when there is something to repaint,
effects may see a very large interval between the last painted frame and
the current. In order to address this issue, the Scene invalidates the
timer that is used to measure time between consecutive frames before the
Compositor is about to become idle.
While this works perfectly fine with Xinerama-style rendering, with per
screen rendering, determining whether the compositor is about to idle is
rather a tedious task mostly because a single output can't be used for
the test.
Furthermore, since the Compositor schedules pointless repaints just to
ensure that it's idle, it might take several attempts to figure out
whether the scene timer must be invalidated if you use (true) per screen
rendering.
Ideally, all effects should use a timeline helper that is aware of the
underlying render loop and its timings. However, this option is off the
table because it will involve a lot of work to implement it.
Alternative and much simpler option is to pass the expected presentation
time to effects rather than time between consecutive frames. This means
that effects are responsible for determining how much animation timelines
have to be advanced. Typically, an effect would have to store the
presentation timestamp provided in either prePaint{Screen,Window} and
use it in the subsequent prePaint{Screen,Window} call to estimate the
amount of time passed between the next and the last frames.
Unfortunately, this is an API incompatible change. However, it shouldn't
take a lot of work to port third-party binary effects, which don't use the
AnimationEffect class, to the new API. On the bright side, we no longer
need to be concerned about the Compositor getting idle.
We do still try to determine whether the Compositor is about to idle,
primarily, because the OpenGL render backend swaps buffers on present,
but that will change with the ongoing compositing timing rework.
2020-11-20 15:44:04 +00:00
|
|
|
void paint(int screenId, const QRegion &damage, const QList<Toplevel *> &windows,
|
|
|
|
std::chrono::milliseconds presentTime) override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
Scene::EffectFrame *createEffectFrame(EffectFrameImpl *frame) override;
|
|
|
|
Shadow *createShadow(Toplevel *toplevel) override;
|
|
|
|
void screenGeometryChanged(const QSize &size) override;
|
2017-08-08 15:13:59 +00:00
|
|
|
xcb_render_picture_t xrenderBufferPicture() const override;
|
2020-12-05 15:54:19 +00:00
|
|
|
OverlayWindow *overlayWindow() const override;
|
|
|
|
bool usesOverlayWindow() const override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
Decoration::Renderer *createDecorationRenderer(Decoration::DecoratedClientImpl *client) override;
|
2013-06-17 13:25:32 +00:00
|
|
|
|
2016-08-10 07:24:53 +00:00
|
|
|
bool animationsSupported() const override {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-02-23 13:41:45 +00:00
|
|
|
static SceneXrender *createScene(QObject *parent);
|
2011-01-30 14:34:42 +00:00
|
|
|
protected:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
Scene::Window *createWindow(Toplevel *toplevel) override;
|
2020-03-13 16:41:56 +00:00
|
|
|
void paintBackground(const QRegion ®ion) override;
|
|
|
|
void paintGenericScreen(int mask, const ScreenPaintData &data) override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void paintDesktop(int desktop, int mask, const QRegion ®ion, ScreenPaintData &data) override;
|
2020-10-26 07:39:55 +00:00
|
|
|
void paintCursor(const QRegion ®ion) override;
|
[libkwineffects] Introduce API to easily show a QtQuick scene in an effect
Summary:
EffectQuickView/Scene is a convenient class to render a QtQuick
scenegraph into an effect.
Current methods (such as present windows) involve creating an underlying
platform window which is expensive, causes a headache to filter out
again in the rest of the code, and only works as an overlay.
The new class exposes things more natively to an effect where we don't
mess with real windows, we can perform the painting anywhere in the view
and we don't have issues with hiding/closing.
QtQuick has both software and hardware accelerated modes, and kwin also
has 3 render backends. Every combination is supported.
* When used in OpenGL mode for both, we render into an FBO export the
texture ID then it's up to the effect to render that into a scene.
* When using software QtQuick rendering we blit into an image, upload
that into a KWinGLTexture which serves as an abstraction layer and
render that into the scene.
* When using GL for QtQuick and XRender/QPainter in kwin everything is
rendered into the internal FBO, blit and exported as an image.
* When using software rendering for both an image gets passed directly.
Mouse and keyboard events can be forwarded, only if the effect
intercepts them.
The class is meant to be generic enough that we can remove all the
QtQuick code from Aurorae.
The intention is also to replace EffectFrameImpl using this backend and
we can kill all of the EffectFrame code throughout the scenes.
The close button in present windows will also be ported to this,
simplifiying that code base.
Classes that handle the rendering and handling QML are intentionally
split so that in the future we can have a declarative effects API create
overlays from within the same context. Similar to how one can
instantiate windows from a typical QML scene.
Notes:
I don't like how I pass the kwin GL context from the backends into the
effect, but I need something that works with the library separation. It
also currently has wayland problem if I create a QOpenGLContext before
the QPA is set up with a scene - but I don't have anything better?
I know for the EffectFrame we need an API to push things through the
effects stack to handle blur/invert etc. Will deal with that when we
port the EffectFrame.
Test Plan: Used in an effect
Reviewers: #kwin, zzag
Reviewed By: #kwin, zzag
Subscribers: zzag, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D24215
2019-09-27 15:06:37 +00:00
|
|
|
void paintEffectQuickView(EffectQuickView *w) override;
|
2011-01-30 14:34:42 +00:00
|
|
|
private:
|
2015-02-23 13:41:45 +00:00
|
|
|
explicit SceneXrender(XRenderBackend *backend, QObject *parent = nullptr);
|
2011-01-30 14:34:42 +00:00
|
|
|
static ScreenPaintData screen_paint;
|
|
|
|
class Window;
|
2013-06-17 13:25:32 +00:00
|
|
|
QScopedPointer<XRenderBackend> m_backend;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2020-06-10 06:13:35 +00:00
|
|
|
class SceneXrender::Window : public Scene::Window
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2020-06-10 06:13:35 +00:00
|
|
|
Q_OBJECT
|
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
2013-06-17 13:25:32 +00:00
|
|
|
Window(Toplevel* c, SceneXrender *scene);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~Window() override;
|
2020-03-13 16:41:56 +00:00
|
|
|
void performPaint(int mask, const QRegion ®ion, const WindowPaintData &data) override;
|
2011-01-30 14:34:42 +00:00
|
|
|
QRegion transformedShape() const;
|
|
|
|
void setTransformedShape(const QRegion& shape);
|
2013-02-11 20:01:41 +00:00
|
|
|
static void cleanup();
|
2013-05-10 10:07:56 +00:00
|
|
|
protected:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
WindowPixmap* createWindowPixmap() override;
|
2011-01-30 14:34:42 +00:00
|
|
|
private:
|
|
|
|
QRect mapToScreen(int mask, const WindowPaintData &data, const QRect &rect) const;
|
|
|
|
QPoint mapToScreen(int mask, const WindowPaintData &data, const QPoint &point) const;
|
2019-12-12 12:39:03 +00:00
|
|
|
QRect bufferToWindowRect(const QRect &rect) const;
|
|
|
|
QRegion bufferToWindowRegion(const QRegion ®ion) const;
|
2011-07-24 21:04:06 +00:00
|
|
|
void prepareTempPixmap();
|
2013-02-27 14:08:09 +00:00
|
|
|
void setPictureFilter(xcb_render_picture_t pic, ImageFilterType filter);
|
2013-06-17 13:25:32 +00:00
|
|
|
SceneXrender *m_scene;
|
2013-02-27 14:08:09 +00:00
|
|
|
xcb_render_pictformat_t format;
|
2011-01-30 14:34:42 +00:00
|
|
|
QRegion transformed_shape;
|
2012-03-10 10:34:56 +00:00
|
|
|
static QRect temp_visibleRect;
|
2013-02-11 20:01:41 +00:00
|
|
|
static XRenderPicture *s_tempPicture;
|
2016-06-01 10:51:10 +00:00
|
|
|
static XRenderPicture *s_fadeAlphaPicture;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2013-05-10 10:07:56 +00:00
|
|
|
class XRenderWindowPixmap : public WindowPixmap
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
explicit XRenderWindowPixmap(Scene::Window *window, xcb_render_pictformat_t format);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~XRenderWindowPixmap() override;
|
2013-05-10 10:07:56 +00:00
|
|
|
xcb_render_picture_t picture() const;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void create() override;
|
2013-05-10 10:07:56 +00:00
|
|
|
private:
|
|
|
|
xcb_render_picture_t m_picture;
|
|
|
|
xcb_render_pictformat_t m_format;
|
|
|
|
};
|
|
|
|
|
2010-07-18 16:32:37 +00:00
|
|
|
class SceneXrender::EffectFrame
|
|
|
|
: public Scene::EffectFrame
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
|
|
|
public:
|
|
|
|
EffectFrame(EffectFrameImpl* frame);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~EffectFrame() override;
|
|
|
|
|
|
|
|
void free() override;
|
|
|
|
void freeIconFrame() override;
|
|
|
|
void freeTextFrame() override;
|
|
|
|
void freeSelection() override;
|
|
|
|
void crossFadeIcon() override;
|
|
|
|
void crossFadeText() override;
|
2020-03-13 16:41:56 +00:00
|
|
|
void render(const QRegion ®ion, double opacity, double frameOpacity) override;
|
2013-02-06 07:03:14 +00:00
|
|
|
static void cleanup();
|
2011-01-30 14:34:42 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void updatePicture();
|
|
|
|
void updateTextPicture();
|
2013-02-06 07:03:14 +00:00
|
|
|
void renderUnstyled(xcb_render_picture_t pict, const QRect &rect, qreal opacity);
|
2011-01-30 14:34:42 +00:00
|
|
|
|
|
|
|
XRenderPicture* m_picture;
|
|
|
|
XRenderPicture* m_textPicture;
|
|
|
|
XRenderPicture* m_iconPicture;
|
|
|
|
XRenderPicture* m_selectionPicture;
|
2013-02-06 07:03:14 +00:00
|
|
|
static XRenderPicture* s_effectFrameCircle;
|
2011-01-30 14:34:42 +00:00
|
|
|
};
|
2010-07-18 16:32:37 +00:00
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
inline
|
|
|
|
QRegion SceneXrender::Window::transformedShape() const
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2007-04-29 17:35:43 +00:00
|
|
|
return transformed_shape;
|
2011-01-30 14:34:42 +00:00
|
|
|
}
|
2007-04-29 17:35:43 +00:00
|
|
|
|
|
|
|
inline
|
2011-01-30 14:34:42 +00:00
|
|
|
void SceneXrender::Window::setTransformedShape(const QRegion& shape)
|
|
|
|
{
|
2007-04-29 17:35:43 +00:00
|
|
|
transformed_shape = shape;
|
2011-01-30 14:34:42 +00:00
|
|
|
}
|
2007-04-29 17:35:43 +00:00
|
|
|
|
2013-05-10 10:07:56 +00:00
|
|
|
inline
|
|
|
|
xcb_render_picture_t XRenderWindowPixmap::picture() const
|
|
|
|
{
|
|
|
|
return m_picture;
|
|
|
|
}
|
|
|
|
|
2011-04-28 15:22:17 +00:00
|
|
|
/**
|
|
|
|
* @short XRender implementation of Shadow.
|
|
|
|
*
|
|
|
|
* This class extends Shadow by the elements required for XRender rendering.
|
|
|
|
* @author Jacopo De Simoi <wilderkde@gmail.org>
|
2019-07-29 18:58:33 +00:00
|
|
|
*/
|
2011-04-28 15:22:17 +00:00
|
|
|
class SceneXRenderShadow
|
|
|
|
: public Shadow
|
|
|
|
{
|
|
|
|
public:
|
2012-12-29 06:34:38 +00:00
|
|
|
explicit SceneXRenderShadow(Toplevel *toplevel);
|
2011-11-25 00:56:56 +00:00
|
|
|
using Shadow::ShadowElements;
|
|
|
|
using Shadow::ShadowElementTop;
|
|
|
|
using Shadow::ShadowElementTopRight;
|
|
|
|
using Shadow::ShadowElementRight;
|
|
|
|
using Shadow::ShadowElementBottomRight;
|
|
|
|
using Shadow::ShadowElementBottom;
|
|
|
|
using Shadow::ShadowElementBottomLeft;
|
|
|
|
using Shadow::ShadowElementLeft;
|
|
|
|
using Shadow::ShadowElementTopLeft;
|
|
|
|
using Shadow::ShadowElementsCount;
|
|
|
|
using Shadow::shadowPixmap;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SceneXRenderShadow() override;
|
2011-04-28 15:22:17 +00:00
|
|
|
|
|
|
|
void layoutShadowRects(QRect& top, QRect& topRight,
|
|
|
|
QRect& right, QRect& bottomRight,
|
|
|
|
QRect& bottom, QRect& bottomLeft,
|
|
|
|
QRect& Left, QRect& topLeft);
|
2013-02-27 11:56:38 +00:00
|
|
|
xcb_render_picture_t picture(ShadowElements element) const;
|
2011-04-28 15:22:17 +00:00
|
|
|
|
|
|
|
protected:
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void buildQuads() override;
|
|
|
|
bool prepareBackend() override;
|
2013-02-27 11:56:38 +00:00
|
|
|
private:
|
|
|
|
XRenderPicture* m_pictures[ShadowElementsCount];
|
2011-04-28 15:22:17 +00:00
|
|
|
};
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
class SceneXRenderDecorationRenderer : public Decoration::Renderer
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
|
|
|
enum class DecorationPart : int {
|
|
|
|
Left,
|
|
|
|
Top,
|
|
|
|
Right,
|
|
|
|
Bottom,
|
|
|
|
Count
|
|
|
|
};
|
|
|
|
explicit SceneXRenderDecorationRenderer(Decoration::DecoratedClientImpl *client);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SceneXRenderDecorationRenderer() override;
|
2014-07-22 11:11:19 +00:00
|
|
|
|
|
|
|
void render() override;
|
2014-07-23 07:20:28 +00:00
|
|
|
void reparent(Deleted *deleted) override;
|
2014-07-22 11:11:19 +00:00
|
|
|
|
|
|
|
xcb_render_picture_t picture(DecorationPart part) const;
|
|
|
|
|
|
|
|
private:
|
|
|
|
void resizePixmaps();
|
|
|
|
QSize m_sizes[int(DecorationPart::Count)];
|
|
|
|
xcb_pixmap_t m_pixmaps[int(DecorationPart::Count)];
|
|
|
|
xcb_gcontext_t m_gc;
|
|
|
|
XRenderPicture* m_pictures[int(DecorationPart::Count)];
|
|
|
|
};
|
|
|
|
|
2017-08-10 16:13:42 +00:00
|
|
|
class KWIN_EXPORT XRenderFactory : public SceneFactory
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
Q_INTERFACES(KWin::SceneFactory)
|
|
|
|
Q_PLUGIN_METADATA(IID "org.kde.kwin.Scene" FILE "xrender.json")
|
|
|
|
|
|
|
|
public:
|
|
|
|
explicit XRenderFactory(QObject *parent = nullptr);
|
|
|
|
~XRenderFactory() override;
|
|
|
|
|
|
|
|
Scene *create(QObject *parent = nullptr) const override;
|
|
|
|
};
|
|
|
|
|
2007-04-29 17:35:43 +00:00
|
|
|
} // namespace
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#endif
|