2011-10-19 23:04:52 +00:00
|
|
|
/********************************************************************
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
|
|
|
Copyright (C) 2011 Thomas Lübking <thomas.luebking@web.de>
|
[effects/dialogparent] Fix flickering of parent windows
Summary:
If a modal window is closed and some alternative effect that animates
the disappearing of windows is enabled(e.g. the Glide effect, or the
Scale effect), the Dialog Parent effect can cause flickering of the
parent window because its animation duration doesn't match duration of
those alternative effects.
Also, if the Fade effect, the Glide effect, and the Scale effect are
disabled, the Dialog Parent will keep the parent window alive for no
good reason.
This change addresses that problem by adding keepAlive property to
`animate` function so scripted effects have more control over lifetime
of animated windows.
If both a modal window and its parent window are closed at the same time
(and there is no effect that animates the disappearing of windows), the
Dialog Parent will stop immediately(because windowDeleted will be
emitted right after windowClosed signal).
If both a modal window and its parent window are closed at the same time
(and there is effect that animates the disappearing of windows), the
Dialog Parent won't reference the latter window. Thus, it won't cause
flickering. I.e. it will "passively" animate parent windows.
BUG: 355036
FIXED-IN: 5.15.0
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14919
2018-10-10 07:36:45 +00:00
|
|
|
Copyright (C) 2018 Vlad Zagorodniy <vladzzag@gmail.com>
|
2011-10-19 23:04:52 +00:00
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
|
|
|
|
|
|
|
#include "anidata_p.h"
|
|
|
|
|
2015-07-31 10:07:53 +00:00
|
|
|
#include "logging_p.h"
|
2011-10-19 23:04:52 +00:00
|
|
|
|
2012-10-27 21:35:19 +00:00
|
|
|
QDebug operator<<(QDebug dbg, const KWin::AniData &a)
|
|
|
|
{
|
|
|
|
dbg.nospace() << a.debugInfo();
|
|
|
|
return dbg.space();
|
|
|
|
}
|
|
|
|
|
2011-10-19 23:04:52 +00:00
|
|
|
using namespace KWin;
|
|
|
|
|
2018-10-09 15:44:07 +00:00
|
|
|
FullScreenEffectLock::FullScreenEffectLock(Effect *effect)
|
|
|
|
{
|
|
|
|
effects->setActiveFullScreenEffect(effect);
|
|
|
|
}
|
|
|
|
|
|
|
|
FullScreenEffectLock::~FullScreenEffectLock()
|
|
|
|
{
|
|
|
|
effects->setActiveFullScreenEffect(nullptr);
|
|
|
|
}
|
|
|
|
|
[effects/dialogparent] Fix flickering of parent windows
Summary:
If a modal window is closed and some alternative effect that animates
the disappearing of windows is enabled(e.g. the Glide effect, or the
Scale effect), the Dialog Parent effect can cause flickering of the
parent window because its animation duration doesn't match duration of
those alternative effects.
Also, if the Fade effect, the Glide effect, and the Scale effect are
disabled, the Dialog Parent will keep the parent window alive for no
good reason.
This change addresses that problem by adding keepAlive property to
`animate` function so scripted effects have more control over lifetime
of animated windows.
If both a modal window and its parent window are closed at the same time
(and there is no effect that animates the disappearing of windows), the
Dialog Parent will stop immediately(because windowDeleted will be
emitted right after windowClosed signal).
If both a modal window and its parent window are closed at the same time
(and there is effect that animates the disappearing of windows), the
Dialog Parent won't reference the latter window. Thus, it won't cause
flickering. I.e. it will "passively" animate parent windows.
BUG: 355036
FIXED-IN: 5.15.0
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14919
2018-10-10 07:36:45 +00:00
|
|
|
KeepAliveLock::KeepAliveLock(EffectWindow *w)
|
|
|
|
: m_window(w)
|
|
|
|
{
|
|
|
|
m_window->refWindow();
|
|
|
|
}
|
|
|
|
|
|
|
|
KeepAliveLock::~KeepAliveLock()
|
|
|
|
{
|
|
|
|
m_window->unrefWindow();
|
|
|
|
}
|
|
|
|
|
2011-10-19 23:04:52 +00:00
|
|
|
AniData::AniData()
|
2015-11-05 14:14:06 +00:00
|
|
|
: attribute(AnimationEffect::Opacity)
|
|
|
|
, customCurve(0) // Linear
|
|
|
|
, time(0)
|
|
|
|
, duration(0)
|
|
|
|
, meta(0)
|
|
|
|
, startTime(0)
|
|
|
|
, waitAtSource(false)
|
|
|
|
, keepAtTarget(false)
|
[effects/dialogparent] Fix flickering of parent windows
Summary:
If a modal window is closed and some alternative effect that animates
the disappearing of windows is enabled(e.g. the Glide effect, or the
Scale effect), the Dialog Parent effect can cause flickering of the
parent window because its animation duration doesn't match duration of
those alternative effects.
Also, if the Fade effect, the Glide effect, and the Scale effect are
disabled, the Dialog Parent will keep the parent window alive for no
good reason.
This change addresses that problem by adding keepAlive property to
`animate` function so scripted effects have more control over lifetime
of animated windows.
If both a modal window and its parent window are closed at the same time
(and there is no effect that animates the disappearing of windows), the
Dialog Parent will stop immediately(because windowDeleted will be
emitted right after windowClosed signal).
If both a modal window and its parent window are closed at the same time
(and there is effect that animates the disappearing of windows), the
Dialog Parent won't reference the latter window. Thus, it won't cause
flickering. I.e. it will "passively" animate parent windows.
BUG: 355036
FIXED-IN: 5.15.0
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14919
2018-10-10 07:36:45 +00:00
|
|
|
, keepAlive(true)
|
2011-10-19 23:04:52 +00:00
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2015-11-05 14:14:06 +00:00
|
|
|
AniData::AniData(AnimationEffect::Attribute a, int meta_, int ms, const FPx2 &to_,
|
2018-10-03 00:11:59 +00:00
|
|
|
QEasingCurve curve_, int delay, const FPx2 &from_, bool waitAtSource_, bool keepAtTarget_,
|
[effects/dialogparent] Fix flickering of parent windows
Summary:
If a modal window is closed and some alternative effect that animates
the disappearing of windows is enabled(e.g. the Glide effect, or the
Scale effect), the Dialog Parent effect can cause flickering of the
parent window because its animation duration doesn't match duration of
those alternative effects.
Also, if the Fade effect, the Glide effect, and the Scale effect are
disabled, the Dialog Parent will keep the parent window alive for no
good reason.
This change addresses that problem by adding keepAlive property to
`animate` function so scripted effects have more control over lifetime
of animated windows.
If both a modal window and its parent window are closed at the same time
(and there is no effect that animates the disappearing of windows), the
Dialog Parent will stop immediately(because windowDeleted will be
emitted right after windowClosed signal).
If both a modal window and its parent window are closed at the same time
(and there is effect that animates the disappearing of windows), the
Dialog Parent won't reference the latter window. Thus, it won't cause
flickering. I.e. it will "passively" animate parent windows.
BUG: 355036
FIXED-IN: 5.15.0
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14919
2018-10-10 07:36:45 +00:00
|
|
|
FullScreenEffectLockPtr fullScreenEffectLock_, bool keepAlive)
|
2015-11-05 14:14:06 +00:00
|
|
|
: attribute(a)
|
|
|
|
, curve(curve_)
|
|
|
|
, from(from_)
|
|
|
|
, to(to_)
|
|
|
|
, time(0)
|
|
|
|
, duration(ms)
|
|
|
|
, meta(meta_)
|
|
|
|
, startTime(AnimationEffect::clock() + delay)
|
2018-10-03 00:11:59 +00:00
|
|
|
, fullScreenEffectLock(fullScreenEffectLock_)
|
2015-11-05 14:14:06 +00:00
|
|
|
, waitAtSource(waitAtSource_)
|
|
|
|
, keepAtTarget(keepAtTarget_)
|
[effects/dialogparent] Fix flickering of parent windows
Summary:
If a modal window is closed and some alternative effect that animates
the disappearing of windows is enabled(e.g. the Glide effect, or the
Scale effect), the Dialog Parent effect can cause flickering of the
parent window because its animation duration doesn't match duration of
those alternative effects.
Also, if the Fade effect, the Glide effect, and the Scale effect are
disabled, the Dialog Parent will keep the parent window alive for no
good reason.
This change addresses that problem by adding keepAlive property to
`animate` function so scripted effects have more control over lifetime
of animated windows.
If both a modal window and its parent window are closed at the same time
(and there is no effect that animates the disappearing of windows), the
Dialog Parent will stop immediately(because windowDeleted will be
emitted right after windowClosed signal).
If both a modal window and its parent window are closed at the same time
(and there is effect that animates the disappearing of windows), the
Dialog Parent won't reference the latter window. Thus, it won't cause
flickering. I.e. it will "passively" animate parent windows.
BUG: 355036
FIXED-IN: 5.15.0
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D14919
2018-10-10 07:36:45 +00:00
|
|
|
, keepAlive(keepAlive)
|
2011-10-19 23:04:52 +00:00
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2012-10-27 21:35:19 +00:00
|
|
|
static QString attributeString(KWin::AnimationEffect::Attribute attribute)
|
|
|
|
{
|
|
|
|
switch (attribute) {
|
2013-07-23 05:02:52 +00:00
|
|
|
case KWin::AnimationEffect::Opacity: return QStringLiteral("Opacity");
|
|
|
|
case KWin::AnimationEffect::Brightness: return QStringLiteral("Brightness");
|
|
|
|
case KWin::AnimationEffect::Saturation: return QStringLiteral("Saturation");
|
|
|
|
case KWin::AnimationEffect::Scale: return QStringLiteral("Scale");
|
|
|
|
case KWin::AnimationEffect::Translation: return QStringLiteral("Translation");
|
|
|
|
case KWin::AnimationEffect::Rotation: return QStringLiteral("Rotation");
|
|
|
|
case KWin::AnimationEffect::Position: return QStringLiteral("Position");
|
|
|
|
case KWin::AnimationEffect::Size: return QStringLiteral("Size");
|
|
|
|
case KWin::AnimationEffect::Clip: return QStringLiteral("Clip");
|
|
|
|
default: return QStringLiteral(" ");
|
2012-10-27 21:35:19 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
QString AniData::debugInfo() const
|
|
|
|
{
|
2015-11-05 14:14:06 +00:00
|
|
|
return QLatin1String("Animation: ") + attributeString(attribute) +
|
|
|
|
QLatin1String("\n From: ") + from.toString() +
|
|
|
|
QLatin1String("\n To: ") + to.toString() +
|
|
|
|
QLatin1String("\n Started: ") + QString::number(AnimationEffect::clock() - startTime) + QLatin1String("ms ago\n") +
|
|
|
|
QLatin1String( " Duration: ") + QString::number(duration) + QLatin1String("ms\n") +
|
2018-10-23 15:21:51 +00:00
|
|
|
QLatin1String( " Passed: ") + QString::number(time) + QLatin1String("ms\n");
|
2012-10-27 21:35:19 +00:00
|
|
|
}
|