yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/src/scene/dndiconitem.cpp

50 lines
1.3 KiB
C++
Raw Normal View History

scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
/*
SPDX-FileCopyrightText: 2022 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
SPDX-License-Identifier: GPL-2.0-or-later
*/
Move scene related bits into src/scene/ directory We've got quite a few scene related files, move them in a directory to group related code together.
2022-12-15 20:35:22 +00:00
#include "scene/dndiconitem.h"
#include "scene/surfaceitem_wayland.h"
wayland: Drop "_interface" from filenames The cpp files in the wayland directory are named after protocol names. "_interface" does not contribute anything new.
2023-09-13 05:52:59 +00:00
#include "wayland/datadevice.h"
#include "wayland/surface.h"
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
namespace KWin
{
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
DragAndDropIconItem::DragAndDropIconItem(DragAndDropIcon *icon, Scene *scene, Item *parent)
scene: Pass Scene to Item constructor This is needed to establish explicit connection between an item and the scene it belongs to. For now, the scene must be known at the item construction time. Perhaps it can be improved in the future by items inheriting their scene from the parent item, but the scene would need to be refactored more so there's a root item or something like that.
2022-12-18 12:30:40 +00:00
: Item(scene, parent)
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
{
scene: Pass Scene to Item constructor This is needed to establish explicit connection between an item and the scene it belongs to. For now, the scene must be known at the item construction time. Perhaps it can be improved in the future by items inheriting their scene from the parent item, but the scene would need to be refactored more so there's a root item or something like that.
2022-12-18 12:30:40 +00:00
m_surfaceItem = std::make_unique<SurfaceItemWayland>(icon->surface(), scene, this);
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
m_surfaceItem->setPosition(icon->position());
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
connect(icon, &DragAndDropIcon::destroyed, this, [this]() {
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
m_surfaceItem.reset();
});
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
connect(icon, &DragAndDropIcon::changed, this, [this, icon]() {
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
m_surfaceItem->setPosition(icon->position());
});
}
DragAndDropIconItem::~DragAndDropIconItem()
{
}
wayland: Make SurfaceInterface::{frameRendered,takePresentationFeedback} not touch subsurface tree This gives us greater flexibility and in general more cleaner code.
2023-11-14 06:58:00 +00:00
SurfaceInterface *DragAndDropIconItem::surface() const
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
{
wayland: Make SurfaceInterface::{frameRendered,takePresentationFeedback} not touch subsurface tree This gives us greater flexibility and in general more cleaner code.
2023-11-14 06:58:00 +00:00
return m_surfaceItem ? m_surfaceItem->surface() : nullptr;
wayland: implement presentation time
2023-10-19 14:35:14 +00:00
}
scene: Set preferred output scale for DND icon Otherwise the icon will have a scale of 1, leading to blurry drag pixmaps on Wayland.
2023-08-02 12:01:02 +00:00
void DragAndDropIconItem::setOutput(Output *output)
{
if (m_surfaceItem && output) {
wayland: implement presentation time
2023-10-19 14:35:14 +00:00
m_output = output;
scene: Set preferred output scale for DND icon Otherwise the icon will have a scale of 1, leading to blurry drag pixmaps on Wayland.
2023-08-02 12:01:02 +00:00
m_surfaceItem->surface()->setPreferredBufferScale(output->scale());
implement the frog color management protocol
2023-10-25 16:36:33 +00:00
m_surfaceItem->surface()->setPreferredColorDescription(output->colorDescription());
scene: Set preferred output scale for DND icon Otherwise the icon will have a scale of 1, leading to blurry drag pixmaps on Wayland.
2023-08-02 12:01:02 +00:00
}
}
scene: Remove dnd icon hack Currently, kwin blits the dnd icon onto the cursor image. This doesn't work on mobile because the cursor is usually hidden there. As a short term solution, put the dnd icon in the Scene. In the future, it needs to be put in its own render layer.
2022-05-07 11:17:36 +00:00
} // namespace KWin
Add explicit moc includes to sources for moc-covered headers * speeds up incremental builds as changes to a header will not always need the full mocs_compilation.cpp for all the target's headers rebuild, while having a moc file sourced into a source file only adds minor extra costs, due to small own code and the used headers usually already covered by the source file, being for the same class/struct * seems to not slow down clean builds, due to empty mocs_compilation.cpp resulting in those quickly processed, while the minor extra cost of the sourced moc files does not outweigh that in summary. Measured times actually improved by some percent points. (ideally CMake would just skip empty mocs_compilation.cpp & its object file one day) * enables compiler to see all methods of a class in same compilation unit to do some sanity checks * potentially more inlining in general, due to more in the compilation unit * allows to keep using more forward declarations in the header, as with the moc code being sourced into the cpp file there definitions can be ensured and often are already for the needs of the normal class methods
2023-07-05 06:30:14 +00:00
#include "moc_dndiconitem.cpp"
Reference in a new issue Copy permalink