2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
2016-08-25 11:23:06 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2016 Martin Gräßlin <mgraesslin@kde.org>
|
2016-08-25 11:23:06 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
*/
|
2016-08-25 11:23:06 +00:00
|
|
|
#include "kwin_wayland_test.h"
|
2022-03-23 10:13:38 +00:00
|
|
|
|
2016-08-25 11:23:06 +00:00
|
|
|
#include "atoms.h"
|
2022-08-29 07:55:49 +00:00
|
|
|
#include "core/output.h"
|
|
|
|
#include "core/platform.h"
|
2016-08-25 11:23:06 +00:00
|
|
|
#include "cursor.h"
|
|
|
|
#include "deleted.h"
|
|
|
|
#include "rules.h"
|
|
|
|
#include "wayland_server.h"
|
|
|
|
#include "workspace.h"
|
2022-04-22 17:54:31 +00:00
|
|
|
#include "x11window.h"
|
2016-08-25 11:23:06 +00:00
|
|
|
|
|
|
|
#include <netwm.h>
|
|
|
|
#include <xcb/xcb_icccm.h>
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
|
|
|
|
static const QString s_socketName = QStringLiteral("wayland_test_kwin_window_rules-0");
|
|
|
|
|
|
|
|
class WindowRuleTest : public QObject
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
private Q_SLOTS:
|
|
|
|
void initTestCase();
|
|
|
|
void init();
|
|
|
|
void cleanup();
|
|
|
|
void testApplyInitialMaximizeVert_data();
|
|
|
|
void testApplyInitialMaximizeVert();
|
2018-11-04 19:23:00 +00:00
|
|
|
void testWindowClassChange();
|
2016-08-25 11:23:06 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
void WindowRuleTest::initTestCase()
|
|
|
|
{
|
2022-04-22 17:39:12 +00:00
|
|
|
qRegisterMetaType<KWin::Window *>();
|
2022-03-23 10:13:38 +00:00
|
|
|
qRegisterMetaType<KWin::Deleted *>();
|
2020-07-07 09:32:29 +00:00
|
|
|
QSignalSpy applicationStartedSpy(kwinApp(), &Application::started);
|
2016-08-25 11:23:06 +00:00
|
|
|
kwinApp()->platform()->setInitialWindowSize(QSize(1280, 1024));
|
2020-12-09 13:06:15 +00:00
|
|
|
QVERIFY(waylandServer()->init(s_socketName));
|
2019-08-26 21:16:53 +00:00
|
|
|
QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
|
2016-08-25 11:23:06 +00:00
|
|
|
|
|
|
|
kwinApp()->start();
|
2020-07-07 09:32:29 +00:00
|
|
|
QVERIFY(applicationStartedSpy.wait());
|
2022-07-11 10:41:15 +00:00
|
|
|
const auto outputs = workspace()->outputs();
|
2021-08-31 07:03:05 +00:00
|
|
|
QCOMPARE(outputs.count(), 2);
|
|
|
|
QCOMPARE(outputs[0]->geometry(), QRect(0, 0, 1280, 1024));
|
|
|
|
QCOMPARE(outputs[1]->geometry(), QRect(1280, 0, 1280, 1024));
|
2016-08-25 11:23:06 +00:00
|
|
|
setenv("QT_QPA_PLATFORM", "wayland", true);
|
|
|
|
}
|
|
|
|
|
|
|
|
void WindowRuleTest::init()
|
|
|
|
{
|
2021-08-28 18:58:29 +00:00
|
|
|
workspace()->setActiveOutput(QPoint(640, 512));
|
2020-04-02 16:18:01 +00:00
|
|
|
Cursors::self()->mouse()->setPos(QPoint(640, 512));
|
2022-04-23 08:33:23 +00:00
|
|
|
QVERIFY(waylandServer()->windows().isEmpty());
|
2016-08-25 11:23:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void WindowRuleTest::cleanup()
|
|
|
|
{
|
|
|
|
// discards old rules
|
2022-07-30 22:40:49 +00:00
|
|
|
workspace()->rulebook()->load();
|
2016-08-25 11:23:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
struct XcbConnectionDeleter
|
|
|
|
{
|
2022-08-01 21:29:02 +00:00
|
|
|
void operator()(xcb_connection_t *pointer)
|
2016-08-25 11:23:06 +00:00
|
|
|
{
|
|
|
|
xcb_disconnect(pointer);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
void WindowRuleTest::testApplyInitialMaximizeVert_data()
|
|
|
|
{
|
|
|
|
QTest::addColumn<QByteArray>("role");
|
|
|
|
|
|
|
|
QTest::newRow("lowercase") << QByteArrayLiteral("mainwindow");
|
|
|
|
QTest::newRow("CamelCase") << QByteArrayLiteral("MainWindow");
|
|
|
|
}
|
|
|
|
|
|
|
|
void WindowRuleTest::testApplyInitialMaximizeVert()
|
|
|
|
{
|
|
|
|
// this test creates the situation of BUG 367554: creates a window and initial apply maximize vertical
|
|
|
|
// the window is matched by class and role
|
|
|
|
// load the rule
|
|
|
|
QFile ruleFile(QFINDTESTDATA("./data/rules/maximize-vert-apply-initial"));
|
|
|
|
QVERIFY(ruleFile.open(QIODevice::ReadOnly | QIODevice::Text));
|
2022-07-30 22:40:49 +00:00
|
|
|
QMetaObject::invokeMethod(workspace()->rulebook(), "temporaryRulesMessage", Q_ARG(QString, QString::fromUtf8(ruleFile.readAll())));
|
2016-08-25 11:23:06 +00:00
|
|
|
|
|
|
|
// create the test window
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
|
|
|
QVERIFY(!xcb_connection_has_error(c.get()));
|
2016-08-25 11:23:06 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_window_t windowId = xcb_generate_id(c.get());
|
2016-08-25 11:23:06 +00:00
|
|
|
const QRect windowGeometry = QRect(0, 0, 10, 20);
|
|
|
|
const uint32_t values[] = {
|
2022-03-23 10:13:38 +00:00
|
|
|
XCB_EVENT_MASK_ENTER_WINDOW | XCB_EVENT_MASK_LEAVE_WINDOW};
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
|
2016-08-25 11:23:06 +00:00
|
|
|
windowGeometry.x(),
|
|
|
|
windowGeometry.y(),
|
|
|
|
windowGeometry.width(),
|
|
|
|
windowGeometry.height(),
|
|
|
|
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, XCB_CW_EVENT_MASK, values);
|
|
|
|
xcb_size_hints_t hints;
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
|
|
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
|
|
|
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
|
|
|
|
xcb_icccm_set_wm_class(c.get(), windowId, 9, "kpat\0kpat");
|
2016-08-25 11:23:06 +00:00
|
|
|
|
|
|
|
QFETCH(QByteArray, role);
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_change_property(c.get(), XCB_PROP_MODE_REPLACE, windowId, atoms->wm_window_role, XCB_ATOM_STRING, 8, role.length(), role.constData());
|
2016-08-25 11:23:06 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
|
2016-08-25 11:23:06 +00:00
|
|
|
info.setWindowType(NET::Normal);
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_map_window(c.get(), windowId);
|
|
|
|
xcb_flush(c.get());
|
2016-08-25 11:23:06 +00:00
|
|
|
|
2022-04-23 08:33:23 +00:00
|
|
|
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
|
2016-08-25 11:23:06 +00:00
|
|
|
QVERIFY(windowCreatedSpy.wait());
|
2022-04-23 19:51:16 +00:00
|
|
|
X11Window *window = windowCreatedSpy.last().first().value<X11Window *>();
|
|
|
|
QVERIFY(window);
|
|
|
|
QVERIFY(window->isDecorated());
|
|
|
|
QVERIFY(!window->hasStrut());
|
|
|
|
QVERIFY(!window->isHiddenInternal());
|
|
|
|
QVERIFY(!window->readyForPainting());
|
|
|
|
QMetaObject::invokeMethod(window, "setReadyForPainting");
|
|
|
|
QVERIFY(window->readyForPainting());
|
|
|
|
QVERIFY(Test::waitForWaylandSurface(window));
|
|
|
|
QCOMPARE(window->maximizeMode(), MaximizeVertical);
|
2016-08-25 11:23:06 +00:00
|
|
|
|
|
|
|
// destroy window again
|
2022-04-23 19:51:16 +00:00
|
|
|
QSignalSpy windowClosedSpy(window, &X11Window::windowClosed);
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_unmap_window(c.get(), windowId);
|
|
|
|
xcb_destroy_window(c.get(), windowId);
|
|
|
|
xcb_flush(c.get());
|
2016-08-25 11:23:06 +00:00
|
|
|
QVERIFY(windowClosedSpy.wait());
|
|
|
|
}
|
|
|
|
|
2018-11-04 19:23:00 +00:00
|
|
|
void WindowRuleTest::testWindowClassChange()
|
|
|
|
{
|
|
|
|
KSharedConfig::Ptr config = KSharedConfig::openConfig(QString(), KConfig::SimpleConfig);
|
|
|
|
config->group("General").writeEntry("count", 1);
|
|
|
|
|
|
|
|
auto group = config->group("1");
|
|
|
|
group.writeEntry("above", true);
|
|
|
|
group.writeEntry("aboverule", 2);
|
|
|
|
group.writeEntry("wmclass", "org.kde.foo");
|
|
|
|
group.writeEntry("wmclasscomplete", false);
|
|
|
|
group.writeEntry("wmclassmatch", 1);
|
|
|
|
group.sync();
|
|
|
|
|
2022-07-30 22:40:49 +00:00
|
|
|
workspace()->rulebook()->setConfig(config);
|
2018-11-04 19:23:00 +00:00
|
|
|
workspace()->slotReconfigure();
|
|
|
|
|
|
|
|
// create the test window
|
2022-08-01 21:29:02 +00:00
|
|
|
std::unique_ptr<xcb_connection_t, XcbConnectionDeleter> c(xcb_connect(nullptr, nullptr));
|
|
|
|
QVERIFY(!xcb_connection_has_error(c.get()));
|
2018-11-04 19:23:00 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_window_t windowId = xcb_generate_id(c.get());
|
2018-11-04 19:23:00 +00:00
|
|
|
const QRect windowGeometry = QRect(0, 0, 10, 20);
|
|
|
|
const uint32_t values[] = {
|
2022-03-23 10:13:38 +00:00
|
|
|
XCB_EVENT_MASK_ENTER_WINDOW | XCB_EVENT_MASK_LEAVE_WINDOW};
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_create_window(c.get(), XCB_COPY_FROM_PARENT, windowId, rootWindow(),
|
2018-11-04 19:23:00 +00:00
|
|
|
windowGeometry.x(),
|
|
|
|
windowGeometry.y(),
|
|
|
|
windowGeometry.width(),
|
|
|
|
windowGeometry.height(),
|
|
|
|
0, XCB_WINDOW_CLASS_INPUT_OUTPUT, XCB_COPY_FROM_PARENT, XCB_CW_EVENT_MASK, values);
|
|
|
|
xcb_size_hints_t hints;
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
|
|
xcb_icccm_size_hints_set_position(&hints, 1, windowGeometry.x(), windowGeometry.y());
|
|
|
|
xcb_icccm_size_hints_set_size(&hints, 1, windowGeometry.width(), windowGeometry.height());
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_icccm_set_wm_normal_hints(c.get(), windowId, &hints);
|
|
|
|
xcb_icccm_set_wm_class(c.get(), windowId, 23, "org.kde.bar\0org.kde.bar");
|
2018-11-04 19:23:00 +00:00
|
|
|
|
2022-08-01 21:29:02 +00:00
|
|
|
NETWinInfo info(c.get(), windowId, rootWindow(), NET::WMAllProperties, NET::WM2AllProperties);
|
2018-11-04 19:23:00 +00:00
|
|
|
info.setWindowType(NET::Normal);
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_map_window(c.get(), windowId);
|
|
|
|
xcb_flush(c.get());
|
2018-11-04 19:23:00 +00:00
|
|
|
|
2022-04-23 08:33:23 +00:00
|
|
|
QSignalSpy windowCreatedSpy(workspace(), &Workspace::windowAdded);
|
2018-11-04 19:23:00 +00:00
|
|
|
QVERIFY(windowCreatedSpy.wait());
|
2022-04-23 19:51:16 +00:00
|
|
|
X11Window *window = windowCreatedSpy.last().first().value<X11Window *>();
|
|
|
|
QVERIFY(window);
|
|
|
|
QVERIFY(window->isDecorated());
|
|
|
|
QVERIFY(!window->hasStrut());
|
|
|
|
QVERIFY(!window->isHiddenInternal());
|
|
|
|
QVERIFY(!window->readyForPainting());
|
|
|
|
QMetaObject::invokeMethod(window, "setReadyForPainting");
|
|
|
|
QVERIFY(window->readyForPainting());
|
|
|
|
QVERIFY(Test::waitForWaylandSurface(window));
|
|
|
|
QCOMPARE(window->keepAbove(), false);
|
2018-11-04 19:23:00 +00:00
|
|
|
|
|
|
|
// now change class
|
2022-04-23 19:51:16 +00:00
|
|
|
QSignalSpy windowClassChangedSpy{window, &X11Window::windowClassChanged};
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_icccm_set_wm_class(c.get(), windowId, 23, "org.kde.foo\0org.kde.foo");
|
|
|
|
xcb_flush(c.get());
|
2018-11-04 19:23:00 +00:00
|
|
|
QVERIFY(windowClassChangedSpy.wait());
|
2022-04-23 19:51:16 +00:00
|
|
|
QCOMPARE(window->keepAbove(), true);
|
2018-11-04 19:23:00 +00:00
|
|
|
|
|
|
|
// destroy window
|
2022-04-23 19:51:16 +00:00
|
|
|
QSignalSpy windowClosedSpy(window, &X11Window::windowClosed);
|
2022-08-01 21:29:02 +00:00
|
|
|
xcb_unmap_window(c.get(), windowId);
|
|
|
|
xcb_destroy_window(c.get(), windowId);
|
|
|
|
xcb_flush(c.get());
|
2018-11-04 19:23:00 +00:00
|
|
|
QVERIFY(windowClosedSpy.wait());
|
|
|
|
}
|
|
|
|
|
2016-08-25 11:23:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
WAYLANDTEST_MAIN(KWin::WindowRuleTest)
|
|
|
|
#include "window_rules_test.moc"
|