2020-08-02 22:22:19 +00:00
|
|
|
/*
|
|
|
|
|
KWin - the KDE window manager
|
|
|
|
|
This file is part of the KDE project.
|
2009-02-06 18:53:16 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-FileCopyrightText: 2009 Martin Gräßlin <mgraesslin@kde.org>
|
2009-02-06 18:53:16 +00:00
|
|
|
|
2020-08-02 22:22:19 +00:00
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
|
*/
|
2009-02-06 18:53:16 +00:00
|
|
|
|
|
|
|
|
#ifndef KWIN_CUBESLIDE_H
|
|
|
|
|
#define KWIN_CUBESLIDE_H
|
|
|
|
|
|
|
|
|
|
#include <kwineffects.h>
|
|
|
|
|
#include <kwinglutils.h>
|
|
|
|
|
#include <QQueue>
|
|
|
|
|
#include <QSet>
|
2011-03-14 21:50:05 +00:00
|
|
|
#include <QTimeLine>
|
2009-02-06 18:53:16 +00:00
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
|
{
|
|
|
|
|
class CubeSlideEffect
|
|
|
|
|
: public Effect
|
2011-01-30 14:34:42 +00:00
|
|
|
{
|
2011-02-25 19:25:21 +00:00
|
|
|
Q_OBJECT
|
2012-08-11 09:24:37 +00:00
|
|
|
Q_PROPERTY(int rotationDuration READ configuredRotationDuration)
|
|
|
|
|
Q_PROPERTY(bool dontSlidePanels READ isDontSlidePanels)
|
|
|
|
|
Q_PROPERTY(bool dontSlideStickyWindows READ isDontSlideStickyWindows)
|
|
|
|
|
Q_PROPERTY(bool usePagerLayout READ isUsePagerLayout)
|
|
|
|
|
Q_PROPERTY(bool useWindowMoving READ isUseWindowMoving)
|
2011-01-30 14:34:42 +00:00
|
|
|
public:
|
|
|
|
|
CubeSlideEffect();
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~CubeSlideEffect() override;
|
|
|
|
|
void reconfigure(ReconfigureFlags) override;
|
Provide expected presentation time to effects
Effects are given the interval between two consecutive frames. The main
flaw of this approach is that if the Compositor transitions from the idle
state to "active" state, i.e. when there is something to repaint,
effects may see a very large interval between the last painted frame and
the current. In order to address this issue, the Scene invalidates the
timer that is used to measure time between consecutive frames before the
Compositor is about to become idle.
While this works perfectly fine with Xinerama-style rendering, with per
screen rendering, determining whether the compositor is about to idle is
rather a tedious task mostly because a single output can't be used for
the test.
Furthermore, since the Compositor schedules pointless repaints just to
ensure that it's idle, it might take several attempts to figure out
whether the scene timer must be invalidated if you use (true) per screen
rendering.
Ideally, all effects should use a timeline helper that is aware of the
underlying render loop and its timings. However, this option is off the
table because it will involve a lot of work to implement it.
Alternative and much simpler option is to pass the expected presentation
time to effects rather than time between consecutive frames. This means
that effects are responsible for determining how much animation timelines
have to be advanced. Typically, an effect would have to store the
presentation timestamp provided in either prePaint{Screen,Window} and
use it in the subsequent prePaint{Screen,Window} call to estimate the
amount of time passed between the next and the last frames.
Unfortunately, this is an API incompatible change. However, it shouldn't
take a lot of work to port third-party binary effects, which don't use the
AnimationEffect class, to the new API. On the bright side, we no longer
need to be concerned about the Compositor getting idle.
We do still try to determine whether the Compositor is about to idle,
primarily, because the OpenGL render backend swaps buffers on present,
but that will change with the ongoing compositing timing rework.
2020-11-20 15:44:04 +00:00
|
|
|
void prePaintScreen(ScreenPrePaintData& data, std::chrono::milliseconds presentTime) override;
|
2019-10-29 22:04:15 +00:00
|
|
|
void paintScreen(int mask, const QRegion ®ion, ScreenPaintData& data) override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void postPaintScreen() override;
|
Provide expected presentation time to effects
Effects are given the interval between two consecutive frames. The main
flaw of this approach is that if the Compositor transitions from the idle
state to "active" state, i.e. when there is something to repaint,
effects may see a very large interval between the last painted frame and
the current. In order to address this issue, the Scene invalidates the
timer that is used to measure time between consecutive frames before the
Compositor is about to become idle.
While this works perfectly fine with Xinerama-style rendering, with per
screen rendering, determining whether the compositor is about to idle is
rather a tedious task mostly because a single output can't be used for
the test.
Furthermore, since the Compositor schedules pointless repaints just to
ensure that it's idle, it might take several attempts to figure out
whether the scene timer must be invalidated if you use (true) per screen
rendering.
Ideally, all effects should use a timeline helper that is aware of the
underlying render loop and its timings. However, this option is off the
table because it will involve a lot of work to implement it.
Alternative and much simpler option is to pass the expected presentation
time to effects rather than time between consecutive frames. This means
that effects are responsible for determining how much animation timelines
have to be advanced. Typically, an effect would have to store the
presentation timestamp provided in either prePaint{Screen,Window} and
use it in the subsequent prePaint{Screen,Window} call to estimate the
amount of time passed between the next and the last frames.
Unfortunately, this is an API incompatible change. However, it shouldn't
take a lot of work to port third-party binary effects, which don't use the
AnimationEffect class, to the new API. On the bright side, we no longer
need to be concerned about the Compositor getting idle.
We do still try to determine whether the Compositor is about to idle,
primarily, because the OpenGL render backend swaps buffers on present,
but that will change with the ongoing compositing timing rework.
2020-11-20 15:44:04 +00:00
|
|
|
void prePaintWindow(EffectWindow* w, WindowPrePaintData& data, std::chrono::milliseconds presentTime) override;
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
void paintWindow(EffectWindow* w, int mask, QRegion region, WindowPaintData& data) override;
|
|
|
|
|
bool isActive() const override;
|
2009-02-06 18:53:16 +00:00
|
|
|
|
2014-03-24 10:50:09 +00:00
|
|
|
int requestedEffectChainPosition() const override {
|
|
|
|
|
return 50;
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
static bool supported();
|
2011-02-25 19:41:10 +00:00
|
|
|
|
2012-08-11 09:24:37 +00:00
|
|
|
// for properties
|
|
|
|
|
int configuredRotationDuration() const {
|
|
|
|
|
return rotationDuration;
|
|
|
|
|
}
|
|
|
|
|
bool isDontSlidePanels() const {
|
|
|
|
|
return dontSlidePanels;
|
|
|
|
|
}
|
|
|
|
|
bool isDontSlideStickyWindows() const {
|
|
|
|
|
return dontSlideStickyWindows;
|
|
|
|
|
}
|
|
|
|
|
bool isUsePagerLayout() const {
|
|
|
|
|
return usePagerLayout;
|
|
|
|
|
}
|
|
|
|
|
bool isUseWindowMoving() const {
|
|
|
|
|
return useWindowMoving;
|
|
|
|
|
}
|
2011-02-25 19:41:10 +00:00
|
|
|
private Q_SLOTS:
|
2018-09-14 09:36:55 +00:00
|
|
|
void slotWindowAdded(EffectWindow* w);
|
|
|
|
|
void slotWindowDeleted(EffectWindow* w);
|
|
|
|
|
|
|
|
|
|
void slotDesktopChanged(int old, int current, EffectWindow* w);
|
2012-01-29 11:29:24 +00:00
|
|
|
void slotWindowStepUserMovedResized(KWin::EffectWindow *w);
|
|
|
|
|
void slotWindowFinishUserMovedResized(KWin::EffectWindow *w);
|
2019-05-07 09:07:02 +00:00
|
|
|
void slotNumberDesktopsChanged();
|
2011-02-25 19:41:10 +00:00
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
private:
|
|
|
|
|
enum RotationDirection {
|
|
|
|
|
Left,
|
|
|
|
|
Right,
|
|
|
|
|
Upwards,
|
|
|
|
|
Downwards
|
2009-02-06 18:53:16 +00:00
|
|
|
};
|
2011-01-30 14:34:42 +00:00
|
|
|
void paintSlideCube(int mask, QRegion region, ScreenPaintData& data);
|
|
|
|
|
void windowMovingChanged(float progress, RotationDirection direction);
|
2018-09-14 09:36:55 +00:00
|
|
|
|
|
|
|
|
bool shouldAnimate(const EffectWindow* w) const;
|
|
|
|
|
void startAnimation();
|
|
|
|
|
|
2011-01-30 14:34:42 +00:00
|
|
|
bool cube_painting;
|
|
|
|
|
int front_desktop;
|
|
|
|
|
int painting_desktop;
|
|
|
|
|
int other_desktop;
|
|
|
|
|
bool firstDesktop;
|
2018-09-14 09:36:55 +00:00
|
|
|
bool stickyPainting;
|
|
|
|
|
QSet<EffectWindow*> staticWindows;
|
2011-03-14 21:50:05 +00:00
|
|
|
QTimeLine timeLine;
|
Provide expected presentation time to effects
Effects are given the interval between two consecutive frames. The main
flaw of this approach is that if the Compositor transitions from the idle
state to "active" state, i.e. when there is something to repaint,
effects may see a very large interval between the last painted frame and
the current. In order to address this issue, the Scene invalidates the
timer that is used to measure time between consecutive frames before the
Compositor is about to become idle.
While this works perfectly fine with Xinerama-style rendering, with per
screen rendering, determining whether the compositor is about to idle is
rather a tedious task mostly because a single output can't be used for
the test.
Furthermore, since the Compositor schedules pointless repaints just to
ensure that it's idle, it might take several attempts to figure out
whether the scene timer must be invalidated if you use (true) per screen
rendering.
Ideally, all effects should use a timeline helper that is aware of the
underlying render loop and its timings. However, this option is off the
table because it will involve a lot of work to implement it.
Alternative and much simpler option is to pass the expected presentation
time to effects rather than time between consecutive frames. This means
that effects are responsible for determining how much animation timelines
have to be advanced. Typically, an effect would have to store the
presentation timestamp provided in either prePaint{Screen,Window} and
use it in the subsequent prePaint{Screen,Window} call to estimate the
amount of time passed between the next and the last frames.
Unfortunately, this is an API incompatible change. However, it shouldn't
take a lot of work to port third-party binary effects, which don't use the
AnimationEffect class, to the new API. On the bright side, we no longer
need to be concerned about the Compositor getting idle.
We do still try to determine whether the Compositor is about to idle,
primarily, because the OpenGL render backend swaps buffers on present,
but that will change with the ongoing compositing timing rework.
2020-11-20 15:44:04 +00:00
|
|
|
std::chrono::milliseconds lastPresentTime;
|
2011-01-30 14:34:42 +00:00
|
|
|
QQueue<RotationDirection> slideRotations;
|
|
|
|
|
bool dontSlidePanels;
|
|
|
|
|
bool dontSlideStickyWindows;
|
|
|
|
|
bool usePagerLayout;
|
|
|
|
|
int rotationDuration;
|
|
|
|
|
bool useWindowMoving;
|
|
|
|
|
bool windowMoving;
|
|
|
|
|
bool desktopChangedWhileMoving;
|
|
|
|
|
double progressRestriction;
|
|
|
|
|
};
|
2009-02-06 18:53:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#endif
|
