2014-07-22 11:11:19 +00:00
|
|
|
/********************************************************************
|
|
|
|
KWin - the KDE window manager
|
|
|
|
This file is part of the KDE project.
|
|
|
|
|
|
|
|
Copyright (C) 2014 Martin Gräßlin <mgraesslin@kde.org>
|
|
|
|
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
|
|
it under the terms of the GNU General Public License as published by
|
|
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
|
|
(at your option) any later version.
|
|
|
|
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
GNU General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*********************************************************************/
|
|
|
|
#ifndef KWIN_DECORATION_SETTINGS_H
|
|
|
|
#define KWIN_DECORATION_SETTINGS_H
|
|
|
|
|
|
|
|
#include <KDecoration2/Private/DecorationSettingsPrivate>
|
|
|
|
|
|
|
|
#include <QObject>
|
|
|
|
|
2014-07-22 14:02:22 +00:00
|
|
|
class KConfigGroup;
|
|
|
|
|
2014-07-22 11:11:19 +00:00
|
|
|
namespace KWin
|
|
|
|
{
|
|
|
|
namespace Decoration
|
|
|
|
{
|
|
|
|
|
|
|
|
class SettingsImpl : public QObject, public KDecoration2::DecorationSettingsPrivate
|
|
|
|
{
|
|
|
|
Q_OBJECT
|
|
|
|
public:
|
|
|
|
explicit SettingsImpl(KDecoration2::DecorationSettings *parent);
|
Run clang-tidy with modernize-use-override check
Summary:
Currently code base of kwin can be viewed as two pieces. One is very
ancient, and the other one is more modern, which uses new C++ features.
The main problem with the ancient code is that it was written before
C++11 era. So, no override or final keywords, lambdas, etc.
Quite recently, KDE compiler settings were changed to show a warning if
a virtual method has missing override keyword. As you might have already
guessed, this fired back at us because of that ancient code. We had
about 500 new compiler warnings.
A "solution" was proposed to that problem - disable -Wno-suggest-override
and the other similar warning for clang. It's hard to call a solution
because those warnings are disabled not only for the old code, but also
for new. This is not what we want!
The main argument for not actually fixing the problem was that git
history will be screwed as well because of human factor. While good git
history is a very important thing, we should not go crazy about it and
block every change that somehow alters git history. git blame allows to
specify starting revision for a reason.
The other argument (human factor) can be easily solved by using tools
such as clang-tidy. clang-tidy is a clang-based linter for C++. It can
be used for various things, e.g. fixing coding style(e.g. add missing
braces to if statements, readability-braces-around-statements check),
or in our case add missing override keywords.
Test Plan: Compiles.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: davidedmundson, apol, romangg, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
|
|
|
~SettingsImpl() override;
|
2014-07-22 11:11:19 +00:00
|
|
|
bool isAlphaChannelSupported() const override;
|
|
|
|
bool isOnAllDesktopsAvailable() const override;
|
2014-07-25 06:07:08 +00:00
|
|
|
bool isCloseOnDoubleClickOnMenu() const override;
|
2014-07-24 06:37:48 +00:00
|
|
|
KDecoration2::BorderSize borderSize() const override {
|
|
|
|
return m_borderSize;
|
|
|
|
}
|
2014-12-01 10:53:44 +00:00
|
|
|
QVector< KDecoration2::DecorationButtonType > decorationButtonsLeft() const override {
|
2014-07-22 14:02:22 +00:00
|
|
|
return m_leftButtons;
|
|
|
|
}
|
2014-12-01 10:53:44 +00:00
|
|
|
QVector< KDecoration2::DecorationButtonType > decorationButtonsRight() const override {
|
2014-07-22 14:02:22 +00:00
|
|
|
return m_rightButtons;
|
|
|
|
}
|
[decorations] Emit DecorationSettings::fontChanged signal
Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.
Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.
Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.
Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
BUG: 400980
FIXED-IN: 5.15.0
Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16908
2018-11-15 17:40:00 +00:00
|
|
|
QFont font() const override {
|
|
|
|
return m_font;
|
|
|
|
}
|
2014-07-22 14:02:22 +00:00
|
|
|
|
|
|
|
private:
|
|
|
|
void readSettings();
|
2014-12-01 10:53:44 +00:00
|
|
|
QVector< KDecoration2::DecorationButtonType > readDecorationButtons(const KConfigGroup &config,
|
2014-07-22 14:02:22 +00:00
|
|
|
const char *key,
|
2014-12-01 10:53:44 +00:00
|
|
|
const QVector< KDecoration2::DecorationButtonType > &defaultValue) const;
|
|
|
|
QVector< KDecoration2::DecorationButtonType > m_leftButtons;
|
|
|
|
QVector< KDecoration2::DecorationButtonType > m_rightButtons;
|
2014-07-24 06:37:48 +00:00
|
|
|
KDecoration2::BorderSize m_borderSize;
|
[decorations] Let KDecoration plugins recommend a border size per default
Summary:
This is an alternative solution to T8707 and in comparision to D13276 a less
drastic change to KWin's default behavior.
Instead of changing the border size default for all KDecoration plugins by
switching the default from border size Normal to None introduce new
functionality, which allows a KDecoration plugin to recommend a border size in
its metadata. By default KWin listens for these recommendations and sets the
border size accordingly.
If there is no metadata recommending a border size, KWin falls back to the
current setting of Normal sized borders.
A user is able to override the recommendations from the KCM, which has been
extended accordingly.
Test Plan: Manually with adjusted metadata of Breeze.
Reviewers: #kwin, #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: hpereiradacosta, filipf, anemeth, davidedmundson, abetts, graesslin, ngraham, zzag, kwin
Tags: #kwin
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13284
2019-05-04 14:48:44 +00:00
|
|
|
bool m_autoBorderSize = true;
|
2014-12-04 15:28:06 +00:00
|
|
|
bool m_closeDoubleClickMenu = false;
|
[decorations] Emit DecorationSettings::fontChanged signal
Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.
Currently, there are two places where we can emit that signal:
- in KDecoration library itself;
- and in KWin.
Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.
Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.
BUG: 400980
FIXED-IN: 5.15.0
Test Plan:
* Increased the size of the window title font, titlebars got bigger;
* Decreased the font size, titlebars got smaller.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D16908
2018-11-15 17:40:00 +00:00
|
|
|
QFont m_font;
|
2014-07-22 11:11:19 +00:00
|
|
|
};
|
|
|
|
} // Decoration
|
|
|
|
} // KWin
|
|
|
|
|
|
|
|
#endif
|