yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/thumbnailitem.h

151 lines
3.9 KiB
C
Raw Normal View History

Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
/********************************************************************
KWin - the KDE window manager
This file is part of the KDE project.
Copyright (C) 2011 Martin Gräßlin <mgraesslin@kde.org>
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*********************************************************************/
#ifndef KWIN_THUMBNAILITEM_H
#define KWIN_THUMBNAILITEM_H
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
#include <QPointer>
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
#include <QUuid>
Strip module path from all Qt #include <> Done with: fixqt4headers.pl --strip-modules REVIEW: 109176
2013-02-26 08:00:51 +00:00
#include <QWeakPointer>
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
#include <QQuickPaintedItem>
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
namespace KWin
{
ThumbnailItem operates on AbstractClient
2015-05-20 14:23:42 +00:00
class AbstractClient;
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
class EffectWindow;
class EffectWindowImpl;
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
class AbstractThumbnailItem : public QQuickPaintedItem
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
{
Q_OBJECT
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
Q_PROPERTY(qreal brightness READ brightness WRITE setBrightness NOTIFY brightnessChanged)
Q_PROPERTY(qreal saturation READ saturation WRITE setSaturation NOTIFY saturationChanged)
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
Q_PROPERTY(QQuickItem *clipTo READ clipTo WRITE setClipTo NOTIFY clipToChanged)
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
public:
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~AbstractThumbnailItem() override;
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
qreal brightness() const;
qreal saturation() const;
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
QQuickItem *clipTo() const;
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
public Q_SLOTS:
void setBrightness(qreal brightness);
void setSaturation(qreal saturation);
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
void setClipTo(QQuickItem *clip);
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
Q_SIGNALS:
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
void brightnessChanged();
void saturationChanged();
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
void clipToChanged();
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
protected:
Use nullptr everywhere Summary: Because KWin is a very old project, we use three kinds of null pointer literals: 0, NULL, and nullptr. Since C++11, it's recommended to use nullptr keyword. This change converts all usages of 0 and NULL literal to nullptr. Even though it breaks git history, we need to do it in order to have consistent code as well to ease code reviews (it's very tempting for some people to add unrelated changes to their patches, e.g. converting NULL to nullptr). Test Plan: Compiles. Reviewers: #kwin, davidedmundson, romangg Reviewed By: #kwin, davidedmundson, romangg Subscribers: romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
explicit AbstractThumbnailItem(QQuickItem *parent = nullptr);
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
protected Q_SLOTS:
virtual void repaint(KWin::EffectWindow* w) = 0;
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
private Q_SLOTS:
void init();
void effectWindowAdded();
Connect ThumbnailItem to Compositor::compositingToggled If a KWin script uses a ThumbnailItem which gets created before the Compositor is fully initialized the thumbnail is not shown at all because the connect to windowAdded etc. will never happen. Therefore connect to Compositor::compositingToggled to re-connect whenever the compositing state changes. REVIEW: 109310
2013-03-06 08:46:25 +00:00
void compositingToggled();
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
private:
void findParentEffectWindow();
Remove usage of QWeakPointer for QObject for AbstractThumbnailItem::m_parent Summary: This usage of QWeakPointer has been deprecated since Qt 5.0, since it leads to really confusing API - usually you must never dereference a QWeakPointer directly, but always go through QSharedPointer, except in this one case, where it's permissible. Use QPointer instead, which is clean. Reviewers: #kwin, zzag, romangg Reviewed By: #kwin, zzag, romangg Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23071
2019-08-10 14:25:02 +00:00
QPointer<EffectWindowImpl> m_parent;
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
qreal m_brightness;
qreal m_saturation;
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
QPointer<QQuickItem> m_clipToItem;
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
};
Rename ThumbnailItem to WindowThumbnailItem This is for discrimination from the to be added DesktopThumbnailItem. The name for QML is unchanged to keep the public API stable.
2012-03-29 13:46:53 +00:00
class WindowThumbnailItem : public AbstractThumbnailItem
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
{
Q_OBJECT
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
Q_PROPERTY(QUuid wId READ wId WRITE setWId NOTIFY wIdChanged SCRIPTABLE true)
ThumbnailItem operates on AbstractClient
2015-05-20 14:23:42 +00:00
Q_PROPERTY(KWin::AbstractClient *client READ client WRITE setClient NOTIFY clientChanged)
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
public:
Use nullptr everywhere Summary: Because KWin is a very old project, we use three kinds of null pointer literals: 0, NULL, and nullptr. Since C++11, it's recommended to use nullptr keyword. This change converts all usages of 0 and NULL literal to nullptr. Even though it breaks git history, we need to do it in order to have consistent code as well to ease code reviews (it's very tempting for some people to add unrelated changes to their patches, e.g. converting NULL to nullptr). Test Plan: Compiles. Reviewers: #kwin, davidedmundson, romangg Reviewed By: #kwin, davidedmundson, romangg Subscribers: romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
explicit WindowThumbnailItem(QQuickItem *parent = nullptr);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~WindowThumbnailItem() override;
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
QUuid wId() const {
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
return m_wId;
}
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
void setWId(const QUuid &wId);
ThumbnailItem operates on AbstractClient
2015-05-20 14:23:42 +00:00
AbstractClient *client() const;
void setClient(AbstractClient *client);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
void paint(QPainter *painter) override;
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
Q_SIGNALS:
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
void wIdChanged(const QUuid &wid);
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
void clientChanged();
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
protected Q_SLOTS:
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
void repaint(KWin::EffectWindow* w) override;
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
private:
Switch ThumbnailItem to internal uuid instead of WId Summary: So far the ThumbnailItem in TabBox mode used the window id for finding the window it should render a thumbnail on. In the Wayland world this is not unique. The window id could be either an X11 window or a wayland window. We don't guarantee that there are no conflicting ids. With the internal id we have a way to properly identify the windows, so this element should use them. To support this the property changed the type to QUuid and the clientmodel also provides the QUuid. As in TabBox the way to get the window is through the model this should be compatible for all themes. It's tested and verified with the Breeze switcher. For declarative KWin scripts the ThumbnailItem also provides the AbstractClient as a property, so there should not be any script which uses wid. If it does, this could break, but well the script should use the intended API. Test Plan: ctest passes, manual testing of Breeze alt-tab switcher Reviewers: #kwin Differential Revision: https://phabricator.kde.org/D18405
2019-01-20 13:04:13 +00:00
QUuid m_wId;
ThumbnailItem operates on AbstractClient
2015-05-20 14:23:42 +00:00
AbstractClient *m_client;
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
};
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
class DesktopThumbnailItem : public AbstractThumbnailItem
{
Q_OBJECT
Q_PROPERTY(int desktop READ desktop WRITE setDesktop NOTIFY desktopChanged)
public:
Use nullptr everywhere Summary: Because KWin is a very old project, we use three kinds of null pointer literals: 0, NULL, and nullptr. Since C++11, it's recommended to use nullptr keyword. This change converts all usages of 0 and NULL literal to nullptr. Even though it breaks git history, we need to do it in order to have consistent code as well to ease code reviews (it's very tempting for some people to add unrelated changes to their patches, e.g. converting NULL to nullptr). Test Plan: Compiles. Reviewers: #kwin, davidedmundson, romangg Reviewed By: #kwin, davidedmundson, romangg Subscribers: romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D23618
2019-09-19 14:46:54 +00:00
DesktopThumbnailItem(QQuickItem *parent = nullptr);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~DesktopThumbnailItem() override;
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
int desktop() const {
return m_desktop;
}
void setDesktop(int desktop);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
void paint(QPainter *painter) override;
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
Q_SIGNALS:
void desktopChanged(int desktop);
protected Q_SLOTS:
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
void repaint(KWin::EffectWindow* w) override;
Adding a DesktopThumbnailItem declarative item Similar to WindowThumbnailItem for rendering a desktop thumbnail. Uses the new paintDesktop hook. FEATURE: 296067 FIXED-IN: 4.11.0 REVIEW: 104441
2012-03-29 18:17:57 +00:00
private:
int m_desktop;
};
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
inline
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
qreal AbstractThumbnailItem::brightness() const
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
{
return m_brightness;
}
inline
Refactoring: break out a base class for ThumbnailItem Everything that has nothing to do with rendering the window thumbnail goes into an AbstractThumbnailItem. This is a preparation step for adding a DesktopThumbnailItem.
2012-03-29 13:32:41 +00:00
qreal AbstractThumbnailItem::saturation() const
Support saturation/brightness in ThumbnailItem Two new properties saturation and brightness are added to the ThumbnailItem which can be set from QML. The properties are honoured by the Scene when rendering the thumbnail.
2013-03-19 08:08:32 +00:00
{
return m_saturation;
}
Adjust the ThumbnailItems to QtQuick2 AbstractThumbnailItem inherits from QQuickPaintedItem using QPainter to do the fallback painting of icons. The scene is adjusted to get the information from QQuickItem instead of QDeclarativeItem. Clipping got a little bit more complex as the clip path does not exist any more. To get it right the ThumbnailItem needs to specify the parent it wants to be clipped to with the clipTo property. E.g.: clipTo: listView The scene uses this clipTo parent item to correctly calculate the clip region. Also the ThumbnailItem needs to have clipping enabled. Note: this commit currently breaks TabBox as the qml and view are not yet adjusted. In scripting the export of the item is disabled, but any qml script using a ThumbnailItem would obviously also fail.
2013-08-08 09:39:39 +00:00
inline
QQuickItem* AbstractThumbnailItem::clipTo() const
{
return m_clipToItem.data();
}
Add a client property to ThumbnailItem Makes it a little bit easier to use a ThumbnailItem for a Client. E.g. ThumbnailItem { client: model.client } instead of mapping the windowIds, which is rather uncomfty.
2013-03-26 13:43:36 +00:00
inline
ThumbnailItem operates on AbstractClient
2015-05-20 14:23:42 +00:00
AbstractClient *WindowThumbnailItem::client() const
Add a client property to ThumbnailItem Makes it a little bit easier to use a ThumbnailItem for a Client. E.g. ThumbnailItem { client: model.client } instead of mapping the windowIds, which is rather uncomfty.
2013-03-26 13:43:36 +00:00
{
return m_client;
}
Window Thumbnail support for QML A new QML item "ThumbnailItem" is registered to the TabBox. The C++ implementation finds the EffectWindow of the TabBox and adds itself to the EffectWindow. While rendering the EffectWindow the information for all registered ThumbnailItems are extracted and the thumbnail is rendered on top of the EffectWindow. This has obvious limitations like you cannot put other QML items on top of the thumbnail. Nevertheless it works well enough to be a possible replacement for e.g. BoxSwitch effect. When compositing is disabled an icon is rendered instead of the Thumbnail. One TabBox Layout inspired by BoxSwitch Effect is added. For the KCM small pre-rendered items are used. REVIEW: 103039
2011-11-10 13:28:06 +00:00
} // KWin
#endif // KWIN_THUMBNAILITEM_H
Reference in a new issue Copy permalink