kwin/autotests/test_x11_timestamp_update.cpp

113 lines
2.8 KiB
C++
Raw Normal View History

2020-08-02 22:22:19 +00:00
/*
KWin - the KDE window manager
This file is part of the KDE project.
2020-08-02 22:22:19 +00:00
SPDX-FileCopyrightText: 2017 Martin Gräßlin <mgraesslin@kde.org>
2020-08-02 22:22:19 +00:00
SPDX-License-Identifier: GPL-2.0-or-later
*/
#include <QTest>
#include <private/qtx11extras_p.h>
#include "libkwineffects/kwinxcb.h"
#include "main.h"
2022-01-18 08:35:52 +00:00
#include "utils/common.h"
namespace KWin
{
class X11TestApplication : public Application
{
Q_OBJECT
public:
X11TestApplication(int &argc, char **argv);
Run clang-tidy with modernize-use-override check Summary: Currently code base of kwin can be viewed as two pieces. One is very ancient, and the other one is more modern, which uses new C++ features. The main problem with the ancient code is that it was written before C++11 era. So, no override or final keywords, lambdas, etc. Quite recently, KDE compiler settings were changed to show a warning if a virtual method has missing override keyword. As you might have already guessed, this fired back at us because of that ancient code. We had about 500 new compiler warnings. A "solution" was proposed to that problem - disable -Wno-suggest-override and the other similar warning for clang. It's hard to call a solution because those warnings are disabled not only for the old code, but also for new. This is not what we want! The main argument for not actually fixing the problem was that git history will be screwed as well because of human factor. While good git history is a very important thing, we should not go crazy about it and block every change that somehow alters git history. git blame allows to specify starting revision for a reason. The other argument (human factor) can be easily solved by using tools such as clang-tidy. clang-tidy is a clang-based linter for C++. It can be used for various things, e.g. fixing coding style(e.g. add missing braces to if statements, readability-braces-around-statements check), or in our case add missing override keywords. Test Plan: Compiles. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, apol, romangg, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D22371
2019-07-22 16:52:26 +00:00
~X11TestApplication() override;
protected:
void performStartup() override;
};
X11TestApplication::X11TestApplication(int &argc, char **argv)
: Application(OperationModeX11, argc, argv)
{
setX11Connection(QX11Info::connection());
setX11RootWindow(QX11Info::appRootWindow());
}
X11TestApplication::~X11TestApplication()
{
}
void X11TestApplication::performStartup()
{
}
}
class X11TimestampUpdateTest : public QObject
{
Q_OBJECT
private Q_SLOTS:
void testGrabAfterServerTime();
void testBeforeLastGrabTime();
};
void X11TimestampUpdateTest::testGrabAfterServerTime()
{
// this test tries to grab the X keyboard with a timestamp in future
// that should fail, but after updating the X11 timestamp, it should
// work again
2022-10-08 10:48:54 +00:00
KWin::kwinApp()->updateXTime();
QCOMPARE(KWin::grabXKeyboard(), true);
KWin::ungrabXKeyboard();
// now let's change the timestamp
KWin::kwinApp()->setX11Time(KWin::xTime() + 5 * 60 * 1000);
// now grab keyboard should fail
QCOMPARE(KWin::grabXKeyboard(), false);
// let's update timestamp, now it should work again
2022-10-08 10:48:54 +00:00
KWin::kwinApp()->updateXTime();
QCOMPARE(KWin::grabXKeyboard(), true);
KWin::ungrabXKeyboard();
}
void X11TimestampUpdateTest::testBeforeLastGrabTime()
{
// this test tries to grab the X keyboard with a timestamp before the
// last grab time on the server. That should fail, but after updating the X11
// timestamp it should work again
// first set the grab timestamp
2022-10-08 10:48:54 +00:00
KWin::kwinApp()->updateXTime();
QCOMPARE(KWin::grabXKeyboard(), true);
KWin::ungrabXKeyboard();
// now go to past
const auto timestamp = KWin::xTime();
KWin::kwinApp()->setX11Time(KWin::xTime() - 5 * 60 * 1000, KWin::Application::TimestampUpdate::Always);
QCOMPARE(KWin::xTime(), timestamp - 5 * 60 * 1000);
// now grab keyboard should fail
QCOMPARE(KWin::grabXKeyboard(), false);
// let's update timestamp, now it should work again
2022-10-08 10:48:54 +00:00
KWin::kwinApp()->updateXTime();
QVERIFY(KWin::xTime() >= timestamp);
QCOMPARE(KWin::grabXKeyboard(), true);
KWin::ungrabXKeyboard();
}
int main(int argc, char *argv[])
{
setenv("QT_QPA_PLATFORM", "xcb", true);
KWin::X11TestApplication app(argc, argv);
app.setAttribute(Qt::AA_Use96Dpi, true);
X11TimestampUpdateTest tc;
return QTest::qExec(&tc, argc, argv);
}
#include "test_x11_timestamp_update.moc"