2020-08-07 19:01:42 +00:00
|
|
|
/*
|
|
|
|
|
SPDX-FileCopyrightText: 2020 Vlad Zahorodnii <vlad.zahorodnii@kde.org>
|
|
|
|
|
|
|
|
|
|
SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
|
|
#include "waylandclient.h"
|
|
|
|
|
|
|
|
|
|
namespace KWaylandServer
|
|
|
|
|
{
|
|
|
|
|
class LayerSurfaceV1Interface;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
namespace KWin
|
|
|
|
|
{
|
|
|
|
|
|
|
|
|
|
class AbstractOutput;
|
|
|
|
|
class LayerShellV1Integration;
|
|
|
|
|
|
|
|
|
|
class LayerShellV1Client : public WaylandClient
|
|
|
|
|
{
|
|
|
|
|
Q_OBJECT
|
|
|
|
|
|
|
|
|
|
public:
|
|
|
|
|
explicit LayerShellV1Client(KWaylandServer::LayerSurfaceV1Interface *shellSurface,
|
|
|
|
|
AbstractOutput *output,
|
|
|
|
|
LayerShellV1Integration *integration);
|
|
|
|
|
|
|
|
|
|
KWaylandServer::LayerSurfaceV1Interface *shellSurface() const;
|
2021-08-25 10:47:44 +00:00
|
|
|
AbstractOutput *desiredOutput() const;
|
2020-08-07 19:01:42 +00:00
|
|
|
|
|
|
|
|
NET::WindowType windowType(bool direct = false, int supported_types = 0) const override;
|
|
|
|
|
bool isPlaceable() const override;
|
|
|
|
|
bool isCloseable() const override;
|
|
|
|
|
bool isMovable() const override;
|
|
|
|
|
bool isMovableAcrossScreens() const override;
|
|
|
|
|
bool isResizable() const override;
|
|
|
|
|
bool takeFocus() override;
|
|
|
|
|
bool wantsInput() const override;
|
|
|
|
|
StrutRect strutRect(StrutArea area) const override;
|
|
|
|
|
bool hasStrut() const override;
|
|
|
|
|
void destroyClient() override;
|
|
|
|
|
void closeWindow() override;
|
2021-04-09 14:44:44 +00:00
|
|
|
void setVirtualKeyboardGeometry(const QRect &geo) override;
|
2020-08-07 19:01:42 +00:00
|
|
|
|
|
|
|
|
protected:
|
|
|
|
|
Layer belongsToLayer() const override;
|
|
|
|
|
bool acceptsFocus() const override;
|
Rework async geometry updates
Window management features were written with synchronous geometry
updates in mind. Currently, this poses a big problem on Wayland because
geometry updates are done in asynchronous fashion there.
At the moment, geometry is updated in a so called pseudo-asynchronous
fashion, meaning that the frame geometry will be reset to the old value
once geometry updates are unblocked. The main drawback of this approach
is that it is too error prone, the data flow is hard to comprehend, etc.
It is worth noting that there is already a machinery to perform async
geometry which is used during interactive move/resize operations.
This change extends the move/resize geometry usage beyond interactive
move/resize to make asynchronous geometry updates less error prone and
easier to comprehend.
With the proposed solution, all geometry updates must be done on the
move/resize geometry first. After that, the new geometry is passed on to
the Client-specific implementation of moveResizeInternal().
To be more specific, the frameGeometry() returns the current frame
geometry, it is primarily useful only to the scene. If you want to move
or resize a window, you need to use moveResizeGeometry() because it
corresponds to the last requested frame geometry.
It is worth noting that the moveResizeGeometry() returns the desired
bounding geometry. The client may commit the xdg_toplevel surface with a
slightly smaller window geometry, for example to enforce a specific
aspect ratio. The client is not allowed to resize beyond the size as
indicated in moveResizeGeometry().
The data flow is very simple: moveResize() updates the move/resize
geometry and calls the client-specific implementation of the
moveResizeInternal() method. Based on whether a configure event is
needed, moveResizeInternal() will update the frameGeometry() either
immediately or after the client commits a new buffer.
Unfortunately, both the compositor and xdg-shell clients try to update
the window geometry. It means that it's possible to have conflicts
between the two. With this change, the compositor's move resize geometry
will be synced only if there are no pending configure events, meaning
that the user doesn't try to resize the window.
2021-04-30 18:26:09 +00:00
|
|
|
void moveResizeInternal(const QRect &rect, MoveResizeMode mode) override;
|
2020-08-07 19:01:42 +00:00
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
void handleSizeChanged();
|
|
|
|
|
void handleUnmapped();
|
|
|
|
|
void handleCommitted();
|
|
|
|
|
void handleAcceptsFocusChanged();
|
2021-01-22 08:22:24 +00:00
|
|
|
void handleOutputEnabledChanged();
|
2020-08-07 19:01:42 +00:00
|
|
|
void handleOutputDestroyed();
|
|
|
|
|
void scheduleRearrange();
|
|
|
|
|
|
2021-08-25 10:47:44 +00:00
|
|
|
AbstractOutput *m_desiredOutput;
|
2020-08-07 19:01:42 +00:00
|
|
|
LayerShellV1Integration *m_integration;
|
|
|
|
|
KWaylandServer::LayerSurfaceV1Interface *m_shellSurface;
|
|
|
|
|
NET::WindowType m_windowType;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
} // namespace KWin
|
