yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/tabbox/CMakeLists.txt

101 lines
2.9 KiB
Text
Raw Normal View History

Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
include_directories(${KWin_SOURCE_DIR}/src)
[tabbox] Bring back disabled unit tests SwitcherItem is disabled for the unit test to reduce pulled in deps.
2014-06-10 09:14:59 +00:00
add_definitions(-DKWIN_UNIT_TEST)
Verify pointer is valid when calculating the longest caption The method was missing a check whether the weak pointers in the internal list got deleted. This could in very unlikely cases lead to a crash. In order to verify that adding the null pointer check fixes the crash a unit test is added to simulate the situation of a pointer being deleted. This required to add a mock a few classes of TabBox. A MockTabBoxHandler and MockTabBoxClient are added implementing the specific interfaces. The DeclarativeView is completely mocked to make the linker happy. Including the actual implementation is not possible as it pulls in half of KWin core. BUG: 303840 FIXED-IN: 4.9.0 REVIEW: 105645
2012-07-21 09:25:17 +00:00
########################################################
# Test TabBox::ClientModel
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testTabBoxClientModel_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../../src/tabbox/clientmodel.cpp
../../src/tabbox/desktopmodel.cpp
../../src/tabbox/tabbox_logging.cpp
../../src/tabbox/tabboxconfig.cpp
../../src/tabbox/tabboxhandler.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
mock_tabboxclient.cpp
mock_tabboxhandler.cpp
test_tabbox_clientmodel.cpp
Verify pointer is valid when calculating the longest caption The method was missing a check whether the weak pointers in the internal list got deleted. This could in very unlikely cases lead to a crash. In order to verify that adding the null pointer check fixes the crash a unit test is added to simulate the situation of a pointer being deleted. This required to add a mock a few classes of TabBox. A MockTabBoxHandler and MockTabBoxClient are added implementing the specific interfaces. The DeclarativeView is completely mocked to make the linker happy. Including the actual implementation is not possible as it pulls in half of KWin core. BUG: 303840 FIXED-IN: 4.9.0 REVIEW: 105645
2012-07-21 09:25:17 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testTabBoxClientModel ${testTabBoxClientModel_SRCS})
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 16:47:58 +00:00
set_target_properties(testTabBoxClientModel PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
target_link_libraries(testTabBoxClientModel
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Core
Qt::DBus
Qt::Quick
Qt::Test
Qt::Widgets
Qt::X11Extras
Use imported target for QtGui private headers It's nicer
2021-02-09 18:59:51 +00:00
Qt::GuiPrivate
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::I18n
KF5::Package
KF5::WindowSystem
[tabbox] Bring back disabled unit tests SwitcherItem is disabled for the unit test to reduce pulled in deps.
2014-06-10 09:14:59 +00:00
XCB::XCB
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testTabBoxClientModel COMMAND testTabBoxClientModel)
[tabbox] Bring back disabled unit tests SwitcherItem is disabled for the unit test to reduce pulled in deps.
2014-06-10 09:14:59 +00:00
ecm_mark_as_test(testTabBoxClientModel)
Verify QVariant is valid before casting to Client* If the ClientModel does not contain any Clients, which can happen if there is no desktop window, accessing the data of a ModelIndex returns an invalid QVariant. Because of that it needs to be ensured that the QVariant is valid before trying to cast it to a Client Pointer. BUG: 304620 FIXED-IN: 4.9.1 REVIEW: 105935
2012-08-08 20:28:22 +00:00
########################################################
# Test TabBox::TabBoxHandler
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testTabBoxHandler_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../../src/tabbox/clientmodel.cpp
../../src/tabbox/desktopmodel.cpp
../../src/tabbox/tabbox_logging.cpp
../../src/tabbox/tabboxconfig.cpp
../../src/tabbox/tabboxhandler.cpp
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
mock_tabboxclient.cpp
mock_tabboxhandler.cpp
test_tabbox_handler.cpp
Verify QVariant is valid before casting to Client* If the ClientModel does not contain any Clients, which can happen if there is no desktop window, accessing the data of a ModelIndex returns an invalid QVariant. Because of that it needs to be ensured that the QVariant is valid before trying to cast it to a Client Pointer. BUG: 304620 FIXED-IN: 4.9.1 REVIEW: 105935
2012-08-08 20:28:22 +00:00
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testTabBoxHandler ${testTabBoxHandler_SRCS})
[autotests] Fix unused function warnings The functions are defined in a common header but not used in all tests. This creates needless warning noise, so hide them through an ifdef.
2017-07-29 16:47:58 +00:00
set_target_properties(testTabBoxHandler PROPERTIES COMPILE_DEFINITIONS "NO_NONE_WINDOW")
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
target_link_libraries(testTabBoxHandler
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
Qt::Core
Qt::DBus
Qt::Quick
Qt::Test
Qt::Widgets
Qt::X11Extras
Use imported target for QtGui private headers It's nicer
2021-02-09 18:59:51 +00:00
Qt::GuiPrivate
Undo some recent cmake changes Unfortunately linking can be very fragile so let's not break things.
2019-09-18 10:31:02 +00:00
KF5::ConfigCore
KF5::I18n
KF5::Package
KF5::WindowSystem
[tabbox] Bring back disabled unit tests SwitcherItem is disabled for the unit test to reduce pulled in deps.
2014-06-10 09:14:59 +00:00
XCB::XCB
)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testTabBoxHandler COMMAND testTabBoxHandler)
[tabbox] Bring back disabled unit tests SwitcherItem is disabled for the unit test to reduce pulled in deps.
2014-06-10 09:14:59 +00:00
ecm_mark_as_test(testTabBoxHandler)
Adding a unit test for TabBoxConfig Currently only testing the default ctor and assignment operator. Inspired by bug fixed with commit 4276161. REVIEW: 106048
2012-08-15 18:53:05 +00:00
########################################################
# Test TabBox::TabBoxConfig
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testTabBoxConfig_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../../src/tabbox/tabbox_logging.cpp
../../src/tabbox/tabboxconfig.cpp
Adding a unit test for TabBoxConfig Currently only testing the default ctor and assignment operator. Inspired by bug fixed with commit 4276161. REVIEW: 106048
2012-08-15 18:53:05 +00:00
test_tabbox_config.cpp
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testTabBoxConfig ${testTabBoxConfig_SRCS})
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
target_link_libraries(testTabBoxConfig Qt::Core Qt::Test)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testTabBoxConfig COMMAND testTabBoxConfig)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testTabBoxConfig)
Move Desktop Chain management from Workspace into own class Most recently used virtual desktop chain is only used in the context of TabBox and therefore moved into this namespace. KWin uses one desktop chain for each activity. This is mapped by having multiple DesktopChains. In addition there is a DesktopChainManager which contains all those chains which are identified by a QString. The manager gets connected to the signals emitted by VirtualDesktopManager for changes in virtual desktops and to signals related to Activities emitted by Workspace. This means the manager is rather generic as it does not depend on any other components.
2012-11-17 10:50:59 +00:00
########################################################
# Test TabBox::DesktopChainManager
########################################################
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
set(testDesktopChain_SRCS
Move source code to src/ directory Once in a while, we receive complaints from other fellow KDE developers about the file organization of kwin. This change addresses some of those complaints by moving all of source code in a separate directory, src/, thus making the project structure more traditional. Things such as tests are kept in their own toplevel directories. This change may wreak havoc on merge requests that add new files to kwin, but if a patch modifies an already existing file, git should be smart enough to figure out that the file has been relocated. We may potentially split the src/ directory further to make navigating the source code easier, but hopefully this is good enough already.
2021-02-09 19:31:40 +00:00
../../src/tabbox/desktopchain.cpp
../../src/tabbox/tabbox_logging.cpp
Move Desktop Chain management from Workspace into own class Most recently used virtual desktop chain is only used in the context of TabBox and therefore moved into this namespace. KWin uses one desktop chain for each activity. This is mapped by having multiple DesktopChains. In addition there is a DesktopChainManager which contains all those chains which are identified by a QString. The manager gets connected to the signals emitted by VirtualDesktopManager for changes in virtual desktops and to signals related to Activities emitted by Workspace. This means the manager is rather generic as it does not depend on any other components.
2012-11-17 10:50:59 +00:00
test_desktopchain.cpp
)
Cleanup style in CMakeLists.txt files We have lots of inconsistency at the moment in CMakeLists.txt files. Most of it is due to kwin being a very old project. This change hopefully fixes all of it.
2019-09-17 09:15:35 +00:00
add_executable(testDesktopChain ${testDesktopChain_SRCS})
Use versionless Qt cmake target This makes it easier to build against both Qt5 and Qt6 GIT_SILENT
2021-01-30 16:18:21 +00:00
target_link_libraries(testDesktopChain Qt::Core Qt::Test)
[autotests] Support new way to run the tests without need to install Summary: KWin was quite good in ensuring that you don't need to install by passing paths to the tests. The new way is much nicer, so code is adjusted for the new way. Also if we require a newer ECM in future we need to support the new way. No guarantee that the tests don't pick something up from the system env, that needs more testing. References: https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled Test Plan: The tests which loaded helpers pass Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D7543
2017-08-25 16:18:20 +00:00
add_test(NAME kwin-testDesktopChain COMMAND testDesktopChain)
[kwin] Port autotests away from kde4_add_unit_test
2014-03-18 10:49:53 +00:00
ecm_mark_as_test(testDesktopChain)
Reference in a new issue Copy permalink