yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kwin/autotests/wayland/server/test_textinputv3_interface.cpp

657 lines
26 KiB
C++
Raw Normal View History

server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
/*
SPDX-FileCopyrightText: 2020 Bhushan Shah <bshah@kde.org>
SPDX-License-Identifier: LGPL-2.1-only OR LGPL-3.0-only OR LicenseRef-KDE-Accepted-LGPL
*/
Don't use QtTest => use QTest + missing include
2023-07-03 19:28:19 +00:00
#include <QSignalSpy>
#include <QTest>
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
#include <QThread>
wayland: Drop "_interface" from filenames The cpp files in the wayland directory are named after protocol names. "_interface" does not contribute anything new.
2023-09-13 05:52:59 +00:00
#include "wayland/compositor.h"
Integrate kwaylandserver This makes KWin switch to in-tree copy of KWaylandServer codebase. KWaylandServer namespace has been left as is. It will be addressed later by renaming classes in order to fit in the KWin namespace.
2022-04-22 09:27:33 +00:00
#include "wayland/display.h"
wayland: Drop "_interface" from filenames The cpp files in the wayland directory are named after protocol names. "_interface" does not contribute anything new.
2023-09-13 05:52:59 +00:00
#include "wayland/seat.h"
#include "wayland/surface.h"
#include "wayland/textinput_v3.h"
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
#include "KWayland/Client/compositor.h"
#include "KWayland/Client/connection_thread.h"
#include "KWayland/Client/event_queue.h"
#include "KWayland/Client/registry.h"
#include "KWayland/Client/seat.h"
#include "KWayland/Client/surface.h"
#include "qwayland-text-input-unstable-v3.h"
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
using namespace KWin;
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
Hopefully fix build on FreeBSD
2020-09-29 11:11:32 +00:00
Q_DECLARE_METATYPE(QtWayland::zwp_text_input_v3::content_purpose)
Q_DECLARE_METATYPE(QtWayland::zwp_text_input_v3::content_hint)
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
class TextInputV3 : public QObject, public QtWayland::zwp_text_input_v3
{
Q_OBJECT
Q_SIGNALS:
void surface_enter(wl_surface *surface);
void surface_leave(wl_surface *surface);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void commit_string(const QString &text);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
void delete_surrounding_text(quint32 before_length, quint32 after_length);
void preedit_string(const QString &text, quint32 cursor_begin, quint32 cursor_end);
void done(quint32 serial);
public:
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
~TextInputV3() override
{
destroy();
}
void zwp_text_input_v3_enter(struct ::wl_surface *surface) override
{
Use Q_EMIT to make it compile against kf5.82
2021-05-13 09:33:08 +00:00
Q_EMIT surface_enter(surface);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void zwp_text_input_v3_leave(struct ::wl_surface *surface) override
{
Use Q_EMIT to make it compile against kf5.82
2021-05-13 09:33:08 +00:00
Q_EMIT surface_leave(surface);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void zwp_text_input_v3_commit_string(const QString &text) override
{
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
commitText = text;
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void zwp_text_input_v3_delete_surrounding_text(uint32_t before_length, uint32_t after_length) override
{
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
before = before_length;
after = after_length;
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void zwp_text_input_v3_done(uint32_t serial) override
{
Use Q_EMIT to make it compile against kf5.82
2021-05-13 09:33:08 +00:00
Q_EMIT commit_string(commitText);
Q_EMIT preedit_string(preeditText, cursorBegin, cursorEnd);
Q_EMIT delete_surrounding_text(before, after);
Q_EMIT done(serial);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
void zwp_text_input_v3_preedit_string(const QString &text, int32_t cursor_begin, int32_t cursor_end) override
{
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
preeditText = text;
cursorBegin = cursor_begin;
cursorEnd = cursor_end;
}
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
private:
QString preeditText;
QString commitText;
uint32_t cursorBegin, cursorEnd;
uint32_t before, after;
};
class TextInputManagerV3 : public QtWayland::zwp_text_input_manager_v3
{
public:
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
~TextInputManagerV3() override
{
destroy();
}
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
};
class TestTextInputV3Interface : public QObject
{
Q_OBJECT
public:
~TestTextInputV3Interface() override;
private Q_SLOTS:
void initTestCase();
void testEnableDisable();
void testEvents();
void testContentPurpose_data();
void testContentPurpose();
void testContentHints_data();
void testContentHints();
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
void testMultipleTextinputs();
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
private:
KWayland::Client::ConnectionThread *m_connection;
KWayland::Client::EventQueue *m_queue;
KWayland::Client::Compositor *m_clientCompositor;
KWayland::Client::Seat *m_clientSeat = nullptr;
SeatInterface *m_seat;
QThread *m_thread;
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
KWin::Display m_display;
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
TextInputV3 *m_clientTextInputV3;
CompositorInterface *m_serverCompositor;
TextInputV3Interface *m_serverTextInputV3;
TextInputManagerV3 *m_clientTextInputManagerV3;
quint32 m_totalCommits = 0;
};
static const QString s_socketName = QStringLiteral("kwin-wayland-server-text-input-v3-test-0");
void TestTextInputV3Interface::initTestCase()
{
Allow accepting client connections on multiple sockets libwayland-server allows the wl_display accept client connections on more than one socket. We currently don't listen on multiple sockets, but it would be nice if Display supported such operation mode.
2020-10-19 15:52:56 +00:00
m_display.addSocketName(s_socketName);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
m_display.start();
QVERIFY(m_display.isRunning());
Remove factory methods in Display The main reason why we have factory methods is that up to some point, kwayland had its own signal to indicate when globals have to be removed. Now that all globals add destroy listeners for the wl_display object, we don't have that signal. Most factory methods are equivalent to doing new T(display). Besides adding unnecessary boilerplate code, another reason to get rid of the factory methods is to reduce the amount of merge conflicts. If several persons work on implementing wayland protocols at the same time, sooner or later someone will have to resolve merge conflicts in Display.
2020-12-09 20:13:19 +00:00
m_seat = new SeatInterface(&m_display, this);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
m_seat->setHasKeyboard(true);
Remove factory methods in Display The main reason why we have factory methods is that up to some point, kwayland had its own signal to indicate when globals have to be removed. Now that all globals add destroy listeners for the wl_display object, we don't have that signal. Most factory methods are equivalent to doing new T(display). Besides adding unnecessary boilerplate code, another reason to get rid of the factory methods is to reduce the amount of merge conflicts. If several persons work on implementing wayland protocols at the same time, sooner or later someone will have to resolve merge conflicts in Display.
2020-12-09 20:13:19 +00:00
m_serverCompositor = new CompositorInterface(&m_display, this);
new TextInputManagerV3Interface(&m_display);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
m_connection = new KWayland::Client::ConnectionThread;
QSignalSpy connectedSpy(m_connection, &KWayland::Client::ConnectionThread::connected);
m_connection->setSocketName(s_socketName);
m_thread = new QThread(this);
m_connection->moveToThread(m_thread);
m_thread->start();
m_connection->initConnection();
QVERIFY(connectedSpy.wait());
QVERIFY(!m_connection->connections().isEmpty());
m_queue = new KWayland::Client::EventQueue(this);
QVERIFY(!m_queue->isValid());
m_queue->setup(m_connection);
QVERIFY(m_queue->isValid());
auto registry = new KWayland::Client::Registry(this);
connect(registry, &KWayland::Client::Registry::interfaceAnnounced, this, [this, registry](const QByteArray &interface, quint32 id, quint32 version) {
if (interface == QByteArrayLiteral("zwp_text_input_manager_v3")) {
m_clientTextInputManagerV3 = new TextInputManagerV3();
m_clientTextInputManagerV3->init(*registry, id, version);
}
});
connect(registry, &KWayland::Client::Registry::seatAnnounced, this, [this, registry](quint32 name, quint32 version) {
m_clientSeat = registry->createSeat(name, version);
});
QSignalSpy allAnnouncedSpy(registry, &KWayland::Client::Registry::interfaceAnnounced);
QSignalSpy compositorSpy(registry, &KWayland::Client::Registry::compositorAnnounced);
QSignalSpy shmSpy(registry, &KWayland::Client::Registry::shmAnnounced);
registry->setEventQueue(m_queue);
registry->create(m_connection->display());
QVERIFY(registry->isValid());
registry->setup();
QVERIFY(allAnnouncedSpy.wait());
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
m_clientCompositor = registry->createCompositor(compositorSpy.first().first().value<quint32>(), compositorSpy.first().last().value<quint32>(), this);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QVERIFY(m_clientCompositor->isValid());
// create a text input v3
m_clientTextInputV3 = new TextInputV3();
m_clientTextInputV3->init(m_clientTextInputManagerV3->get_text_input(*m_clientSeat));
QVERIFY(m_clientTextInputV3);
}
TestTextInputV3Interface::~TestTextInputV3Interface()
{
if (m_clientTextInputV3) {
delete m_clientTextInputV3;
m_clientTextInputV3 = nullptr;
}
if (m_clientTextInputManagerV3) {
delete m_clientTextInputManagerV3;
m_clientTextInputManagerV3 = nullptr;
}
if (m_queue) {
delete m_queue;
m_queue = nullptr;
}
if (m_thread) {
m_thread->quit();
m_thread->wait();
delete m_thread;
m_thread = nullptr;
}
m_connection->deleteLater();
m_connection = nullptr;
}
// Ensures that enable disable events don't fire without commit
void TestTextInputV3Interface::testEnableDisable()
{
// create a surface
QSignalSpy serverSurfaceCreatedSpy(m_serverCompositor, &CompositorInterface::surfaceCreated);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> clientSurface(m_clientCompositor->createSurface(this));
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QVERIFY(serverSurfaceCreatedSpy.wait());
SurfaceInterface *serverSurface = serverSurfaceCreatedSpy.first().first().value<SurfaceInterface *>();
QVERIFY(serverSurface);
m_serverTextInputV3 = m_seat->textInputV3();
QVERIFY(m_serverTextInputV3);
QSignalSpy focusedSurfaceChangedSpy(m_seat, &SeatInterface::focusedTextInputSurfaceChanged);
QSignalSpy textInputEnabledSpy(m_serverTextInputV3, &TextInputV3Interface::enabledChanged);
QSignalSpy cursorRectangleChangedSpy(m_serverTextInputV3, &TextInputV3Interface::cursorRectangleChanged);
Implement a enableRequested signal for text-input-v3 The signal will be emitted if text-input-v3 applies a new enable state if it's already enabled. In Gtk's implementation, sending text_input_v3.enable for the second time has the similar semantics of text-input-v2.showInputPanel. Try to connect them together and add corresponding test. See also: https://github.com/GNOME/gtk/blob/a95cfb1c457cbd3ff365f7f1244c42dda8540b66/gtk/gtkimcontextwayland.c#L555
2022-10-24 23:38:40 +00:00
QSignalSpy enableRequestedSpy(m_serverTextInputV3, &TextInputV3Interface::enableRequested);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QSignalSpy surfaceEnterSpy(m_clientTextInputV3, &TextInputV3::surface_enter);
QSignalSpy surfaceLeaveSpy(m_clientTextInputV3, &TextInputV3::surface_leave);
// Enter the textinput
QCOMPARE(focusedSurfaceChangedSpy.count(), 0);
// Make sure that entering surface does not trigger the text input
m_seat->setFocusedTextInputSurface(serverSurface);
QVERIFY(surfaceEnterSpy.wait());
QCOMPARE(surfaceEnterSpy.count(), 1);
QCOMPARE(focusedSurfaceChangedSpy.count(), 1);
QCOMPARE(textInputEnabledSpy.count(), 0);
// Now enable the textInput, we should not get event just yet
m_clientTextInputV3->enable();
m_clientTextInputV3->set_cursor_rectangle(0, 0, 20, 20);
m_clientTextInputV3->set_surrounding_text("KDE Plasma Desktop", 0, 3);
QCOMPARE(textInputEnabledSpy.count(), 0);
QCOMPARE(cursorRectangleChangedSpy.count(), 0);
// after we do commit we should get event
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
m_totalCommits++;
Implement a enableRequested signal for text-input-v3 The signal will be emitted if text-input-v3 applies a new enable state if it's already enabled. In Gtk's implementation, sending text_input_v3.enable for the second time has the similar semantics of text-input-v2.showInputPanel. Try to connect them together and add corresponding test. See also: https://github.com/GNOME/gtk/blob/a95cfb1c457cbd3ff365f7f1244c42dda8540b66/gtk/gtkimcontextwayland.c#L555
2022-10-24 23:38:40 +00:00
QCOMPARE(enableRequestedSpy.count(), 0);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QCOMPARE(textInputEnabledSpy.count(), 1);
QCOMPARE(cursorRectangleChangedSpy.count(), 1);
QCOMPARE(m_serverTextInputV3->cursorRectangle(), QRect(0, 0, 20, 20));
QCOMPARE(m_serverTextInputV3->surroundingText(), QString("KDE Plasma Desktop"));
QCOMPARE(m_serverTextInputV3->surroundingTextCursorPosition(), 0);
QCOMPARE(m_serverTextInputV3->surroundingTextSelectionAnchor(), 3);
Implement a enableRequested signal for text-input-v3 The signal will be emitted if text-input-v3 applies a new enable state if it's already enabled. In Gtk's implementation, sending text_input_v3.enable for the second time has the similar semantics of text-input-v2.showInputPanel. Try to connect them together and add corresponding test. See also: https://github.com/GNOME/gtk/blob/a95cfb1c457cbd3ff365f7f1244c42dda8540b66/gtk/gtkimcontextwayland.c#L555
2022-10-24 23:38:40 +00:00
// Do another enable when it's already enabled.
m_clientTextInputV3->enable();
m_clientTextInputV3->set_cursor_rectangle(0, 0, 20, 20);
m_clientTextInputV3->set_surrounding_text("KDE Plasma Desktop", 0, 3);
m_clientTextInputV3->commit();
QVERIFY(enableRequestedSpy.wait());
QCOMPARE(textInputEnabledSpy.count(), 1);
QCOMPARE(cursorRectangleChangedSpy.count(), 1);
QCOMPARE(m_serverTextInputV3->cursorRectangle(), QRect(0, 0, 20, 20));
QCOMPARE(m_serverTextInputV3->surroundingText(), QString("KDE Plasma Desktop"));
QCOMPARE(m_serverTextInputV3->surroundingTextCursorPosition(), 0);
QCOMPARE(m_serverTextInputV3->surroundingTextSelectionAnchor(), 3);
m_totalCommits++;
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
// disabling we should not get the event
m_clientTextInputV3->disable();
QCOMPARE(textInputEnabledSpy.count(), 1);
// after we do commit we should get event
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
QCOMPARE(textInputEnabledSpy.count(), 2);
m_totalCommits++;
// Lets try leaving the surface and make sure event propogage
m_seat->setFocusedTextInputSurface(nullptr);
QVERIFY(surfaceLeaveSpy.wait());
QCOMPARE(surfaceLeaveSpy.count(), 1);
}
void TestTextInputV3Interface::testEvents()
{
// create a surface
QSignalSpy serverSurfaceCreatedSpy(m_serverCompositor, &CompositorInterface::surfaceCreated);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> clientSurface(m_clientCompositor->createSurface(this));
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QVERIFY(serverSurfaceCreatedSpy.wait());
SurfaceInterface *serverSurface = serverSurfaceCreatedSpy.first().first().value<SurfaceInterface *>();
QVERIFY(serverSurface);
m_serverTextInputV3 = m_seat->textInputV3();
QVERIFY(m_serverTextInputV3);
QSignalSpy focusedSurfaceChangedSpy(m_seat, &SeatInterface::focusedTextInputSurfaceChanged);
QSignalSpy textInputEnabledSpy(m_serverTextInputV3, &TextInputV3Interface::enabledChanged);
Always send a done after commit for text input v3. In Gtk's text-input-v3 implementation it expect done to update the client serial after every commit. Though it is unclear whether this is a protocol requirements, do the same thing like mutter for more compatiblity, especially Gtk3 is in EOL not likely to be patched any time soon. To do so, we will need to keep track of the last active preedit, otherwise only send_done() will clear the preedit.
2022-06-10 23:23:52 +00:00
QSignalSpy doneSpy(m_clientTextInputV3, &TextInputV3::done);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
// Enter the textinput
QCOMPARE(focusedSurfaceChangedSpy.count(), 0);
// Make sure that entering surface does not trigger the text input
m_seat->setFocusedTextInputSurface(serverSurface);
// FIXME: somehow this triggers BEFORE setFocusedTextInputSurface returns :(
// QVERIFY(focusedSurfaceChangedSpy.wait());
QCOMPARE(focusedSurfaceChangedSpy.count(), 1);
// Now enable the textInput
m_clientTextInputV3->enable();
m_clientTextInputV3->commit();
m_totalCommits++;
QVERIFY(textInputEnabledSpy.wait());
Always send a done after commit for text input v3. In Gtk's text-input-v3 implementation it expect done to update the client serial after every commit. Though it is unclear whether this is a protocol requirements, do the same thing like mutter for more compatiblity, especially Gtk3 is in EOL not likely to be patched any time soon. To do so, we will need to keep track of the last active preedit, otherwise only send_done() will clear the preedit.
2022-06-10 23:23:52 +00:00
QVERIFY(doneSpy.wait());
QCOMPARE(doneSpy.count(), 1);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QSignalSpy preEditSpy(m_clientTextInputV3, &TextInputV3::preedit_string);
QSignalSpy commitStringSpy(m_clientTextInputV3, &TextInputV3::commit_string);
QSignalSpy deleteSurroundingSpy(m_clientTextInputV3, &TextInputV3::delete_surrounding_text);
m_serverTextInputV3->sendPreEditString("Hello KDE community!", 1, 2);
m_serverTextInputV3->deleteSurroundingText(6, 10);
m_serverTextInputV3->commitString("Plasma");
m_serverTextInputV3->done();
QVERIFY(doneSpy.wait());
Always send a done after commit for text input v3. In Gtk's text-input-v3 implementation it expect done to update the client serial after every commit. Though it is unclear whether this is a protocol requirements, do the same thing like mutter for more compatiblity, especially Gtk3 is in EOL not likely to be patched any time soon. To do so, we will need to keep track of the last active preedit, otherwise only send_done() will clear the preedit.
2022-06-10 23:23:52 +00:00
QCOMPARE(doneSpy.count(), 2);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QCOMPARE(preEditSpy.count(), 1);
QCOMPARE(commitStringSpy.count(), 1);
QCOMPARE(deleteSurroundingSpy.count(), 1);
QCOMPARE(preEditSpy.last().at(0).value<QString>(), "Hello KDE community!");
QCOMPARE(preEditSpy.last().at(1).value<quint32>(), 1);
QCOMPARE(preEditSpy.last().at(2).value<quint32>(), 2);
QCOMPARE(commitStringSpy.last().at(0).value<QString>(), "Plasma");
QCOMPARE(deleteSurroundingSpy.last().at(0).value<quint32>(), 6);
QCOMPARE(deleteSurroundingSpy.last().at(1).value<quint32>(), 10);
// zwp_text_input_v3.done event have serial of total commits
QCOMPARE(doneSpy.last().at(0).value<quint32>(), m_totalCommits);
// Now disable the textInput
m_clientTextInputV3->disable();
m_clientTextInputV3->commit();
m_totalCommits++;
QVERIFY(textInputEnabledSpy.wait());
}
void TestTextInputV3Interface::testContentPurpose_data()
{
QTest::addColumn<QtWayland::zwp_text_input_v3::content_purpose>("clientPurpose");
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
QTest::addColumn<KWin::TextInputContentPurpose>("serverPurpose");
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QTest::newRow("Alpha") << QtWayland::zwp_text_input_v3::content_purpose_alpha << TextInputContentPurpose::Alpha;
QTest::newRow("Digits") << QtWayland::zwp_text_input_v3::content_purpose_digits << TextInputContentPurpose::Digits;
QTest::newRow("Number") << QtWayland::zwp_text_input_v3::content_purpose_number << TextInputContentPurpose::Number;
QTest::newRow("Phone") << QtWayland::zwp_text_input_v3::content_purpose_phone << TextInputContentPurpose::Phone;
QTest::newRow("Url") << QtWayland::zwp_text_input_v3::content_purpose_url << TextInputContentPurpose::Url;
QTest::newRow("Email") << QtWayland::zwp_text_input_v3::content_purpose_email << TextInputContentPurpose::Email;
QTest::newRow("Name") << QtWayland::zwp_text_input_v3::content_purpose_name << TextInputContentPurpose::Name;
QTest::newRow("Password") << QtWayland::zwp_text_input_v3::content_purpose_password << TextInputContentPurpose::Password;
QTest::newRow("Pin") << QtWayland::zwp_text_input_v3::content_purpose_pin << TextInputContentPurpose::Pin;
QTest::newRow("Date") << QtWayland::zwp_text_input_v3::content_purpose_date << TextInputContentPurpose::Date;
QTest::newRow("Time") << QtWayland::zwp_text_input_v3::content_purpose_time << TextInputContentPurpose::Time;
QTest::newRow("DateTime") << QtWayland::zwp_text_input_v3::content_purpose_datetime << TextInputContentPurpose::DateTime;
QTest::newRow("Terminal") << QtWayland::zwp_text_input_v3::content_purpose_terminal << TextInputContentPurpose::Terminal;
}
void TestTextInputV3Interface::testContentPurpose()
{
// create a surface
QSignalSpy serverSurfaceCreatedSpy(m_serverCompositor, &CompositorInterface::surfaceCreated);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> clientSurface(m_clientCompositor->createSurface(this));
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QVERIFY(serverSurfaceCreatedSpy.wait());
SurfaceInterface *serverSurface = serverSurfaceCreatedSpy.first().first().value<SurfaceInterface *>();
QVERIFY(serverSurface);
m_serverTextInputV3 = m_seat->textInputV3();
QVERIFY(m_serverTextInputV3);
QSignalSpy focusedSurfaceChangedSpy(m_seat, &SeatInterface::focusedTextInputSurfaceChanged);
QSignalSpy textInputEnabledSpy(m_serverTextInputV3, &TextInputV3Interface::enabledChanged);
// Enter the textinput
QCOMPARE(focusedSurfaceChangedSpy.count(), 0);
// Make sure that entering surface does not trigger the text input
m_seat->setFocusedTextInputSurface(serverSurface);
// FIXME: somehow this triggers BEFORE setFocusedTextInputSurface returns :(
// QVERIFY(focusedSurfaceChangedSpy.wait());
QCOMPARE(focusedSurfaceChangedSpy.count(), 1);
// Now enable the textInput
m_clientTextInputV3->enable();
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
m_totalCommits++;
// Default should be normal content purpose
QCOMPARE(m_serverTextInputV3->contentPurpose(), TextInputContentPurpose::Normal);
QSignalSpy contentTypeChangedSpy(m_serverTextInputV3, &TextInputV3Interface::contentTypeChanged);
QFETCH(QtWayland::zwp_text_input_v3::content_purpose, clientPurpose);
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(QtWayland::zwp_text_input_v3::content_hint_none, clientPurpose);
m_clientTextInputV3->commit();
QVERIFY(contentTypeChangedSpy.wait());
QTEST(m_serverTextInputV3->contentPurpose(), "serverPurpose");
m_totalCommits++;
// Setting same thing should not trigger update
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(QtWayland::zwp_text_input_v3::content_hint_none, clientPurpose);
m_clientTextInputV3->commit();
QVERIFY(!contentTypeChangedSpy.wait(100));
m_totalCommits++;
// unset to normal
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(QtWayland::zwp_text_input_v3::content_hint_none, QtWayland::zwp_text_input_v3::content_purpose_normal);
m_clientTextInputV3->commit();
QVERIFY(contentTypeChangedSpy.wait());
m_totalCommits++;
QCOMPARE(m_serverTextInputV3->contentPurpose(), TextInputContentPurpose::Normal);
// Now disable the textInput
m_clientTextInputV3->disable();
m_clientTextInputV3->commit();
m_totalCommits++;
QVERIFY(textInputEnabledSpy.wait());
}
void TestTextInputV3Interface::testContentHints_data()
{
QTest::addColumn<quint32>("clientHint");
wayland: Integrate KWaylandServer classes into KWin namespace
2023-09-13 17:59:29 +00:00
QTest::addColumn<KWin::TextInputContentHints>("serverHints");
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QTest::addRow("Spellcheck") << quint32(QtWayland::zwp_text_input_v3::content_hint_spellcheck)
<< TextInputContentHints(TextInputContentHint::AutoCorrection);
QTest::addRow("Completion") << quint32(QtWayland::zwp_text_input_v3::content_hint_completion)
<< TextInputContentHints(TextInputContentHint::AutoCompletion);
QTest::addRow("AutoCapital") << quint32(QtWayland::zwp_text_input_v3::content_hint_auto_capitalization)
<< TextInputContentHints(TextInputContentHint::AutoCapitalization);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QTest::addRow("Lowercase") << quint32(QtWayland::zwp_text_input_v3::content_hint_lowercase) << TextInputContentHints(TextInputContentHint::LowerCase);
QTest::addRow("Uppercase") << quint32(QtWayland::zwp_text_input_v3::content_hint_uppercase) << TextInputContentHints(TextInputContentHint::UpperCase);
QTest::addRow("Titlecase") << quint32(QtWayland::zwp_text_input_v3::content_hint_titlecase) << TextInputContentHints(TextInputContentHint::TitleCase);
QTest::addRow("HiddenText") << quint32(QtWayland::zwp_text_input_v3::content_hint_hidden_text) << TextInputContentHints(TextInputContentHint::HiddenText);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QTest::addRow("SensitiveData") << quint32(QtWayland::zwp_text_input_v3::content_hint_sensitive_data)
<< TextInputContentHints(TextInputContentHint::SensitiveData);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QTest::addRow("Latin") << quint32(QtWayland::zwp_text_input_v3::content_hint_latin) << TextInputContentHints(TextInputContentHint::Latin);
QTest::addRow("Multiline") << quint32(QtWayland::zwp_text_input_v3::content_hint_multiline) << TextInputContentHints(TextInputContentHint::MultiLine);
Run clang-format If you want git blame to ignore formatting revisions run: git config blame.ignoreRevsFile .git-blame-ignore-revs
2021-08-29 05:11:06 +00:00
QTest::addRow("Auto") << quint32(QtWayland::zwp_text_input_v3::content_hint_completion | QtWayland::zwp_text_input_v3::content_hint_spellcheck
| QtWayland::zwp_text_input_v3::content_hint_auto_capitalization)
<< TextInputContentHints(TextInputContentHint::AutoCompletion | TextInputContentHint::AutoCorrection
| TextInputContentHint::AutoCapitalization);
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
}
void TestTextInputV3Interface::testContentHints()
{
// create a surface
QSignalSpy serverSurfaceCreatedSpy(m_serverCompositor, &CompositorInterface::surfaceCreated);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> clientSurface(m_clientCompositor->createSurface(this));
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QVERIFY(serverSurfaceCreatedSpy.wait());
SurfaceInterface *serverSurface = serverSurfaceCreatedSpy.first().first().value<SurfaceInterface *>();
QVERIFY(serverSurface);
m_serverTextInputV3 = m_seat->textInputV3();
QVERIFY(m_serverTextInputV3);
QSignalSpy focusedSurfaceChangedSpy(m_seat, &SeatInterface::focusedTextInputSurfaceChanged);
QSignalSpy textInputEnabledSpy(m_serverTextInputV3, &TextInputV3Interface::enabledChanged);
// Enter the textinput
QCOMPARE(focusedSurfaceChangedSpy.count(), 0);
// Make sure that entering surface does not trigger the text input
m_seat->setFocusedTextInputSurface(serverSurface);
// FIXME: somehow this triggers BEFORE setFocusedTextInputSurface returns :(
// QVERIFY(focusedSurfaceChangedSpy.wait());
QCOMPARE(focusedSurfaceChangedSpy.count(), 1);
// Now enable the textInput
m_clientTextInputV3->enable();
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
m_totalCommits++;
QCOMPARE(m_serverTextInputV3->contentHints(), TextInputContentHint::None);
// Now disable the textInput
m_clientTextInputV3->disable();
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
m_totalCommits++;
QSignalSpy contentTypeChangedSpy(m_serverTextInputV3, &TextInputV3Interface::contentTypeChanged);
QFETCH(quint32, clientHint);
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(clientHint, QtWayland::zwp_text_input_v3::content_purpose_normal);
m_clientTextInputV3->commit();
QVERIFY(contentTypeChangedSpy.wait());
QTEST(m_serverTextInputV3->contentHints(), "serverHints");
m_totalCommits++;
// Setting same thing should not trigger update
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(clientHint, QtWayland::zwp_text_input_v3::content_purpose_normal);
m_clientTextInputV3->commit();
QVERIFY(!contentTypeChangedSpy.wait(100));
m_totalCommits++;
// unset to normal
m_clientTextInputV3->enable();
m_clientTextInputV3->set_content_type(QtWayland::zwp_text_input_v3::content_hint_none, QtWayland::zwp_text_input_v3::content_purpose_normal);
m_clientTextInputV3->commit();
QVERIFY(contentTypeChangedSpy.wait());
m_totalCommits++;
// Now disable the textInput
m_clientTextInputV3->disable();
m_clientTextInputV3->commit();
QVERIFY(textInputEnabledSpy.wait());
m_totalCommits++;
}
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
void TestTextInputV3Interface::testMultipleTextinputs()
{
// create two more text inputs
TextInputV3 *ti1 = new TextInputV3();
ti1->init(m_clientTextInputManagerV3->get_text_input(*m_clientSeat));
QVERIFY(ti1);
TextInputV3 *ti2 = new TextInputV3();
ti2->init(m_clientTextInputManagerV3->get_text_input(*m_clientSeat));
QVERIFY(ti2);
// create a surface
QSignalSpy serverSurfaceCreatedSpy(m_serverCompositor, &CompositorInterface::surfaceCreated);
replace all uses of QScopedPointer with std::unique_ptr
2022-08-01 21:29:02 +00:00
std::unique_ptr<KWayland::Client::Surface> clientSurface(m_clientCompositor->createSurface(this));
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
QVERIFY(serverSurfaceCreatedSpy.wait());
SurfaceInterface *serverSurface = serverSurfaceCreatedSpy.first().first().value<SurfaceInterface *>();
QVERIFY(serverSurface);
QSignalSpy focusedSurfaceChangedSpy(m_seat, &SeatInterface::focusedTextInputSurfaceChanged);
// Make sure that entering surface does not trigger the text input
m_seat->setFocusedTextInputSurface(serverSurface);
QCOMPARE(focusedSurfaceChangedSpy.count(), 1);
m_serverTextInputV3 = m_seat->textInputV3();
QVERIFY(m_serverTextInputV3);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(!m_serverTextInputV3->isEnabled());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
Fix flaky testTextInputV3Interface In a74c4361564217919437986feb91a3f85c5a5c33, we changed behavior that every commit() will be followed by a done(), which makes this test might catch a different done() from server. Change the spy to make sure it exhaust all other done before checking the one expected.
2022-06-22 16:33:18 +00:00
QSignalSpy doneSpy1(ti1, &TextInputV3::done);
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
QSignalSpy committedSpy(m_serverTextInputV3, &TextInputV3Interface::stateCommitted);
// Enable ti1
ti1->enable();
ti1->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 1);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(m_serverTextInputV3->isEnabled());
Fix flaky testTextInputV3Interface In a74c4361564217919437986feb91a3f85c5a5c33, we changed behavior that every commit() will be followed by a done(), which makes this test might catch a different done() from server. Change the spy to make sure it exhaust all other done before checking the one expected.
2022-06-22 16:33:18 +00:00
QVERIFY(doneSpy1.wait());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// Send another three commits on ti1
ti1->enable();
ti1->set_surrounding_text("hello", 0, 1);
ti1->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 2);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(m_serverTextInputV3->isEnabled());
Fix flaky testTextInputV3Interface In a74c4361564217919437986feb91a3f85c5a5c33, we changed behavior that every commit() will be followed by a done(), which makes this test might catch a different done() from server. Change the spy to make sure it exhaust all other done before checking the one expected.
2022-06-22 16:33:18 +00:00
QVERIFY(doneSpy1.wait());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
ti1->enable();
ti1->set_content_type(QtWayland::zwp_text_input_v3::content_hint_none, QtWayland::zwp_text_input_v3::content_purpose_normal);
ti1->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 3);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(m_serverTextInputV3->isEnabled());
Fix flaky testTextInputV3Interface In a74c4361564217919437986feb91a3f85c5a5c33, we changed behavior that every commit() will be followed by a done(), which makes this test might catch a different done() from server. Change the spy to make sure it exhaust all other done before checking the one expected.
2022-06-22 16:33:18 +00:00
QVERIFY(doneSpy1.wait());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// at this point total commit count to ti1 is 3
QSignalSpy doneSpy2(ti2, &TextInputV3::done);
m_serverTextInputV3->commitString("Hello");
m_serverTextInputV3->done();
QVERIFY(doneSpy1.wait());
// zwp_text_input_v3.done event have serial of total commits
QCOMPARE(doneSpy1.last().at(0).value<quint32>(), 3);
// now ti1 is at 4 commit, while ti2 is still 0
ti1->disable();
ti1->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 4);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(!m_serverTextInputV3->isEnabled());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// first commit to ti2
ti2->enable();
ti2->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 1);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(m_serverTextInputV3->isEnabled());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// send commit string
m_serverTextInputV3->commitString("Hello world");
m_serverTextInputV3->done();
QVERIFY(doneSpy2.wait());
// ti2 is at one commit
QCOMPARE(doneSpy2.last().at(0).value<quint32>(), 1);
ti2->disable();
ti2->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 2);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(!m_serverTextInputV3->isEnabled());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// now re-enable the ti1 and verify sending commits to t2 hasn't affected it's serial
// Enable ti1 : 5 commits now
ti1->enable();
ti1->commit();
QVERIFY(committedSpy.wait());
QCOMPARE(committedSpy.last().at(0).value<quint32>(), 5);
Clean up the focus handling for text input. Usually, a client will only use text input v2/v3. Do not return the focused surface for text input if it has no relevant text input resource. If text-input object is created after surface get the focus, send enter to this text input object. Ensure sendEnter and sendLeave always appear in pair. Also, use the same technique in text-input-v2 for text-input-v3 to handle per resource's enable/disable state, and only send update to enabled text-input-v3 object.
2021-12-19 08:00:22 +00:00
QVERIFY(m_serverTextInputV3->isEnabled());
text-input-v3: track commit counts per resource If we track the commit counts at compositor global, this will fail horribly for anything other than the first text-input-v3 client, as for new client the serial count will not be what it expects in the done() request and it will simply consider events as outdated and will refuse to accept those events
2020-10-07 03:19:15 +00:00
// send done signal
m_serverTextInputV3->commitString("Hello");
m_serverTextInputV3->done();
QVERIFY(doneSpy1.wait());
QCOMPARE(doneSpy1.last().at(0).value<quint32>(), 5);
// cleanup
if (ti1) {
delete ti1;
ti1 = nullptr;
}
if (ti2) {
delete ti2;
ti2 = nullptr;
}
}
server: implement the text-input-unstable-v3 This commit implements the zwp_text_input_v3 in kwayland-server, part of code is inspired based on the initial patch from Roman at D16735.
2020-09-15 07:27:46 +00:00
QTEST_GUILESS_MAIN(TestTextInputV3Interface)
#include "test_textinputv3_interface.moc"
Reference in a new issue Copy permalink