yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

backends/drm: don't leak gbm surface if creating egl surface fails

Browse source
This commit is contained in:
Xaver Hugl 2022-12-01 20:11:18 +01:00 committed by Vlad Zahorodnii
parent 07a2ef4273
commit 00b21992c4
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backends/drm/drm_gbm_surface.cpp
View file

@ -134,6 +134,7 @@ std::variant<std::shared_ptr<GbmSurface>, GbmSurface::Error> GbmSurface::createS
EGLSurface eglSurface = eglCreatePlatformWindowSurfaceEXT(backend->eglDisplay(), config, surface, nullptr); EGLSurface eglSurface = eglCreatePlatformWindowSurfaceEXT(backend->eglDisplay(), config, surface, nullptr);
if (eglSurface == EGL_NO_SURFACE) { if (eglSurface == EGL_NO_SURFACE) {
qCCritical(KWIN_DRM) << "Creating EGL surface failed!" << getEglErrorString(); qCCritical(KWIN_DRM) << "Creating EGL surface failed!" << getEglErrorString();
gbm_surface_destroy(surface);
return Error::Unknown; return Error::Unknown;
} }
return std::make_shared<GbmSurface>(backend, size, format, QVector<uint64_t>{}, flags, surface, eglSurface); return std::make_shared<GbmSurface>(backend, size, format, QVector<uint64_t>{}, flags, surface, eglSurface);
@ -153,6 +154,7 @@ std::variant<std::shared_ptr<GbmSurface>, GbmSurface::Error> GbmSurface::createS
EGLSurface eglSurface = eglCreatePlatformWindowSurfaceEXT(backend->eglDisplay(), config, surface, nullptr); EGLSurface eglSurface = eglCreatePlatformWindowSurfaceEXT(backend->eglDisplay(), config, surface, nullptr);
if (eglSurface == EGL_NO_SURFACE) { if (eglSurface == EGL_NO_SURFACE) {
qCCritical(KWIN_DRM) << "Creating EGL surface failed!" << getEglErrorString(); qCCritical(KWIN_DRM) << "Creating EGL surface failed!" << getEglErrorString();
gbm_surface_destroy(surface);
return Error::Unknown; return Error::Unknown;
} }
return std::make_shared<GbmSurface>(backend, size, format, modifiers, 0, surface, eglSurface); return std::make_shared<GbmSurface>(backend, size, format, modifiers, 0, surface, eglSurface);