yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop Toplevel::transparentRect()

Browse source 
It can be computed via other means (Toplevel::frameMargins()) and its
name is confusing. It specifies the inner decoration rect.
This commit is contained in:
Vlad Zahorodnii 2021-08-12 14:56:39 +03:00
parent ac16bef409
commit 0197d770ab
3 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/effects.cpp
View file

@ -1987,7 +1987,7 @@ void EffectWindowImpl::setSceneWindow(Scene::Window* w)
QRect EffectWindowImpl::decorationInnerRect() const
{
return toplevel->transparentRect();
return toplevel->rect() - toplevel->frameMargins();
}
QByteArray EffectWindowImpl::readProperty(long atom, long type, int format) const

3
src/scene.cpp
View file

@ -656,7 +656,8 @@ void Scene::Window::unreferencePreviousPixmap_helper(SurfaceItem *item)
QRegion Scene::Window::decorationShape() const
{
return QRegion(toplevel->rect()) - toplevel->transparentRect();
const QRect decorationInnerRect = toplevel->rect() - toplevel->frameMargins();
return QRegion(toplevel->rect()) - decorationInnerRect;
}
bool Scene::Window::isVisible() const

6
src/toplevel.h
View file

@ -362,7 +362,6 @@ public:
* Returns a rectangle that the window occupies on the screen, including drop-shadows.
*/
QRect visibleGeometry() const;
QRect transparentRect() const;
virtual bool isClient() const;
virtual bool isDeleted() const;
@ -789,11 +788,6 @@ inline QRect Toplevel::rect() const
return QRect(0, 0, width(), height());
}
inline QRect Toplevel::transparentRect() const
{
return isShade() ? QRect() : QRect(clientPos(), clientSize());
}
inline bool Toplevel::readyForPainting() const
{
return ready_for_painting;