yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ensure that list is not empty before accessing

Browse source 
With settings to animate windows in boxswitch it was
possible that an empty list was accessed when the last
window closed.
BUG: 263306
FIXED-IN: 4.7.0
This commit is contained in:
Martin Gräßlin 2011-05-07 11:23:15 +02:00
parent 1dd614ee4b
commit 032c2cc333
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
effects/boxswitch/boxswitch.cpp
View file

@ -547,6 +547,10 @@ void BoxSwitchEffect::calculateItemSizes()
qDeleteAll(windows); qDeleteAll(windows);
windows.clear(); windows.clear();
if ((mAnimateSwitch && !mProxyActivated) || (mProxyActivated && mProxyAnimateSwitch)) { if ((mAnimateSwitch && !mProxyActivated) || (mProxyActivated && mProxyAnimateSwitch)) {
if (original_windows.isEmpty()) {
// can happen when last window is closed.
return;
}
int index = original_windows.indexOf(effects->currentTabBoxWindow()); int index = original_windows.indexOf(effects->currentTabBoxWindow());
int leftIndex = index; int leftIndex = index;
int rightIndex = index + 1; int rightIndex = index + 1;