yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[effects/dialogparent] Fix strict mode issues

Browse source 
Summary:
Modification of undeclared variables is illegal in the strict mode, e.g.

```lang=js
mainWindows = window.mainWindows();
```

is illegal.

Test Plan: The Dialog Parent effect works with both QScriptEngine and QJSEngine.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D15413
This commit is contained in:
Vlad Zagorodniy 2018-09-10 22:12:21 +03:00
parent 617b4d92fa
commit 03a2a05fc7
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
effects/dialogparent/package/contents/code/main.js
View file

@ -23,7 +23,6 @@ var dialogParentEffect = {
duration: animationTime(300), duration: animationTime(300),
windowAdded: function (window) { windowAdded: function (window) {
"use strict"; "use strict";
var mainWindows, i, w;
if (window === null || window.modal === false) { if (window === null || window.modal === false) {
return; return;
} }
@ -31,9 +30,9 @@ var dialogParentEffect = {
}, },
dialogGotModality: function (window) { dialogGotModality: function (window) {
"use strict"; "use strict";
mainWindows = window.mainWindows(); var mainWindows = window.mainWindows();
for (i = 0; i < mainWindows.length; i += 1) { for (var i = 0; i < mainWindows.length; i += 1) {
w = mainWindows[i]; var w = mainWindows[i];
if (w.dialogParentAnimation !== undefined) { if (w.dialogParentAnimation !== undefined) {
continue; continue;
} }
@ -59,7 +58,6 @@ var dialogParentEffect = {
}, },
windowClosed: function (window) { windowClosed: function (window) {
"use strict"; "use strict";
var mainWindows, i, w;
dialogParentEffect.cancelAnimation(window); dialogParentEffect.cancelAnimation(window);
if (window.modal === false) { if (window.modal === false) {
return; return;
@ -68,9 +66,9 @@ var dialogParentEffect = {
}, },
dialogLostModality: function (window) { dialogLostModality: function (window) {
"use strict"; "use strict";
mainWindows = window.mainWindows(); var mainWindows = window.mainWindows();
for (i = 0; i < mainWindows.length; i += 1) { for (var i = 0; i < mainWindows.length; i += 1) {
w = mainWindows[i]; var w = mainWindows[i];
if (w.dialogParentAnimation === undefined) { if (w.dialogParentAnimation === undefined) {
continue; continue;
} }