From 04dbafd75edd4fb9f0adcb0942f270a5b7168ae9 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Wed, 10 Jan 2018 02:25:31 +0000 Subject: [PATCH] Fix Plastik bottom and right border Summary: x and y are always relative to the parent, adding parent.width to calculate the position doesn't make sense. Original author meant just "x: parent.width-1" But we may as well just use anchors. Programatically it comes out the same. Test Plan: No more weird vertical lines in the KCM when view is slightly less than 2 previews wide. Modded colour to hardcoded "red" for easier visualisation, checked it looked ok when set as a real deco. Reviewers: #plasma Subscribers: plasma-devel, kwin, #kwin Tags: #plasma Differential Revision: https://phabricator.kde.org/D9776 --- .../aurorae/themes/plastik/package/contents/ui/main.qml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml b/plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml index 34a41fd8f4..3bbc2f830f 100644 --- a/plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml +++ b/plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/main.qml @@ -154,8 +154,8 @@ Decoration { anchors { bottom: parent.bottom top: parent.top + right: parent.right } - x: parent.x + parent.width - 1 color: colorHelper.shade(root.titleBarColor, ColorHelper.DarkShade, colorHelper.contrast - (decoration.client.active ? 0.4 : 0.8)) } } @@ -176,8 +176,8 @@ Decoration { anchors { left: parent.left right: parent.right + bottom: parent.bottom } - y: parent.y + parent.height - 1 color: colorHelper.shade(root.titleBarColor, ColorHelper.DarkShade, colorHelper.contrast - (decoration.client.active ? 0.4 : 0.8)) } }