From 05811535d41203fde466a41fd2e05f4b9ce6c971 Mon Sep 17 00:00:00 2001 From: Aleix Pol Gonzalez Date: Sat, 6 Mar 2021 03:37:51 +0000 Subject: [PATCH] Apply 1 suggestion(s) to 1 file(s) --- src/inputmethod.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/inputmethod.cpp b/src/inputmethod.cpp index 5343efef62..3a0d2176b8 100644 --- a/src/inputmethod.cpp +++ b/src/inputmethod.cpp @@ -168,6 +168,10 @@ void InputMethod::clientAdded(AbstractClient* client) } }); connect(m_inputClient, &AbstractClient::frameGeometryChanged, this, refreshFrame); + // Current code have a assumption that InputMethod started by the kwin is virtual keyboard, + // InputMethod::hide sends out a deactivate signal to input-method client, this is not desired + // when we support input methods like ibus which can show and hide surfaces/windows as they please + // and are not exactly Virtual keyboards. connect(m_inputClient, &AbstractClient::windowHidden, this, &InputMethod::hide); connect(m_inputClient, &AbstractClient::windowClosed, this, &InputMethod::hide); }