yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libkwineffects: Make dirty view tracking more robust in SceneEffect

Browse source 
It's possible that a view can request a repaint again in update(). If
that happens, we don't want to overwrite the dirty state after update().
This commit is contained in:
Vlad Zahorodnii 2023-10-18 13:09:33 +03:00
parent b4717ca590
commit 066492ef1d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/libkwineffects/kwinquickeffect.cpp
View file

@ -367,14 +367,14 @@ void QuickSceneEffect::prePaintScreen(ScreenPrePaintData &data, std::chrono::mil
if (effects->waylandDisplay()) { if (effects->waylandDisplay()) {
const auto it = d->views.find(data.screen); const auto it = d->views.find(data.screen);
if (it != d->views.end() && it->second->isDirty()) { if (it != d->views.end() && it->second->isDirty()) {
it->second->update();
it->second->resetDirty(); it->second->resetDirty();
it->second->update();
} }
} else { } else {
for (const auto &[screen, screenView] : d->views) { for (const auto &[screen, screenView] : d->views) {
if (screenView->isDirty()) { if (screenView->isDirty()) {
screenView->update();
screenView->resetDirty(); screenView->resetDirty();
screenView->update();
} }
} }
} }