yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects/overview: Remove premature optimization in ExpoLayout::calculateWindowTransformationsNatural()

Browse source 
The natural geometry can live in a different coordinate space than the
target area. Remove the premature optimization so the cell is properly
placed if the two are in different coordinate spaces.
This commit is contained in:
Vlad Zahorodnii 2021-12-04 17:57:04 +02:00
parent a5028ab5c5
commit 0765a08cc8
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/effects/overview/expolayout.cpp
View file

@ -452,17 +452,6 @@ static bool isOverlappingAny(ExpoCell *w, const QHash<ExpoCell *, QRect> &target
void ExpoLayout::calculateWindowTransformationsNatural() void ExpoLayout::calculateWindowTransformationsNatural()
{ {
const QRect area = QRect(0, 0, width(), height()); const QRect area = QRect(0, 0, width(), height());
if (m_cells.count() == 1) {
// Just move the window to its original location to save time
ExpoCell *cell = m_cells.constFirst();
if (area.contains(cell->naturalRect().marginsAdded(cell->margins()))) {
cell->setX(cell->naturalX());
cell->setY(cell->naturalY());
cell->setWidth(cell->naturalWidth());
cell->setHeight(cell->naturalHeight());
return;
}
}
// As we are using pseudo-random movement (See "slot") we need to make sure the list // As we are using pseudo-random movement (See "slot") we need to make sure the list
// is always sorted the same way no matter which window is currently active. // is always sorted the same way no matter which window is currently active.