yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[scripting] Introduce writable frameGeometry property

Browse source 
Summary:
The geometry property has been deprecated for quite some time and its
usage in scripts is highly discouraged. Since AbstractClient overrides
the geometry property to make it writable, the same thing must be done
for the frameGeometry property.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D29666
This commit is contained in:
Vlad Zahorodnii 2020-05-11 20:15:06 +03:00
parent a35792e59d
commit 079f9890ad
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
abstract_client.h
View file

@ -219,9 +219,17 @@ class KWIN_EXPORT AbstractClient : public Toplevel
/**
* The geometry of this Client. Be aware that depending on resize mode the frameGeometryChanged
* signal might be emitted at each resize step or only at the end of the resize operation.
*
* @deprecated Use frameGeometry
*/
Q_PROPERTY(QRect geometry READ frameGeometry WRITE setFrameGeometry)
/**
* The geometry of this Client. Be aware that depending on resize mode the frameGeometryChanged
* signal might be emitted at each resize step or only at the end of the resize operation.
*/
Q_PROPERTY(QRect frameGeometry READ frameGeometry WRITE setFrameGeometry)
/**
* Whether the Client is currently being moved by the user.
* Notify signal is emitted when the Client starts or ends move/resize mode.

2
scripts/videowall/contents/code/main.js
View file

@ -39,7 +39,7 @@ function isVideoPlayer(client) {
var videowall = function(client, set) {
if (set && isVideoPlayer(client)) {
client.geometry = workspace.clientArea(KWin.FullArea, 0, 1);
client.frameGeometry = workspace.clientArea(KWin.FullArea, 0, 1);
}
};